Page MenuHomePhabricator
Feed Advanced Search

May 27 2019

deadalnix requested changes to D3104: Allow wallet files not in -walletdir directory.

Fix the release notes.

May 27 2019, 21:43
deadalnix resigned from D3105: Create new wallet databases as directories rather than files.
May 27 2019, 21:42
deadalnix accepted D3105: Create new wallet databases as directories rather than files.
May 27 2019, 21:41
Herald added a reviewer for D3136: Remove IsSolvable: Restricted Project.
May 27 2019, 21:38
deadalnix added a comment to D3120: (finally) remove getinfo in favor of more module-specific infos.

Ok we can wait 3 days.

May 27 2019, 21:28
deadalnix requested changes to D2938: index: Move index DBs into index/ directory..
May 27 2019, 21:26
deadalnix accepted D2937: MOVEONLY: Move BaseIndex to its own file..
May 27 2019, 21:04
deadalnix accepted D2936: index: Generalize logged statements in BaseIndex..
May 27 2019, 21:02
deadalnix accepted D2935: index: Extract logic from TxIndex into reusable base class..
May 27 2019, 21:01
deadalnix accepted D2934: db: Make reusable base class for index databases..
May 27 2019, 21:00
deadalnix accepted D3103: Allow wallet files in multiple directories.
May 27 2019, 20:51
deadalnix accepted D3128: Bump wallet version to 190700 and remove the `usehd` option.
May 27 2019, 20:50
deadalnix accepted D3135: Merge #13396: Drop unused arith_uint256 ! operator.
May 27 2019, 20:44
Herald added a reviewer for D3134: Support downgrading after recovered keypool witness keys: Restricted Project.
May 27 2019, 18:39
Herald added a reviewer for D3133: SegWit wallet support: Restricted Project.
May 27 2019, 18:31
deadalnix requested changes to D3103: Allow wallet files in multiple directories.
May 27 2019, 16:38
Herald added a reviewer for D3132: Implicitly know about P2WPKH redeemscripts: Restricted Project.
May 27 2019, 16:25
deadalnix accepted D3130: Add comments indicating "Schnorr" in Schnorr-related script tests..
May 27 2019, 16:19
deadalnix accepted D2997: [CMAKE] Add support for Miniupnpc.
May 27 2019, 16:05
Herald added a reviewer for D3131: Use GetKeyForDestination in various RPCs: Restricted Project.
May 27 2019, 16:02
Herald added a reviewer for D3129: Extend validateaddress information for P2SH-embedded witness: Restricted Project.
May 27 2019, 15:36
deadalnix accepted D3102: Don't create another wallet db directory in walletdb_tests.
May 27 2019, 15:21
deadalnix accepted D3124: qa: Use node.datadir instead of tmpdir in test framework.
May 27 2019, 15:20
deadalnix committed rABC9c76f4564b0b: Update prevector (authored by deadalnix).
Update prevector
May 27 2019, 14:54
deadalnix closed D3061: Update prevector.
May 27 2019, 14:54
deadalnix accepted D3127: Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG.
May 27 2019, 14:44
deadalnix accepted D3126: Merge #14510: Avoid triggering undefined behaviour in base_uint<BITS>::bits().
May 27 2019, 14:34
deadalnix requested changes to D3124: qa: Use node.datadir instead of tmpdir in test framework.

You need to port the abc-* series of tests as well.

May 27 2019, 14:33
deadalnix accepted D3125: Fixed multiple typos.
May 27 2019, 14:31
deadalnix accepted D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
May 27 2019, 14:30
deadalnix committed rABC23ae291d3e83: Expose method to find key for a single-key destination (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Expose method to find key for a single-key destination
May 27 2019, 12:14
deadalnix closed D3122: Expose method to find key for a single-key destination.
May 27 2019, 12:14
deadalnix committed rABC3c24b5dfffba: Abstract out IsSolvable from Witnessifier (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Abstract out IsSolvable from Witnessifier
May 27 2019, 12:14
deadalnix closed D3121: Abstract out IsSolvable from Witnessifier.
May 27 2019, 12:13
Herald added a reviewer for D3122: Expose method to find key for a single-key destination: Restricted Project.
May 27 2019, 01:38
Herald added a reviewer for D3121: Abstract out IsSolvable from Witnessifier: Restricted Project.
May 27 2019, 01:34
Herald added a reviewer for D3120: (finally) remove getinfo in favor of more module-specific infos: Restricted Project.
May 27 2019, 01:22
deadalnix committed rABCb4504f19e52a: [script] Unit tests for IsMine (authored by jimpo).
[script] Unit tests for IsMine
May 27 2019, 01:17
deadalnix closed D3117: [script] Unit tests for IsMine.
May 27 2019, 01:17
deadalnix committed rABCcf54664b876c: [script] Unit tests for script/standard functions (authored by jimpo).
[script] Unit tests for script/standard functions
May 27 2019, 01:15
deadalnix closed D3116: [script] Unit tests for script/standard functions.
May 27 2019, 01:15
deadalnix closed D3119: Fix code style in keystore.cpp/crypter.cpp.
May 27 2019, 00:59
deadalnix committed rABCb453782af681: Fix code style in keystore.cpp/crypter.cpp (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Fix code style in keystore.cpp/crypter.cpp
May 27 2019, 00:59
deadalnix committed rABCb865fe7e333a: Remove the virtual specifier for functions with the override specifier (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove the virtual specifier for functions with the override specifier
May 27 2019, 00:59
deadalnix closed D3118: Remove the virtual specifier for functions with the override specifier.
May 27 2019, 00:59

May 26 2019

deadalnix accepted D2924: [txindex] Activate new transaction index code that runs in background.
May 26 2019, 23:43
deadalnix requested changes to D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
May 26 2019, 20:00
deadalnix requested changes to D3102: Don't create another wallet db directory in walletdb_tests.

The test are not independent of each other anymore.

May 26 2019, 19:57
deadalnix accepted D3102: Don't create another wallet db directory in walletdb_tests.
May 26 2019, 19:56
Herald added a reviewer for D3119: Fix code style in keystore.cpp/crypter.cpp: Restricted Project.
May 26 2019, 19:51
deadalnix accepted D3115: Set InitMessage for txindex migration.
May 26 2019, 18:20
deadalnix requested changes to D3114: De-witnessing some comments.
May 26 2019, 18:19
deadalnix added inline comments to D3116: [script] Unit tests for script/standard functions.
May 26 2019, 18:16
Herald added a reviewer for D3118: Remove the virtual specifier for functions with the override specifier: Restricted Project.
May 26 2019, 18:07
Herald added a reviewer for D3117: [script] Unit tests for IsMine: Restricted Project.
May 26 2019, 17:49
Herald added a reviewer for D3116: [script] Unit tests for script/standard functions: Restricted Project.
May 26 2019, 17:34
deadalnix committed rABC1f2a6d15575b: Comments: More comments on functions/globals in standard.h. (authored by jimpo).
Comments: More comments on functions/globals in standard.h.
May 26 2019, 10:13
deadalnix closed D3113: Comments: More comments on functions/globals in standard.h..
May 26 2019, 10:13

May 25 2019

Herald added a reviewer for D3113: Comments: More comments on functions/globals in standard.h.: Restricted Project.
May 25 2019, 15:00
deadalnix committed rABC73cca7eeebd8: [refactor] GetAccount{PubKey,Address} -> GetAccountDestination (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[refactor] GetAccount{PubKey,Address} -> GetAccountDestination
May 25 2019, 00:39
deadalnix closed D3111: [refactor] GetAccount{PubKey,Address} -> GetAccountDestination.
May 25 2019, 00:39

May 24 2019

deadalnix updated the summary of D3111: [refactor] GetAccount{PubKey,Address} -> GetAccountDestination.
May 24 2019, 22:52
Herald added a reviewer for D3111: [refactor] GetAccount{PubKey,Address} -> GetAccountDestination: Restricted Project.
May 24 2019, 22:49
deadalnix requested changes to D2997: [CMAKE] Add support for Miniupnpc.
May 24 2019, 18:24
deadalnix accepted D3017: [CMAKE] Add QT plugins according to the target platform.
May 24 2019, 17:21
deadalnix accepted D3012: Backport current GetDifficulty logic (& tests) from Core.
May 24 2019, 17:19
deadalnix accepted D3100: Interpret scripts with CHECKDATASIG opcode always valid..
May 24 2019, 15:26
deadalnix updated the diff for D3061: Update prevector.

Remove include as well.

May 24 2019, 14:36
deadalnix updated the diff for D3061: Update prevector.

Remove IS_TRIVIALLY_CONSTRUCTIBLE from compat.h

May 24 2019, 14:27

May 23 2019

deadalnix accepted D3094: [qa] don't pad transactions during make_conform_to_ctor.
May 23 2019, 23:05
deadalnix requested changes to D3100: Interpret scripts with CHECKDATASIG opcode always valid..
May 23 2019, 23:04
deadalnix accepted D3079: Merge #11742: rpc: Add testmempoolaccept.
May 23 2019, 15:31
deadalnix accepted D3080: Merge #13527: policy: Remove promiscuousmempoolflags.
May 23 2019, 15:29
deadalnix accepted D3099: Refactor walletdb_tests to use the wallet test fixture.
May 23 2019, 15:25
deadalnix accepted D3097: Fix for mismatched extern definition in wallet test.
May 23 2019, 15:22
deadalnix accepted D3096: Fix uninitialized atomic variables.
May 23 2019, 15:21
deadalnix updated the diff for D3061: Update prevector.

rebase, ping

May 23 2019, 12:12
deadalnix accepted D3091: [CMAKE] Move-only: refactor qt/CMakeLists.txt.
May 23 2019, 12:02
deadalnix accepted D3092: Remove BIP9 dead code in util.py.
May 23 2019, 12:00
deadalnix accepted D3069: Add CHECKDATASIG to standard flags..
May 23 2019, 12:00
deadalnix accepted D3093: Remove AcceptToMemoryPoolWithTime default args.
May 23 2019, 11:59

May 22 2019

deadalnix accepted D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
May 22 2019, 00:13
deadalnix requested changes to D3080: Merge #13527: policy: Remove promiscuousmempoolflags.
May 22 2019, 00:07
deadalnix requested changes to D3079: Merge #11742: rpc: Add testmempoolaccept.
May 22 2019, 00:00

May 21 2019

deadalnix requested changes to D2735: Add scripted-diffs verification into arcanist.

This is not a workflow we can run on diff. The whole approach is unsound. See previous comments as to why. Right now, arc diff supports unclean tree and this breaks that. I don't really see how this can be integrated in an automated workflow, but regardless, this is not it.

May 21 2019, 23:52
deadalnix accepted D3078: Merge #10503: Use REJECT_DUPLICATE for already known and conflicted txn.

This is rather disconcerting that this comes with no tests.

May 21 2019, 23:49
deadalnix accepted D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs.
May 21 2019, 23:48
deadalnix accepted D3081: [qa] Delete cookie file before starting node.
May 21 2019, 23:32
deadalnix added inline comments to D2997: [CMAKE] Add support for Miniupnpc.
May 21 2019, 23:15
deadalnix accepted D3082: qa: Cache only chain and wallet for regtest datadir.
May 21 2019, 21:48
deadalnix accepted D3083: Remove sleep in feature_config_args.
May 21 2019, 21:47
deadalnix accepted D3084: [tests] bind functional test nodes to 127.0.0.1.
May 21 2019, 21:46
deadalnix requested changes to D3017: [CMAKE] Add QT plugins according to the target platform.
May 21 2019, 21:24
deadalnix accepted D3063: Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags.
May 21 2019, 21:19
deadalnix accepted D3089: Merge #13522: [tests] Fix p2p_sendheaders race.
May 21 2019, 21:16
deadalnix accepted D3088: Merge #13350: [tests] Add logging to provide anchor points when debugging p2p_sendheaders.
May 21 2019, 21:16
deadalnix accepted D3087: Merge #13192: [tests] Fixed intermittent failure in p2p_sendheaders.py..
May 21 2019, 21:15
deadalnix accepted D3086: Merge #12849: Tests: Add logging in loops in p2p_sendhears.py.
May 21 2019, 21:14
deadalnix accepted D3085: Merge #11707: [tests] Fix sendheaders.
May 21 2019, 21:13

May 20 2019

deadalnix accepted D3074: Fix undefined behavior in avalanche.cpp.
May 20 2019, 20:29