Page MenuHomePhabricator
Feed Advanced Search

Oct 1 2019

jasonbcox committed rABC5ab2f96ed68d: Add phpcs exclusion for strict_types declararion (authored by jasonbcox).
Add phpcs exclusion for strict_types declararion
Oct 1 2019, 18:10
jasonbcox closed D4193: Add phpcs exclusion for strict_types declararion.
Oct 1 2019, 18:10
jasonbcox added inline comments to D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.
Oct 1 2019, 18:05
jasonbcox added inline comments to D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.
Oct 1 2019, 17:56
jasonbcox created D4193: Add phpcs exclusion for strict_types declararion.
Oct 1 2019, 17:54

Sep 30 2019

jasonbcox updated the summary of D4184: Change CI builds to use utf-8 encoding.
Sep 30 2019, 23:06
jasonbcox created D4184: Change CI builds to use utf-8 encoding.
Sep 30 2019, 23:06
jasonbcox created D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.
Sep 30 2019, 23:04
jasonbcox requested changes to D4179: Return void instead of bool for functions that cannot fail.
Sep 30 2019, 16:34
jasonbcox created D4181: Updated release-process to use github-release.sh.
Sep 30 2019, 16:30
jasonbcox added inline comments to D4180: Added more explicit instructions for release tagging.
Sep 30 2019, 16:28
jasonbcox created D4180: Added more explicit instructions for release tagging.
Sep 30 2019, 16:26
jasonbcox committed rABC65e770d8d5b5: Added a script for creating Github release drafts (authored by jasonbcox).
Added a script for creating Github release drafts
Sep 30 2019, 16:10
jasonbcox closed D3714: Added a script for creating Github release drafts.
Sep 30 2019, 16:10
jasonbcox requested review of D4177: Bump version to 0.20.4.
Sep 30 2019, 16:00

Sep 27 2019

jasonbcox created D4177: Bump version to 0.20.4.
Sep 27 2019, 23:10
jasonbcox committed rSTAGING588f6e958c94: Update seeds (authored by jasonbcox).
Update seeds
Sep 27 2019, 22:49
jasonbcox committed rSTAGING458149b29852: Updated manpages for 0.20.3 release (authored by jasonbcox).
Updated manpages for 0.20.3 release
Sep 27 2019, 22:49
jasonbcox committed rSTAGINGdbba49707004: Updated chainparams (authored by jasonbcox).
Updated chainparams
Sep 27 2019, 22:49
jasonbcox committed rSTAGING283e25d959c0: Added README for generating chainparams constants (authored by jasonbcox).
Added README for generating chainparams constants
Sep 27 2019, 22:49
jasonbcox committed rSTAGINGe03ddb98ec2c: Added a script to generate chainparams constants from intermediate files (authored by jasonbcox).
Added a script to generate chainparams constants from intermediate files
Sep 27 2019, 22:49
jasonbcox committed rSTAGING9d80a5e3f9b7: Added net debug info to IBD builds (authored by jasonbcox).
Added net debug info to IBD builds
Sep 27 2019, 22:49
jasonbcox committed rSTAGING5c01ead3ea53: Fix errant newline in make_chainparams (authored by jasonbcox).
Fix errant newline in make_chainparams
Sep 27 2019, 22:48
jasonbcox committed rSTAGINGd99b0bb6dcf5: Fix missing newline in make_chainparams (authored by jasonbcox).
Fix missing newline in make_chainparams
Sep 27 2019, 22:48
jasonbcox committed rSTAGING7ea9778c492e: [RPC] Fix header guard comment (authored by jasonbcox).
[RPC] Fix header guard comment
Sep 27 2019, 22:48
jasonbcox updated the diff for D3714: Added a script for creating Github release drafts.

Fixed according to feedback (see comments)

Sep 27 2019, 22:42
jasonbcox added inline comments to D3714: Added a script for creating Github release drafts.
Sep 27 2019, 22:23
jasonbcox abandoned D4172: Moved Misbehaving() overload to header file.

I think you're right.

Sep 27 2019, 22:16
jasonbcox accepted D4168: tiny refactor for ArgsManager.
Sep 27 2019, 22:00
jasonbcox accepted D4170: Add AssertLockHeld assertions in CWallet::ListCoins.
Sep 27 2019, 21:59
jasonbcox accepted D4169: Document RPC method aliasing.
Sep 27 2019, 21:54
jasonbcox requested changes to D4174: utils: Convert Windows args to utf-8 string.

The backport looks ok comparing to the original PR, but the test is broken.

Sep 27 2019, 21:48
jasonbcox accepted D4173: doxygen: Fix member comments.

The comments in txmempool.h are no longer trailing, but I don't think gaining ownership on those comments is worth it.

Sep 27 2019, 18:10
jasonbcox requested review of D4150: Merge #12218: net: Move misbehaving logging to net logging category.

There are several extra calls to Misbehaving from our codebase that require updating.

Sep 27 2019, 17:24
jasonbcox created D4172: Moved Misbehaving() overload to header file.
Sep 27 2019, 17:22
jasonbcox abandoned D4163: Include 0.19.x seeds until more nodes have upgraded.
Sep 27 2019, 16:09
jasonbcox committed rABC588f6e958c94: Update seeds (authored by jasonbcox).
Update seeds
Sep 27 2019, 15:49
jasonbcox closed D4161: Update seeds.
Sep 27 2019, 15:49
jasonbcox updated the summary of D4161: Update seeds.
Sep 27 2019, 15:41
jasonbcox committed rABC458149b29852: Updated manpages for 0.20.3 release (authored by jasonbcox).
Updated manpages for 0.20.3 release
Sep 27 2019, 15:39
jasonbcox closed D4162: Updated manpages for 0.20.3 release.
Sep 27 2019, 15:39
jasonbcox committed rABCdbba49707004: Updated chainparams (authored by jasonbcox).
Updated chainparams
Sep 27 2019, 15:36
jasonbcox closed D4158: Updated chainparams.
Sep 27 2019, 15:36
jasonbcox committed rABC283e25d959c0: Added README for generating chainparams constants (authored by jasonbcox).
Added README for generating chainparams constants
Sep 27 2019, 15:30
jasonbcox closed D4157: Added README for generating chainparams constants.
Sep 27 2019, 15:30
jasonbcox updated the diff for D4150: Merge #12218: net: Move misbehaving logging to net logging category.

Addressed feedback:

  • Reverted back to using *CNode rather than NodeId for calls to Misbehaving()
  • Removed superfluous peer numbers: Peer %d did something... -> Peer did something...
  • Added back descriptive error codes.
Sep 27 2019, 00:41

Sep 26 2019

jasonbcox updated the summary of D4161: Update seeds.
Sep 26 2019, 21:37
jasonbcox updated the diff for D4161: Update seeds.

This version of the patch gets a much better seed list.

Sep 26 2019, 21:36
jasonbcox created D4163: Include 0.19.x seeds until more nodes have upgraded.
Sep 26 2019, 21:28
jasonbcox created D4162: Updated manpages for 0.20.3 release.
Sep 26 2019, 21:15
jasonbcox planned changes to D4161: Update seeds.
Sep 26 2019, 21:06
jasonbcox created D4161: Update seeds.
Sep 26 2019, 21:06
jasonbcox committed rABC9d80a5e3f9b7: Added net debug info to IBD builds (authored by jasonbcox).
Added net debug info to IBD builds
Sep 26 2019, 19:26
jasonbcox closed D4159: Added net debug info to IBD builds.
Sep 26 2019, 19:25
jasonbcox created D4159: Added net debug info to IBD builds.
Sep 26 2019, 19:02
jasonbcox updated the diff for D4157: Added README for generating chainparams constants.

Added missing output file

Sep 26 2019, 18:25
jasonbcox updated the summary of D4158: Updated chainparams.
Sep 26 2019, 18:23
jasonbcox created D4158: Updated chainparams.
Sep 26 2019, 18:22
jasonbcox created D4157: Added README for generating chainparams constants.
Sep 26 2019, 17:56
jasonbcox committed rABCe03ddb98ec2c: Added a script to generate chainparams constants from intermediate files (authored by jasonbcox).
Added a script to generate chainparams constants from intermediate files
Sep 26 2019, 17:39
jasonbcox closed D4120: Added a script to generate chainparams constants from intermediate files.
Sep 26 2019, 17:39

Sep 25 2019

jasonbcox requested changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

The regression fix is still open: https://github.com/bitcoin/bitcoin/pull/16161

Sep 25 2019, 17:35
jasonbcox updated the diff for D4120: Added a script to generate chainparams constants from intermediate files.

Added assert

Sep 25 2019, 17:30
jasonbcox added inline comments to D4120: Added a script to generate chainparams constants from intermediate files.
Sep 25 2019, 17:30
jasonbcox requested review of D3694: Update the github issue template to include disclosure policy.

Asking people to contact by mail is the perfect way to ensure that you'll have to answer the same questions again and again.

Sep 25 2019, 17:25
jasonbcox added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

Update on my side: we're waiting for one last ETA from a responsible disclosure. I will green this once they have applied a fix.

Sep 25 2019, 17:20
jasonbcox accepted D4147: [CMAKE] Install the man pages.
Sep 25 2019, 17:18

Sep 24 2019

jasonbcox requested changes to D4147: [CMAKE] Install the man pages.
Sep 24 2019, 22:37
jasonbcox accepted D4149: Move cs_main locking annotations from .cpp to .h.
Sep 24 2019, 22:35
jasonbcox updated the diff for D3714: Added a script for creating Github release drafts.

Fixed remaining lint issues

Sep 24 2019, 22:32
jasonbcox updated the diff for D4150: Merge #12218: net: Move misbehaving logging to net logging category.

Fixed missed reason -> message

Sep 24 2019, 21:22
jasonbcox added inline comments to D4150: Merge #12218: net: Move misbehaving logging to net logging category.
Sep 24 2019, 21:20
jasonbcox created D4150: Merge #12218: net: Move misbehaving logging to net logging category.
Sep 24 2019, 21:13
jasonbcox accepted D4142: Remove redundant variables, statements and forward declarations.
Sep 24 2019, 17:58
jasonbcox updated the diff for D4120: Added a script to generate chainparams constants from intermediate files.

Incorporated feedback with a minor adjustment to simplify the formatting of newlines at the beginning and end of the generated output.

Sep 24 2019, 17:18
jasonbcox committed rABC5c01ead3ea53: Fix errant newline in make_chainparams (authored by jasonbcox).
Fix errant newline in make_chainparams
Sep 24 2019, 16:32
jasonbcox closed D4140: Fix errant newline in make_chainparams.
Sep 24 2019, 16:32

Sep 23 2019

jasonbcox accepted D4137: [CMAKE] Add the check-security target.
Sep 23 2019, 23:56
jasonbcox accepted D4136: [CMAKE] Add the check-symbols target.
Sep 23 2019, 23:55
jasonbcox updated the diff for D3714: Added a script for creating Github release drafts.

Changed behavior: warn -> error on asset upload failure.

Sep 23 2019, 23:45
jasonbcox planned changes to D3714: Added a script for creating Github release drafts.
Sep 23 2019, 23:39
jasonbcox updated the diff for D3714: Added a script for creating Github release drafts.

Simplified and cleaned up script logic according to feedback.

Sep 23 2019, 23:35
jasonbcox abandoned D3502: Added a script to generate chainparams constants header files.

Part 2: D4120

Sep 23 2019, 21:58
jasonbcox accepted D4141: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3.
Sep 23 2019, 21:56
jasonbcox requested changes to D4142: Remove redundant variables, statements and forward declarations.

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

Sep 23 2019, 21:52
jasonbcox accepted D4119: Merge #13201: [qa] Handle disconnect_node race.

Macro likestamp:

Sep 23 2019, 21:51
jasonbcox accepted D4139: Merge #13402: Document validationinterace callback blocking deadlock potential..
Sep 23 2019, 21:49
jasonbcox accepted D4138: Revert change to PreciousBlock() comment made in D1182.

I don't mind this since resolving merge conflicts against these comments is becoming tiresome. Only downside is that we're losing a more valuable explanation of what a "precious" block is, but inspection of the code solves this.

Sep 23 2019, 21:47
jasonbcox committed rABCd99b0bb6dcf5: Fix missing newline in make_chainparams (authored by jasonbcox).
Fix missing newline in make_chainparams
Sep 23 2019, 21:43
jasonbcox closed D4122: Fix missing newline in make_chainparams.
Sep 23 2019, 21:42
jasonbcox committed rABC7ea9778c492e: [RPC] Fix header guard comment (authored by jasonbcox).
[RPC] Fix header guard comment
Sep 23 2019, 21:42
jasonbcox closed D4123: [RPC] Fix header guard comment.
Sep 23 2019, 21:42
jasonbcox updated the test plan for D4120: Added a script to generate chainparams constants from intermediate files.
Sep 23 2019, 21:39
jasonbcox updated the test plan for D4120: Added a script to generate chainparams constants from intermediate files.
Sep 23 2019, 21:36
jasonbcox updated the test plan for D4140: Fix errant newline in make_chainparams.
Sep 23 2019, 21:33
jasonbcox updated the summary of D4120: Added a script to generate chainparams constants from intermediate files.
Sep 23 2019, 21:33
jasonbcox updated the diff for D4120: Added a script to generate chainparams constants from intermediate files.

Added generated files and migrated chainparams.cpp to use the new constants.

Sep 23 2019, 21:32
jasonbcox updated the diff for D4140: Fix errant newline in make_chainparams.

Fixed tests

Sep 23 2019, 21:29
jasonbcox created D4140: Fix errant newline in make_chainparams.
Sep 23 2019, 18:31
jasonbcox accepted D4072: Abstract out BlockAssembler options.
Sep 23 2019, 16:20