- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 1 2019
Sep 30 2019
Sep 27 2019
Fixed according to feedback (see comments)
I think you're right.
The backport looks ok comparing to the original PR, but the test is broken.
The comments in txmempool.h are no longer trailing, but I don't think gaining ownership on those comments is worth it.
In D4150#99724, @deadalnix wrote:There are several extra calls to Misbehaving from our codebase that require updating.
Addressed feedback:
- Reverted back to using *CNode rather than NodeId for calls to Misbehaving()
- Removed superfluous peer numbers: Peer %d did something... -> Peer did something...
- Added back descriptive error codes.
Sep 26 2019
This version of the patch gets a much better seed list.
Added missing output file
Sep 25 2019
The regression fix is still open: https://github.com/bitcoin/bitcoin/pull/16161
Added assert
In D3694#95156, @deadalnix wrote:Asking people to contact by mail is the perfect way to ensure that you'll have to answer the same questions again and again.
Update on my side: we're waiting for one last ETA from a responsible disclosure. I will green this once they have applied a fix.
Sep 24 2019
Fixed remaining lint issues
Fixed missed reason -> message
Incorporated feedback with a minor adjustment to simplify the formatting of newlines at the beginning and end of the generated output.
Sep 23 2019
Changed behavior: warn -> error on asset upload failure.
Simplified and cleaned up script logic according to feedback.
Part 2: D4120
Can you clarify if the other instances are missing or all of them are already applied to the codebase?
I don't mind this since resolving merge conflicts against these comments is becoming tiresome. Only downside is that we're losing a more valuable explanation of what a "precious" block is, but inspection of the code solves this.
Added generated files and migrated chainparams.cpp to use the new constants.
Fixed tests