Running some tests on the build agents

build-extended-tests all green: https://build.bitcoinabc.org/viewLog.html?buildId=21344&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildResultsDiv
Run time is ~35 minutes.

This diff is doing at least 3 things that aren't in the summary or title. Why not do nit-fixes in a separate diff and make this an easily reviewable, small change?

Tested the installer/uninstaller on a Win 10 (64bit) machine.

Cleaned up tests and lint issues

Looks like the stack is clearing up. Please don't land this until D3950 is green.

Thanks for explaining. I think there's some minor improvements we can make later, but they don't need to block this diff specifically.

In D4240#102152, @deadalnix wrote:

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

In D4241#102149, @deadalnix wrote:

First, I'm not convinced this is ambiguous. What would you sign in there that makes any sense? Is that worth breaking things? Second, the test plan doesn't cover the feature whatsoever.

I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.

No word from them yet, though they're expected to do a release soon. Pinging them again.

I don't agree that this is easier to read, but I do agree with where this is heading and that it will integrate with ArgsManager better.

testplan doesn't verify that all modified defaults are still set as expected

For testing the defaults, the testplan should *not* include various arguments.

Good catch.