Page MenuHomePhabricator
Feed Advanced Search

Oct 20 2020

jasonbcox accepted D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Oct 20 2020, 15:44
jasonbcox closed T614: Backport Core PR 11640 as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T613: Backport Core PR 10587 as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T612: Backport Core PR 10408, a subtask of T613: Backport Core PR 10587, as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T612: Backport Core PR 10408 as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T558: Backport Core PR 12830 as Resolved.
Oct 20 2020, 00:35 · Bootcamp, Restricted Project
jasonbcox closed T246: Testing scripts should run all tests as Resolved.
Oct 20 2020, 00:34 · Bootcamp
jasonbcox closed T189: Ensure documentation for new developers is easy to understand as Resolved.

Resolving this since the docs are constantly improving and this task is too open-ended. Patches to improve the docs further are always welcome.

Oct 20 2020, 00:33 · Bootcamp
jasonbcox closed T191: Fix missing-braces warnings. as Resolved.
Oct 20 2020, 00:29 · Bootcamp
jasonbcox closed T321: Create test to check node banning behavior as Resolved.
Oct 20 2020, 00:28 · Bootcamp
jasonbcox updated the diff for D7994: [build-bot] Persist build info between redeployments.

Rebase

Oct 20 2020, 00:27
jasonbcox updated the diff for D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Rebase

Oct 20 2020, 00:25
jasonbcox updated the diff for D7995: Merge #16931: test: add unittests for CheckProofOfWork.

Rebase so that CI passes with the new build-debug config

Oct 20 2020, 00:25
jasonbcox requested review of D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.
Oct 20 2020, 00:20

Oct 19 2020

jasonbcox requested review of D7995: Merge #16931: test: add unittests for CheckProofOfWork.
Oct 19 2020, 23:58
jasonbcox accepted D7988: rpc: Remove mempool global from miner.
Oct 19 2020, 23:36
jasonbcox requested changes to D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Oct 19 2020, 22:53
jasonbcox accepted D7989: Add util::Ref class as temporary alternative for c++17 std::any.
Oct 19 2020, 22:48
jasonbcox requested review of D7994: [build-bot] Persist build info between redeployments.
Oct 19 2020, 22:32
jasonbcox accepted D7982: [CI] Improve the error snippet in diffs when a test fails.
Oct 19 2020, 16:19

Oct 16 2020

jasonbcox closed D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 23:39
jasonbcox committed rABC73d648a23683: Merge #17564: rpc: Use mempool from node context instead of global (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #17564: rpc: Use mempool from node context instead of global
Oct 16 2020, 23:39
jasonbcox closed D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 22:23
jasonbcox committed rABC3e158f2af481: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some… (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some…
Oct 16 2020, 22:23
jasonbcox updated the diff for D7966: Merge #17564: rpc: Use mempool from node context instead of global.
  • Removed an unnecessary include
  • Patched changes onto estimateSmartFee since our code diverges from Core
Oct 16 2020, 22:13
jasonbcox planned changes to D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 22:02
jasonbcox requested review of D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 21:52
jasonbcox requested review of D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 21:07
jasonbcox closed D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 19:19
jasonbcox committed rABC39fae5b8b23d: [land-bot] Give a reasonable error when a revision cannot be found (authored by jasonbcox).
[land-bot] Give a reasonable error when a revision cannot be found
Oct 16 2020, 19:19
jasonbcox closed D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 19:09
jasonbcox committed rABC9306dc3d8e81: [land-bot] Allow users to specify the branch/commit in order to determine the… (authored by jasonbcox).
[land-bot] Allow users to specify the branch/commit in order to determine the…
Oct 16 2020, 19:09
jasonbcox requested review of D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 17:52
jasonbcox closed D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 16 2020, 17:27
jasonbcox committed rABC12d862c0dffa: [land-bot] Add a sanity rebase after running smoke tests (authored by jasonbcox).
[land-bot] Add a sanity rebase after running smoke tests
Oct 16 2020, 17:27
jasonbcox requested review of D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:50
jasonbcox planned changes to D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:47
jasonbcox requested review of D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:47
jasonbcox accepted D7957: bitcoin-wallet: Add a missing closing parenthesis in the help.
Oct 16 2020, 15:58
jasonbcox accepted D7945: UTXO snapshot creation (dumptxoutset).
Oct 16 2020, 00:56

Oct 15 2020

jasonbcox closed D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 19:29
jasonbcox committed rABC2c98a843a474: [build-bot] Fix character escapes in ignore list (authored by jasonbcox).
[build-bot] Fix character escapes in ignore list
Oct 15 2020, 19:29
jasonbcox closed D7942: Use new roadmap link.
Oct 15 2020, 19:00
jasonbcox committed rABCWEBbac85b76fb06: Use new roadmap link (authored by jasonbcox).
Use new roadmap link
Oct 15 2020, 19:00
jasonbcox closed D7725: [CI] Do not wait too long for build logs to flush.
Oct 15 2020, 18:49
jasonbcox committed rABCc1ff352e013c: [CI] Do not wait too long for build logs to flush (authored by jasonbcox).
[CI] Do not wait too long for build logs to flush
Oct 15 2020, 18:49
jasonbcox requested review of D7942: Use new roadmap link.
Oct 15 2020, 17:29
jasonbcox updated the diff for D7725: [CI] Do not wait too long for build logs to flush.

Rebase

Oct 15 2020, 16:46
jasonbcox accepted D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.
Oct 15 2020, 16:38
jasonbcox closed D7920: [land-bot] Queue the HEAD revision by default.
Oct 15 2020, 16:38
jasonbcox committed rABCa6b0545ead7a: [land-bot] Queue the HEAD revision by default (authored by jasonbcox).
[land-bot] Queue the HEAD revision by default
Oct 15 2020, 16:38
jasonbcox requested review of D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 16:29

Oct 14 2020

jasonbcox closed D7921: Merge #17251: net: SocketHandler logs peer id for close and disconnect.
Oct 14 2020, 22:13
jasonbcox committed rABC7fa3480bcc65: Merge #17251: net: SocketHandler logs peer id for close and disconnect (authored by fanquake <fanquake@gmail.com>).
Merge #17251: net: SocketHandler logs peer id for close and disconnect
Oct 14 2020, 22:13
jasonbcox requested review of D7921: Merge #17251: net: SocketHandler logs peer id for close and disconnect.
Oct 14 2020, 20:52
jasonbcox requested review of D7920: [land-bot] Queue the HEAD revision by default.
Oct 14 2020, 19:15
jasonbcox accepted D7917: [backport#14879]Add warning messages to the debug window.
Oct 14 2020, 17:09
jasonbcox accepted D7919: doc: add default bitcoin.conf locations.
Oct 14 2020, 17:06
jasonbcox closed D7911: [land-bot] Add basic test coverage.
Oct 14 2020, 16:29
jasonbcox committed rABC3b4e698c7e84: [land-bot] Add basic test coverage (authored by jasonbcox).
[land-bot] Add basic test coverage
Oct 14 2020, 16:29
jasonbcox accepted D7918: [CI] Add required packages for building and uploading a DEB file.
Oct 14 2020, 16:07
jasonbcox closed D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 14 2020, 15:54
jasonbcox committed rABC8fc318140dfd: Merge #16470: test: Fail early on disconnect in mininode.wait_for_* (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16470: test: Fail early on disconnect in mininode.wait_for_*
Oct 14 2020, 15:54
jasonbcox accepted D7916: [WEBSITE] Don't special case 0.22.3 and always use xvfb-run.
Oct 14 2020, 15:39
jasonbcox accepted D7913: Don't enforce xvfb for generating the man pages.
Oct 14 2020, 15:31

Oct 13 2020

jasonbcox added inline comments to D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 13 2020, 23:24
jasonbcox requested review of D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 13 2020, 23:22
jasonbcox updated the summary of D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 13 2020, 22:20
jasonbcox updated the diff for D7468: [land-bot] Add a sanity rebase after running smoke tests.

Make it more robust and add tests (now depends on D7911)

Oct 13 2020, 22:19
jasonbcox requested review of D7911: [land-bot] Add basic test coverage.
Oct 13 2020, 22:07
jasonbcox closed D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 21:26
jasonbcox committed rABC8c361009afdd: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
Oct 13 2020, 21:26
jasonbcox requested review of D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 16:26
jasonbcox planned changes to D7899: Test patch; please ignore.
Oct 13 2020, 00:04
jasonbcox requested review of D7899: Test patch; please ignore.
Oct 13 2020, 00:04

Oct 12 2020

jasonbcox requested changes to D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.

While OUTPUT_TYPES is not itself useful, this patch is only going to induce merge conflicts. This trade-off does not seem worth it since it does not get rid of a substantial amount of code.

Oct 12 2020, 23:47
jasonbcox closed D7829: Bump version to 0.22.5.
Oct 12 2020, 23:00
jasonbcox committed rABC943fb252a21e: Bump version to 0.22.5 (authored by jasonbcox).
Bump version to 0.22.5
Oct 12 2020, 23:00
jasonbcox accepted D7896: [backport#15163] Correct units for "-dbcache" and "-prune".
Oct 12 2020, 22:23
jasonbcox added a comment to D7894: [Qt] Restore < Qt5.6 compatibility for addAction.

Is this change necessary given D7893 ?

Oct 12 2020, 22:15
jasonbcox accepted D7895: qt: Fix Window -> Minimize menu item on linux.
Oct 12 2020, 22:15

Oct 8 2020

jasonbcox accepted D7834: wallet: Prefer full destination groups in coin selection.
Oct 8 2020, 23:49
jasonbcox closed D7811: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2].
Oct 8 2020, 23:13
jasonbcox committed rABCd899b47131c5: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part…
Oct 8 2020, 23:13
jasonbcox closed D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.
Oct 8 2020, 23:13
jasonbcox committed rABC082ae8450192: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18192: Bugfix: Wallet: Safely deal with change in the address book
Oct 8 2020, 23:13
jasonbcox closed D7831: Cleanup superfluous newline.
Oct 8 2020, 22:33
jasonbcox committed rABC2179ddf0a598: Cleanup superfluous newline (authored by jasonbcox).
Cleanup superfluous newline
Oct 8 2020, 22:32
jasonbcox closed D7830: Remove archiving release notes from release process.
Oct 8 2020, 22:13
jasonbcox committed rABC9a3d5bcc7deb: Remove archiving release notes from release process (authored by jasonbcox).
Remove archiving release notes from release process
Oct 8 2020, 22:12
jasonbcox updated the diff for D7811: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2].

Rebase

Oct 8 2020, 21:56
jasonbcox closed D7823: Cleanup unused old_label variable.
Oct 8 2020, 21:01
jasonbcox committed rABCba9b046e0fd1: Cleanup unused old_label variable (authored by jasonbcox).
Cleanup unused old_label variable
Oct 8 2020, 21:01
jasonbcox requested review of D7831: Cleanup superfluous newline.
Oct 8 2020, 20:25
jasonbcox requested review of D7830: Remove archiving release notes from release process.
Oct 8 2020, 20:24
jasonbcox requested review of D7829: Bump version to 0.22.5.
Oct 8 2020, 20:17
jasonbcox closed D7825: Some more release notes.
Oct 8 2020, 20:14
jasonbcox committed rABC866495d927d6: Some more release notes (authored by jasonbcox).
Some more release notes
Oct 8 2020, 20:14
jasonbcox closed D7827: [buildbot] Fix ref master to be full ref name.
Oct 8 2020, 19:16
jasonbcox committed rABCd9fd0b1a8163: [buildbot] Fix ref master to be full ref name (authored by jasonbcox).
[buildbot] Fix ref master to be full ref name
Oct 8 2020, 19:16