Page MenuHomePhabricator
Feed All Stories

Jan 8 2021

PiRK added a reverting change for D8770: test: check custom descendant limit in mempool_packages.py: rABCa775f0a210e3: Revert "test: check custom descendant limit in mempool_packages.py".
Jan 8 2021, 16:04
PiRK committed rABCa775f0a210e3: Revert "test: check custom descendant limit in mempool_packages.py" (authored by PiRK).
Revert "test: check custom descendant limit in mempool_packages.py"
Jan 8 2021, 16:04
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Mountain of Wealth token.
Jan 8 2021, 15:59
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 15:58
majcosta updated the diff for D8849: [cashtab] use npm ci instead of install on CI.

rebase

Jan 8 2021, 15:58
Fabien accepted D8851: Revert "test: check custom descendant limit in mempool_packages.py".
Jan 8 2021, 15:54
PiRK updated the summary of D8851: Revert "test: check custom descendant limit in mempool_packages.py".
Jan 8 2021, 15:47
PiRK requested review of D8851: Revert "test: check custom descendant limit in mempool_packages.py".
Jan 8 2021, 15:46
PiRK added a reverting change for D8770: test: check custom descendant limit in mempool_packages.py: D8851: Revert "test: check custom descendant limit in mempool_packages.py".
Jan 8 2021, 15:46
teamcity added a comment to D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 15:41
deadalnix accepted D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 15:34
deadalnix requested review of D8850: [cashtab] Update to react 17.
Jan 8 2021, 15:29
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Doubloon token.
Jan 8 2021, 15:16
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 15:16
majcosta updated the diff for D8849: [cashtab] use npm ci instead of install on CI.

fixed backports installation erroring out and fixed the issue with npm breaking when trying to talk to github via ssh

Jan 8 2021, 15:14
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

Can you add these instructions to the README? (instead of npm install, npm ci)

Jan 8 2021, 15:12
teamcity closed T1416: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Resolved.
Jan 8 2021, 14:58
deadalnix closed D8838: [cashtab] Upgrade webpack modules.
Jan 8 2021, 14:41
deadalnix committed rABC0dddb517c3f8: [cashtab] Upgrade webpack modules (authored by deadalnix).
[cashtab] Upgrade webpack modules
Jan 8 2021, 14:41
Fabien accepted D8838: [cashtab] Upgrade webpack modules.
Jan 8 2021, 14:36
deadalnix requested review of D8838: [cashtab] Upgrade webpack modules.
Jan 8 2021, 14:00
teamcity closed T1417: Build Bitcoin-ABC / Master / Make Generator is broken. as Resolved.
Jan 8 2021, 14:00
bytesofman accepted D8838: [cashtab] Upgrade webpack modules.

Never mind, I just ran the start command from the wrong folder. This is good to go.

Jan 8 2021, 13:57
bytesofman requested changes to D8838: [cashtab] Upgrade webpack modules.

npm i needs to be run to update package-lock.json after this rebase as there are additional npm modules.

Jan 8 2021, 13:54
bytesofman abandoned D8825: css-loader to highest version without breaking npm start.

Abandoned / resolved by D8841

Jan 8 2021, 13:50
teamcity triaged T1417: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
Jan 8 2021, 13:47
deadalnix updated the diff for D8838: [cashtab] Upgrade webpack modules.

Updated package-lock and rebase

Jan 8 2021, 13:43
deadalnix added a comment to D8838: [cashtab] Upgrade webpack modules.
In D8838#202946, @josephroyking wrote:

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

Jan 8 2021, 13:43
teamcity closed T1410: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Jan 8 2021, 13:38
deadalnix closed D8841: [cashtab] Downgrade css-loader.
Jan 8 2021, 13:38
deadalnix committed rABCb1515370602b: [cashtab] Downgrade css-loader (authored by deadalnix).
[cashtab] Downgrade css-loader
Jan 8 2021, 13:38
Joey King <joseph.roy.king@gmail.com> closed D8840: Remove web hosted npm module.
Jan 8 2021, 13:32
Joey King <joseph.roy.king@gmail.com> committed rABC8c026aee8a3b: Remove web hosted npm module (authored by Joey King <joseph.roy.king@gmail.com>).
Remove web hosted npm module
Jan 8 2021, 13:31
Fabien accepted D8840: Remove web hosted npm module.
Jan 8 2021, 13:13
bytesofman accepted D8841: [cashtab] Downgrade css-loader.

Looks good, I will abandon D8825 when this lands

Jan 8 2021, 13:12
alcipir requested changes to D8849: [cashtab] use npm ci instead of install on CI.

Can you add these instructions to the README? (instead of npm install, npm ci)

Jan 8 2021, 13:06
bytesofman updated the diff for D8840: Remove web hosted npm module.

Remove unused lines from useWallet.test.js

Jan 8 2021, 12:56
majcosta planned changes to D8849: [cashtab] use npm ci instead of install on CI.

investigating bustedness

Jan 8 2021, 12:50
teamcity added a comment to D8849: [cashtab] use npm ci instead of install on CI.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jan 8 2021, 12:36
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Piece of Eight token.
Jan 8 2021, 12:31
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 12:30
majcosta updated the diff for D8849: [cashtab] use npm ci instead of install on CI.

adding nodejs

Jan 8 2021, 12:29
teamcity added a comment to D8849: [cashtab] use npm ci instead of install on CI.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jan 8 2021, 12:21
teamcity triaged T1416: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
Jan 8 2021, 12:20
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Haypence token.
Jan 8 2021, 12:14
teamcity closed T1413: Build Bitcoin-ABC / Master / Build without CLI is broken. as Resolved.
Jan 8 2021, 12:14
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 12:13
majcosta requested review of D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 12:11
Fabien closed D8844: [CI] Fix gitian script path.
Jan 8 2021, 12:04
Fabien committed rABC7733537d6a33: [CI] Fix gitian script path (authored by Fabien).
[CI] Fix gitian script path
Jan 8 2021, 12:04
deadalnix requested changes to D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.

Check build failure

Jan 8 2021, 11:06
deadalnix accepted D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 11:05
teamcity added a comment to D8847: tests: simplify next_block() function in feature_block.
Jan 8 2021, 11:04
deadalnix requested changes to D8673: Add -overridednsseed for testing DNS seed behavior.
Jan 8 2021, 11:04
deadalnix accepted D8847: tests: simplify next_block() function in feature_block.
Jan 8 2021, 11:02
deadalnix accepted D8848: rand: remove getentropy() fallback for macOS < 10.12.
Jan 8 2021, 11:02
teamcity closed T1412: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jan 8 2021, 10:55
PiRK updated the summary of D8848: rand: remove getentropy() fallback for macOS < 10.12.
Jan 8 2021, 10:54
teamcity updated the summary of D8848: rand: remove getentropy() fallback for macOS < 10.12.
Jan 8 2021, 10:53
PiRK requested review of D8848: rand: remove getentropy() fallback for macOS < 10.12.
Jan 8 2021, 10:53
PiRK updated the summary of D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 10:47
PiRK updated the summary of D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 10:47
teamcity updated the summary of D8847: tests: simplify next_block() function in feature_block.
Jan 8 2021, 10:46
teamcity triaged T1413: Build Bitcoin-ABC / Master / Build without CLI is broken. as Unbreak Now! priority.
Jan 8 2021, 10:46
PiRK updated the summary of D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 10:46
PiRK requested review of D8847: tests: simplify next_block() function in feature_block.
Jan 8 2021, 10:46
majcosta accepted D8844: [CI] Fix gitian script path.
Jan 8 2021, 10:42
teamcity updated the summary of D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 10:39
PiRK requested review of D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Jan 8 2021, 10:38
teamcity added a comment to D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Jan 8 2021, 10:37
PiRK closed D8843: Fix missing header in sync.h.
Jan 8 2021, 10:34
PiRK committed rABCf602c2627c0c: Fix missing header in sync.h (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
Fix missing header in sync.h
Jan 8 2021, 10:34
PiRK accepted D8844: [CI] Fix gitian script path.
Jan 8 2021, 10:26
PiRK updated the test plan for D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Jan 8 2021, 10:25
PiRK updated the summary of D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Jan 8 2021, 10:24
teamcity updated the summary of D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Jan 8 2021, 10:16
PiRK requested review of D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Jan 8 2021, 10:15
teamcity triaged T1412: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jan 8 2021, 10:06
teamcity closed T1411: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Resolved.
Jan 8 2021, 10:04
teamcity triaged T1411: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Unbreak Now! priority.
Jan 8 2021, 09:45
Fabien closed D8839: [CI] Generate coverage reports for cashtab.
Jan 8 2021, 09:40
Fabien committed rABCb56c6036cd0b: [CI] Generate coverage reports for cashtab (authored by Fabien).
[CI] Generate coverage reports for cashtab
Jan 8 2021, 09:40
Fabien closed D8842: [CI] Improve cashtab reporting in case of a test failure.
Jan 8 2021, 09:26
Fabien committed rABC9b3702de8db9: [CI] Improve cashtab reporting in case of a test failure (authored by Fabien).
[CI] Improve cashtab reporting in case of a test failure
Jan 8 2021, 09:26
majcosta accepted D8839: [CI] Generate coverage reports for cashtab.
Jan 8 2021, 09:17
majcosta accepted D8842: [CI] Improve cashtab reporting in case of a test failure.

looks good

Jan 8 2021, 09:06
Fabien accepted D8843: Fix missing header in sync.h.
Jan 8 2021, 08:33
Fabien updated the diff for D8839: [CI] Generate coverage reports for cashtab.

Rebase on top of D8842

Jan 8 2021, 08:31
Fabien requested changes to D8840: Remove web hosted npm module.
Jan 8 2021, 08:24
Fabien added a comment to D8842: [CI] Improve cashtab reporting in case of a test failure.

The (unrelated) failure above shows how the report will look like after this diff is landed. The current report is pretty much useless, see D8840 for an example.

Jan 8 2021, 08:12
Fabien requested review of D8844: [CI] Fix gitian script path.
Jan 8 2021, 08:10
teamcity updated the summary of D8843: Fix missing header in sync.h.
Jan 8 2021, 07:37
PiRK requested review of D8843: Fix missing header in sync.h.
Jan 8 2021, 07:36
PiRK closed D8837: Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic.
Jan 8 2021, 07:35
PiRK committed rABC4ace18ab6498: Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic
Jan 8 2021, 07:35
teamcity triaged T1410: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Jan 8 2021, 07:27
PiRK closed D8770: test: check custom descendant limit in mempool_packages.py.
Jan 8 2021, 07:21
PiRK committed rABC0ea7b89e0aca: test: check custom descendant limit in mempool_packages.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: check custom descendant limit in mempool_packages.py
Jan 8 2021, 07:21
PiRK closed D8836: [refactor] interpreter: define interface for vfExec.
Jan 8 2021, 07:16
PiRK committed rABC9f3f4dd47411: [refactor] interpreter: define interface for vfExec (authored by Anthony Towns <aj@erisian.com.au>).
[refactor] interpreter: define interface for vfExec
Jan 8 2021, 07:16