The bot build ran from master, there is a bug there
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 30 2020
Jun 30 2020
Fabien added a comment to D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
teamcity added a comment to D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
Build Bitcoin ABC Diffs / Diff Testing (build-ubsan) failed.
Fabien requested review of D6785: Add an exception for the TSAN lock-order-inversion on reverselock_tests.
Fabien added a comment to D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
@bot build-ubsan
Can you rename the UBSAN exception accordingly ? See D6784
Fabien requested review of D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
jasonbcox committed rABCa654cf361a4d: Enable Axion upgrades in functional tests (authored by jasonbcox).
Enable Axion upgrades in functional tests
In D6782#164841, @deadalnix wrote:Think about cleaning up the old activation.
Enable Axion upgrades in unit tests
jasonbcox added inline comments to D6780: Add facility and test for checking if Axion upgrade is enabled.
jasonbcox committed rABC0a5d600206c0: Add facility and test for checking if Axion upgrade is enabled (authored by jasonbcox).
Add facility and test for checking if Axion upgrade is enabled
teamcity triaged T988: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken. as Unbreak Now! priority.
deadalnix updated the diff for D6775: [avalanche] separate avalanche.{h|cpp} into more relevent files.
rebase
deadalnix committed rABC193c2f510578: [avalanche] Use utility method to find slots (authored by deadalnix).
[avalanche] Use utility method to find slots
Think about cleaning up the old activation.
deadalnix committed rABC130a15b2b73b: [avalanche] Add the ability to remove and rescore peers (authored by deadalnix).
[avalanche] Add the ability to remove and rescore peers
Ok. Seems I was on the right track.
jasonbcox updated the diff for D6780: Add facility and test for checking if Axion upgrade is enabled.
Add missing comment
jasonbcox requested review of D6780: Add facility and test for checking if Axion upgrade is enabled.
It gives you how much "space" is taken in term of slots but not allocated to any slot. See https://en.wikipedia.org/wiki/Fragmentation_(computing)
Jun 29 2020
Jun 29 2020
teamcity triaged T987: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
teamcity triaged T986: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken. as Unbreak Now! priority.
majcosta updated the diff for D6721: [backport#16237 3/3] Add GetNewChangeDestination for getting new change Destinations.
rebase
deadalnix committed rABC1a731a37599a: [avalanche] Introduce a datastructure to keep track of peers (authored by deadalnix).
[avalanche] Introduce a datastructure to keep track of peers
majcosta updated the diff for D6717: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin.
rebase
majcosta updated the diff for D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
rebase
This change seems fine, but there isn't enough info in the summary to get a good picture for why this particular implementation was selected over other possible implementations. Regardless, it appears to do some job and is tested.
What does this fragmentation score give you in the future? It's not clear what this is building towards and the rest of the stack does not clarify in regards to the fragmentation. Since the fragmentation is essentially a loosely-tracked sum of gaps between entries, is it intended as a cleanup trigger once the sum exceeds some threshold? If not, then how will it be used?
jasonbcox committed rABCeb48537aa444: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
deadalnix requested review of D6779: [avalanche] Build Slot using start and score rather than start/stop.
deadalnix requested review of D6777: [avalanche] Abstract the Slot infos so that layout can be changed easily.
majcosta requested review of D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
added the missing link
majcosta updated the summary of D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
sorry about that, fixed now
deadalnix requested review of D6775: [avalanche] separate avalanche.{h|cpp} into more relevent files.
deadalnix requested changes to D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
The description is innacurate
Description is not correct.
teamcity updated the summary of D6774: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase.
teamcity added a comment to D6774: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
jasonbcox requested review of D6774: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase.
changed library order in CMakeLists.tx
rebased
Fabien committed rABCdbf3ab2a2f44: [CI] Log sanitizers output to stdout instead of log files (authored by Fabien).
[CI] Log sanitizers output to stdout instead of log files
Fabien committed rABC90aaf20e54cf: Move NodeContext from TestingSetup to BasicTestingSetup (authored by Fabien).
Move NodeContext from TestingSetup to BasicTestingSetup
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Fabien committed rABCb23802b86950: test: Check that wait_until returns if time point is in the past (authored by MarcoFalke <falke.marco@gmail.com>).
test: Check that wait_until returns if time point is in the past
Fabien committed rABCed2f9c673fdd: refactor: Make scheduler methods type safe (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Make scheduler methods type safe
Fabien committed rABCd4da1816a80c: [CI] Run the check target instead of a list of subtargets (authored by Fabien).
[CI] Run the check target instead of a list of subtargets
teamcity added a comment to D6765: test: Check that wait_until returns if time point is in the past.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D6765: test: Check that wait_until returns if time point is in the past.
Relayout the usage comment
Rebase
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.