Page MenuHomePhabricator
Feed All Stories

Oct 1 2020

majcosta updated the diff for D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.

rebase

Oct 1 2020, 18:13
jasonbcox closed D7723: Fix clang-tidy error.
Oct 1 2020, 17:48
jasonbcox committed rABC8d492105b489: Fix clang-tidy error (authored by jasonbcox).
Fix clang-tidy error
Oct 1 2020, 17:47
teamcity added a comment to D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.
Oct 1 2020, 17:40
teamcity added a comment to D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 17:38
teamcity added a comment to D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 17:35
majcosta updated the diff for D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.

removed segwit crud

Oct 1 2020, 17:30
majcosta planned changes to D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.

oh, left some segwit stuff in there, fixing it

Oct 1 2020, 17:20
majcosta accepted D7723: Fix clang-tidy error.

sigh, junior engineers

Oct 1 2020, 17:18
teamcity added a comment to D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 17:17
jasonbcox requested review of D7723: Fix clang-tidy error.
Oct 1 2020, 17:16
jasonbcox closed D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 17:13
jasonbcox committed rABCbee6c23a30e6: Fix shadowing of bin Python keyword (authored by jasonbcox).
Fix shadowing of bin Python keyword
Oct 1 2020, 17:13
teamcity added a comment to D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 17:12
teamcity added a comment to D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 17:11
teamcity updated the summary of D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 17:11
majcosta requested review of D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 17:10
teamcity added a comment to D7720: [CMAKE] Drop dependency search for the native builds.
Oct 1 2020, 17:05
teamcity added a comment to D7719: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config.
Oct 1 2020, 17:01
teamcity added a comment to D7721: [backport#17617] doc: unify unix epoch time descriptions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 17:00
teamcity updated the summary of D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 17:00
majcosta requested review of D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 17:00
teamcity added a comment to D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 16:58
Fabien requested review of D7720: [CMAKE] Drop dependency search for the native builds.
Oct 1 2020, 16:53
Fabien requested review of D7719: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config.
Oct 1 2020, 16:53
Fabien accepted D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 16:50
teamcity added a comment to D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.
Oct 1 2020, 16:39
teamcity added a comment to D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 16:38
majcosta closed D7715: [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey.
Oct 1 2020, 16:34
majcosta committed rABCbe62d940c425: [backport#17584] wallet: replace raw pointer with const reference in… (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17584] wallet: replace raw pointer with const reference in…
Oct 1 2020, 16:34
teamcity added a comment to D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 16:30
teamcity updated the summary of D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.
Oct 1 2020, 16:30
majcosta requested review of D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.
Oct 1 2020, 16:30
jasonbcox requested review of D7717: Fix shadowing of bin Python keyword.
Oct 1 2020, 16:27
teamcity added a comment to D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.
Oct 1 2020, 16:24
teamcity added a comment to D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 16:24
teamcity added a comment to D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 16:22
teamcity updated the summary of D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.
Oct 1 2020, 16:22
majcosta requested review of D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.
Oct 1 2020, 16:22
teamcity added a comment to D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 16:13
teamcity added a comment to D7715: [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey.
Oct 1 2020, 16:11
teamcity added a comment to D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 16:05
Fabien accepted D7715: [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey.
Oct 1 2020, 15:37
PiRK closed D7710: tests: Added missing tests for RPC wallet errors.
Oct 1 2020, 15:34
PiRK committed rABC1884ca2a13c8: tests: Added missing tests for RPC wallet errors (authored by Ben Carman <benthecarman@live.com>).
tests: Added missing tests for RPC wallet errors
Oct 1 2020, 15:34
teamcity added a comment to D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).
Oct 1 2020, 15:32
teamcity added a comment to D7715: [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 15:26
teamcity updated the summary of D7715: [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey.
Oct 1 2020, 15:26
majcosta requested review of D7715: [backport#17584] wallet: replace raw pointer with const reference in AddrToPubKey.
Oct 1 2020, 15:25
PiRK closed D7704: Fix assertion in CKey::SignCompact.
Oct 1 2020, 15:20
PiRK committed rABC0c7574e08812: Fix assertion in CKey::SignCompact (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
Fix assertion in CKey::SignCompact
Oct 1 2020, 15:20
PiRK added inline comments to D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 15:19
Fabien accepted D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 15:17
Fabien closed D7705: [CMAKE] Disable Jemalloc for the native OSX build.
Oct 1 2020, 15:17
Fabien committed rABCab7890b344dd: [CMAKE] Disable Jemalloc for the native OSX build (authored by Fabien).
[CMAKE] Disable Jemalloc for the native OSX build
Oct 1 2020, 15:16
PiRK updated the diff for D7714: remove some magic mining constants in functional tests.

add trailing comma

Oct 1 2020, 15:15
teamcity closed T1083: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Resolved.
Oct 1 2020, 15:15
majcosta closed D7713: [backport#17447] wallet: Make -walletdir network only.
Oct 1 2020, 15:14
majcosta committed rABC4e8ce19c380e: [backport#17447] wallet: Make -walletdir network only (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17447] wallet: Make -walletdir network only
Oct 1 2020, 15:14
teamcity added a comment to D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).
Oct 1 2020, 15:14
PiRK updated the diff for D7714: remove some magic mining constants in functional tests.

squash the second commit

Oct 1 2020, 15:12
Fabien requested changes to D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 15:12
majcosta closed D7712: [backport#17437] rpc: Expose block height of wallet transactions.
Oct 1 2020, 15:11
majcosta committed rABC6098a1cb2b25: [backport#17437] rpc: Expose block height of wallet transactions (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17437] rpc: Expose block height of wallet transactions
Oct 1 2020, 15:11
Fabien accepted D7710: tests: Added missing tests for RPC wallet errors.

Please use PR# syntax in the summary so we use the same style everywhere and can grep for it

Oct 1 2020, 15:09
teamcity added a comment to D7714: remove some magic mining constants in functional tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 15:08
teamcity updated the summary of D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 15:08
PiRK requested review of D7714: remove some magic mining constants in functional tests.
Oct 1 2020, 15:07
majcosta closed D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).
Oct 1 2020, 15:07
majcosta committed rABCd8bb96b2fd07: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`) (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17410] Rename `db` log category to `walletdb` (like `coindb`)
Oct 1 2020, 15:07
Fabien updated the summary of D7710: tests: Added missing tests for RPC wallet errors.
Oct 1 2020, 15:07
Fabien accepted D7713: [backport#17447] wallet: Make -walletdir network only.
Oct 1 2020, 15:06
Fabien accepted D7712: [backport#17437] rpc: Expose block height of wallet transactions.
Oct 1 2020, 15:05
teamcity added a comment to D7713: [backport#17447] wallet: Make -walletdir network only.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 15:03
teamcity updated the summary of D7713: [backport#17447] wallet: Make -walletdir network only.
Oct 1 2020, 15:03
majcosta requested review of D7713: [backport#17447] wallet: Make -walletdir network only.
Oct 1 2020, 15:03
Fabien accepted D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).
Oct 1 2020, 15:02
teamcity added a comment to D7708: wallet: Remove trailing whitespace from potential translation strings.
Oct 1 2020, 15:01
teamcity added a comment to D7712: [backport#17437] rpc: Expose block height of wallet transactions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 14:55
teamcity updated the summary of D7712: [backport#17437] rpc: Expose block height of wallet transactions.
Oct 1 2020, 14:55
majcosta requested review of D7712: [backport#17437] rpc: Expose block height of wallet transactions.
Oct 1 2020, 14:55
majcosta triaged T1084: Refactor pruning related code from validation.cpp as Normal priority.
Oct 1 2020, 14:53
teamcity added a comment to D7708: wallet: Remove trailing whitespace from potential translation strings.
Oct 1 2020, 14:49
teamcity added a comment to D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 14:46
teamcity updated the summary of D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).
Oct 1 2020, 14:45
majcosta requested review of D7711: [backport#17410] Rename `db` log category to `walletdb` (like `coindb`).
Oct 1 2020, 14:45
teamcity triaged T1083: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Unbreak Now! priority.
Oct 1 2020, 14:42
PiRK requested review of D7710: tests: Added missing tests for RPC wallet errors.
Oct 1 2020, 14:41
teamcity added a comment to D7706: test: tool wallet test coverage for unexpected writes to wallet.
Oct 1 2020, 14:37
deadalnix closed D7708: wallet: Remove trailing whitespace from potential translation strings.
Oct 1 2020, 14:33
deadalnix committed rABCe3f1ac00d451: wallet: Remove trailing whitespace from potential translation strings (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Remove trailing whitespace from potential translation strings
Oct 1 2020, 14:33
majcosta closed D7709: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point.
Oct 1 2020, 14:31
majcosta committed rABCe51055fa300b: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point (authored by fanquake <fanquake@gmail.com>).
[backport#17405] wallet: Remove unused boost::this_thread::interruption_point
Oct 1 2020, 14:31
majcosta closed D7698: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet.
Oct 1 2020, 14:30
majcosta committed rABCffc617b7dde7: [backport#17369] Refactor: Move encryption code between KeyMan and Wallet (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17369] Refactor: Move encryption code between KeyMan and Wallet
Oct 1 2020, 14:30
Fabien updated the diff for D7705: [CMAKE] Disable Jemalloc for the native OSX build.

Fix typo

Oct 1 2020, 14:24
Fabien accepted D7704: Fix assertion in CKey::SignCompact.
Oct 1 2020, 14:23
Fabien accepted D7708: wallet: Remove trailing whitespace from potential translation strings.
Oct 1 2020, 14:23
deadalnix accepted D7709: [backport#17405] wallet: Remove unused boost::this_thread::interruption_point.
Oct 1 2020, 14:22
teamcity added a comment to D7703: wallet: Avoid translating RPC errors when creating txs.
Oct 1 2020, 14:22