fix circular dependency by replacing the PeerManager parameter by a generic lambda function in OrphanProofPool::rescan.

Make dump() an internal method of the orphan pool, add a public rescan method that takes a peermanager as a parameter, makes a temporary copy of the pool, clears the main container and calls PeerManager::fetchOrCreatePeer on all proofs (which adds the proofs back to the main container if they are still orphans).

Make the interface destructor purely virtual, use std::make_unique

Why isn't it part of D9562 ?

I'm not super convinced this is really a plus, as it adds an indirection to something that just does one thing.

You might want to fix the Diff title... unless it really is a "pubic" interface 😂

@bot build-tsan

Inline the templatized wrapper definitions

Make the interface methods public, capitalize the typedefs, pick better class names, grind the concrete

Removing diff error import

For now, I still have slpBalancesAndUtxos in the console in prod -- it helps for testing in case there is some unforeseen issue.

We probably shouldn't ignore unsolicited messages en general.

This is doing a number of refactoring in addition to what it is actually doing. You need to split this up.

This is too big. You are touching a ton of thing everywhere here. I'm sure you can extract many refactoring from there. It doesn't matter if they are trivial, in fact that's the point, they can be landed right away and non trivial things aren't drowned into noise.

don't use an instance method on a partially constructed object, in the Delegation constructor. It works, but is fragile, it requires a specific order for member initialization.

just ignore unsollicited avalanche messages the same way we ignore unknown messages

Simplify TestNode.sendHello. Use waitfordisconnect to check banning behavior (reduces the test fragility if the logging changes)

Address review. The main change is that the proofid is now no longer part of the serialized Delegation, and no longer needed as a constructor parameter. We can always computed it from the limited id and proof master key. This removes a way for the delegation to be invalid, so I removed the validation state INCORRECT_PROOF.

typo

Comment on the tsan exception so we don't forget