Page MenuHomePhabricator
Feed All Stories

Sep 16 2021

Fabien accepted D10134: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages.
Sep 16 2021, 20:15
Fabien requested review of D10140: [avalanche] Sign the avalanche proof.
Sep 16 2021, 20:10
Joey King <joseph.roy.king@gmail.com> closed D10138: [Cashtab] Patch decimal parsing of params in wallet, extension, and components.
Sep 16 2021, 16:56
Joey King <joseph.roy.king@gmail.com> committed rABC0d9a4b367371: [Cashtab] Patch decimal parsing of params in wallet, extension, and components (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Patch decimal parsing of params in wallet, extension, and components
Sep 16 2021, 16:55
tobias_ruck closed D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.
Sep 16 2021, 16:29
tobias_ruck committed rABCe3c96f8ddab2: Fix spelling of "unreachable" in OP_CHECKMULTISIG (authored by tobias_ruck).
Fix spelling of "unreachable" in OP_CHECKMULTISIG
Sep 16 2021, 16:29
PiRK accepted D10138: [Cashtab] Patch decimal parsing of params in wallet, extension, and components.
Sep 16 2021, 16:14
PiRK added a comment to D10138: [Cashtab] Patch decimal parsing of params in wallet, extension, and components.

Note that Electrum ABC switched back to using the base unit (now XEC) in the payment URIs. And the node software does the same.

Sep 16 2021, 16:07
bytesofman requested review of D10138: [Cashtab] Patch decimal parsing of params in wallet, extension, and components.
Sep 16 2021, 15:09
teamcity updated the summary of D10137: test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles.
Sep 16 2021, 15:00
PiRK requested review of D10137: test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles.
Sep 16 2021, 15:00
Mengerian accepted D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.

I also checked that this typo isn't in Bitcoin Core, it originated with ABC here: https://reviews.bitcoinabc.org/D3474

Sep 16 2021, 14:57
teamcity updated the summary of D10136: doc: Document differences in bitcoind and bitcoin-qt locale handling.
Sep 16 2021, 14:51
PiRK requested review of D10136: doc: Document differences in bitcoind and bitcoin-qt locale handling.
Sep 16 2021, 14:50
teamcity updated the summary of D10135: Add visual accenting for the 'Create new receiving address' button.
Sep 16 2021, 14:43
PiRK requested review of D10135: Add visual accenting for the 'Create new receiving address' button.
Sep 16 2021, 14:43
PiRK closed D10132: test: Update wait_until usage in abc tests not to use the one from utils.
Sep 16 2021, 14:31
PiRK committed rABCa564bcdcd80a: test: Update wait_until usage in abc tests not to use the one from utils (authored by PiRK).
test: Update wait_until usage in abc tests not to use the one from utils
Sep 16 2021, 14:31
PiRK closed D10128: test: Update wait_until usage in tests not to use the one from utils.
Sep 16 2021, 14:29
PiRK committed rABC914e834144d0: test: Update wait_until usage in tests not to use the one from utils (authored by Seleme Topuz <seleme94@hotmail.com>).
test: Update wait_until usage in tests not to use the one from utils
Sep 16 2021, 14:29
PiRK accepted D10109: [avalanche] Add a payout script to the proof.
Sep 16 2021, 14:28
PiRK accepted D10133: [avalanche] Let buildavalancheproof take a payout address.
Sep 16 2021, 14:25
Fabien accepted D10132: test: Update wait_until usage in abc tests not to use the one from utils.
Sep 16 2021, 13:33
Fabien accepted D10128: test: Update wait_until usage in tests not to use the one from utils.
Sep 16 2021, 13:32
teamcity updated the summary of D10134: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages.
Sep 16 2021, 13:27
PiRK requested review of D10134: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messages.
Sep 16 2021, 13:27
PiRK closed D10131: chain: Remove UB CChain comparison.
Sep 16 2021, 13:24
PiRK committed rABCba848a43e275: chain: Remove UB CChain comparison (authored by Carl Dong <contact@carldong.me>).
chain: Remove UB CChain comparison
Sep 16 2021, 13:24
PiRK closed D10130: gui: Clarify block height label.
Sep 16 2021, 13:23
PiRK committed rABC6e51b724e9c9: gui: Clarify block height label (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
gui: Clarify block height label
Sep 16 2021, 13:23
PiRK closed D10129: rpc: Validate provided keys for query_options parameter in listunspent.
Sep 16 2021, 13:23
PiRK committed rABC7d31c1813b78: rpc: Validate provided keys for query_options parameter in listunspent (authored by pasta <pasta@dashboost.org>).
rpc: Validate provided keys for query_options parameter in listunspent
Sep 16 2021, 13:23
PiRK closed D10127: test: nits in TestChain100Setup.
Sep 16 2021, 13:22
PiRK committed rABCf7b6498de892: test: nits in TestChain100Setup (authored by MarcoFalke <falke.marco@gmail.com>).
test: nits in TestChain100Setup
Sep 16 2021, 13:22
Fabien requested review of D10133: [avalanche] Let buildavalancheproof take a payout address.
Sep 16 2021, 13:21
PiRK requested review of D10132: test: Update wait_until usage in abc tests not to use the one from utils.
Sep 16 2021, 13:01
PiRK requested review of D10128: test: Update wait_until usage in tests not to use the one from utils.
Sep 16 2021, 12:43
PiRK added a comment to D10128: test: Update wait_until usage in tests not to use the one from utils.

Thanks. I fixed the description.

Sep 16 2021, 12:42
PiRK updated the summary of D10128: test: Update wait_until usage in tests not to use the one from utils.
Sep 16 2021, 12:41
Fabien accepted D10131: chain: Remove UB CChain comparison.
Sep 16 2021, 12:31
Fabien accepted D10130: gui: Clarify block height label.
Sep 16 2021, 12:21
Fabien accepted D10129: rpc: Validate provided keys for query_options parameter in listunspent.
Sep 16 2021, 12:17
Fabien requested changes to D10128: test: Update wait_until usage in tests not to use the one from utils.

The PR number is wrong

Sep 16 2021, 12:15
Fabien accepted D10127: test: nits in TestChain100Setup.
Sep 16 2021, 12:14
teamcity updated the summary of D10131: chain: Remove UB CChain comparison.
Sep 16 2021, 12:12
PiRK requested review of D10131: chain: Remove UB CChain comparison.
Sep 16 2021, 12:11
teamcity updated the summary of D10130: gui: Clarify block height label.
Sep 16 2021, 12:04
PiRK requested review of D10130: gui: Clarify block height label.
Sep 16 2021, 12:04
teamcity updated the summary of D10129: rpc: Validate provided keys for query_options parameter in listunspent.
Sep 16 2021, 11:56
PiRK requested review of D10129: rpc: Validate provided keys for query_options parameter in listunspent.
Sep 16 2021, 11:56
teamcity updated the summary of D10128: test: Update wait_until usage in tests not to use the one from utils.
Sep 16 2021, 11:39
PiRK requested review of D10128: test: Update wait_until usage in tests not to use the one from utils.
Sep 16 2021, 11:39
Fabien updated the diff for D10109: [avalanche] Add a payout script to the proof.

Fix the circular dependency

Sep 16 2021, 11:35
teamcity added a comment to D10109: [avalanche] Add a payout script to the proof.
Sep 16 2021, 10:57
Fabien updated the diff for D10109: [avalanche] Add a payout script to the proof.

Use a script instead

Sep 16 2021, 10:55
Fabien retitled D10109: [avalanche] Add a payout script to the proof from [avalanche] Add a payout address to the proof to [avalanche] Add a payout script to the proof.
Sep 16 2021, 10:45
teamcity updated the summary of D10127: test: nits in TestChain100Setup.
Sep 16 2021, 09:36
PiRK requested review of D10127: test: nits in TestChain100Setup.
Sep 16 2021, 09:35
PiRK accepted D10125: Send BIP37 fRelay as false.
Sep 16 2021, 09:00
PiRK added a comment to D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.

It was wrong in multiple ways :)

Sep 16 2021, 08:57
PiRK accepted D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.
Sep 16 2021, 08:57
PiRK planned changes to D10124: add a linter for python imports.

Investigating how to tweak the parameters to avoid undoing existing multiline imports when they would be shorter than 80 characters on a single line.

Sep 16 2021, 08:55
PiRK planned changes to D10123: lint all the python imports with isort.

it needs splitting, and I'm still investigating whether it is possible to preserve the multiline imports that we already have, even if they would be shorter than 80 characters on a single line.

Sep 16 2021, 08:53
tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Verify [Add|Sub]Int63OverflowEmulated and [Add|Sub]Int63Overflow overflow for the same operands and produce the same result for for non-overflowing operands.

Sep 16 2021, 07:16
tobias_ruck updated the diff for D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.

Actually fix the typo in "unreachable" in OP_CHECKMULTISIG

Sep 16 2021, 06:59
PiRK closed D10120: [test] Add test for getblockheader verboseness.
Sep 16 2021, 04:58
PiRK committed rABCc7152f710ca1: [test] Add test for getblockheader verboseness (authored by Torhte Butler <torhte@protonmail.com>).
[test] Add test for getblockheader verboseness
Sep 16 2021, 04:58
PiRK updated the test plan for D10124: add a linter for python imports.
Sep 16 2021, 04:55
PiRK added a comment to D10124: add a linter for python imports.
$ time arc lint --everything
...
real	1m5,412s
user	4m6,869s
sys	0m35,975s
Sep 16 2021, 04:54
PiRK requested changes to D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.

Can you also remove the extra e after the h, while you are at it.

Sep 16 2021, 04:43
PiRK closed D10122: Remove a trailing comma in a linter.
Sep 16 2021, 04:37
PiRK committed rABC07cfe1721f64: Remove a trailing comma in a linter (authored by PiRK).
Remove a trailing comma in a linter
Sep 16 2021, 04:37
abc-bot committed rABCc90bbe1c1c24: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sep 16 2021, 03:19
abc-bot committed rABC2959edab9625: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sep 16 2021, 02:17
abc-bot committed rABC7b9b6256e77b: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sep 16 2021, 02:11

Sep 15 2021

tobias_ruck requested review of D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.
Sep 15 2021, 23:05
thonkle requested review of D10125: Send BIP37 fRelay as false.
Sep 15 2021, 22:08
deadalnix requested changes to D9928: Add AddInt63Overflow and SubInt63Overflow.

Ok, nevermind, the assumptions are there, but we have a file for that. This avoids baking in contradictory assumptions.

Sep 15 2021, 20:39
Fabien added a comment to D10124: add a linter for python imports.

Can you please time before/after this linter ? External linters tend to be costly.

Sep 15 2021, 19:32
Fabien requested changes to D10123: lint all the python imports with isort.

This is way too big to be reviewed, please split

Sep 15 2021, 19:30
Fabien accepted D10122: Remove a trailing comma in a linter.
Sep 15 2021, 19:24
Fabien accepted D10120: [test] Add test for getblockheader verboseness.

No need to wait for anything before landing

Sep 15 2021, 19:24
Fabien accepted D9928: Add AddInt63Overflow and SubInt63Overflow.
Sep 15 2021, 19:23
teamcity closed T1857: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Sep 15 2021, 17:39
PiRK closed D10121: docs: Correct description for getblockstats's txs field.
Sep 15 2021, 17:07
PiRK committed rABC27cf4e80cab5: docs: Correct description for getblockstats's txs field (authored by Nadav Ivgi <nadav@shesek.info>).
docs: Correct description for getblockstats's txs field
Sep 15 2021, 17:07
PiRK added a comment to D10120: [test] Add test for getblockheader verboseness.

I will wait for D10124 to land before rebasing and landing this.

Sep 15 2021, 17:06
PiRK closed D10119: Move comment about BaseIndex::DB from TxIndex::DB.
Sep 15 2021, 17:04
PiRK committed rABCbcb68a351d4e: Move comment about BaseIndex::DB from TxIndex::DB (authored by Marcin Jachymiak <marcin.jachymiak1@gmail.com>).
Move comment about BaseIndex::DB from TxIndex::DB
Sep 15 2021, 17:04
PiRK closed D10118: rpc: Add getindexinfo RPC.
Sep 15 2021, 17:03
PiRK committed rABC2a36ff1840ba: rpc: Add getindexinfo RPC (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Add getindexinfo RPC
Sep 15 2021, 17:03
PiRK closed D10117: test: Remove unused classes from p2p_leak.py.
Sep 15 2021, 17:03
PiRK committed rABC5e48e99a4b34: test: Remove unused classes from p2p_leak.py (authored by Dhruv Mehta <856960+dhruv@users.noreply.github.com>).
test: Remove unused classes from p2p_leak.py
Sep 15 2021, 17:03
PiRK updated the test plan for D10123: lint all the python imports with isort.
Sep 15 2021, 16:42
PiRK updated the summary of D10123: lint all the python imports with isort.
Sep 15 2021, 16:34
PiRK requested review of D10124: add a linter for python imports.
Sep 15 2021, 16:32
PiRK requested review of D10123: lint all the python imports with isort.
Sep 15 2021, 16:28
tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Add comment for the int64_t == long long int assertion.

Sep 15 2021, 16:28
PiRK requested review of D10122: Remove a trailing comma in a linter.
Sep 15 2021, 15:58
PiRK updated the diff for D10120: [test] Add test for getblockheader verboseness.

fix import ordering

Sep 15 2021, 14:35