Page MenuHomePhabricator
Feed All Stories

Mar 31 2020

teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

Mar 31 2020, 16:48
teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 31 2020, 16:47
teamcity added a comment to D5612: Remove Windows 32 bit build.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 31 2020, 16:45
Fabien updated the diff for D5612: Remove Windows 32 bit build.

Fix remaining win32 references in docs.

Mar 31 2020, 16:45
jasonbcox requested changes to D5612: Remove Windows 32 bit build.
Mar 31 2020, 16:38
teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Mar 31 2020, 16:36
teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

Mar 31 2020, 16:36
teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

Mar 31 2020, 16:36
Fabien planned changes to D5622: depends: xtrans: Configure flags cleanup..

Pending gitian builds

Mar 31 2020, 16:36
teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 31 2020, 16:35
teamcity added a comment to D5622: depends: xtrans: Configure flags cleanup..

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 31 2020, 16:35
teamcity updated the summary of D5622: depends: xtrans: Configure flags cleanup..
Mar 31 2020, 16:35
Fabien created D5622: depends: xtrans: Configure flags cleanup..
Mar 31 2020, 16:35
teamcity added a comment to D5621: depends: Purge libtool archives.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 31 2020, 15:52
teamcity added a comment to D5620: depends: add ability to skip building zeromq.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 31 2020, 15:46
teamcity added a comment to D5621: depends: Purge libtool archives.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 31 2020, 15:30
teamcity added a comment to D5620: depends: add ability to skip building zeromq.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 31 2020, 15:29
teamcity added a comment to D5621: depends: Purge libtool archives.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 31 2020, 15:02
teamcity updated the summary of D5621: depends: Purge libtool archives.
Mar 31 2020, 15:02
Fabien created D5621: depends: Purge libtool archives.
Mar 31 2020, 15:02
teamcity added a comment to D5614: depends: Make less assumptions about build env.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 31 2020, 14:49
teamcity added a comment to D5614: depends: Make less assumptions about build env.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 31 2020, 14:26
deadalnix accepted D5617: Add version number to the seeder.
Mar 31 2020, 13:57
teamcity added a comment to D5620: depends: add ability to skip building zeromq.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 31 2020, 13:22
teamcity updated the summary of D5620: depends: add ability to skip building zeromq.
Mar 31 2020, 13:22
Fabien created D5620: depends: add ability to skip building zeromq.
Mar 31 2020, 13:22
Fabien committed rABCee1c4e3d09ec: depends: Make less assumptions about build env (authored by Carl Dong <accounts@carldong.me>).
depends: Make less assumptions about build env
Mar 31 2020, 12:40
Fabien closed D5614: depends: Make less assumptions about build env.
Mar 31 2020, 12:40
Fabien requested review of D5612: Remove Windows 32 bit build.

@jasonbcox We will remove the i686 arch when we remove linux 32.

Mar 31 2020, 12:39
deadalnix accepted D5614: depends: Make less assumptions about build env.
Mar 31 2020, 12:35
Fabien committed rABC98ac38dd75e7: contrib: Fix test-security-check fail in Ubuntu 18.04 (authored by Chun Kuan Lee <ken2812221@gmail.com>).
contrib: Fix test-security-check fail in Ubuntu 18.04
Mar 31 2020, 12:27
Fabien closed D5610: contrib: Fix test-security-check fail in Ubuntu 18.04.
Mar 31 2020, 12:27
Fabien committed rABC981786527d2a: tests: Add test for 64-bit PE, modify 32-bit test results (authored by Chun Kuan Lee <ken2812221@gmail.com>).
tests: Add test for 64-bit PE, modify 32-bit test results
Mar 31 2020, 12:26
Fabien closed D5609: tests: Add test for 64-bit PE, modify 32-bit test results.
Mar 31 2020, 12:26
Fabien committed rABC252ab6c0bce0: Improve depends debuggability (authored by Carl Dong <accounts@carldong.me>).
Improve depends debuggability
Mar 31 2020, 12:24
Fabien closed D5608: Improve depends debuggability.
Mar 31 2020, 12:24
Fabien committed rABC1a7a047db44c: Update zmq to 4.3.1 (authored by rex4539).
Update zmq to 4.3.1
Mar 31 2020, 12:23
Fabien closed D5607: Update zmq to 4.3.1.
Mar 31 2020, 12:23
Fabien committed rABC68e6fd916098: depends: expat 2.2.6 and qt 5.9.7 (authored by fanquake <fanquake@gmail.com>).
depends: expat 2.2.6 and qt 5.9.7
Mar 31 2020, 12:21
Fabien closed D5606: depends: expat 2.2.6 and qt 5.9.7.
Mar 31 2020, 12:21
Fabien updated the diff for D5614: depends: Make less assumptions about build env.

Make the backport a single diff.

Mar 31 2020, 12:20
Fabien committed rABC752632fd6864: depends: native_protobuf: avoid system zlib (authored by Carl Dong <accounts@carldong.me>).
depends: native_protobuf: avoid system zlib
Mar 31 2020, 12:18
Fabien closed D5605: depends: native_protobuf: avoid system zlib.
Mar 31 2020, 12:18
Fabien committed rABC2a05ba02dcc7: depends: Enable unicode support on dbd for Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>).
depends: Enable unicode support on dbd for Windows
Mar 31 2020, 12:17
Fabien closed D5604: depends: Enable unicode support on dbd for Windows.
Mar 31 2020, 12:17
Fabien committed rABCe2dd83623162: [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq (authored by mruddy <6440430+mruddy@users.noreply.github.com>).
[depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq
Mar 31 2020, 12:16
Fabien closed D5603: [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq.
Mar 31 2020, 12:15
Fabien committed rABCcef0b6a2057e: build: Remove illegal spacing in darwin.mk (authored by Jon Layton <me@jonl.io>).
build: Remove illegal spacing in darwin.mk
Mar 31 2020, 12:14
Fabien closed D5602: build: Remove illegal spacing in darwin.mk.
Mar 31 2020, 12:14
Fabien committed rABC3df7a74d0e8d: depends: Add 'make clean' and 'make clean-all' rules (authored by Henrik Jonsson <me@hkjn.me>).
depends: Add 'make clean' and 'make clean-all' rules
Mar 31 2020, 12:13
Fabien closed D5601: depends: Add 'make clean' and 'make clean-all' rules.
Mar 31 2020, 12:12
Fabien committed rABC8a8007128fed: [tests] Remove rpc_zmq.py (authored by John Newbery <john@johnnewbery.com>).
[tests] Remove rpc_zmq.py
Mar 31 2020, 12:11
Fabien closed D5600: [tests] Remove rpc_zmq.py.
Mar 31 2020, 12:11
Fabien closed D5619: [CMAKE] Replace the test runner with a test wrapper.
Mar 31 2020, 12:08
Fabien committed rABC4f6559b0c623: [CMAKE] Replace the test runner with a test wrapper (authored by Fabien).
[CMAKE] Replace the test runner with a test wrapper
Mar 31 2020, 12:08
teamcity added a comment to D5619: [CMAKE] Replace the test runner with a test wrapper.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 31 2020, 12:08
deadalnix committed rABC5a74bd17d75c: Clean the native directory when using the clean target (authored by deadalnix).
Clean the native directory when using the clean target
Mar 31 2020, 12:07
deadalnix closed D5613: Clean the native directory when using the clean target.
Mar 31 2020, 12:07
Fabien committed rABC329971ea7c14: depends: zeromq 4.2.3 (authored by fanquake <fanquake@gmail.com>).
depends: zeromq 4.2.3
Mar 31 2020, 12:06
Fabien closed D5599: depends: zeromq 4.2.3.
Mar 31 2020, 12:06
Fabien closed D5598: [SECP256K1] Travis Don't run the constant time check with java tests.
Mar 31 2020, 12:02
Fabien committed rABCcb0260b37347: [SECP256K1] Travis Don't run the constant time check with java tests (authored by Fabien).
[SECP256K1] Travis Don't run the constant time check with java tests
Mar 31 2020, 12:02
deadalnix accepted D5619: [CMAKE] Replace the test runner with a test wrapper.
Mar 31 2020, 12:02
teamcity added a comment to D5619: [CMAKE] Replace the test runner with a test wrapper.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 31 2020, 11:58
Fabien created D5619: [CMAKE] Replace the test runner with a test wrapper.
Mar 31 2020, 11:58
Fabien accepted D5613: Clean the native directory when using the clean target.
Mar 31 2020, 08:03
Fabien retitled D5614: depends: Make less assumptions about build env from depends: tar: Always extract as yourself to depends: Make less assumptions about build env.
Mar 31 2020, 07:45
Fabien planned changes to D5614: depends: Make less assumptions about build env.

Will complete the backport in a single diff

Mar 31 2020, 07:40
Fabien updated the summary of D5614: depends: Make less assumptions about build env.
Mar 31 2020, 07:36
nakihito requested review of D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Updated test plan as requested.

Mar 31 2020, 01:33
nakihito updated the test plan for D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 31 2020, 01:33
nakihito updated the test plan for D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 31 2020, 01:32
teamcity added a comment to D5617: Add version number to the seeder.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 31 2020, 00:04

Mar 30 2020

nakihito updated the test plan for D5617: Add version number to the seeder.
Mar 30 2020, 23:56
teamcity added a comment to D5617: Add version number to the seeder.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 23:55
nakihito updated the diff for D5617: Add version number to the seeder.

Fix to make more consistent across executables.

Mar 30 2020, 23:55
deadalnix requested changes to D5617: Add version number to the seeder.

Good call, but this needs to be consistent accross executables.

Mar 30 2020, 23:30
deadalnix requested changes to D5614: depends: Make less assumptions about build env.

This is not the backport this claims to be. Can you update the description?

Mar 30 2020, 23:26
teamcity added a comment to D5617: Add version number to the seeder.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 23:14
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Alright, I looked at a few diffs, but this is clear that this is still not reviewable as this.

Mar 30 2020, 23:14
deadalnix requested review of D5613: Clean the native directory when using the clean target.
Mar 30 2020, 23:06
teamcity added a comment to D5617: Add version number to the seeder.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 23:05
nakihito created D5617: Add version number to the seeder.
Mar 30 2020, 23:04
nakihito abandoned D5616: Seeder gitian test.
Mar 30 2020, 22:51
teamcity added a comment to D5616: Seeder gitian test.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Mar 30 2020, 22:27
teamcity added a comment to D5616: Seeder gitian test.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 22:20
teamcity added a comment to D5616: Seeder gitian test.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

Mar 30 2020, 22:14
nakihito planned changes to D5616: Seeder gitian test.
Mar 30 2020, 22:13
teamcity added a comment to D5616: Seeder gitian test.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 22:11
nakihito created D5616: Seeder gitian test.
Mar 30 2020, 22:10
teamcity added a comment to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 20:57
nakihito updated the test plan for D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 30 2020, 20:50
deadalnix added inline comments to D5611: [DOC] Add checking the secp256k1 Travis build to the release process.
Mar 30 2020, 20:48
teamcity added a comment to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 30 2020, 20:47
nakihito updated the diff for D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Fixed some discrepancies and updated test plan.

Mar 30 2020, 20:47
nakihito updated the test plan for D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 30 2020, 20:46
Fabien requested changes to D5613: Clean the native directory when using the clean target.
Mar 30 2020, 19:50
jasonbcox added a comment to D5612: Remove Windows 32 bit build.

Also, summarizing a discussion I had with Fabien offline:
I'm of the opinion that cleaning up our codebase to get rid of 32-bit-supporting features (like reverting D5587 for example) would put us in a better state. It improves code readability to simply not have these sorts of changes when they aren't needed. Currently, our assumptions are that C++11 is well supported. Reverting D5587 would also be in line with the same spirit as D2219, which had a similar removal. However, cleaning this up too aggressively has two factors that oppose this: merge conflicts when backporting, and sudden breakage of support for 32-bit Windows. While the release containing this change will no longer support 32-bit, it seems prudent to not immediately break it while these users (if any) transition.

Mar 30 2020, 19:21
jasonbcox requested changes to D5612: Remove Windows 32 bit build.

We require a similar change to https://github.com/bitcoin/bitcoin/pull/15939/files#diff-ff7aa83852bca28e4ff420bc97c6cf7c in contrib/teamcity/setup-debian-buster.sh You happened to catch me mid-migration, so you wouldn't see test failures for this quite yet. If you'd prefer to coordinate on this in separate diff, let me know.

Mar 30 2020, 19:21
teamcity added a comment to D5611: [DOC] Add checking the secp256k1 Travis build to the release process.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 30 2020, 19:18