Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 31 2020
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Fix remaining win32 references in docs.
Pending gitian builds
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
@jasonbcox We will remove the i686 arch when we remove linux 32.
Make the backport a single diff.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Will complete the backport in a single diff
Updated test plan as requested.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Mar 30 2020
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Fix to make more consistent across executables.
Good call, but this needs to be consistent accross executables.
This is not the backport this claims to be. Can you update the description?
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Alright, I looked at a few diffs, but this is clear that this is still not reviewable as this.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.
Fixed some discrepancies and updated test plan.
Also, summarizing a discussion I had with Fabien offline:
I'm of the opinion that cleaning up our codebase to get rid of 32-bit-supporting features (like reverting D5587 for example) would put us in a better state. It improves code readability to simply not have these sorts of changes when they aren't needed. Currently, our assumptions are that C++11 is well supported. Reverting D5587 would also be in line with the same spirit as D2219, which had a similar removal. However, cleaning this up too aggressively has two factors that oppose this: merge conflicts when backporting, and sudden breakage of support for 32-bit Windows. While the release containing this change will no longer support 32-bit, it seems prudent to not immediately break it while these users (if any) transition.
We require a similar change to https://github.com/bitcoin/bitcoin/pull/15939/files#diff-ff7aa83852bca28e4ff420bc97c6cf7c in contrib/teamcity/setup-debian-buster.sh You happened to catch me mid-migration, so you wouldn't see test failures for this quite yet. If you'd prefer to coordinate on this in separate diff, let me know.