Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Aug 24 2021

majcosta accepted D9925: gui: Disable unavailable context menu items in transactions tab.
Aug 24 2021, 16:20
majcosta requested changes to D9924: qt: Remove QFont warnings with QPA=minimal.
Aug 24 2021, 16:09
majcosta accepted D9923: qt: Rename slot to updateDisplayUnit().
Aug 24 2021, 16:07
majcosta accepted D9922: qt: Overhaul ReceiveRequestDialog.
Aug 24 2021, 16:04
majcosta accepted D9921: qt: change BCH to XEC in QLabel's default text.
Aug 24 2021, 15:34
majcosta accepted D9906: test: Add p2p test for forcerelay permission.
Aug 24 2021, 15:34
majcosta accepted D9920: qt: Add privacy feature to Overview page.
Aug 24 2021, 13:35
majcosta requested changes to D9921: qt: change BCH to XEC in QLabel's default text.

see feedback left on D9920

Aug 24 2021, 11:24
majcosta requested changes to D9920: qt: Add privacy feature to Overview page.

please, make the cosmetic BCH -> XEC changes all in D9921 since they don't belong in the backport

Aug 24 2021, 11:23
majcosta accepted D9919: qt: Add BitcoinUnits::formatWithPrivacy() function.
Aug 24 2021, 11:16
majcosta added a comment to D9921: qt: change BCH to XEC in QLabel's default text.

nice catch

Aug 24 2021, 11:10
majcosta accepted D9918: Do not expose and consider -logthreadnames when it does not work.
Aug 24 2021, 11:04
majcosta accepted D9917: test: Bump timeout in wallet_import_rescan.
Aug 24 2021, 11:03
majcosta added a comment to D9916: net: fix use-after-free in tests.

can you reproduce this tsan error? I can't

Aug 24 2021, 11:02
majcosta accepted D9915: test: Explain why test logging should be used.
Aug 24 2021, 10:41
majcosta accepted D9900: doc: Describe log files + consistent paths in test READMEs.
Aug 24 2021, 10:00
majcosta accepted D9914: [Cashtab] Better looking notifications.
Aug 24 2021, 00:06

Aug 23 2021

majcosta accepted D9913: [Cashtab] Support token tx parsing from HD wallet.
Aug 23 2021, 23:44
majcosta closed D9911: Bump version to 0.24.0.
Aug 23 2021, 21:44
majcosta committed rABC6cc6847857d3: Bump version to 0.24.0 (authored by majcosta).
Bump version to 0.24.0
Aug 23 2021, 21:44
majcosta accepted D9912: [Cashtab] Remove legacy utxos state field from useWallet.js.
Aug 23 2021, 21:43
majcosta accepted D9910: [Cashtab] Deprecate obsolete websocket support.
Aug 23 2021, 21:25
majcosta accepted D9908: [Cashtab] Show fiat amount of incoming XEC txs.
Aug 23 2021, 21:23
majcosta requested changes to D9906: test: Add p2p test for forcerelay permission.

tests failing, back on your court

Aug 23 2021, 21:10
majcosta accepted D9905: gui: Fix unintialized WalletView::progressDialog.

isn't this core#18062?

Aug 23 2021, 21:03
majcosta accepted D9904: test: add missing #include.
Aug 23 2021, 21:00
majcosta accepted D9903: docs: Update Transifex and doxygen links.
Aug 23 2021, 20:59
majcosta accepted D9902: [doc] developer-notes.md: point out that UniValue deviates from upstream.
Aug 23 2021, 20:26
majcosta accepted D9901: util: Filter out macOS process serial number.
Aug 23 2021, 20:25
majcosta requested changes to D9900: doc: Describe log files + consistent paths in test READMEs.
Aug 23 2021, 20:19
majcosta requested review of D9911: Bump version to 0.24.0.
Aug 23 2021, 19:42
majcosta accepted D9899: [rpc] Fix broken bitcoin-cli examples.
Aug 23 2021, 18:59
majcosta accepted D9898: Set init stop timeout to 10 min.
Aug 23 2021, 18:35
majcosta accepted D9897: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing.
Aug 23 2021, 18:32
majcosta accepted D9896: Prevent processing duplicate payment requests.
Aug 23 2021, 18:27
majcosta accepted D9894: [Cashtab] Remove legacy walletState parameter.
Aug 23 2021, 18:11

Aug 22 2021

majcosta closed D9876: Bump replay protection to may 2022.
Aug 22 2021, 01:43
majcosta committed rABC8efe8c8b009c: Bump replay protection to may 2022 (authored by Fabien).
Bump replay protection to may 2022
Aug 22 2021, 01:43

Aug 20 2021

majcosta accepted D9891: [Cashtab] Move price API to coingecko rebrand.
Aug 20 2021, 20:39
majcosta accepted D9890: [Cashtab] Remove unused function export.
Aug 20 2021, 20:38
majcosta accepted D9889: [Cashtab] remove unused imports and functions from Wallet.js.
Aug 20 2021, 20:38
majcosta accepted D9888: [Cashtab] Match UI locking pattern of rest of app in Tokens.js.
Aug 20 2021, 20:38

Aug 19 2021

majcosta accepted D9885: [Cashtab] Standardize use of wallet state parameters.
Aug 19 2021, 22:41
majcosta closed D9886: refactor: use structured binding instead of first/second in processor_tests.
Aug 19 2021, 21:20
majcosta committed rABC17ae0fce00b1: refactor: use structured binding instead of first/second in processor_tests (authored by majcosta).
refactor: use structured binding instead of first/second in processor_tests
Aug 19 2021, 21:20
majcosta requested changes to D9885: [Cashtab] Standardize use of wallet state parameters.
Aug 19 2021, 21:19
majcosta requested review of D9887: tests: consistently use underscores for functional tests.
Aug 19 2021, 20:59
majcosta requested review of D9886: refactor: use structured binding instead of first/second in processor_tests.
Aug 19 2021, 20:52
majcosta closed D9882: refactor: allow constructing a valid CKey in place.
Aug 19 2021, 18:26
majcosta committed rABC95c4a42ff4f0: refactor: allow constructing a valid CKey in place (authored by majcosta).
refactor: allow constructing a valid CKey in place
Aug 19 2021, 18:26

Aug 18 2021

majcosta updated the diff for D9882: refactor: allow constructing a valid CKey in place.

wtb newlines

Aug 18 2021, 20:18
majcosta updated the diff for D9882: refactor: allow constructing a valid CKey in place.

went the factory route

Aug 18 2021, 20:17
majcosta accepted D9883: [Cashtab] Remove support for sending to BCH or SLP addresses.
Aug 18 2021, 00:09

Aug 17 2021

majcosta accepted D9884: [Cashtab] Remove unused artifact params from Send.js.
Aug 17 2021, 23:15
majcosta requested changes to D9883: [Cashtab] Remove support for sending to BCH or SLP addresses.

fat fingers, sorry

Aug 17 2021, 22:50
majcosta accepted D9883: [Cashtab] Remove support for sending to BCH or SLP addresses.
Aug 17 2021, 22:49
majcosta requested review of D9882: refactor: allow constructing a valid CKey in place.
Aug 17 2021, 19:05

Aug 16 2021

majcosta accepted D9881: [Cashtab] Remove legacy address display.
Aug 16 2021, 22:39
majcosta accepted D9880: [Cashtab] add support for BRL and INR fiat.

nice

Aug 16 2021, 21:30
majcosta commandeered D9876: Bump replay protection to may 2022.
Aug 16 2021, 17:31

Aug 13 2021

majcosta accepted D9877: Replace boost::shared_mutex and shared_lock with their std:: equivalent in rwcollection.h.
Aug 13 2021, 19:59
majcosta accepted D9878: [avalanche] Move the VoteRecord to its own header.
Aug 13 2021, 19:41
majcosta closed D9871: ecash: make XEC/eCash the default.
Aug 13 2021, 19:23
majcosta committed rABC0d24eca8816d: ecash: make XEC/eCash the default (authored by majcosta).
ecash: make XEC/eCash the default
Aug 13 2021, 19:23
majcosta closed D9879: tests: make bitcoin-tx test using ecash=1.
Aug 13 2021, 19:19
majcosta committed rABC3ae37a2477c4: tests: make bitcoin-tx test using ecash=1 (authored by majcosta).
tests: make bitcoin-tx test using ecash=1
Aug 13 2021, 19:19
majcosta updated the diff for D9871: ecash: make XEC/eCash the default.

use backquotes in release notes

Aug 13 2021, 19:10
majcosta accepted D9876: Bump replay protection to may 2022.

timestamps check out

Aug 13 2021, 19:04
majcosta updated the diff for D9871: ecash: make XEC/eCash the default.

rebase

Aug 13 2021, 18:38
majcosta accepted D9874: [WEBSITE] Display 0.24.x releases.
Aug 13 2021, 18:25
majcosta accepted D9873: Prepare docs for 0.24.0.
Aug 13 2021, 18:21
majcosta updated the diff for D9871: ecash: make XEC/eCash the default.

addressed feedback. I'd rather change the debug text on abc_rpc_ecash.py, if anything that's another test that will break if someone unwittingly changes the ecash default, which I like

Aug 13 2021, 18:20
majcosta requested review of D9879: tests: make bitcoin-tx test using ecash=1.
Aug 13 2021, 17:57
majcosta added a comment to D9871: ecash: make XEC/eCash the default.

oops, fixed summary

Aug 13 2021, 04:23
majcosta updated the summary of D9871: ecash: make XEC/eCash the default.
Aug 13 2021, 04:22
majcosta added a comment to D9871: ecash: make XEC/eCash the default.

Yea, this doesn't remove the option, it just changes the default.

Aug 13 2021, 01:10
majcosta updated the diff for D9871: ecash: make XEC/eCash the default.

newline

Aug 13 2021, 00:45
majcosta updated the diff for D9871: ecash: make XEC/eCash the default.

add some release notes

Aug 13 2021, 00:37

Aug 12 2021

majcosta requested review of D9871: ecash: make XEC/eCash the default.
Aug 12 2021, 21:57
majcosta accepted D9870: Remove outdated comment in radix.h.
Aug 12 2021, 03:30

Aug 11 2021

majcosta accepted D9866: [WEBSITE] Update website description from Bitcoin Cash to eCash.
Aug 11 2021, 15:29

Aug 10 2021

majcosta accepted D9864: [Cashtab] Do not assume 546 sat utxo is token.
Aug 10 2021, 18:01

Aug 9 2021

majcosta accepted D9851: [avalanche] Remove the (node) PeerManager member from the avalanche processor.
Aug 9 2021, 15:40

Aug 6 2021

majcosta accepted D9853: [avalanche] Reduce dependency to net.h from avalanche.
Aug 6 2021, 19:37
majcosta accepted D9852: [avalanche] Clarify processor dependency to net.h.
Aug 6 2021, 19:35
majcosta requested changes to D9851: [avalanche] Remove the (node) PeerManager member from the avalanche processor.
Aug 6 2021, 19:25
majcosta accepted D9849: [Cashtab] add support for additional fiat currencies.
Aug 6 2021, 18:01

Aug 5 2021

majcosta accepted D9850: [Cashtab] remove price api order of magnitude error check.
Aug 5 2021, 20:12
majcosta requested changes to D9849: [Cashtab] add support for additional fiat currencies.

if you could also please split this diff in two, that's better; adding new fiat currencies isn't related to reverting the precaution in D9718.

Aug 5 2021, 19:26
majcosta closed T600: Backport Core PR 14711: Refactor: Start to separate wallet from node, a subtask of T603: Backport Core PR 10976: Refactor: separate wallet from node, as Resolved.
Aug 5 2021, 00:13 · Restricted Project, Backport
majcosta closed T600: Backport Core PR 14711: Refactor: Start to separate wallet from node as Resolved.

done in D5683

Aug 5 2021, 00:13 · Restricted Project, Backport
majcosta closed T601: Backport Core PR 10973: Refactor: separate wallet from node as Resolved.

finished in D5943

Aug 5 2021, 00:12 · Restricted Project, Backport

Aug 4 2021

majcosta accepted D9846: [avalanche] Move testing the getavalanchepeerinfo RPC to its own test.
Aug 4 2021, 15:58

Jul 29 2021

majcosta closed T504: Migrate to c++14 as Resolved.

migrated to c++17 on D8493

Jul 29 2021, 21:33 · Restricted Project

Jul 27 2021

majcosta accepted D9837: [doc] start a developer documentation for avalanche.
Jul 27 2021, 15:05
majcosta accepted D9841: [avalanche] Fix the getavalanchepeerinfo help.
Jul 27 2021, 15:05

Jul 26 2021

majcosta accepted D9838: [LINTER] Handle errors from the Prettier linter.
Jul 26 2021, 19:29

Jul 23 2021

majcosta closed D9835: add some release notes for 0.23.9.
Jul 23 2021, 17:42
majcosta committed rABC471fa6e36e42: add some release notes for 0.23.9 (authored by majcosta).
add some release notes for 0.23.9
Jul 23 2021, 17:42
majcosta requested review of D9835: add some release notes for 0.23.9.
Jul 23 2021, 17:29
First
Prev
Next