Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Sep 22 2022

sdulfari accepted D12022: [avalanche] Add a BlockFinalized callback to the validation interface.

Sep 22 2022, 16:54

sdulfari updated the diff for D12014: [avalanche] Create a type alias for proof id sets.

Move ProofIdSet to to proofpool.h

Sep 22 2022, 16:51

Sep 21 2022

sdulfari requested changes to D12022: [avalanche] Add a BlockFinalized callback to the validation interface.

Sep 21 2022, 20:09

sdulfari accepted D12027: Fix an occasional failure in abc_p2p_fullblocktest.

Sep 21 2022, 18:44

sdulfari accepted D12024: [avalanche] Fix abc_p2p_compactproofs flakiness.

Sep 21 2022, 16:17

sdulfari requested review of D12014: [avalanche] Create a type alias for proof id sets.

Sep 21 2022, 16:13

sdulfari closed D12016: [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr.

Sep 21 2022, 16:10

sdulfari committed rABC89e1f6634387: [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr (authored by sdulfari).

[avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr

Sep 21 2022, 16:10

sdulfari retitled D12016: [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr from [avalanche] Increase mock time delay for ava addr responses to [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr.

Sep 21 2022, 16:10

Sep 20 2022

sdulfari requested review of D12016: [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr.

Sep 20 2022, 23:47

sdulfari planned changes to D12013: [avalanche] Add a way to retrieve proof ids from each pool.

Sep 20 2022, 20:56

sdulfari requested review of D12014: [avalanche] Create a type alias for proof id sets.

Sep 20 2022, 20:56

sdulfari updated the diff for D12013: [avalanche] Add a way to retrieve proof ids from each pool.

Fixup some comments

Sep 20 2022, 19:14

sdulfari requested review of D12013: [avalanche] Add a way to retrieve proof ids from each pool.

Sep 20 2022, 19:10

sdulfari accepted D12001: [avalanche] Let isfinaltransaction raise an error when the transaction is not found.

Sep 20 2022, 16:36

sdulfari closed D11999: [avalanche] Add a way to retrieve all proof ids in a proofpool.

Sep 20 2022, 15:54

sdulfari committed rABC6efbe90b2307: [avalanche] Add a way to retrieve all proof ids in a proofpool (authored by sdulfari).

[avalanche] Add a way to retrieve all proof ids in a proofpool

Sep 20 2022, 15:54

sdulfari accepted D11975: fs: consistently use fsbridge:: for ifstream / ofstream.

Sep 20 2022, 15:52

Sep 19 2022

sdulfari updated the diff for D11999: [avalanche] Add a way to retrieve all proof ids in a proofpool.

Remove unnecessary dedup logic

Sep 19 2022, 20:14

sdulfari requested changes to D12001: [avalanche] Let isfinaltransaction raise an error when the transaction is not found.

Sep 19 2022, 20:08

sdulfari requested review of D11999: [avalanche] Add a way to retrieve all proof ids in a proofpool.

Sep 19 2022, 18:00

sdulfari accepted D12001: [avalanche] Let isfinaltransaction raise an error when the transaction is not found.

Sep 19 2022, 17:58

sdulfari accepted D12002: Cleanup the deprecated RPC fields.

Sep 19 2022, 17:43

Sep 16 2022

sdulfari requested review of D11999: [avalanche] Add a way to retrieve all proof ids in a proofpool.

Sep 16 2022, 19:10

Sep 15 2022

sdulfari accepted D11998: [website] Don't build the docs for 0.24.x.

Sep 15 2022, 22:07

sdulfari committed rABC97302d4c32a6: [avalanche] Make sure we remember the avalanche addresses we sent (authored by Fabien).

[avalanche] Make sure we remember the avalanche addresses we sent

Sep 15 2022, 16:52

sdulfari accepted D11996: [avalanche] Add a RPC to check if a block/tx is finalized by avalanche.

Sep 15 2022, 16:50

sdulfari requested changes to D11996: [avalanche] Add a RPC to check if a block/tx is finalized by avalanche.

Sep 15 2022, 16:45

sdulfari requested changes to D11996: [avalanche] Add a RPC to check if a block/tx is finalized by avalanche.

Sep 15 2022, 15:47

Sep 13 2022

sdulfari closed D11963: [avalanche] Rename proof filter to match rest of the code base.

Sep 13 2022, 18:53

sdulfari committed rABC6bd0f29f4332: [avalanche] Rename proof filter to match rest of the code base (authored by sdulfari).

[avalanche] Rename proof filter to match rest of the code base

Sep 13 2022, 18:53

sdulfari updated the summary of D11963: [avalanche] Rename proof filter to match rest of the code base.

Sep 13 2022, 18:16

sdulfari accepted D11971: Replace fs::absolute calls with AbsPathJoin calls.

Sep 13 2022, 17:42

sdulfari accepted D11970: test: Clear forced -walletdir setting after wallet init_tests.

Sep 13 2022, 17:33

sdulfari accepted D11969: Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem..

Sep 13 2022, 17:32

sdulfari accepted D11972: convert unsafe fs::path std::string conversion call.

Sep 13 2022, 17:28

sdulfari requested changes to D11975: fs: consistently use fsbridge:: for ifstream / ofstream.

psbtoperationsdialog should be its own backport

Sep 13 2022, 17:22

sdulfari updated the diff for D11963: [avalanche] Rename proof filter to match rest of the code base.

Make the naming more accurate for consensus-invalid case and update comment.

Sep 13 2022, 17:13

sdulfari requested changes to D11968: [avalanche] Tests: stop the scheduler before the fixture is destructed.

This only fixes the case where the scheduled cleanup happens post-test-cleanup, but not the case where m_processor is replaced and the test is still running, therefore the first processor instance's cleanup gets run on the destructed processor. I think my solution here is more complete: D11965

Sep 13 2022, 16:29

Sep 12 2022

sdulfari requested review of D11965: [avalanche] Move scheduled dangling proof cleanup to init.

Sep 12 2022, 22:50

sdulfari requested review of D11963: [avalanche] Rename proof filter to match rest of the code base.

Sep 12 2022, 20:21

sdulfari requested review of D11961: [avalanche] Make a low dust threshold the default for functional tests.

Sep 12 2022, 16:49

Sep 11 2022

sdulfari closed D11950: [avalanche] Cleanup comment referring to legacy proofs.

Sep 11 2022, 20:16

sdulfari committed rABCd77e7b8543c9: [avalanche] Cleanup comment referring to legacy proofs (authored by sdulfari).

[avalanche] Cleanup comment referring to legacy proofs

Sep 11 2022, 20:16

Sep 9 2022

sdulfari requested review of D11950: [avalanche] Cleanup comment referring to legacy proofs.

Sep 9 2022, 23:27

sdulfari accepted D11949: [avalanche] Deduplicate the log message when an avapoll is received.

Sep 9 2022, 17:03

Sep 8 2022

sdulfari accepted D11940: [avalanche] Fix proof_tests potential failure.

Sep 8 2022, 15:13

Sep 6 2022

sdulfari accepted D11918: [avalanche] Use sane default for the quorum minimum connected stake ratio.

Sep 6 2022, 23:32

sdulfari accepted D11919: [avalanche] Use sane default for the minimum number of nodes that sent compact proofs.

Sep 6 2022, 23:32

sdulfari accepted D11922: [avalanche] Deprecate the -enableavalanche flag.

Sep 6 2022, 16:26

sdulfari requested changes to D11919: [avalanche] Use sane default for the minimum number of nodes that sent compact proofs.

Sep 6 2022, 16:23

sdulfari requested changes to D11918: [avalanche] Use sane default for the quorum minimum connected stake ratio.

Sep 6 2022, 16:20

sdulfari accepted D11915: [avalanche] Deprecate the enablepeerdiscovery flag.

Sep 6 2022, 16:19

sdulfari accepted D11917: [avalanche] Set the quorum minimal stake to a sane default.

Sep 6 2022, 16:17

Aug 30 2022

teamcity awarded D11895: [avalanche] Stop scheduler after syncing validation queue a Piece of Eight token.

Aug 30 2022, 22:50

teamcity awarded D11895: [avalanche] Stop scheduler after syncing validation queue a Haypence token.

Aug 30 2022, 21:58

sdulfari accepted D11894: Bump version to 0.25.13.

Aug 30 2022, 20:12

Aug 26 2022

sdulfari accepted D11884: test: speedup wallet tests by whitelisting peers (immediate tx relay).

Aug 26 2022, 16:41

sdulfari closed D11880: [avalanche] Add log message when dangling proofs get dropped.

Aug 26 2022, 16:14

sdulfari committed rABC4bb701324f80: [avalanche] Add log message when dangling proofs get dropped (authored by sdulfari).

[avalanche] Add log message when dangling proofs get dropped

Aug 26 2022, 16:14

sdulfari closed D11879: [avalanche] Reuse code to fetch the processor's local proof during proof cleanup.

Aug 26 2022, 16:09

sdulfari committed rABC691c5ad03e5e: [avalanche] Reuse code to fetch the processor's local proof during proof cleanup (authored by sdulfari).

[avalanche] Reuse code to fetch the processor's local proof during proof cleanup

Aug 26 2022, 16:09

Aug 22 2022

sdulfari requested review of D11880: [avalanche] Add log message when dangling proofs get dropped.

Aug 22 2022, 22:41

sdulfari requested review of D11879: [avalanche] Reuse code to fetch the processor's local proof during proof cleanup.

Aug 22 2022, 21:37

Aug 19 2022

sdulfari accepted D11873: [avalanche] Implement proof expiration time.

Aug 19 2022, 16:20

Aug 18 2022

sdulfari requested changes to D11873: [avalanche] Implement proof expiration time.

At a minimum, needs these test cases and maybe more:

Start a node and expire its proof.
Start a node and expire its proof with conflict replacement.
Check quorum status when expiration occurs.

Aug 18 2022, 18:08

Aug 17 2022

sdulfari closed D11869: [avalanche] Do same checks on local proof as peer proofs in getavalancheinfo functional test.

Aug 17 2022, 20:30

sdulfari committed rABCe2d765cb0cd3: [avalanche] Do same checks on local proof as peer proofs in getavalancheinfo… (authored by sdulfari).

[avalanche] Do same checks on local proof as peer proofs in getavalancheinfo…

Aug 17 2022, 20:30

sdulfari closed D11870: [avalanche] Fix flakiness where finalization of the newly mature proof was not checked along with the other finalized proofs.

Aug 17 2022, 20:29

sdulfari committed rABC488982b50207: [avalanche] Fix flakiness where finalization of the newly mature proof was not… (authored by sdulfari).

[avalanche] Fix flakiness where finalization of the newly mature proof was not…

Aug 17 2022, 20:29

sdulfari requested review of D11870: [avalanche] Fix flakiness where finalization of the newly mature proof was not checked along with the other finalized proofs.

Aug 17 2022, 19:01

sdulfari requested review of D11869: [avalanche] Do same checks on local proof as peer proofs in getavalancheinfo functional test.

Aug 17 2022, 18:39

sdulfari closed D11859: [avalanche] Make sure AlreadyHaveProof always returns true for the local proof.

Aug 17 2022, 16:07

sdulfari committed rABCadb55e12b703: [avalanche] Make sure AlreadyHaveProof always returns true for the local proof (authored by sdulfari).

[avalanche] Make sure AlreadyHaveProof always returns true for the local proof

Aug 17 2022, 16:07

sdulfari accepted D11867: [avalanche] Poll for our local proof.

Aug 17 2022, 16:04

sdulfari accepted D11866: [avalanche] Complete renaming from orphan to immature where applicable.

Aug 17 2022, 16:00

sdulfari accepted D11864: [avalanche] Rename the orphan pool to immature pool.

Aug 17 2022, 15:51

sdulfari accepted D11861: [avalanche] Rename the orphan API accessors to immature.

Aug 17 2022, 15:48

sdulfari accepted D11860: [avalanche] Update the getrawavalancheproof RPC to return 'immature' instead of 'orphan'.

Aug 17 2022, 15:46

Aug 16 2022

sdulfari closed D11830: [avalanche] Increase proof dust threshold.

Aug 16 2022, 18:40

sdulfari committed rABCf33eb4f5aa97: [avalanche] Increase proof dust threshold (authored by sdulfari).

[avalanche] Increase proof dust threshold

Aug 16 2022, 18:40

sdulfari closed D11750: [avalanche] Make proof dust threshold configurable.

Aug 16 2022, 18:30

sdulfari committed rABC6681fd88014a: [avalanche] Make proof dust threshold configurable (authored by sdulfari).

[avalanche] Make proof dust threshold configurable

Aug 16 2022, 18:30

Aug 15 2022

sdulfari requested review of D11859: [avalanche] Make sure AlreadyHaveProof always returns true for the local proof.

Aug 15 2022, 22:09

sdulfari accepted D11858: Bump version to 0.25.12.

Aug 15 2022, 20:46

sdulfari accepted D11857: [avalanche] Improve the getavalancheinfo RPC.

Aug 15 2022, 20:45

Aug 12 2022

sdulfari closed D11841: [avalanche] Fix comment related to proof requests.

Aug 12 2022, 16:49

sdulfari committed rABCa74757f1b30d: [avalanche] Fix comment related to proof requests (authored by sdulfari).

[avalanche] Fix comment related to proof requests

Aug 12 2022, 16:49

sdulfari accepted D11849: [avalanche] Don't poll blocks who are ancestors of a vote finalized block.

Aug 12 2022, 16:48

sdulfari requested changes to D11849: [avalanche] Don't poll blocks who are ancestors of a vote finalized block.

Aug 12 2022, 16:26

Aug 11 2022

sdulfari requested review of D11841: [avalanche] Fix comment related to proof requests.

Aug 11 2022, 22:29

sdulfari accepted D11840: [avalanche] Bump the peer replacement cooldown.

This should be a std::chrono::duration

Aug 11 2022, 16:20

Aug 10 2022

sdulfari accepted D11839: [avalanche] Hide the master and session keys in the debug log and console.

Aug 10 2022, 21:08

sdulfari accepted D11838: Revert "[avalanche] Ban peers that send conflicting proofs repeatidly".

Aug 10 2022, 16:34

Aug 9 2022

sdulfari accepted D11837: [avalanche] Fix getavaaddr on OSX.

Aug 9 2022, 16:06

Aug 8 2022

sdulfari added inline comments to D11750: [avalanche] Make proof dust threshold configurable.

Aug 8 2022, 23:31

sdulfari updated the diff for D11750: [avalanche] Make proof dust threshold configurable.

Use the dust threshold directly where it is needed, not involving the config.
The patch is now simpler and accomplishes a more focused set of changes.

Aug 8 2022, 23:27

sdulfari accepted D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.

Aug 8 2022, 15:55

sdulfari accepted D11833: Fix a race in the net tests.

Aug 8 2022, 15:49

sdulfari accepted D11834: [avalanche] Fix abc_p2p_getavaaddr flakiness.

Aug 8 2022, 15:45