Page MenuHomePhabricator
Feed Advanced Search

Jun 12 2019

D3299: [LINTER] Run selected linters last now requires changes to proceed.
Jun 12 2019, 17:03
D3300: [LINTER] Run some linter only once now requires changes to proceed.

You can call the linter n times, but only do the work once. You know a configuration is not what you are after because it makes no sense to run that linter multiple time. This is a property of the linter, not of the environment in which it runs so we clearly are facing a new type of linter, not a new workflow to be configured

Jun 12 2019, 17:01
deadalnix created D3304: Add a test to make sure that negative effective values are filtered.
Jun 12 2019, 16:12
deadalnix created D3303: Benchmark BnB in the worst case where it exhausts.
Jun 12 2019, 15:52
deadalnix created D3302: Build wallet dependent benchmark using cmake.
Jun 12 2019, 15:41
deadalnix committed rABCcd606f147cba: Use a struct for output eligibility (authored by Andrew Chow <achow101-github@achow101.com>).
Use a struct for output eligibility
Jun 12 2019, 15:18
deadalnix closed D3246: Use a struct for output eligibility.
Jun 12 2019, 15:18
deadalnix added a comment to D3252: Add tests for the Branch and Bound algorithm.

Reorder includes

Jun 12 2019, 14:22
deadalnix added inline comments to D3252: Add tests for the Branch and Bound algorithm.
Jun 12 2019, 14:20
deadalnix added a comment to D3250: Remove coinselection.h -> wallet.h circular dependency.

rebase

Jun 12 2019, 14:18
deadalnix added a comment to D3249: Implement Branch and Bound coin selection in a new file.

Reoder includes

Jun 12 2019, 14:15
deadalnix added a comment to D3243: Calculate and store the number of bytes required to spend an input.

rebase

Jun 12 2019, 14:10
deadalnix added a comment to D3243: Calculate and store the number of bytes required to spend an input.

Address comments

Jun 12 2019, 14:07
deadalnix committed rABC721d2df22e50: Store effective value, fee, and long term fee in CInputCoin (authored by Andrew Chow <achow101-github@achow101.com>).
Store effective value, fee, and long term fee in CInputCoin
Jun 12 2019, 14:00
deadalnix closed D3248: Store effective value, fee, and long term fee in CInputCoin.
Jun 12 2019, 14:00
deadalnix committed rABCa0f222f20b3e: Move output eligibility to a separate function (authored by Andrew Chow <achow101-github@achow101.com>).
Move output eligibility to a separate function
Jun 12 2019, 13:57
deadalnix closed D3245: Move output eligibility to a separate function.
Jun 12 2019, 13:57
deadalnix committed rABCf578ca9dd0fb: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee (authored by Andrew Chow <achow101-github@achow101.com>).
Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee
Jun 12 2019, 13:53
deadalnix closed D3251: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee.
Jun 12 2019, 13:53
deadalnix committed rABCd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size (authored by Alex Morcos <morcos@chaincode.com>).
Fix rounding errors in calculation of minimum change size
Jun 12 2019, 13:51
deadalnix closed D3291: Fix rounding errors in calculation of minimum change size.
Jun 12 2019, 13:51
deadalnix committed rABCf4321052c578: Don't create change at the dust limit, even if it means paying more than… (authored by Alex Morcos <morcos@chaincode.com>).
Don't create change at the dust limit, even if it means paying more than…
Jun 12 2019, 13:49
deadalnix closed D3296: Don't create change at the dust limit, even if it means paying more than expected.
Jun 12 2019, 13:49
deadalnix committed rABC7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients (authored by Alex Morcos <morcos@chaincode.com>).
Eliminate fee overpaying edge case when subtracting fee from recipients
Jun 12 2019, 13:47
deadalnix closed D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.
Jun 12 2019, 13:47
D3265: add new encoding checker for Schnorr sigs now requires changes to proceed.
Jun 12 2019, 13:06
D3271: add SCRIPTSIGMINPUSHONLY flag and logic now requires changes to proceed.
Jun 12 2019, 13:02
D3299: [LINTER] Run selected linters last now requires changes to proceed.
Jun 12 2019, 13:00
D3292: Explicitly call out updating makeseeds.py after major releases now requires changes to proceed.
Jun 12 2019, 12:57
D3292: Explicitly call out updating makeseeds.py after major releases is now accepted and ready to land.
Jun 12 2019, 12:56
D3300: [LINTER] Run some linter only once now requires changes to proceed.

Why can't the linter un once to begin with, instead o having a linter that run multiple times and then build all kind of scafolding to have it run only once ?

Jun 12 2019, 12:55
deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:50
deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:50
deadalnix updated the summary of D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:49
deadalnix created D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Jun 12 2019, 12:48

Jun 11 2019

deadalnix created D3297: Eliminate fee overpaying edge case when subtracting fee from recipients.
Jun 11 2019, 23:56
deadalnix added inline comments to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.
Jun 11 2019, 23:47
D3287: [LINTER] Fix some PHP linter rules is now accepted and ready to land.
Jun 11 2019, 23:46
D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory is now accepted and ready to land.
Jun 11 2019, 23:46
deadalnix added a comment to D3269: move CheckMinimalPush to script.h.

While mildly useful, I don't think we should be making changes like this until backports are up-to-date.

Jun 11 2019, 23:46
D3270: add CScript::IsMinimalPushOnly now requires changes to proceed.

There is already logic to check if a push is minimal or not, duplicating indicate the approach is wrong.

Jun 11 2019, 23:43
deadalnix created D3296: Don't create change at the dust limit, even if it means paying more than expected.
Jun 11 2019, 23:24
deadalnix created D3291: Fix rounding errors in calculation of minimum change size.
Jun 11 2019, 18:18
deadalnix created D3290: Move original knapsack solver tests to coinselector_tests.cpp.
Jun 11 2019, 16:54
deadalnix created D3289: Move current coin selection algorithm to coinselection.{cpp,h}.
Jun 11 2019, 16:24
D3256: Fix make distcheck is now accepted and ready to land.
Jun 11 2019, 16:07

Jun 8 2019

D3259: Merge #10524: [tests] Remove printf(...) is now accepted and ready to land.
Jun 8 2019, 00:24
D3260: Merge #10560: Remove unused constants is now accepted and ready to land.
Jun 8 2019, 00:23
D3253: Remove Schnorr activation now requires changes to proceed.

There are still a lot of leftovers, like the flags that are passed down to functions that do not need them, the caching layer depending on flags, or the exception tot he banning code for schnorr txns. Not all need to be done in this patch, but this need some battle plan or we'll have a lot of pieces laying around.

Jun 8 2019, 00:23

Jun 7 2019

deadalnix created D3252: Add tests for the Branch and Bound algorithm.
Jun 7 2019, 00:27
deadalnix created D3251: Add a GetMinimumFeeRate function which is wrapped by GetMinimumFee.
Jun 7 2019, 00:16
deadalnix created D3250: Remove coinselection.h -> wallet.h circular dependency.
Jun 7 2019, 00:12
deadalnix created D3249: Implement Branch and Bound coin selection in a new file.
Jun 7 2019, 00:06

Jun 6 2019

deadalnix created D3248: Store effective value, fee, and long term fee in CInputCoin.
Jun 6 2019, 23:57
deadalnix created D3246: Use a struct for output eligibility.
Jun 6 2019, 23:44
deadalnix created D3245: Move output eligibility to a separate function.
Jun 6 2019, 23:41
deadalnix created D3243: Calculate and store the number of bytes required to spend an input.
Jun 6 2019, 23:34
deadalnix committed rABC75e6b44a4669: Rework the wallet fees interface to make it closer to core's (authored by deadalnix).
Rework the wallet fees interface to make it closer to core's
Jun 6 2019, 22:44
deadalnix closed D3233: Rework the wallet fees interface to make it closer to core's.
Jun 6 2019, 22:44
deadalnix added a comment to D3217: [LINTER] Add a spell checker to arcanist.

Why not use command line tools like aspell to do this ? I think some of them are already have arc integration.

Jun 6 2019, 22:41
deadalnix accepted D3235: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end.
Jun 6 2019, 22:39
deadalnix accepted D3219: Merge #9890: Add a button to open the config file in a text editor.
Jun 6 2019, 22:39
D3238: Merge #10469: Fixing typo in rpcdump.cpp is now accepted and ready to land.
Jun 6 2019, 22:38
D3240: Merge #10514: Bugfix: missing == 0 after randrange is now accepted and ready to land.
Jun 6 2019, 22:37
deadalnix accepted D3225: Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds.
Jun 6 2019, 17:21
deadalnix created D3233: Rework the wallet fees interface to make it closer to core's.
Jun 6 2019, 13:58
D3216: Fix a bunch of spelling errors is now accepted and ready to land.
Jun 6 2019, 00:19

Jun 5 2019

deadalnix committed rABC9db35c621140: Remove unused function for fees.h exposed interface (authored by deadalnix).
Remove unused function for fees.h exposed interface
Jun 5 2019, 22:55
deadalnix closed D3214: Remove unused function for fees.h exposed interface.
Jun 5 2019, 22:55
D3215: Replace childs => children in radix.h is now accepted and ready to land.
Jun 5 2019, 17:23
D3213: [LINTER] Enforce using C++ headers instead of C compatible headers is now accepted and ready to land.
Jun 5 2019, 15:26
D3212: Replace c compatibility header with native c++ header is now accepted and ready to land.
Jun 5 2019, 15:24
deadalnix committed rABC5b2438c3fc11: Remove useless priority calculation in wallet (authored by deadalnix).
Remove useless priority calculation in wallet
Jun 5 2019, 15:24
deadalnix closed D3210: Remove useless priority calculation in wallet.
Jun 5 2019, 15:23
deadalnix created D3214: Remove unused function for fees.h exposed interface.
Jun 5 2019, 15:22
D3200: Merge #12384: [Docs] Add version footnote to tor.md is now accepted and ready to land.
Jun 5 2019, 12:08
D3204: Merge #12584: Fix typos and cleanup documentation is now accepted and ready to land.
Jun 5 2019, 12:08
D3197: Make Teamcity agent setup easier now requires changes to proceed.
Jun 5 2019, 12:08
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.

If you abstract the node in some class and call from there, you can mock it and unit test the whole thing without a node.

Jun 5 2019, 01:30
D3206: Merge #12501: [qt] Improved "custom fee" explanation in tooltip is now accepted and ready to land.
Jun 5 2019, 01:25
D3207: Merge #12434: [doc] dev-notes: Members should be initialized is now accepted and ready to land.
Jun 5 2019, 01:25
D3203: Merge #12999: qt: Show the Window when double clicking the taskbar icon is now accepted and ready to land.
Jun 5 2019, 01:24
D3201: Merge #12616: Set modal overlay hide button as default is now accepted and ready to land.
Jun 5 2019, 01:24
D3202: Merge #13052: trivial: Fix relevent typo is now accepted and ready to land.
Jun 5 2019, 01:23
D3209: Merge #10714: Avoid printing incorrect block indexing time due to uninitialized variable is now accepted and ready to land.
Jun 5 2019, 01:23
D3208: Merge #11884: Remove unused include in hash.cpp is now accepted and ready to land.
Jun 5 2019, 01:22
D3211: Merge #11406: Add state message print to AcceptBlock failure message. is now accepted and ready to land.
Jun 5 2019, 01:22
D3194: Clean up Segwit Recovery feature is now accepted and ready to land.
Jun 5 2019, 01:21
deadalnix committed rABC368d489b8abe: Use constexpr in the RCU code (authored by deadalnix).
Use constexpr in the RCU code
Jun 5 2019, 01:14
deadalnix closed D3198: Use constexpr in the RCU code.
Jun 5 2019, 01:14
deadalnix retitled D3198: Use constexpr in the RCU code from Use constexpr in the RCO code to Use constexpr in the RCU code.
Jun 5 2019, 01:14
deadalnix retitled D3210: Remove useless priority calculation in wallet from emove useless priority calculation in wallet to Remove useless priority calculation in wallet.
Jun 5 2019, 00:23
deadalnix created D3210: Remove useless priority calculation in wallet.
Jun 5 2019, 00:13

Jun 4 2019

deadalnix created D3198: Use constexpr in the RCU code.
Jun 4 2019, 21:30
deadalnix committed rABC3a8bd492d2ee: Remove implicit parameter from GetSerializeSize (authored by deadalnix).
Remove implicit parameter from GetSerializeSize
Jun 4 2019, 21:28
deadalnix closed D3195: Remove implicit parameter from GetSerializeSize.
Jun 4 2019, 21:28
deadalnix requested changes to D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.
Jun 4 2019, 13:57
deadalnix created D3195: Remove implicit parameter from GetSerializeSize.
Jun 4 2019, 13:11
D3190: Merge #11337: Fix code constness in CBlockIndex::GetAncestor() overloads is now accepted and ready to land.
Jun 4 2019, 12:54
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.

The elephant in the room is that this doesn't set checkpoints.

Jun 4 2019, 00:50