JFC this test is slow without this patch. >_<

Note backports are basically caught up on this part of the code, except weak overlap with the incomplete parts of D1972, and some linting-related stuff in #12891 (which it looks like will we cannot take as-is due to code style differences).

braces

In D2788#80068, @jasonbcox wrote:

Depends on itself?

rebased (part of this is now already done, in D3181)

somehow the include didn't get removed on first pass

This is mostly a nominal backport -- these parts will likely be removed anyway. (see D2788)

What about the UpdateTip changes?

update per comment

simple rebase

simple rebase

tweak per comment

Returning for at least a rubber-stamp review from ABC member. :-)

change name to IsRelevantBesidesInputsAndUpdate, also clarify comments.

Alternatively it would work to move the txid check to the second function, making them:

• HasRelevantOutputsAndUpdate
• HasRelevantTxidOrInputs

@bvk How about IsRelevantBesidesInputsAndUpdate? 😄

remove comment again

@deadalnix looks like your comments showed up late for some reason. Anyway the amount.h is removed as jason asked for as well.

tweaks per comments

move Amount to forward declaration

(final rebase was necessary for release notes)

restore help text, per discussion

reduce scope (remove RPC changes, restore a comment)

update per discussion

include missed doxygen comment & remove superfluous comment from CheckInputs

change to deprecation instead of removal

rebase

In D3350#79433, @jasonbcox wrote:

What about including the script_tests.cpp changes in the script_build test?

As mentioned in the meeting I'm happy to green this if the duplicates are going to be removed reasonably soon in some other diffs, even if landed later on.

OK, cool! I think that's a good way to go as well.

@nakihito hmmm, would that -deprecatedrpc thing be appropriate here (sort of like what happened with validateaddress in the recent release)? Or you mean it should be marked deprecated in helptext for some time before being taken out?

With patch:

{
  "chain": "test",
  "blocks": 1309568,
  "headers": 1303313,
  "bestblockhash": "0000000000000c97db875750712183dc3d608d225e275ce992a647ba084ea848",
  "difficulty": 842811.5393743159,
  "mediantime": 1560802822,
  "verificationprogress": 0.9999993508198258,
  "initialblockdownload": false,
  "chainwork": "00000000000000000000000000000000000000000000004f5d4024d8d2d6fd56",
  "size_on_disk": 26073090536,
  "pruned": false,
  "warnings": ""
}

remove mocktiming

oops, some tests duplicated

IBD testing done

update the functional test per my last comment; we can't properly test 64 byte ECDSA here,
but we can test the multisig length check banning.

rebase pre-land

Discussions with @Fabien make it clear that this is pretty ugly behaviour, and I've forwarded this problem to Core to see if they have some solutions in mind. https://github.com/bitcoin/bitcoin/issues/16220

add TODO comments to aid in clean backporting one day (when Core figures out
how they want to fix this)

keep functional test same name to allow diff to show properly

Also I find it a bit odd that we have a known error that triggers UNKNOWN_ERROR (this is because it works by throwing an exception instead of doing the usual s_error mechanism). Would be good to make it clearer, but that can be a separate diff.

rebase for good measure

rebase for conflict (txindex_tests' GetHash -> GetId changes were done in D3315 too)