Page MenuHomePhabricator
Feed All Stories

Jan 18 2021

PiRK updated the diff for D8939: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting.

include the new functional test that the original PR added to wallet_bumpfee

Jan 18 2021, 10:39
teamcity updated the summary of D8939: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting.
Jan 18 2021, 10:21
PiRK requested review of D8939: rpc: Add doc for deactivating settxfee and respect -maxtxfee wallet setting.
Jan 18 2021, 10:20
PiRK closed D8935: script: Disallow silent bool -> CScript conversion.
Jan 18 2021, 09:56
PiRK committed rABC4f308eaa812b: script: Disallow silent bool -> CScript conversion (authored by MarcoFalke <falke.marco@gmail.com>).
script: Disallow silent bool -> CScript conversion
Jan 18 2021, 09:56
PiRK closed D8937: refactor: Remove unused methods CBloomFilter::reset()/clear().
Jan 18 2021, 09:46
PiRK committed rABC2f90a6e88129: refactor: Remove unused methods CBloomFilter::reset()/clear() (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: Remove unused methods CBloomFilter::reset()/clear()
Jan 18 2021, 09:46
PiRK updated the diff for D8936: tests: have coins simulation test also use CCoinsViewDB.

replace uint256 with BlockHash in comment

Jan 18 2021, 09:41
PiRK updated the diff for D8934: tests: don't repeat scriptPubKey value.

don't redefine OP_TRUE, use existing components from script.py

Jan 18 2021, 09:38
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Piece of Eight token.
Jan 18 2021, 08:54
Fabien added a comment to D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].

@bot build-native-osx

Jan 18 2021, 08:54
teamcity added a comment to D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 18 2021, 08:49
Fabien requested changes to D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 18 2021, 08:45
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Haypence token.
Jan 18 2021, 08:38
Fabien added a comment to D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].

@bot build-linux32

Jan 18 2021, 08:38
Fabien requested changes to D8934: tests: don't repeat scriptPubKey value.
Jan 18 2021, 08:15

Jan 17 2021

majcosta updated the summary of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 17 2021, 12:11
majcosta accepted D8937: refactor: Remove unused methods CBloomFilter::reset()/clear().
Jan 17 2021, 10:37
majcosta accepted D8936: tests: have coins simulation test also use CCoinsViewDB.
Jan 17 2021, 10:35
majcosta accepted D8935: script: Disallow silent bool -> CScript conversion.
Jan 17 2021, 10:33
teamcity updated the summary of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 17 2021, 10:26
majcosta requested review of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 17 2021, 10:26
teamcity updated the summary of D8937: refactor: Remove unused methods CBloomFilter::reset()/clear().
Jan 17 2021, 09:59
PiRK requested review of D8937: refactor: Remove unused methods CBloomFilter::reset()/clear().
Jan 17 2021, 09:58
teamcity updated the summary of D8936: tests: have coins simulation test also use CCoinsViewDB.
Jan 17 2021, 09:47
PiRK requested review of D8936: tests: have coins simulation test also use CCoinsViewDB.
Jan 17 2021, 09:47
teamcity updated the summary of D8935: script: Disallow silent bool -> CScript conversion.
Jan 17 2021, 09:30
PiRK requested review of D8935: script: Disallow silent bool -> CScript conversion.
Jan 17 2021, 09:30
PiRK updated the diff for D8934: tests: don't repeat scriptPubKey value.

assign the variable on the same line as the original PR

Jan 17 2021, 09:08
teamcity updated the summary of D8934: tests: don't repeat scriptPubKey value.
Jan 17 2021, 09:01
PiRK requested review of D8934: tests: don't repeat scriptPubKey value.
Jan 17 2021, 09:00
PiRK updated the diff for D8899: Check for overflow when calculating sum of outputs.

revert accidental change to unrelated documentation file

Jan 17 2021, 08:30

Jan 16 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Jan 16 2021, 15:55

Jan 15 2021

PiRK closed D8932: test: Verify findCommonAncestor always initializes outputs.
Jan 15 2021, 17:38
PiRK committed rABC7d707861f71c: test: Verify findCommonAncestor always initializes outputs (authored by Russell Yanofsky <russ@yanofsky.org>).
test: Verify findCommonAncestor always initializes outputs
Jan 15 2021, 17:38
PiRK closed D8931: test: coverage improvements in interface-bitcoin_cli.py.
Jan 15 2021, 17:30
PiRK committed rABCb010f23ba61c: test: coverage improvements in interface-bitcoin_cli.py (authored by Jon Atack <jon@atack.com>).
test: coverage improvements in interface-bitcoin_cli.py
Jan 15 2021, 17:30
PiRK closed D8929: test: Add various low-level p2p tests.
Jan 15 2021, 17:23
PiRK committed rABC8c1629415553: test: Add various low-level p2p tests (authored by MarcoFalke <falke.marco@gmail.com>).
test: Add various low-level p2p tests
Jan 15 2021, 17:23
majcosta closed D8921: [backport#16380] Remove unused bits from the service flags enum.
Jan 15 2021, 16:23
majcosta committed rABCb051c69478dd: [backport#16380] Remove unused bits from the service flags enum (authored by fanquake <fanquake@gmail.com>).
[backport#16380] Remove unused bits from the service flags enum
Jan 15 2021, 16:23
Fabien accepted D8921: [backport#16380] Remove unused bits from the service flags enum.
Jan 15 2021, 16:18
majcosta accepted D8932: test: Verify findCommonAncestor always initializes outputs.
Jan 15 2021, 15:35
teamcity updated the summary of D8932: test: Verify findCommonAncestor always initializes outputs.
Jan 15 2021, 15:17
PiRK requested review of D8932: test: Verify findCommonAncestor always initializes outputs.
Jan 15 2021, 15:17
majcosta accepted D8929: test: Add various low-level p2p tests.
Jan 15 2021, 14:45
majcosta accepted D8931: test: coverage improvements in interface-bitcoin_cli.py.
Jan 15 2021, 14:43
PiRK closed D8930: [doc] Update thread information in developer docs.
Jan 15 2021, 14:30
PiRK committed rABC5a3184116345: [doc] Update thread information in developer docs (authored by John Newbery <john@johnnewbery.com>).
[doc] Update thread information in developer docs
Jan 15 2021, 14:30
PiRK closed D8925: test: add rpc_signrawtransaction logging.
Jan 15 2021, 14:23
PiRK committed rABCb36ecbb6b1b5: test: add rpc_signrawtransaction logging (authored by Jon Atack <jon@atack.com>).
test: add rpc_signrawtransaction logging
Jan 15 2021, 14:23
majcosta accepted D8930: [doc] Update thread information in developer docs.
Jan 15 2021, 14:20
PiRK updated the diff for D8929: test: Add various low-level p2p tests.

remove SCRIPT_PUT_KEY_OP_TRUE for now

Jan 15 2021, 14:20
teamcity updated the summary of D8931: test: coverage improvements in interface-bitcoin_cli.py.
Jan 15 2021, 14:11
PiRK requested review of D8931: test: coverage improvements in interface-bitcoin_cli.py.
Jan 15 2021, 14:11
Joey King <joseph.roy.king@gmail.com> closed D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 15 2021, 13:56
Joey King <joseph.roy.king@gmail.com> committed rABCce6b5329e9c0: [Cashtab] parse sats from scanned qr code amount param (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] parse sats from scanned qr code amount param
Jan 15 2021, 13:56
majcosta requested changes to D8929: test: Add various low-level p2p tests.
Jan 15 2021, 13:53
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Rebase

Jan 15 2021, 13:52
Fabien accepted D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 15 2021, 13:47
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Remove condition check from toLegacy() call in Send.js

Jan 15 2021, 13:43
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Do not attempt to send if address converted to error

Jan 15 2021, 13:31
teamcity updated the summary of D8930: [doc] Update thread information in developer docs.
Jan 15 2021, 13:29
PiRK requested review of D8930: [doc] Update thread information in developer docs.
Jan 15 2021, 13:28
teamcity updated the summary of D8929: test: Add various low-level p2p tests.
Jan 15 2021, 12:54
PiRK requested review of D8929: test: Add various low-level p2p tests.
Jan 15 2021, 12:54
PiRK closed D8928: gui: use PACKAGE_NAME in exception message.
Jan 15 2021, 12:30
PiRK committed rABCf472f3394cb4: gui: use PACKAGE_NAME in exception message (authored by fanquake <fanquake@gmail.com>).
gui: use PACKAGE_NAME in exception message
Jan 15 2021, 12:30
PiRK closed D8927: test: shift coverage from getunconfirmedbalance to getbalances.
Jan 15 2021, 12:22
PiRK committed rABC19d226a18966: test: shift coverage from getunconfirmedbalance to getbalances (authored by Jon Atack <jon@atack.com>).
test: shift coverage from getunconfirmedbalance to getbalances
Jan 15 2021, 12:22
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Generalize ecash to bitcoincash conversion function, add tests, use startWith() string method

Jan 15 2021, 12:16
bytesofman added inline comments to D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 15 2021, 12:16
PiRK updated the diff for D8927: test: shift coverage from getunconfirmedbalance to getbalances.

move comment on its own line

Jan 15 2021, 11:57
PiRK updated the summary of D8927: test: shift coverage from getunconfirmedbalance to getbalances.
Jan 15 2021, 11:55
teamcity closed T1438: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Jan 15 2021, 11:41
majcosta updated the diff for D8921: [backport#16380] Remove unused bits from the service flags enum.

corrected date of removal and removed declaration in messages.py

Jan 15 2021, 11:31
PiRK closed D8923: test: Extend wallet_dump test to cover comments.
Jan 15 2021, 10:39
PiRK committed rABCe8fb01c940eb: test: Extend wallet_dump test to cover comments (authored by MarcoFalke <falke.marco@gmail.com>).
test: Extend wallet_dump test to cover comments
Jan 15 2021, 10:39
PiRK closed D8924: doc: default minconf for getbalance should be 0.
Jan 15 2021, 10:33
PiRK committed rABC28e2e62864b0: doc: default minconf for getbalance should be 0 (authored by U-Zyn Chua <chua@uzyn.com>).
doc: default minconf for getbalance should be 0
Jan 15 2021, 10:33
Fabien accepted D8928: gui: use PACKAGE_NAME in exception message.
Jan 15 2021, 10:26
Fabien accepted D8927: test: shift coverage from getunconfirmedbalance to getbalances.
Jan 15 2021, 10:25
PiRK closed D8917: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig.
Jan 15 2021, 10:24
PiRK committed rABC2dc004421409: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig
Jan 15 2021, 10:24
PiRK updated the test plan for D8928: gui: use PACKAGE_NAME in exception message.
Jan 15 2021, 10:20
PiRK updated the test plan for D8928: gui: use PACKAGE_NAME in exception message.
Jan 15 2021, 10:19
teamcity updated the summary of D8928: gui: use PACKAGE_NAME in exception message.
Jan 15 2021, 10:18
PiRK requested review of D8928: gui: use PACKAGE_NAME in exception message.
Jan 15 2021, 10:18
Fabien accepted D8925: test: add rpc_signrawtransaction logging.
Jan 15 2021, 10:17
Fabien accepted D8924: doc: default minconf for getbalance should be 0.
Jan 15 2021, 10:16
Fabien accepted D8923: test: Extend wallet_dump test to cover comments.
Jan 15 2021, 10:15
Fabien requested changes to D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 15 2021, 10:14
PiRK closed D8922: test: Check that the version message does not leak the local address of the node.
Jan 15 2021, 10:12
PiRK committed rABCf39b2c0aa0be: test: Check that the version message does not leak the local address of the node (authored by MarcoFalke <falke.marco@gmail.com>).
test: Check that the version message does not leak the local address of the node
Jan 15 2021, 10:12
Fabien closed D8926: Remove useless calls to setexcessiveblock in extended tests.
Jan 15 2021, 10:11
Fabien committed rABCb6dcf74bae59: Remove useless calls to setexcessiveblock in extended tests (authored by Fabien).
Remove useless calls to setexcessiveblock in extended tests
Jan 15 2021, 10:11
Fabien updated the summary of D8926: Remove useless calls to setexcessiveblock in extended tests.
Jan 15 2021, 10:09
PiRK accepted D8926: Remove useless calls to setexcessiveblock in extended tests.
Jan 15 2021, 10:03
PiRK added a comment to D8926: Remove useless calls to setexcessiveblock in extended tests.

s/D8917/D8918/ in the Summary

Jan 15 2021, 10:00
teamcity updated the summary of D8927: test: shift coverage from getunconfirmedbalance to getbalances.
Jan 15 2021, 09:48