Page MenuHomePhabricator
Feed Advanced Search

Apr 17 2018

schancel added a comment to T327: Ensure pushdata size are enforced by ParseScript.

I'm not sure how you're supposed to check:

Apr 17 2018, 05:46 · Bootcamp

Apr 16 2018

deadalnix triaged T327: Ensure pushdata size are enforced by ParseScript as High priority.
Apr 16 2018, 21:52 · Bootcamp
schancel triaged T326: Script_tests.json handler should ensure pushed groups are the right size as High priority.
Apr 16 2018, 19:55 · Bootcamp
schancel updated the task description for T325: Setup and document doxygen infrastructure.
Apr 16 2018, 16:58 · Bootcamp
schancel created T325: Setup and document doxygen infrastructure.
Apr 16 2018, 16:56 · Bootcamp

Apr 12 2018

schancel created T322: CMake unable to find OpenSSL on MacOS X.
Apr 12 2018, 20:47 · Bootcamp
schancel created T321: Create test to check node banning behavior.
Apr 12 2018, 15:15 · Bootcamp

Apr 10 2018

alexwagg added a comment to T273: Break sendheaders.py up into separate tests.

Are you saying that Part 1 should be a separate test, Part 2 should be a separate test, and etc...?

Apr 10 2018, 21:12 · Bootcamp
jimpo added a comment to T316: Split TxID and TxHash and use them properly across the codebase.

Can you explain this further? Do you just renaming variables and methods with txid or txhash in the name?

Apr 10 2018, 18:18 · Bootcamp

Apr 9 2018

jasonbcox added a parent task for T318: Backport PR 11335 to fix window restore: T126: Backports from Bitcoin Core.
Apr 9 2018, 22:34 · Bootcamp
jasonbcox created T318: Backport PR 11335 to fix window restore.
Apr 9 2018, 22:31 · Bootcamp

Apr 6 2018

schancel created T316: Split TxID and TxHash and use them properly across the codebase.
Apr 6 2018, 14:44 · Bootcamp

Mar 6 2018

jasonbcox created T285: daemon is deprecated on MAC OSX.
Mar 6 2018, 19:15 · Bootcamp

Mar 5 2018

deadalnix closed T245: Add a hardfork date parameter for May 15th HF. as Resolved by committing rABCde6e708a2344: Add a flag to change when the May 15, 2018 hard fork activates.
Mar 5 2018, 18:30 · Bootcamp
schancel added a revision to T245: Add a hardfork date parameter for May 15th HF.: D1159: Add a flag to change when the May 15, 2018 hard fork activates.
Mar 5 2018, 17:52 · Bootcamp

Mar 4 2018

KONTRABANDA added a comment to T170: Replace direct calls of Params() with Config.GetChainParams().
Mar 4 2018, 04:08 · Bootcamp

Mar 2 2018

schancel renamed T271: Better config/command line parameter handling from Better Argument Handling to Better config/command line parameter handling.
Mar 2 2018, 04:51 · Bootcamp

Mar 1 2018

jasonbcox triaged T273: Break sendheaders.py up into separate tests as Low priority.
Mar 1 2018, 17:22 · Bootcamp

Feb 28 2018

schancel updated the task description for T271: Better config/command line parameter handling.
Feb 28 2018, 22:05 · Bootcamp
deadalnix added a comment to T271: Better config/command line parameter handling.

The general idea is to have something that works as follow:

Feb 28 2018, 20:49 · Bootcamp
schancel updated the task description for T271: Better config/command line parameter handling.
Feb 28 2018, 20:08 · Bootcamp
schancel added a project to T271: Better config/command line parameter handling: Bootcamp.
Feb 28 2018, 20:07 · Bootcamp
schancel added a project to T269: Create a `contrib/teamcity/build-cmake.sh`: Bootcamp.
Feb 28 2018, 19:06 · Bootcamp
schancel added a parent task for T165: Build scripts for other compilers/cross compiles: T258: Quality Assurance Improvements.
Feb 28 2018, 18:50 · Bootcamp

Feb 27 2018

schancel added a revision to T245: Add a hardfork date parameter for May 15th HF.: D1139: Enable May 15 2018 HF Activation.
Feb 27 2018, 21:08 · Bootcamp
movrcx added a comment to T245: Add a hardfork date parameter for May 15th HF..

I've added https://reviews.bitcoinabc.org/D1139 to be used for MTP activation... Since it's a trailing indicator ABC will likely activate after BU's activation by local system time.

Feb 27 2018, 20:34 · Bootcamp

Feb 26 2018

matra774 claimed T163: test_runner.py should not list all the test, but instead be able to find them..
Feb 26 2018, 21:21 · Bootcamp

Feb 25 2018

deadalnix triaged T249: Refactor seeder such as it uses the Config as Normal priority.
Feb 25 2018, 18:17 · Bootcamp
matra774 added a revision to T163: test_runner.py should not list all the test, but instead be able to find them.: D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones.
Feb 25 2018, 17:22 · Bootcamp
deadalnix triaged T247: Make CMessageHeader::pchCommand a C++ array as Normal priority.
Feb 25 2018, 11:54 · Bootcamp
deadalnix added a project to T247: Make CMessageHeader::pchCommand a C++ array: Bootcamp.
Feb 25 2018, 11:54 · Bootcamp

Feb 24 2018

schancel closed T164: Implement junit output support in test_runner.py as Resolved.

Resolved by D1089

Feb 24 2018, 07:47 · Bootcamp
schancel created T246: Testing scripts should run all tests.
Feb 24 2018, 07:36 · Bootcamp

Feb 23 2018

schancel triaged T245: Add a hardfork date parameter for May 15th HF. as High priority.
Feb 23 2018, 22:15 · Bootcamp

Feb 21 2018

matra774 added a revision to T163: test_runner.py should not list all the test, but instead be able to find them.: D1116: Write test timing information to the build tree when running test_runner.py.
Feb 21 2018, 22:09 · Bootcamp

Feb 18 2018

matra774 added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

Is it OK to store timing.json in git (test/function/timing.json)?

Feb 18 2018, 21:12 · Bootcamp
matra774 added a comment to T206: Refactor script_tests.cpp::PushSig() to have default SigHashType param.

Hmm, PushSig already has default SigHashType parameter (introduced in D932):

Feb 18 2018, 13:42 · Bootcamp

Feb 16 2018

schancel updated the task description for T170: Replace direct calls of Params() with Config.GetChainParams().
Feb 16 2018, 05:47 · Bootcamp
matra774 added a revision to T238: Make CTransaction construction from CMutableTransaction explicit: D1106: Make CTransaction construction from CMutableTransaction explicit.
Feb 16 2018, 02:51 · Bootcamp

Feb 15 2018

schancel added a project to T237: Make all class type conversions explicit: Bootcamp.
Feb 15 2018, 05:47 · Bootcamp
deadalnix added a project to T238: Make CTransaction construction from CMutableTransaction explicit: Bootcamp.
Feb 15 2018, 05:46 · Bootcamp

Feb 13 2018

matra774 added a comment to T170: Replace direct calls of Params() with Config.GetChainParams().

@jasonbcox, should I also try to remove the following functions from DstEncode.h:

Feb 13 2018, 20:32 · Bootcamp
matra774 added a revision to T164: Implement junit output support in test_runner.py: D1089: T164 - Implement junit output support in test_runner.py.
Feb 13 2018, 12:49 · Bootcamp

Feb 11 2018

jasonbcox triaged T235: Clean up locking in tests to be consistent as Wishlist priority.
Feb 11 2018, 18:22 · Bootcamp
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..
Feb 11 2018, 17:04 · Bootcamp

Feb 10 2018

matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1079: [Part5] CWallet constructor now has additional parameter chainParams.
Feb 10 2018, 09:24 · Bootcamp

Feb 9 2018

matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.
Feb 9 2018, 21:05 · Bootcamp
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.
Feb 9 2018, 21:05 · Bootcamp

Feb 8 2018

matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1070: [Part1] Removed Params() from addrdb.
Feb 8 2018, 21:17 · Bootcamp

Feb 4 2018

jasonbcox updated the task description for T214: Replace LogPrintf with LogPrint.
Feb 4 2018, 23:14 · Restricted Project, Bootcamp
jasonbcox removed a parent task for T216: Add thread_id to LogPrint: T215: Improve logging.
Feb 4 2018, 23:09 · Bootcamp
jasonbcox added a parent task for T216: Add thread_id to LogPrint: T222: Add key-value support to LogPrint.
Feb 4 2018, 23:08 · Bootcamp

Jan 30 2018

jasonbcox added a parent task for T216: Add thread_id to LogPrint: T215: Improve logging.
Jan 30 2018, 21:54 · Bootcamp
jasonbcox created T216: Add thread_id to LogPrint.
Jan 30 2018, 21:54 · Bootcamp
jasonbcox added a parent task for T214: Replace LogPrintf with LogPrint: T215: Improve logging.
Jan 30 2018, 21:48 · Restricted Project, Bootcamp
jasonbcox updated the task description for T214: Replace LogPrintf with LogPrint.
Jan 30 2018, 21:38 · Restricted Project, Bootcamp
jasonbcox triaged T214: Replace LogPrintf with LogPrint as Low priority.
Jan 30 2018, 21:32 · Restricted Project, Bootcamp

Jan 25 2018

jasonbcox triaged T206: Refactor script_tests.cpp::PushSig() to have default SigHashType param as Wishlist priority.
Jan 25 2018, 23:20 · Bootcamp
jasonbcox triaged T205: Create constructor for SigHashType(BaseSigHashType) as Low priority.
Jan 25 2018, 23:17 · Bootcamp

Jan 24 2018

matiu closed T169: Remove CChainParams parameter from BlockAssembler as Resolved by committing rABCd972add4a2d9: Remove CChainParams parameter from BlockAssembler.
Jan 24 2018, 21:46 · Bootcamp
matiu added a revision to T169: Remove CChainParams parameter from BlockAssembler: D1031: Remove CChainParams parameter from BlockAssembler.
Jan 24 2018, 20:14 · Bootcamp
matiu claimed T169: Remove CChainParams parameter from BlockAssembler.
Jan 24 2018, 15:06 · Bootcamp
matiu closed T187: Remove Consensus::Params parameter from ContextualCheckBlock as Resolved.

At D1028

Jan 24 2018, 02:32 · Bootcamp
jasonbcox closed T166: Remove CChainParams parameter from ConnectBlock as Resolved.
Jan 24 2018, 00:16 · Bootcamp

Jan 23 2018

matiu added a revision to T187: Remove Consensus::Params parameter from ContextualCheckBlock: D1028: Remove Consensus::Params parameter from ContextualCheckBlock.
Jan 23 2018, 21:03 · Bootcamp
matiu claimed T187: Remove Consensus::Params parameter from ContextualCheckBlock.

ok, on it.

Jan 23 2018, 19:24 · Bootcamp
jasonbcox added a comment to T187: Remove Consensus::Params parameter from ContextualCheckBlock.

Fixed the task title and descrition. It wasn't CChainParams directly, but rather a subcomponent of that, which is Consensus::Params. Look at calls to ContextualCheckBlock and it will be clear that the "params" parameter is redundant. Thanks for taking a look at this. :)

Jan 23 2018, 18:00 · Bootcamp
jasonbcox renamed T187: Remove Consensus::Params parameter from ContextualCheckBlock from Remove CChainParams parameter from ContextualCheckBlock to Remove Consensus::Params parameter from ContextualCheckBlock.
Jan 23 2018, 17:58 · Bootcamp
matiu added a comment to T187: Remove Consensus::Params parameter from ContextualCheckBlock.

Checking ContextualCheckBlock at https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/validation.cpp;2c81a03ad212b73ca7002ef9f9f891a025c1f6bd$3523

Jan 23 2018, 15:06 · Bootcamp

Jan 22 2018

deadalnix added a comment to T191: Fix missing-braces warnings..

This flag should be added as part of the build as it is not a default on all the plateforms.

Jan 22 2018, 19:09 · Bootcamp
schancel updated the task description for T191: Fix missing-braces warnings..
Jan 22 2018, 18:51 · Bootcamp
schancel created T191: Fix missing-braces warnings..
Jan 22 2018, 18:50 · Bootcamp
matiu added a comment to T189: Ensure documentation for new developers is easy to understand.

Right now, a lot of developers understand how to use Github. For a variety of reasons, we have chosen to use Phabricator, and will remain on Phabricator for the time being.

Jan 22 2018, 18:26 · Bootcamp
schancel created T189: Ensure documentation for new developers is easy to understand.
Jan 22 2018, 17:44 · Bootcamp
jasonbcox added a project to T129: Add instructions for all platforms to build out-of-tree: Bootcamp.
Jan 22 2018, 05:44 · Bootcamp
jasonbcox created T187: Remove Consensus::Params parameter from ContextualCheckBlock.
Jan 22 2018, 04:48 · Bootcamp

Jan 20 2018

schancel closed T145: Port core PR10072 as Invalid.
Jan 20 2018, 19:57 · Bootcamp

Jan 19 2018

jasonbcox created T170: Replace direct calls of Params() with Config.GetChainParams().
Jan 19 2018, 20:04 · Bootcamp
jasonbcox created T169: Remove CChainParams parameter from BlockAssembler.
Jan 19 2018, 20:01 · Bootcamp
jasonbcox claimed T166: Remove CChainParams parameter from ConnectBlock.
Jan 19 2018, 19:26 · Bootcamp
deadalnix triaged T166: Remove CChainParams parameter from ConnectBlock as Normal priority.
Jan 19 2018, 02:58 · Bootcamp

Jan 18 2018

deadalnix added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

Thinking that a bit more, I'm not sure sure we want to have different path. We can just have a cutoff that is time based, and if no time is provided, we run.

Jan 18 2018, 23:18 · Bootcamp
deadalnix added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

That sounds like a plan that could work.

Jan 18 2018, 21:06 · Bootcamp
matiu added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

ok, what about we have 3 paths:

Jan 18 2018, 17:39 · Bootcamp
deadalnix added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

We can have some file describing timing, but the absence of timing or listing shouldn't mean the test doesn't run.

Jan 18 2018, 14:19 · Bootcamp
matiu added a comment to T145: Port core PR10072.

This is a dup of T144 and it is fixed at D979

Jan 18 2018, 04:07 · Bootcamp
matiu added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

Tests are ordered by the estimated runtime, to favor running tests in parallel (at BASE_SCRIPTS and EXTENDED_SCRIPTS arrays).

Jan 18 2018, 03:28 · Bootcamp
schancel removed a subtask for T145: Port core PR10072: T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests.
Jan 18 2018, 00:16 · Bootcamp
schancel removed a parent task for T145: Port core PR10072: T126: Backports from Bitcoin Core.
Jan 18 2018, 00:16 · Bootcamp
deadalnix added a subtask for T145: Port core PR10072: T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests.
Jan 18 2018, 00:13 · Bootcamp

Jan 17 2018

deadalnix added a parent task for T145: Port core PR10072: T126: Backports from Bitcoin Core.
Jan 17 2018, 23:57 · Bootcamp
deadalnix removed a subtask for T145: Port core PR10072: T126: Backports from Bitcoin Core.
Jan 17 2018, 23:57 · Bootcamp
schancel updated the task description for T145: Port core PR10072.
Jan 17 2018, 23:56 · Bootcamp
deadalnix added a subtask for T145: Port core PR10072: T126: Backports from Bitcoin Core.
Jan 17 2018, 23:55 · Bootcamp
schancel updated the task description for T145: Port core PR10072.
Jan 17 2018, 23:54 · Bootcamp
schancel renamed T145: Port core PR10072 from Port bugfix to forknotify.py to Port core PR10072.
Jan 17 2018, 23:53 · Bootcamp
schancel added a project to T145: Port core PR10072: Bootcamp.
Jan 17 2018, 23:51 · Bootcamp
schancel updated the task description for T165: Build scripts for other compilers/cross compiles.
Jan 17 2018, 23:45 · Bootcamp
schancel created T165: Build scripts for other compilers/cross compiles.
Jan 17 2018, 23:44 · Bootcamp
schancel created T164: Implement junit output support in test_runner.py.
Jan 17 2018, 23:40 · Bootcamp