I don't have a way to assign this to myself, but I put up a diff for this: https://reviews.bitcoinabc.org/D1743

The function uses the global variable vinfoBlockFile, however, this function is locked away in an anonymous namespace. I'm not sure this change is actually worth making at this point as it would require either naming the namespace or moving the the variable outside of the namespace.

Ideally, yes. It's possible there are some dependencies, so breaking it up wherever it makes sense is fine. The goal is to separate the test so that each part is in it's own testable, modifiable chunk. There's no need to run a bunch of unrelated tests (and potentially break them with unrelated changes) just because they're part of the same file.

https://reviews.bitcoinabc.org/D554 for Shammah's fee changes, which is a dependency for this task.

Also move /test/README.md

So is it assumed that the parameters are global to the state? The design becomes a little bit more efficient in some regards if the parameter as given in the example is considered global to the run of the program vs living in the "config" object.

I like this task I can take a shot at it.

Yhis will require special privileges, so I'm not sure we want to bootcamp this.

This should be fixed now

This might be able to be configured through a Phabricator setting:

confirming same issue for me.

I'm not sure how you're supposed to check:

Are you saying that Part 1 should be a separate test, Part 2 should be a separate test, and etc...?

Can you explain this further? Do you just renaming variables and methods with txid or txhash in the name?

The general idea is to have something that works as follow:

I've added https://reviews.bitcoinabc.org/D1139 to be used for MTP activation... Since it's a trailing indicator ABC will likely activate after BU's activation by local system time.

Resolved by D1089