More test is always welcome, unless they are flaky or slow as shit.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 17 2019
See comments in D4356
Overall it looks good. A few details needs to be changed, though.
This isn't a really a change request per se, but I don't understand how the template come to be used, considering it is not referenced anywhere.
I don't think the design here is sound. You don't have an error boundary set anywhere, but a parameter that you pass down to ask what's downstream to not error out. This is not solid. The whole point of the maneuver is to not trust what downstream of the error boundary.
Nov 16 2019
Nov 15 2019
Nov 14 2019
The iff description doesn't match what this does, because it clearly does more than simply receiving and processing the headers messages, it also filter/ban nodes based on it.
I don't see any filtering going on anywhere is that patch.
Nov 13 2019
Add fogoten brace
Nov 12 2019
It's not super useful, ut helps backports.
Rebase and address comments
Fix doc and rebase
Add braces
Nov 11 2019
rebase and fix merge conflict
Nov 10 2019
You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.
Depending on system libs will cause the build to not be reproducible. You need to be using depends libs.
You need to be using the depends libs and not the system's.
You need to be using the libs from depends and not the system libs.
Nov 9 2019
Remove release notes. Will add them back when backporting PR13697 and PR14096
Nov 7 2019
Nov 6 2019
Add release notes, sort imports
This PR doesn't contain any change to the release notes. I'm not sure why we would want to warn people about this, it's not breaking any existing behavior, or fixing any bug they'd waiting on, and is not a very major change.
make static and reorder imports
Fix missing else
Nov 5 2019
Nov 3 2019
Make the method static