Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Nov 4 2019

Fabien accepted D4359: Add more methods to Span class.
Nov 4 2019, 14:03
Fabien accepted D4358: Fix comment layout in client.h.
Nov 4 2019, 13:58
Fabien requested changes to D4357: Add scantxoutset RPC method.
Nov 4 2019, 13:58
Fabien requested changes to D4353: Tests for PSBT.
Nov 4 2019, 13:33
Fabien requested changes to D4352: Create wallet RPCs for PSBT.

This deserves release notes.

Nov 4 2019, 13:09
Fabien requested changes to D4351: Create utility RPCs for PSBT.

This deserves release notes.

Nov 4 2019, 12:32
Fabien created D4365: scripted-diff: test: Use py3.5 bytes::hex() method.
Nov 4 2019, 11:29
Fabien created D4364: Upgrade mac_alias to 2.0.7.
Nov 4 2019, 10:06
Fabien created D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.
Nov 4 2019, 10:05
Fabien created D4362: Fix various linter issues.
Nov 4 2019, 09:20
Fabien planned changes to D4340: [CMAKE] Build the OSX DMG image.

Will split for better readability.

Nov 4 2019, 08:59
Fabien updated the diff for D4350: [CMAKE] Generate the split-debug.sh script.

Avoid re-configuring at each call.

Nov 4 2019, 08:58
Fabien added inline comments to D4350: [CMAKE] Generate the split-debug.sh script.
Nov 4 2019, 08:57

Nov 2 2019

Fabien created D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Nov 2 2019, 11:34
Fabien created D4355: [GITIAN] Sort dependencies lexically.
Nov 2 2019, 09:59
Fabien accepted D4306: test: Add lint to prevent SIGNAL/SLOT connect style.
Nov 2 2019, 09:06
Fabien retitled D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build from [GITIAN] Remove link symbolic link to asm for 32-bits gitian build to [GITIAN] Remove symbolic link to asm for 32-bits gitian build.
Nov 2 2019, 08:42
Fabien updated the diff for D4350: [CMAKE] Generate the split-debug.sh script.

Fix permissions.

Nov 2 2019, 08:39
Fabien created D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.
Nov 2 2019, 07:39

Nov 1 2019

Fabien created D4350: [CMAKE] Generate the split-debug.sh script.
Nov 1 2019, 21:06
Fabien committed rABC5263b1d033cb: [contrib] Support ARM symbol check (authored by Chun Kuan Lee <ken2812221@gmail.com>).
[contrib] Support ARM symbol check
Nov 1 2019, 20:20
Fabien closed D4095: [contrib] Support ARM symbol check.
Nov 1 2019, 20:20
Fabien committed rABC555a27d18f47: Migrate Gitian container to Debian 10 Buster (authored by Fabien).
Migrate Gitian container to Debian 10 Buster
Nov 1 2019, 20:19
Fabien closed D4185: Migrate Gitian container to Debian 10 Buster.
Nov 1 2019, 20:19
Fabien accepted D4322: Various fixups for PR13557.
Nov 1 2019, 15:10
Fabien requested changes to D4322: Various fixups for PR13557.

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

Nov 1 2019, 00:09

Oct 31 2019

Fabien committed rABC6c2786272493: [CMAKE] Move FDELT_TYPE declaration to config (authored by Fabien).
[CMAKE] Move FDELT_TYPE declaration to config
Oct 31 2019, 23:52
Fabien closed D4347: [CMAKE] Move FDELT_TYPE declaration to config.
Oct 31 2019, 23:52
Fabien requested changes to D4306: test: Add lint to prevent SIGNAL/SLOT connect style.

One nit, good otherwise.

Oct 31 2019, 22:58
Fabien created D4347: [CMAKE] Move FDELT_TYPE declaration to config.
Oct 31 2019, 21:06
Fabien accepted D4344: Update qt/bitcoin.cpp with Qt5 connect syntax.
Oct 31 2019, 20:14
Fabien accepted D4343: Update qt/walletmodel.cpp with Qt5 connect syntax.
Oct 31 2019, 20:10
Fabien accepted D4342: Update qt/qvalidatedlinedit.cpp to use Qt5 connect syntax.
Oct 31 2019, 20:09
Fabien committed rABCfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled (authored by Fabien).
[CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled
Oct 31 2019, 18:21
Fabien closed D4341: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled.
Oct 31 2019, 18:21
Fabien created D4341: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled.
Oct 31 2019, 17:05
Fabien created D4340: [CMAKE] Build the OSX DMG image.
Oct 31 2019, 15:02
Fabien accepted D4321: Update qt/receivecoinsdialog.cpp with Qt5 connect syntax.
Oct 31 2019, 09:40
Fabien requested changes to D3950: Merge #12953: Deprecate accounts.

This will really benefit from splitting the diff, this is very long and difficult to review.

Oct 31 2019, 09:18

Oct 30 2019

Fabien committed rABC27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt (authored by Fabien).
[CMAKE] Build the OSX application bundle for bitcoin qt
Oct 30 2019, 14:13
Fabien closed D4290: [CMAKE] Build the OSX application bundle for bitcoin qt.
Oct 30 2019, 14:13
Fabien committed rABC6dd33291c9a8: [CMAKE] Create a windows installer (authored by Fabien).
[CMAKE] Create a windows installer
Oct 30 2019, 14:12
Fabien closed D4274: [CMAKE] Create a windows installer.
Oct 30 2019, 14:12
Fabien committed rABCeb1d98d21207: [CMAKE] Build bitcoinconsensus library both static and shared (authored by Fabien).
[CMAKE] Build bitcoinconsensus library both static and shared
Oct 30 2019, 14:10
Fabien closed D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 30 2019, 14:10
Fabien abandoned D4198: [CMAKE] Add the bitcoinconsensus library.
Oct 30 2019, 14:05
Fabien abandoned D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.
Oct 30 2019, 14:04
Fabien requested changes to D4306: test: Add lint to prevent SIGNAL/SLOT connect style.

Please update the diff dependencies according to the parent being splitted.

Oct 30 2019, 10:42
Fabien accepted D4258: Implement PSBT Structures and un/serialization methods per BIP 174.
Oct 30 2019, 10:32

Oct 29 2019

Fabien accepted D4288: Refactor transaction creation and transaction funding logic.
Oct 29 2019, 07:01

Oct 28 2019

Fabien added inline comments to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 28 2019, 16:12
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Update API according to feedback.
Make the static lib a dependency for the shared one instead of building an object lib.

Oct 28 2019, 16:11
Fabien planned changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 28 2019, 15:04
Fabien updated the summary of D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 28 2019, 15:04
Fabien requested changes to D4288: Refactor transaction creation and transaction funding logic.
Oct 28 2019, 07:13

Oct 26 2019

Fabien accepted D4299: Bump version to 0.20.6.
Oct 26 2019, 19:37
Fabien accepted D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 26 2019, 06:53

Oct 25 2019

Fabien requested review of D4290: [CMAKE] Build the OSX application bundle for bitcoin qt.
Oct 25 2019, 16:18
Fabien accepted D4294: Update seeds.
Oct 25 2019, 06:56
Fabien accepted D4293: Updated manpages for 0.20.5 release.
Oct 25 2019, 06:54
Fabien accepted D4292: Updated chainparams.
Oct 25 2019, 06:54
Fabien requested changes to D3950: Merge #12953: Deprecate accounts.

Please rebase the stack on current master, to allow for running the tests.

Oct 25 2019, 06:51
Fabien accepted D4234: bench: Benchmark MempoolToJSON.
Oct 25 2019, 06:07
Fabien accepted D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Oct 25 2019, 06:05

Oct 24 2019

Fabien requested changes to D4288: Refactor transaction creation and transaction funding logic.
Oct 24 2019, 10:00
Fabien updated the test plan for D4290: [CMAKE] Build the OSX application bundle for bitcoin qt.
Oct 24 2019, 08:31
Fabien created D4290: [CMAKE] Build the OSX application bundle for bitcoin qt.
Oct 24 2019, 08:29
Fabien committed rABCc2d1db0a7ef1: [CMAKE] Move package name and copyright to the top level (authored by Fabien).
[CMAKE] Move package name and copyright to the top level
Oct 24 2019, 06:54
Fabien closed D4284: [CMAKE] Move package name and copyright to the top level.
Oct 24 2019, 06:54

Oct 23 2019

Fabien accepted D4287: Added build-werror config to error on build warnings.
Oct 23 2019, 20:52
Fabien accepted D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.

Discussed offline: there is no working lsan suppression for the issue.

Oct 23 2019, 20:29
Fabien requested changes to D4234: bench: Benchmark MempoolToJSON.

One nit, good otherwise.

Oct 23 2019, 20:27
Fabien committed rABC71c0a7d5285c: Fix -Wrange-loop-analysis warnings (authored by Fabien).
Fix -Wrange-loop-analysis warnings
Oct 23 2019, 15:18
Fabien closed D4283: Fix -Wrange-loop-analysis warnings.
Oct 23 2019, 15:18
Fabien committed rABCdf29943217b8: Fix -Wthread-safety-analysis warnings (authored by Fabien).
Fix -Wthread-safety-analysis warnings
Oct 23 2019, 15:17
Fabien closed D4282: Fix -Wthread-safety-analysis warnings.
Oct 23 2019, 15:17
Fabien updated the summary of D4274: [CMAKE] Create a windows installer.
Oct 23 2019, 12:09
Fabien updated the diff for D4274: [CMAKE] Create a windows installer.

Rebase on top of D4284.

Oct 23 2019, 12:09
Fabien updated the diff for D4284: [CMAKE] Move package name and copyright to the top level.

Update package vendor to match copyright holder.

Oct 23 2019, 11:56
Fabien created D4284: [CMAKE] Move package name and copyright to the top level.
Oct 23 2019, 11:50
Fabien accepted D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 23 2019, 10:49
Fabien created D4283: Fix -Wrange-loop-analysis warnings.
Oct 23 2019, 10:08
Fabien created D4282: Fix -Wthread-safety-analysis warnings.
Oct 23 2019, 09:59
Fabien committed rABCebf78761756f: [CMAKE] Use CPack to build source packages (authored by Fabien).
[CMAKE] Use CPack to build source packages
Oct 23 2019, 09:14
Fabien closed D4273: [CMAKE] Use CPack to build source packages.
Oct 23 2019, 09:14
Fabien committed rABC5928cdaa5b2c: [CMAKE] Use CPack to build packages (authored by Fabien).
[CMAKE] Use CPack to build packages
Oct 23 2019, 09:13
Fabien closed D4267: [CMAKE] Use CPack to build packages.
Oct 23 2019, 09:13

Oct 22 2019

Fabien updated the diff for D4273: [CMAKE] Use CPack to build source packages.

Newline.

Oct 22 2019, 11:06
Fabien updated the diff for D4273: [CMAKE] Use CPack to build source packages.

Use git to get an list of files/directories to exclude.

Oct 22 2019, 11:05
Fabien planned changes to D4273: [CMAKE] Use CPack to build source packages.
Oct 22 2019, 06:04

Oct 21 2019

Fabien created D4274: [CMAKE] Create a windows installer.
Oct 21 2019, 10:06
Fabien created D4273: [CMAKE] Use CPack to build source packages.
Oct 21 2019, 08:41
Fabien requested changes to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 21 2019, 06:32

Oct 18 2019

Fabien requested review of D4267: [CMAKE] Use CPack to build packages.
Oct 18 2019, 19:27
Fabien created D4267: [CMAKE] Use CPack to build packages.
Oct 18 2019, 15:51
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Remove useless EXCLUDE_FROM_ALL.
Remove some boilerplates:

  • Let the function define a couple variables so the target names are directly testable and accessible
  • Move the versioning and output naming back into the function as they are not library specific.
Oct 18 2019, 14:33
Fabien updated the test plan for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 18 2019, 13:36
Fabien committed rABCd6f375f2c914: [CMAKE] Propagate requirements for cmake >= 3.12 (authored by Fabien).
[CMAKE] Propagate requirements for cmake >= 3.12
Oct 18 2019, 13:28
Fabien closed D4257: [CMAKE] Propagate requirements for cmake >= 3.12.
Oct 18 2019, 13:28
Fabien added inline comments to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 18 2019, 13:25
First
Prev
Next