Page MenuHomePhabricator
Feed Advanced Search

Apr 4 2019

jasonbcox closed T566: Backport Core PR12317, a subtask of T561: Backport Core PR 12083, as Resolved.
Apr 4 2019, 19:10 · Backport
jasonbcox closed T566: Backport Core PR12317 as Resolved.
Apr 4 2019, 19:10 · Backport
jasonbcox committed rABC129395a132a3: Document method for reviewers to verify chainTxData (authored by John Newbery <john@johnnewbery.com>).
Document method for reviewers to verify chainTxData
Apr 4 2019, 19:09
jasonbcox closed D2711: Document method for reviewers to verify chainTxData.
Apr 4 2019, 19:09
jasonbcox closed T517: Backport Core PR 9680, a subtask of T417: Backport PR10244 from core, as Resolved.
Apr 4 2019, 18:23 · Backport
jasonbcox closed T517: Backport Core PR 9680 as Resolved.
Apr 4 2019, 18:23 · Backport
jasonbcox added a comment to D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.

Fix the comments and this change should be good.

Apr 4 2019, 18:20
jasonbcox changed the edit policy for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 4 2019, 17:35
Herald added a reviewer for D2773: Update manpages for 0.19.3 release: Restricted Project.
Apr 4 2019, 16:58
Herald added a reviewer for D2772: Update chainparams for 0.19.3 release: Restricted Project.
Apr 4 2019, 16:52
jasonbcox committed rABC2c3a95f445a2: Add tip to the create Debian VM instructions (authored by jasonbcox).
Add tip to the create Debian VM instructions
Apr 4 2019, 16:33
jasonbcox closed D2770: Add tip to the create Debian VM instructions.
Apr 4 2019, 16:32

Apr 3 2019

jasonbcox accepted D2009: [Target v0.19] Deprecate and add test for signrawtransaction.
Apr 3 2019, 23:48
jasonbcox accepted D2763: Update wallet_listsinceblock.py to use signrawtransactionwithwallet rpc.
Apr 3 2019, 23:47
jasonbcox committed rABCe5900c671dad: Add missing step in Debian VM creation process (authored by jasonbcox).
Add missing step in Debian VM creation process
Apr 3 2019, 21:38
jasonbcox closed D2769: Add missing step in Debian VM creation process.
Apr 3 2019, 21:38
jasonbcox committed rABCf8adcd8e16f4: Update Debian VM version link to latest (authored by jasonbcox).
Update Debian VM version link to latest
Apr 3 2019, 21:37
jasonbcox closed D2768: Update Debian VM version link to latest.
Apr 3 2019, 21:37
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Fixes for recent feedback

Apr 3 2019, 21:36
jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Apr 3 2019, 21:30
Herald added a reviewer for D2770: Add tip to the create Debian VM instructions: Restricted Project.
Apr 3 2019, 21:27
Herald added a reviewer for D2769: Add missing step in Debian VM creation process: Restricted Project.
Apr 3 2019, 21:22
Herald added a reviewer for D2768: Update Debian VM version link to latest: Restricted Project.
Apr 3 2019, 21:13
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Cleanup + feedback

Apr 3 2019, 20:47
jasonbcox abandoned D2767: Added definitions for subclasses in chainparams.h.
Apr 3 2019, 20:20
Herald added a reviewer for D2767: Added definitions for subclasses in chainparams.h: Restricted Project.
Apr 3 2019, 18:25

Apr 2 2019

jasonbcox added inline comments to D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.
Apr 2 2019, 21:47
jasonbcox accepted D2765: Use static_cast instead of C-style casts for non-fundamental types.
Apr 2 2019, 20:59
jasonbcox accepted D2711: Document method for reviewers to verify chainTxData.
Apr 2 2019, 20:56
jasonbcox updated the summary of D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.
Apr 2 2019, 20:34
jasonbcox updated the summary of D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.
Apr 2 2019, 20:34
jasonbcox updated the summary of D1970: [Part 3 of 5] Add a CChainState class to clarify internal interfaces.
Apr 2 2019, 20:34
jasonbcox updated the summary of D1968: [Part 1 of 5] Add a CChainState class to clarify internal interfaces.
Apr 2 2019, 20:33
jasonbcox closed T562: Backport Core PR 10275, a subtask of T560: Backport Core PR 11041, as Resolved.
Apr 2 2019, 20:32 · Backport
jasonbcox closed T562: Backport Core PR 10275 as Resolved.
Apr 2 2019, 20:32 · Backport
jasonbcox committed rABCa12048663e1f: Merge #10275: [rpc] Allow fetching tx directly from specified block in… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10275: [rpc] Allow fetching tx directly from specified block in…
Apr 2 2019, 20:31
jasonbcox closed D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction.
Apr 2 2019, 20:30
jasonbcox closed T549: Backport Core PR 10742 as Resolved.
Apr 2 2019, 20:29 · Backport
jasonbcox closed T549: Backport Core PR 10742, a subtask of T417: Backport PR10244 from core, as Resolved.
Apr 2 2019, 20:29 · Backport
jasonbcox committed rABC5ff091f6080f: Backport remaining changes from Core PR 10742 (authored by jasonbcox).
Backport remaining changes from Core PR 10742
Apr 2 2019, 20:28
jasonbcox closed D2719: Backport remaining changes from Core PR 10742.
Apr 2 2019, 20:28
jasonbcox accepted D2748: Add schnorr sign benchmark.
Apr 2 2019, 19:01
jasonbcox accepted D2749: Add schnorr verify benchmark.
Apr 2 2019, 19:00
jasonbcox requested changes to D2462: Make c++14 standard the default for compilation.
Apr 2 2019, 18:53
jasonbcox updated the diff for D2719: Backport remaining changes from Core PR 10742.

Rebase

Apr 2 2019, 18:47
jasonbcox requested changes to D2765: Use static_cast instead of C-style casts for non-fundamental types.

Note for other reviewers: netbase.cpp change was already done by Amaury

Apr 2 2019, 18:22
jasonbcox assigned T555: Backport Core PR 10498 to nakihito.
Apr 2 2019, 18:09 · Bootcamp, Restricted Project
jasonbcox updated the diff for D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction.

hash -> id

Apr 2 2019, 18:09
Nico Guiton <nico@bitframe.org> committed rABCc0c5f98dcdfb: Bump version numbers to 0.19.3 (authored by jasonbcox).
Bump version numbers to 0.19.3
Apr 2 2019, 17:34
jasonbcox closed D2761: Bump version numbers to 0.19.3.
Apr 2 2019, 17:34
jasonbcox requested changes to D2755: [secp256k1] add schnorr sign jni binding.
Apr 2 2019, 01:28
jasonbcox accepted D2756: [secp256k1] refactor nativeECDSABuffer to a more generic name.
Apr 2 2019, 01:10
jasonbcox accepted D2759: Fix arc liberate complaining about concatenation in constant definition.
Apr 2 2019, 01:02
jasonbcox accepted D2757: [LINTER] Escape the % char in the description of PythonFormatLinter.
Apr 2 2019, 00:59
Herald added a reviewer for D2762: Update disclosure policy standards: Restricted Project.
Apr 2 2019, 00:51

Apr 1 2019

jasonbcox requested changes to D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.
Apr 1 2019, 22:58
jasonbcox updated the diff for D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction.

Added release notes
Depends on D2761

Apr 1 2019, 22:08
Herald added a reviewer for D2761: Bump version numbers to 0.19.3: Restricted Project.
Apr 1 2019, 22:03

Mar 31 2019

jasonbcox accepted D1970: [Part 3 of 5] Add a CChainState class to clarify internal interfaces.
Mar 31 2019, 05:23

Mar 30 2019

jasonbcox accepted D2754: [LINTER] Enforce a minimum version for autopep8.
Mar 30 2019, 14:30

Mar 29 2019

jasonbcox triaged T575: Backport Core PR 14532: reduce attack surface of RPC server as High priority.
Mar 29 2019, 22:41 · Bootcamp, Restricted Project
jasonbcox triaged T574: Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs as Normal priority.
Mar 29 2019, 22:37 · Restricted Project, Bootcamp
jasonbcox created T574: Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs.
Mar 29 2019, 22:37 · Restricted Project, Bootcamp
jasonbcox accepted D2754: [LINTER] Enforce a minimum version for autopep8.

I missed the fact that getVersion() is defined in the AutoPEP8Linter that is specific to autopep8. The feedback above is pedantic and not required.

Mar 29 2019, 19:21
jasonbcox accepted D2741: Fix comment about s in schnorr sigs.
Mar 29 2019, 17:11
jasonbcox accepted D2745: [secp256k1] add schnorr verify jni binding.
Mar 29 2019, 17:10
jasonbcox updated the diff for D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction.

Rebase + feedback

Mar 29 2019, 16:31
jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Mar 29 2019, 16:26
jasonbcox committed rABC3e946cea3771: Allow setting an env variable to skip tests in build.sh (authored by jasonbcox).
Allow setting an env variable to skip tests in build.sh
Mar 29 2019, 16:23
jasonbcox closed D2752: Allow setting an env variable to skip tests in build.sh.
Mar 29 2019, 16:23
jasonbcox accepted D2753: [CI] Improve performance when running the tests.

Also consider making a similar change for build-secp2561k1.sh, though the impact will be much less noticeable I think.

Mar 29 2019, 16:20
jasonbcox requested changes to D2754: [LINTER] Enforce a minimum version for autopep8.
Mar 29 2019, 16:16
jasonbcox accepted D2751: Improve teamcity agent setup documentation and service script.
Mar 29 2019, 16:08

Mar 28 2019

jasonbcox committed rABC4e4fb6e1bb28: [Part 2 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 2 of 5] Add a CChainState class to clarify internal interfaces
Mar 28 2019, 23:21
jasonbcox closed D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
Mar 28 2019, 23:21
Herald added a reviewer for D2752: Allow setting an env variable to skip tests in build.sh: Restricted Project.
Mar 28 2019, 23:14
jasonbcox requested changes to D2751: Improve teamcity agent setup documentation and service script.
Mar 28 2019, 22:38

Mar 27 2019

jasonbcox updated the summary of D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
Mar 27 2019, 23:48
jasonbcox updated the diff for D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.

Rebase + fixes described above

Mar 27 2019, 23:48
jasonbcox requested changes to D2745: [secp256k1] add schnorr verify jni binding.
Mar 27 2019, 23:25
jasonbcox updated the test plan for D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
Mar 27 2019, 23:18
jasonbcox commandeered D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
Mar 27 2019, 23:17
jasonbcox triaged T572: Backport Core PR 10279 as High priority.
Mar 27 2019, 22:30 · Backport
Herald added a reviewer for D2746: Merge #10275: [rpc] Allow fetching tx directly from specified block in getrawtransaction: Restricted Project.
Mar 27 2019, 22:07
jasonbcox requested changes to D2735: Add scripted-diffs verification into arcanist.

What's the benefit of scripted diffs? If it's for testing, it seems like we should have proper tests.

Mar 27 2019, 19:43
jasonbcox added a parent task for T417: Backport PR10244 from core: T571: Backport Core PR 10973.
Mar 27 2019, 16:25 · Backport
jasonbcox added a subtask for T571: Backport Core PR 10973: T417: Backport PR10244 from core.
Mar 27 2019, 16:25 · Restricted Project
jasonbcox triaged T571: Backport Core PR 10973 as High priority.
Mar 27 2019, 16:25 · Restricted Project

Mar 26 2019

jasonbcox updated the diff for D2645: Reject headers building on invalid chains by tracking invalidity.

Added functional test

Mar 26 2019, 23:42
jasonbcox added a comment to D2719: Backport remaining changes from Core PR 10742.

Depends on T570

Mar 26 2019, 23:13
jasonbcox planned changes to D2719: Backport remaining changes from Core PR 10742.
Mar 26 2019, 23:12
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Better test correctness

Mar 26 2019, 23:10
jasonbcox accepted D2730: Merge #10858: [RPC] Add "warnings" field to getblockchaininfo and unify "warnings" field in get*info RPCs.
Mar 26 2019, 21:34
jasonbcox triaged T570: Backport Core PR 11923 as Low priority.
Mar 26 2019, 16:06 · Bootcamp, Backport
jasonbcox committed rABC816dbd9150e9: Update seeds (authored by deadalnix).
Update seeds
Mar 26 2019, 15:35
jasonbcox closed D2740: Update seeds.
Mar 26 2019, 15:35
jasonbcox accepted D2740: Update seeds.
Mar 26 2019, 15:26
jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Mar 26 2019, 05:00
jasonbcox updated the summary of D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Mar 26 2019, 04:57
jasonbcox added inline comments to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Mar 26 2019, 04:54