Added changes to linter.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 7 2019
Aug 7 2019
nakihito updated the diff for D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
nakihito retitled D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables. from Merge #12284: Remove assigned but never used local variables. to Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Addressed critiques.
nakihito requested review of D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
github-merge.py changes ignored because they are irrelevant to us.
p2p_segwit.py changes also ignored because we don't have/use segwit.
nakihito retitled D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables. from Merge #12284: Remove assigned but never used local variables. Enable Travis checking for unused local variables. to Merge #12284: Remove assigned but never used local variables..
nakihito planned changes to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Missed a dependency. Will update once completed.
Aug 6 2019
Aug 6 2019
Guess it was updated while I was reviewing. Going to take another look while the teamcity error is fixed.
Fixed typo.
Reverted workaround change.
Fixed its and muli-line string. Added new mispellings to dictionary.
Aug 5 2019
Aug 5 2019
Jul 31 2019
Jul 31 2019
Jul 30 2019
Jul 30 2019
Jul 29 2019
Jul 29 2019
nakihito requested review of D3761: Merge #11900: [script] simplify CheckMinimalPush checks, add safety assert.
else if statements changed to independent if statements here: https://reviews.bitcoinabc.org/D341#change-9hDdQ9uC4uT6
nakihito added a comment to D3750: Merge #12159: Use the character based overload for std::string::find..
In D3750#88441, @deadalnix wrote:There are 2 more instances in the codebase.
Jul 25 2019
Jul 25 2019
Jul 23 2019
Jul 23 2019
nakihito updated the summary of D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..
Jul 22 2019
Jul 22 2019
nakihito requested review of D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..
nakihito updated the summary of D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..
Jul 20 2019
Jul 20 2019
nakihito updated the summary of D3696: Merge #10036: Fix init README format to render correctly on github.
nakihito updated the diff for D3698: Merge #11886: Clarify getbalance meaning a tiny bit in response to questions..
Fixed string formatting.
Jul 19 2019
Jul 19 2019
nakihito planned changes to D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..
nakihito requested review of D3695: Merge #11133: Document assumptions that are beoing made to avoid division by zero.
We removed TxConfirmStats::removeTx() in policy/fees.cpp where there would have been a change.
qt/coincontroldialog.cpp was changed here to reflect the current state of Core: https://reviews.bitcoinabc.org/D3233#change-MdfjIvPLq5Hf
nakihito requested review of D3696: Merge #10036: Fix init README format to render correctly on github.
nakihito requested review of D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
nakihito updated the test plan for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
nakihito updated the test plan for D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
nakihito added inline comments to D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
nakihito planned changes to D3697: Merge #11714: [tests] Test that mempool rejects coinbase transactions.
Jul 18 2019
Jul 18 2019
nakihito planned changes to D3696: Merge #10036: Fix init README format to render correctly on github.
nakihito updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Added CMake.
Jul 17 2019
Jul 17 2019
Jul 16 2019
Jul 16 2019
Removed PR11626. It will be made into its own diff.
Jul 15 2019
Jul 15 2019
nakihito added a comment to D3671: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.
In D3671#86664, @jasonbcox wrote:What's up with sighash_tests.cpp?
Added PR11626 to make the logging rpc public.
nakihito requested review of D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.
Jul 12 2019
Jul 12 2019
In D3667#86343, @markblundeberg wrote:[Errno 28] No space left on device
Jul 11 2019
Jul 11 2019
nakihito planned changes to D3660: Merge #11330: Trivial: Fix comments for DEFAULT_WHITELIST[FORCE]RELAY.