Page MenuHomePhabricator
Feed All Stories

Aug 11 2019

jasonbcox added a reverting change for rABCb6179d8326eb: Bump version to 0.20.0: D3851: Revert "Bump version to 0.20.0".
Aug 11 2019, 21:45
Fabien committed rABCa8e46a60271a: [CMAKE] Avoid duplicating the compiler/linker flags (authored by Fabien).
[CMAKE] Avoid duplicating the compiler/linker flags
Aug 11 2019, 08:06
Fabien closed D3826: [CMAKE] Avoid duplicating the compiler/linker flags.
Aug 11 2019, 08:06
Fabien committed rABCc907fdbf9748: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag (authored by Fabien).
[CMAKE] Fix -Wunused-command-line-argument when adding linker flag
Aug 11 2019, 08:05
Fabien closed D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.
Aug 11 2019, 08:05
Fabien committed rABC3584560a4b91: build: avoid getifaddrs when unavailable (authored by Cory Fields <cory-nospam-@coryfields.com>).
build: avoid getifaddrs when unavailable
Aug 11 2019, 08:03
Fabien closed D3824: build: avoid getifaddrs when unavailable.
Aug 11 2019, 08:02
Fabien committed rABC1ffdfb7e1271: build: Enable -Wredundant-decls where available (authored by practicalswift <practicalswift@users.noreply.github.com>).
build: Enable -Wredundant-decls where available
Aug 11 2019, 07:59
Fabien closed D3823: build: Enable -Wredundant-decls where available.
Aug 11 2019, 07:59
jasonbcox committed rABCb6179d8326eb: Bump version to 0.20.0 (authored by jasonbcox).
Bump version to 0.20.0
Aug 11 2019, 00:36
jasonbcox closed D3838: Bump version to 0.20.0.
Aug 11 2019, 00:36

Aug 10 2019

deadalnix accepted D3849: Merge #11573: [Util] Update tinyformat.h.
Aug 10 2019, 05:36
deadalnix accepted D3850: Merge #12969: Drop dead code CScript::Find.
Aug 10 2019, 05:34
teamcity added a comment to D3850: Merge #12969: Drop dead code CScript::Find.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 10 2019, 01:10
teamcity added a comment to D3850: Merge #12969: Drop dead code CScript::Find.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 10 2019, 00:59
nakihito created D3850: Merge #12969: Drop dead code CScript::Find.
Aug 10 2019, 00:59

Aug 9 2019

Nico Guiton <nico@bitframe.org> committed rABCb4306092e42b: Merge #12947: Wallet hd functional test speedup and clarification (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12947: Wallet hd functional test speedup and clarification
Aug 9 2019, 23:24
Nico Guiton <nico@bitframe.org> closed D3839: Merge #12947: Wallet hd functional test speedup and clarification.
Aug 9 2019, 23:24
teamcity added a comment to D3849: Merge #11573: [Util] Update tinyformat.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 22:42
teamcity added a comment to D3849: Merge #11573: [Util] Update tinyformat.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 22:32
nakihito created D3849: Merge #11573: [Util] Update tinyformat.h.
Aug 9 2019, 22:32
teamcity added a comment to D3848: Merge #11842: [build] Add missing stuff to clean-local.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 22:19
teamcity added a comment to D3848: Merge #11842: [build] Add missing stuff to clean-local.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 22:13
jasonbcox created D3848: Merge #11842: [build] Add missing stuff to clean-local.
Aug 9 2019, 22:12
nakihito accepted D3847: Merge #10642: Remove obsolete _MSC_VER check.

Code wise, this looks the same as what I did (even though it is a trivially small/simple change).

Aug 9 2019, 22:08
teamcity added a comment to D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 22:07
teamcity added a comment to D3847: Merge #10642: Remove obsolete _MSC_VER check.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 22:01
teamcity added a comment to D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 21:57
teamcity added a comment to D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 21:56
nakihito updated the diff for D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Removed newline added to end of timing.json.

Aug 9 2019, 21:56
teamcity added a comment to D3847: Merge #10642: Remove obsolete _MSC_VER check.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 21:53
jasonbcox created D3847: Merge #10642: Remove obsolete _MSC_VER check.
Aug 9 2019, 21:53
Nico Guiton <nico@bitframe.org> committed rABC6e101878d7e2: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args
Aug 9 2019, 21:49
Nico Guiton <nico@bitframe.org> closed D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.
Aug 9 2019, 21:48
nakihito added a comment to D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.

Added inline note for documentation's sake.

Aug 9 2019, 21:47
jasonbcox accepted D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.
Aug 9 2019, 21:33
teamcity added a comment to D3846: Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 21:33
jasonbcox accepted D3839: Merge #12947: Wallet hd functional test speedup and clarification.
Aug 9 2019, 21:32
teamcity added a comment to D3846: Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 21:27
jasonbcox created D3846: Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings.
Aug 9 2019, 21:27
teamcity added a comment to D3845: Merge #12447: test: Add missing signal.h header.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 21:24
teamcity added a comment to D3845: Merge #12447: test: Add missing signal.h header.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 21:18
jasonbcox created D3845: Merge #12447: test: Add missing signal.h header.
Aug 9 2019, 21:18
teamcity added a comment to D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 21:03
teamcity added a comment to D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 20:57
nakihito created D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.
Aug 9 2019, 20:57
teamcity added a comment to D3843: Merge #10036: Fix init README format to render correctly on github.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 20:54
teamcity added a comment to D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 20:52
teamcity added a comment to D3841: Merge #10085: Docs: remove 'noconnect' option.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 20:46
teamcity added a comment to D3843: Merge #10036: Fix init README format to render correctly on github.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 20:43
jasonbcox created D3843: Merge #10036: Fix init README format to render correctly on github.
Aug 9 2019, 20:43
teamcity added a comment to D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 20:40
nakihito created D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.
Aug 9 2019, 20:40
teamcity added a comment to D3841: Merge #10085: Docs: remove 'noconnect' option.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 20:39
jasonbcox created D3841: Merge #10085: Docs: remove 'noconnect' option.
Aug 9 2019, 20:39
teamcity added a comment to D3840: Merge #9910: Docs: correct and elaborate -rpcbind doc.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 20:23
teamcity added a comment to D3840: Merge #9910: Docs: correct and elaborate -rpcbind doc.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 20:16
jasonbcox created D3840: Merge #9910: Docs: correct and elaborate -rpcbind doc.
Aug 9 2019, 20:16
teamcity added a comment to D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 20:16
teamcity added a comment to D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 20:10
nakihito created D3839: Merge #12947: Wallet hd functional test speedup and clarification.
Aug 9 2019, 20:10
Mengerian accepted D3838: Bump version to 0.20.0.

Looks fine to me.

Aug 9 2019, 20:09
markblundeberg added a revision to T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics): D3736: New Schnorr multisig activation.
Aug 9 2019, 19:21
markblundeberg added a task to D3736: New Schnorr multisig activation: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).
Aug 9 2019, 19:20
teamcity added a comment to D3838: Bump version to 0.20.0.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 17:55
teamcity added a comment to D3838: Bump version to 0.20.0.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 17:46
jasonbcox created D3838: Bump version to 0.20.0.
Aug 9 2019, 17:46
jasonbcox abandoned D3836: Bumped version number to 0.19.13.

Ah yes. I was thinking we had another version between then and now. that is incorrect.

Aug 9 2019, 17:26
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC3191004fb0ae: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown.
Aug 9 2019, 17:16
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Aug 9 2019, 17:16
jasonbcox accepted D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Aug 9 2019, 17:12
markblundeberg updated the summary of D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Aug 9 2019, 17:07
teamcity added a comment to D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 17:04
markblundeberg added a comment to D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..

just noticed this bug on testnet in my -debug=net logfile

Aug 9 2019, 16:58
teamcity added a comment to D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 16:58
markblundeberg created D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Aug 9 2019, 16:57
Mengerian requested changes to D3836: Bumped version number to 0.19.13.

Next version should be 0.20.0 no?

Aug 9 2019, 16:33
teamcity added a comment to D3836: Bumped version number to 0.19.13.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 16:31
teamcity added a comment to D3836: Bumped version number to 0.19.13.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 16:22
jasonbcox created D3836: Bumped version number to 0.19.13.
Aug 9 2019, 16:22
jasonbcox requested changes to D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.
Aug 9 2019, 16:09
jasonbcox requested changes to D3834: [TRIVIAL] Cleanup the JNI test file.
Aug 9 2019, 15:45
markblundeberg added a comment to D3830: Update chainparams.

Just to follow up, this did indeed break my testnet node's ability to sync to the fork testnet. I had to put minimumchainwork=0 in the bitcoin.conf so it would stop disconnecting imaginary_username's node with reason "Disconnecting outbound peer 51 -- headers chain has insufficient work"

Aug 9 2019, 15:29
teamcity added a comment to D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 10:52
teamcity added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 10:49
Fabien updated the test plan for D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.
Aug 9 2019, 10:49
teamcity added a comment to D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 10:46
Fabien created D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.
Aug 9 2019, 10:46
teamcity added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 10:38
Fabien created D3834: [TRIVIAL] Cleanup the JNI test file.
Aug 9 2019, 10:38
Fabien added a comment to D3807: Fix some more copies in loops.

@markblundeberg No need to skip, it's already in: D3795

Aug 9 2019, 06:59
deadalnix accepted D3823: build: Enable -Wredundant-decls where available.
Aug 9 2019, 05:20
markblundeberg added a comment to D3807: Fix some more copies in loops.

@Fabien Note for reference: https://github.com/bitcoin/bitcoin/pull/13241 -- is that backport skippable now?

Aug 9 2019, 02:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf78c08c106a5: Merge #13194: Remove template matching and pseudo opcodes (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13194: Remove template matching and pseudo opcodes
Aug 9 2019, 02:41
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3810: Merge #13194: Remove template matching and pseudo opcodes.
Aug 9 2019, 02:40
nakihito updated the summary of D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Aug 9 2019, 01:35
teamcity added a comment to D3810: Merge #13194: Remove template matching and pseudo opcodes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 01:06
teamcity added a comment to D3810: Merge #13194: Remove template matching and pseudo opcodes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 00:55
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

rebase for conflict (standard.cpp in D3807)

Aug 9 2019, 00:55
teamcity added a comment to D3833: Merge #11395: Qt: Enable searching by transaction id.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 9 2019, 00:18