Page MenuHomePhabricator
Feed All Stories

Aug 15 2019

markblundeberg changed the visibility for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 15 2019, 04:26
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

update per comments

Aug 15 2019, 02:33
markblundeberg closed T631: Backport PR 15118 "Refactor block file logic", a subtask of T589: BIP157 & BIP158 backports, as Resolved.
Aug 15 2019, 00:01
markblundeberg closed T631: Backport PR 15118 "Refactor block file logic" as Resolved.
Aug 15 2019, 00:01
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCd181505a6b0f: [5 of 5] Style cleanup. (authored by jimpo).
[5 of 5] Style cleanup.
Aug 15 2019, 00:01
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3589: [5 of 5] Style cleanup..
Aug 15 2019, 00:01

Aug 14 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC2530507308ac: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos. (authored by jimpo).
[4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos.
Aug 14 2019, 23:51
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..
Aug 14 2019, 23:51
jasonbcox accepted D3589: [5 of 5] Style cleanup..
Aug 14 2019, 23:37
jasonbcox accepted D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..
Aug 14 2019, 23:36
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Aug 14 2019, 23:35
jasonbcox requested changes to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 14 2019, 23:34
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

resubmit from arc (with lint changes)

Aug 14 2019, 23:15
teamcity added a comment to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 23:12
markblundeberg added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

This is a variant of D3818 that tests all the forms, and does some extra testing on each one.

Aug 14 2019, 23:12
markblundeberg added reviewers for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants: jasonbcox, Fabien.
Aug 14 2019, 23:11
markblundeberg updated the summary of D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 14 2019, 23:11
markblundeberg created D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 14 2019, 23:10
teamcity added a comment to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 23:05
markblundeberg updated the diff for D3865: recognize bare multisigs as standard only when using minimal pushes.

rebase; increase test coverage and add comments.

Aug 14 2019, 23:00
Mengerian committed rABC65a6198254ac: Bump automatic replay protection to May 2020 upgrade (authored by Mengerian).
Bump automatic replay protection to May 2020 upgrade
Aug 14 2019, 22:55
Mengerian closed D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 22:55
Harbormaster failed remote builds in B7155: Diff 10801 for D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework!
Aug 14 2019, 22:55
teamcity added a comment to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Aug 14 2019, 22:55
teamcity added a comment to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 22:53
jasonbcox updated the diff for D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Cleanup unnecessary and confusing sync_blocks function.

Aug 14 2019, 22:53
jasonbcox added inline comments to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.
Aug 14 2019, 22:46
Nico Guiton <nico@bitframe.org> committed rABC6d42e9db2684: Merge #11417: Correct typo in comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11417: Correct typo in comments
Aug 14 2019, 22:28
Nico Guiton <nico@bitframe.org> closed D3876: Merge #11417: Correct typo in comments.
Aug 14 2019, 22:28
jasonbcox requested changes to D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 14 2019, 22:10
jasonbcox accepted D3876: Merge #11417: Correct typo in comments.
Aug 14 2019, 21:59
markblundeberg accepted D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 21:52
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCa9957345dd26: make CheckMinimalPush available to codebase (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
make CheckMinimalPush available to codebase
Aug 14 2019, 21:12
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3872: make CheckMinimalPush available to codebase.
Aug 14 2019, 21:11
teamcity added a comment to D3879: Merge #11353: Small refactor of CCoinsViewCache::BatchWrite().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 20:57
teamcity added a comment to D3879: Merge #11353: Small refactor of CCoinsViewCache::BatchWrite().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 20:51
nakihito created D3879: Merge #11353: Small refactor of CCoinsViewCache::BatchWrite().
Aug 14 2019, 20:51
nakihito accepted D3874: Cleanup reject_code in p2p_invalid_block.py.
Aug 14 2019, 19:38
nakihito accepted D3877: Cleanup reject_code in feature_csv_activation.py.
Aug 14 2019, 19:36
teamcity added a comment to D3875: Read more reject messages from debug logs in feature_dersig.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 19:18
teamcity added a comment to D3878: Read more reject messages from debug logs in feature_cltv.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 19:15
jasonbcox updated the summary of D3878: Read more reject messages from debug logs in feature_cltv.py.
Aug 14 2019, 19:14
jasonbcox updated the summary of D3875: Read more reject messages from debug logs in feature_dersig.py.
Aug 14 2019, 19:13
teamcity added a comment to D3875: Read more reject messages from debug logs in feature_dersig.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 19:11
jasonbcox updated the diff for D3875: Read more reject messages from debug logs in feature_dersig.py.

Removed unnecessary -par arg and cleaned up unnecessary changes to imports

Aug 14 2019, 19:11
teamcity added a comment to D3878: Read more reject messages from debug logs in feature_cltv.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 19:09
jasonbcox created D3878: Read more reject messages from debug logs in feature_cltv.py.
Aug 14 2019, 19:09
teamcity added a comment to D3877: Cleanup reject_code in feature_csv_activation.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 19:05
teamcity added a comment to D3877: Cleanup reject_code in feature_csv_activation.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 18:58
jasonbcox created D3877: Cleanup reject_code in feature_csv_activation.py.
Aug 14 2019, 18:58
teamcity added a comment to D3868: Bump automatic replay protection to May 2020 upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 18:57
teamcity added a comment to D3876: Merge #11417: Correct typo in comments.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 18:47
teamcity added a comment to D3868: Bump automatic replay protection to May 2020 upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 18:42
Mengerian updated the diff for D3868: Bump automatic replay protection to May 2020 upgrade.

Rebase

Aug 14 2019, 18:42
teamcity added a comment to D3876: Merge #11417: Correct typo in comments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 18:40
nakihito created D3876: Merge #11417: Correct typo in comments.
Aug 14 2019, 18:40
Mengerian committed rABCaf9fd425afd7: Add upgrade features to release notes (authored by Mengerian).
Add upgrade features to release notes
Aug 14 2019, 18:38
Mengerian closed D3869: Add upgrade features to release notes.
Aug 14 2019, 18:38
teamcity added a comment to D3875: Read more reject messages from debug logs in feature_dersig.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 18:30
teamcity added a comment to D3875: Read more reject messages from debug logs in feature_dersig.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 18:23
jasonbcox created D3875: Read more reject messages from debug logs in feature_dersig.py.
Aug 14 2019, 18:23
teamcity added a comment to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 18:14
teamcity added a comment to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 18:08
nakihito updated the diff for D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Fixed amount initialization and removed newlines.

Aug 14 2019, 18:07
Nico Guiton <nico@bitframe.org> committed rABC6387a72b3611: Merge #13188: qa: Remove unused option --srcdir (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13188: qa: Remove unused option --srcdir
Aug 14 2019, 17:46
Nico Guiton <nico@bitframe.org> closed D3867: Merge #13188: qa: Remove unused option --srcdir.
Aug 14 2019, 17:45
teamcity added a comment to D3873: Cleanup reject_code in feature_block.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 16:58
teamcity added a comment to D3874: Cleanup reject_code in p2p_invalid_block.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 16:56
jasonbcox created D3874: Cleanup reject_code in p2p_invalid_block.py.
Aug 14 2019, 16:56
teamcity added a comment to D3873: Cleanup reject_code in feature_block.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 16:52
jasonbcox created D3873: Cleanup reject_code in feature_block.py.
Aug 14 2019, 16:52
jasonbcox committed rABCea63c14f0d04: qa: Read reject reasons from debug log, not p2p messages (authored by jasonbcox).
qa: Read reject reasons from debug log, not p2p messages
Aug 14 2019, 16:39
jasonbcox closed D3862: qa: Read reject reasons from debug log, not p2p messages.
Aug 14 2019, 16:39
jasonbcox committed rABCead9b1d0f49d: Merge #14101: qa: Use named args in validation acceptance tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14101: qa: Use named args in validation acceptance tests
Aug 14 2019, 16:31
jasonbcox closed D3861: Merge #14101: qa: Use named args in validation acceptance tests.
Aug 14 2019, 16:31
jasonbcox accepted D3872: make CheckMinimalPush available to codebase.
Aug 14 2019, 16:24
teamcity added a comment to D3872: make CheckMinimalPush available to codebase.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 14:54
markblundeberg updated the diff for D3865: recognize bare multisigs as standard only when using minimal pushes.

updated to use CheckMinimalPush

Aug 14 2019, 14:49
teamcity added a comment to D3872: make CheckMinimalPush available to codebase.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 14:43
markblundeberg created D3872: make CheckMinimalPush available to codebase.
Aug 14 2019, 14:43
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 12:09
teamcity added a comment to D3870: [CMAKE] Allow for building static and shared versions of secp256k1.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 12:05
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 12:00
Fabien created D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Aug 14 2019, 12:00
teamcity added a comment to D3870: [CMAKE] Allow for building static and shared versions of secp256k1.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 11:59
Fabien created D3870: [CMAKE] Allow for building static and shared versions of secp256k1.
Aug 14 2019, 11:58
Fabien added inline comments to D3197: Make Teamcity agent setup easier.
Aug 14 2019, 09:30
Fabien committed rABCe6eac5abd906: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file (authored by Fabien).
[CMAKE] Fix typos in the secp256k1 CMakeLists.txt file
Aug 14 2019, 08:23
Fabien closed D3854: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file.
Aug 14 2019, 08:23
Fabien accepted D3869: Add upgrade features to release notes.
Aug 14 2019, 08:21
Fabien accepted D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 08:21
Fabien accepted D3862: qa: Read reject reasons from debug log, not p2p messages.
Aug 14 2019, 08:15
Fabien requested changes to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Aug 14 2019, 08:04
Fabien accepted D3861: Merge #14101: qa: Use named args in validation acceptance tests.

NVM my previous comment, I missed you pointed this out in the summary.

Aug 14 2019, 07:41
Fabien added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

@deadalnix Absolutely, sepc256k1 relies on BaseEncoding from the guava dependency which was removed from our codebase by D2681, hence the custom function in D3835.

Aug 14 2019, 07:39
teamcity added a comment to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

Aug 14 2019, 06:53
deadalnix added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.
In D3834#90773, @Fabien wrote:

@deadalnix It's already the case, see D2681 or D2755. Also I have D3835 that will take ownership even more, but make your life easier for testing with buster.

Aug 14 2019, 05:02
deadalnix accepted D3867: Merge #13188: qa: Remove unused option --srcdir.
Aug 14 2019, 04:58
teamcity added a comment to D3869: Add upgrade features to release notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 14 2019, 04:41
teamcity added a comment to D3869: Add upgrade features to release notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 14 2019, 04:35