In D4234#102664, @deadalnix wrote:

It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.

Oct 17 2019, 17:46

fpelliccioni added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

In D4243#102663, @deadalnix wrote:

I think you got the dependency reversed.

Oct 17 2019, 17:46

Nico Guiton <nico@bitframe.org> committed rABCca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #11626: rpc: Make `logging` RPC public

Oct 17 2019, 17:42

Nico Guiton <nico@bitframe.org> closed D3684: Merge #11626: rpc: Make `logging` RPC public.

Oct 17 2019, 17:42

fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Oct 17 2019, 17:39

teamcity added a comment to D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 17 2019, 17:39

fpelliccioni created D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.

Oct 17 2019, 17:39

Nico Guiton <nico@bitframe.org> committed rABCa1f767f4b1e9: [rpc] Add logging RPC (authored by John Newbery <john@johnnewbery.com>).

[rpc] Add logging RPC

Oct 17 2019, 17:27

Nico Guiton <nico@bitframe.org> closed D3464: [rpc] Add logging RPC.

Oct 17 2019, 17:27

deadalnix accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

Oct 17 2019, 01:46

deadalnix requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

The changes made in D3371 do not affect the constructor, so the rationale for not backporting makes no sense whatsoever.

Oct 17 2019, 01:44

deadalnix requested changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Oct 17 2019, 01:41

deadalnix requested changes to D4190: Rename master key to seed.

Where are the other rename done, then ? I don't see a patch in the stack doing that. I don't understand why the double write doesn't come first, then the scripted diff? The way this is done is exceedingly difficult to review.

Oct 17 2019, 01:36

deadalnix requested changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Actually run your test plan.

Oct 17 2019, 01:33

deadalnix requested changes to D4234: bench: Benchmark MempoolToJSON.

It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.

Oct 17 2019, 01:28

deadalnix added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I think you got the dependency reversed.

Oct 17 2019, 01:26

deadalnix accepted D3464: [rpc] Add logging RPC.

Oct 17 2019, 01:25

Oct 16 2019

jasonbcox added a comment to D4240: [gitian-build] Remove ambiguous buildsign argument.

In D4240#102152, @deadalnix wrote:

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

Oct 16 2019, 23:59

jasonbcox added a comment to D4241: [gitian-build] Rename ambiguous --sign argument.

In D4241#102149, @deadalnix wrote:

First, I'm not convinced this is ambiguous. What would you sign in there that makes any sense? Is that worth breaking things? Second, the test plan doesn't cover the feature whatsoever.

Oct 16 2019, 23:57

Nico Guiton <nico@bitframe.org> committed rABCbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings (authored by Nico Guiton <nico@bitframe.org>).

Change CDnsSeedOpts to use std::string instead of c-strings

Oct 16 2019, 20:38

Nico Guiton <nico@bitframe.org> closed D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Oct 16 2019, 20:38

jasonbcox accepted D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.

Oct 16 2019, 20:27

jasonbcox requested changes to D4254: ui: Support wallets unloaded dynamically.

Oct 16 2019, 20:26

jasonbcox accepted D4253: rpc: Add unloadwallet RPC, release notes, and tests.

I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.

Oct 16 2019, 20:15

jasonbcox accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.

Oct 16 2019, 20:00

teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 16 2019, 18:19

teamcity added a comment to D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 16 2019, 18:09

nakihito updated the diff for D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

Rebased.

Oct 16 2019, 18:05

Nico Guiton <nico@bitframe.org> committed rABCaefa60f5c9fd: Introduce constant default variables to initialize seeder options (authored by Nico Guiton <nico@bitframe.org>).

Introduce constant default variables to initialize seeder options

Oct 16 2019, 17:53

Nico Guiton <nico@bitframe.org> closed D4250: Introduce constant default variables to initialize seeder options.

Oct 16 2019, 17:53

Nico Guiton <nico@bitframe.org> committed rABC995338aa7108: Remove strlcpy.h (authored by Nico Guiton <nico@bitframe.org>).

Remove strlcpy.h

Oct 16 2019, 17:48

Nico Guiton <nico@bitframe.org> closed D4259: Remove strlcpy.h.

Oct 16 2019, 17:48

jasonbcox committed rABCdef2d9c3216e: Fix misnamed 0.20.4 release notes (authored by jasonbcox).

Fix misnamed 0.20.4 release notes

Oct 16 2019, 16:21

jasonbcox closed D4260: Fix misnamed 0.20.4 release notes.

Oct 16 2019, 16:21

jasonbcox accepted D4250: Introduce constant default variables to initialize seeder options.

Oct 16 2019, 16:21

fpelliccioni added inline comments to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Oct 16 2019, 15:47

Fabien requested changes to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Oct 16 2019, 15:20

deadalnix accepted D4259: Remove strlcpy.h.

Oct 16 2019, 10:02

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 16 2019, 07:16

teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 16 2019, 07:08

teamcity added a comment to D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 16 2019, 07:07

Fabien planned changes to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Oct 16 2019, 06:58

Fabien updated the summary of D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Oct 16 2019, 06:58

Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Revert dependency, now depends on D4257.

Oct 16 2019, 06:58

teamcity added a comment to D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 16 2019, 06:57

Fabien updated the summary of D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Oct 16 2019, 06:56

Fabien updated the diff for D4257: [CMAKE] Propagate requirements for cmake >= 3.12.

Revert diff dependency.

Oct 16 2019, 06:56

Fabien committed rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt (authored by Fabien).

[CMAKE] Add resource file to bitcoin-qt

Oct 16 2019, 06:53

Fabien closed D4256: [CMAKE] Add resource file to bitcoin-qt.

Oct 16 2019, 06:53

teamcity added a comment to D4260: Fix misnamed 0.20.4 release notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 16 2019, 06:41

Fabien accepted D4260: Fix misnamed 0.20.4 release notes.

Oct 16 2019, 06:33

teamcity added a comment to D4260: Fix misnamed 0.20.4 release notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 16 2019, 06:32

jasonbcox created D4260: Fix misnamed 0.20.4 release notes.

Oct 16 2019, 06:32

nakihito updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Oct 16 2019, 02:08

nakihito requested review of D4190: Rename master key to seed.

In D4190#102420, @deadalnix wrote:

The diff doesn't match the description anymore. It's also unclear to me why the double outputs wasn't stacked first.

Oct 16 2019, 02:06

teamcity added a comment to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 16 2019, 02:04

teamcity added a comment to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 16 2019, 02:02

nakihito requested review of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Oct 16 2019, 01:54

nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Oct 16 2019, 01:54

nakihito updated the summary of D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.