reupload for unrelated test failure

In D3627#85518, @deadalnix wrote:

This makes me a bit worried, to be honest. Isn't it possible to move the nulldummy check near the bound check? This will avoid the spooky action at a distance effect (which is probably why this redundant check survived here in the first place).

@deadalnix I'm trying to find style guides and many like this say that we ought to avoid using unsigned types in this kind of situation, for example: https://google.github.io/styleguide/cppguide.html#Integer_Types

introduce idxKeyCount and restore redundant stack size check

@deadalnix I know you want to switch it to size_t but I'd like to defer that until after this refactor... I'm not 100% comfortable with the C++ casting rules and I think it would make more sense as a consistent style change over the entire EvalScript function, not just one opcode.

Also need https://github.com/bitcoin/bitcoin/pull/15623/files

In D3613#85311, @deadalnix wrote:

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

rebase for minor conflict

rebase

rebase for minor conflict

Definitely not needed now.

rebase because all parents are landed

splitting up the big diff into smaller pieces...

The backports that would remove the need for those two lines:

• "qa: Remove need to handle the network thread in tests" https://github.com/bitcoin/bitcoin/pull/13517
• "qa: wait_for_verack by default" https://github.com/bitcoin/bitcoin/pull/13916

I await your review, then :)

I've checked a variety of other implementations (bchd, verde, BU) and none are performing the incorrect bail-early optimization I suggest here, but you never know, someone might think it's a "clever" idea one day.

In D3581#84954, @deadalnix wrote:

The comment in the interpreter should probably be added somewhere in sigencoding.cpp

After seeing this on phabricator it's a much bigger Diff than I imagined 😅 ... will break it up.

In D3601#84923, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

The inspiration for this change was an issue I was seeing: if a test once took longer than 40s to run, then it would never run again until I ran make clean since the last memory of running that test would be >40s. So the number of tests that would actually run was smaller than TeamCity, and gradually reducing over time. Not exactly the desired situation!

Note: alternatively we could keep the split and rename diskblockpos.h to flatfilepos.h and put the ToString() implementation in a .cpp file also, or ...?

Ah man, one of those backports ... I wonder if we missed something else relevant, I guess we'll just have to find out later when doing dependencies.

update per comments

• rebase for new flag name
• add a new error SCRIPT_ERR_INVALID_CHECKBITS_SIGNATURE (for want of a better name...)
• small tweaks to tests

I am not actually able to run CMake in my local setup ... if someone else can verify this before accepting that would be great.

did all the CMakeLists, not just the main one

include more refactors

update name

CI failure from validation_block_tests, seems to be unrelated...

CMakeLists

braces

D3205