Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Oct 22 2020

deadalnix closed D8035: test: follow-up to rpc: default maxfeerate value as BCH/kB.

Oct 22 2020, 11:10

deadalnix committed rABC005230930fc2: test: follow-up to rpc: default maxfeerate value as BCH/kB (authored by Jon Atack <jon@atack.com>).

test: follow-up to rpc: default maxfeerate value as BCH/kB

Oct 22 2020, 11:10

deadalnix accepted D8046: [SECP256K1] Reorder comments/function around scalar_split_lambda.

Oct 22 2020, 11:03

deadalnix closed D8027: rpc: Use the default maxfeerate value as BCH/kB.

Oct 22 2020, 11:03

deadalnix committed rABC04e6d1809aab: rpc: Use the default maxfeerate value as BCH/kB (authored by Joonmo Yang <dev@remagpie.com>).

rpc: Use the default maxfeerate value as BCH/kB

Oct 22 2020, 11:03

deadalnix accepted D8047: [SECP256K1] Consistency improvements to the comments.

Oct 22 2020, 11:01

deadalnix accepted D8050: [backport#16078] replace tx hash with txid in test rawtransaction.

Oct 22 2020, 11:00

deadalnix accepted D8049: [SECP256K1] Stop treating ECDH as experimental.

Oct 22 2020, 10:59

Oct 21 2020

deadalnix accepted D7973: [CI] Fail fast the builds that print error to stdout.

Oct 21 2020, 23:18

deadalnix requested review of D8035: test: follow-up to rpc: default maxfeerate value as BCH/kB.

Oct 21 2020, 22:57

deadalnix updated the diff for D8027: rpc: Use the default maxfeerate value as BCH/kB.

rebase and fix BTC => BCH

Oct 21 2020, 22:51

deadalnix requested changes to D8034: Merge #13928: qa: blocktools enforce named args for amount.

CI is not happy.

Oct 21 2020, 22:11

deadalnix closed D8012: Add <datadir>/settings.json persistent settings storage..

Oct 21 2020, 22:10

deadalnix committed rABC4089671a9e57: Add <datadir>/settings.json persistent settings storage. (authored by Russell Yanofsky <russ@yanofsky.org>).

Add <datadir>/settings.json persistent settings storage.

Oct 21 2020, 22:10

deadalnix accepted D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..

Oct 21 2020, 17:34

deadalnix accepted D8015: Revert "Revert recent coin selection changes".

Oct 21 2020, 17:33

deadalnix added a comment to D7973: [CI] Fail fast the builds that print error to stdout.

Why do sanitizers need to fail fast on master?

Oct 21 2020, 15:04

deadalnix requested review of D8027: rpc: Use the default maxfeerate value as BCH/kB.

Oct 21 2020, 15:03

deadalnix closed D8024: doc: Add internal interface conventions to developer notes.

Oct 21 2020, 14:38

deadalnix committed rABC1f00ddc6203b: doc: Add internal interface conventions to developer notes (authored by Russell Yanofsky <russ@yanofsky.org>).

doc: Add internal interface conventions to developer notes

Oct 21 2020, 14:38

deadalnix closed D8023: refactor: Change createWallet, fillPSBT argument order.

Oct 21 2020, 14:37

deadalnix committed rABC24128015c5a1: refactor: Change createWallet, fillPSBT argument order (authored by Russell Yanofsky <russ@yanofsky.org>).

refactor: Change createWallet, fillPSBT argument order

Oct 21 2020, 14:37

deadalnix requested changes to D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..

In D8018#188187, @PiRK wrote:

I'm still working on the second commit of that PR. I thought it would be easy, but it isn't (new test not passing). Sorry about that, I should not have sent that first diff so fast.

Oct 21 2020, 14:36

deadalnix closed D8022: refactor: Change Chain::broadcastTransaction param order.

Oct 21 2020, 14:34

deadalnix committed rABCba43817291fa: refactor: Change Chain::broadcastTransaction param order (authored by Russell Yanofsky <russ@yanofsky.org>).

refactor: Change Chain::broadcastTransaction param order

Oct 21 2020, 14:34

deadalnix closed D8021: refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods.

Oct 21 2020, 14:32

deadalnix committed rABCa44de4c6343b: refactor: Rename Chain::Notifications methods to be consistent with other… (authored by Russell Yanofsky <russ@yanofsky.org>).

refactor: Rename Chain::Notifications methods to be consistent with other…

Oct 21 2020, 14:32

deadalnix closed D8020: refactor: Rename Node::disconnect methods.

Oct 21 2020, 14:31

deadalnix committed rABC4f3e6494f3c4: refactor: Rename Node::disconnect methods (authored by Russell Yanofsky <russ@yanofsky.org>).

refactor: Rename Node::disconnect methods

Oct 21 2020, 14:31

deadalnix closed D8019: refactor: Get rid of Wallet::IsWalletFlagSet method.

Oct 21 2020, 14:29

deadalnix committed rABCb4ad0581f635: refactor: Get rid of Wallet::IsWalletFlagSet method (authored by Russell Yanofsky <russ@yanofsky.org>).

refactor: Get rid of Wallet::IsWalletFlagSet method

Oct 21 2020, 14:29

deadalnix accepted D8025: [CI] Build secp256k1 with endomorphism disabled.

Oct 21 2020, 14:28

deadalnix requested review of D8024: doc: Add internal interface conventions to developer notes.

Oct 21 2020, 13:41

deadalnix requested review of D8023: refactor: Change createWallet, fillPSBT argument order.

Oct 21 2020, 13:39

deadalnix requested review of D8022: refactor: Change Chain::broadcastTransaction param order.

Oct 21 2020, 13:29

deadalnix requested review of D8021: refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods.

Oct 21 2020, 13:26

deadalnix requested review of D8020: refactor: Rename Node::disconnect methods.

Oct 21 2020, 13:23

deadalnix requested review of D8019: refactor: Get rid of Wallet::IsWalletFlagSet method.

Oct 21 2020, 13:21

deadalnix updated the diff for D8012: Add <datadir>/settings.json persistent settings storage..

rebase

Oct 21 2020, 10:42

deadalnix requested changes to D8018: [backport#14696 1/2] Added comments referencing multiple CVEs in tests and production code..

Oct 21 2020, 10:38

deadalnix accepted D8017: [backport#16865] test: add some unit tests for merkle.cpp.

Oct 21 2020, 10:36

deadalnix closed D8013: util: Add SetupHelpOptions().

Oct 21 2020, 10:26

deadalnix committed rABC99b8f5ba2cc0: util: Add SetupHelpOptions() (authored by MarcoFalke <falke.marco@gmail.com>).

util: Add SetupHelpOptions()

Oct 21 2020, 10:26

deadalnix requested changes to D8015: Revert "Revert recent coin selection changes".

Why?

Oct 21 2020, 00:38

Oct 20 2020

deadalnix added inline comments to D8014: test: Set catch_system_errors=no on boost unit tests.

Oct 20 2020, 23:52

deadalnix accepted D8014: test: Set catch_system_errors=no on boost unit tests.

Oct 20 2020, 23:51

deadalnix requested review of D8013: util: Add SetupHelpOptions().

Oct 20 2020, 23:35

deadalnix updated the diff for D8012: Add <datadir>/settings.json persistent settings storage..

rebase and check that translation work with and without wallet

Oct 20 2020, 23:04

deadalnix closed D8011: util: Add ReadSettings and WriteSettings functions.

Oct 20 2020, 22:43

deadalnix committed rABC34bd94378a82: util: Add ReadSettings and WriteSettings functions (authored by Russell Yanofsky <russ@yanofsky.org>).

util: Add ReadSettings and WriteSettings functions

Oct 20 2020, 22:42

deadalnix updated the diff for D8012: Add <datadir>/settings.json persistent settings storage..

Rebase and fix translation related conflict

Oct 20 2020, 18:36

deadalnix closed D8009: doc: Add detailed info about Bitcoin Core files.

Oct 20 2020, 18:08

deadalnix committed rABC86009464c76b: doc: Add detailed info about Bitcoin Core files (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

doc: Add detailed info about Bitcoin Core files

Oct 20 2020, 18:08

deadalnix accepted D7999: [backport#16224 5/5] util: Cleanup translation.h.

Oct 20 2020, 18:00

deadalnix requested review of D8012: Add <datadir>/settings.json persistent settings storage..

Oct 20 2020, 16:43

deadalnix requested review of D8011: util: Add ReadSettings and WriteSettings functions.

Oct 20 2020, 16:27

deadalnix updated the diff for D8009: doc: Add detailed info about Bitcoin Core files.

Rebase

Oct 20 2020, 15:42

deadalnix requested review of D8009: doc: Add detailed info about Bitcoin Core files.

Oct 20 2020, 15:41

deadalnix accepted D7993: test: Remove duplicate NodeContext hacks.

Oct 20 2020, 15:28

deadalnix accepted D8005: tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer..

Oct 20 2020, 15:27

deadalnix requested changes to D8005: tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer..

Oct 20 2020, 14:41

deadalnix accepted D7981: p2p: Remove BIP61 reject messages.

Oct 20 2020, 14:26

deadalnix accepted D7987: tests: Remove unused testing code.

Oct 20 2020, 14:24

deadalnix accepted D8004: tests: Add fuzzing harness for strprintf(…).

Oct 20 2020, 14:23

deadalnix accepted D8001: Less confusing documentation for `torpassword`.

Oct 20 2020, 14:19

deadalnix accepted D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.

Oct 20 2020, 14:18

deadalnix accepted D7995: Merge #16931: test: add unittests for CheckProofOfWork.

Oct 20 2020, 14:05

deadalnix accepted D8000: added note that control port must be enabled and how to do that in torrc config file.

Oct 20 2020, 14:04

deadalnix requested changes to D7999: [backport#16224 5/5] util: Cleanup translation.h.

Please point to the specific commit. You might also want to rebase these diffs where the CI failed to make sure.

Oct 20 2020, 14:03

deadalnix accepted D7998: [backport#16224 4/5] doc: Do not translate technical or extremely rare errors.

Oct 20 2020, 14:02

deadalnix accepted D7997: [backport#16224 3/5] Make InitError bilingual.

Oct 20 2020, 14:01

deadalnix accepted D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.

Oct 20 2020, 13:55

deadalnix accepted D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.

Oct 20 2020, 13:47

deadalnix accepted D8002: doc: describe onlynet option in doc/tor.md.

Oct 20 2020, 13:46

deadalnix accepted D8003: Elaborate on the need to re-login on Debian-based systems to use tor following usermod.

Oct 20 2020, 13:44

deadalnix accepted D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Oct 20 2020, 01:08

deadalnix requested changes to D7995: Merge #16931: test: add unittests for CheckProofOfWork.

Back to you, CI is busted.

Oct 20 2020, 00:02

Oct 19 2020

deadalnix requested changes to D7993: test: Remove duplicate NodeContext hacks.

Oct 19 2020, 23:56

deadalnix accepted D7991: scripted-diff: Remove g_rpc_node references.

Oct 19 2020, 23:51

deadalnix accepted D7992: refactor: Remove g_rpc_node global.

Oct 19 2020, 23:50

deadalnix added a comment to D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.

Please make sure you have all the PR parts up for review so we can know where this is going when reviewing individual parts. This also helps ensure there won't be a PR half merged in flight forever.

Oct 19 2020, 16:19

deadalnix requested changes to D7973: [CI] Fail fast the builds that print error to stdout.

Oct 19 2020, 16:17

deadalnix added a comment to D7987: tests: Remove unused testing code.

Where is part 2?

Oct 19 2020, 16:15

deadalnix accepted D7984: test: Add generatetodescriptor RPC.

Oct 19 2020, 16:13

deadalnix accepted D7983: [rpc] Correct reconsiderblock help text, add test.

Oct 19 2020, 14:08

deadalnix accepted D7980: [CI] Don't run the sanitizer against the debug build.

Oct 19 2020, 14:05

deadalnix accepted D7979: [CI] Add a debug build configuration.

Oct 19 2020, 14:01

deadalnix requested changes to D7981: p2p: Remove BIP61 reject messages.

Oct 19 2020, 13:20

Oct 17 2020

deadalnix requested changes to D7973: [CI] Fail fast the builds that print error to stdout.

Oct 17 2020, 19:04

deadalnix closed D7971: [secp256k1] Enable endomorphism by default.

Oct 17 2020, 18:17

deadalnix committed rABCc6dbc176ffa9: [secp256k1] Enable endomorphism by default (authored by deadalnix).

[secp256k1] Enable endomorphism by default

Oct 17 2020, 18:16

deadalnix accepted D7970: test: Seed test RNG context for each test case, print seed.

Oct 17 2020, 16:04

deadalnix accepted D7972: rcp: update validateaddress RPCExamples to CashAddr.

Oct 17 2020, 16:02

deadalnix requested changes to D7970: test: Seed test RNG context for each test case, print seed.

Make sure you look at the clang tidy build.

Oct 17 2020, 14:46

deadalnix updated the summary of D7971: [secp256k1] Enable endomorphism by default.

Oct 17 2020, 14:30

deadalnix accepted D7969: Add the python extension to the macdeployqtplus script.

Oct 17 2020, 14:24

deadalnix accepted D7967: [scripts] Minor improvements to `macdeployqtplus` script.

Oct 17 2020, 14:23

deadalnix accepted D7968: build: Drop macports support.

Oct 17 2020, 14:23

deadalnix requested review of D7971: [secp256k1] Enable endomorphism by default.

Oct 17 2020, 14:21

deadalnix accepted D7951: [CI] Add a configuration for running on native OSX agents.

Oct 17 2020, 14:19