Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2024

PiRK added inline comments to D16333: [electrum] start implementing the PSBT format.
Jun 17 2024, 08:58
PiRK updated the diff for D16336: [electrum] make read_compact_size return None at EOF instead of raising an error.

use the walrus operator

Jun 17 2024, 08:19

Jun 16 2024

PiRK updated the diff for D16336: [electrum] make read_compact_size return None at EOF instead of raising an error.

rewrite this in a cleaner way (no error catching, no need for a comment to explain what's happening)

Jun 16 2024, 06:51

Jun 15 2024

PiRK retitled D16336: [electrum] make read_compact_size return None at EOF instead of raising an error from [electrum] make read_compact_size return None at EOL instead of raising an error to [electrum] make read_compact_size return None at EOF instead of raising an error.
Jun 15 2024, 05:40

Jun 14 2024

PiRK updated the diff for D16333: [electrum] start implementing the PSBT format.

rebase onto D16336

Jun 14 2024, 20:18
PiRK requested review of D16336: [electrum] make read_compact_size return None at EOF instead of raising an error.
Jun 14 2024, 20:16
PiRK added a comment to D16333: [electrum] start implementing the PSBT format.

I broke another test when I changed how read_compact_size handles errors.

Jun 14 2024, 19:31
PiRK updated the diff for D16333: [electrum] start implementing the PSBT format.

add copyright header, misc comments and doc fixups

Jun 14 2024, 19:28
PiRK accepted D16335: Fix a -Wstringop-overflow warning in wallet_tests.
Jun 14 2024, 19:27
PiRK added inline comments to D16333: [electrum] start implementing the PSBT format.
Jun 14 2024, 16:24
PiRK planned changes to D16333: [electrum] start implementing the PSBT format.

copyright header missing

Jun 14 2024, 16:23
PiRK requested review of D16333: [electrum] start implementing the PSBT format.
Jun 14 2024, 16:23

Jun 13 2024

PiRK closed D16330: [lint] fix a false positive locale dependence detection.
Jun 13 2024, 16:21
PiRK committed rABC5aa6eda04813: [lint] fix a false positive locale dependence detection (authored by PiRK).
[lint] fix a false positive locale dependence detection
Jun 13 2024, 16:21
PiRK accepted D16322: Revert "[chronik] Disable the Write Ahead Log for rocksdb".
Jun 13 2024, 16:16
PiRK retitled D16330: [lint] fix a false positive locale dependence detection from [lint] fix a false positive locale violation detection to [lint] fix a false positive locale dependence detection.
Jun 13 2024, 09:23
PiRK requested review of D16330: [lint] fix a false positive locale dependence detection.
Jun 13 2024, 09:16
PiRK accepted D16329: Bump linters in contrib/utils.
Jun 13 2024, 09:00

Jun 12 2024

PiRK closed D16327: [electrum] suppress an error when sys.stdout is None.
Jun 12 2024, 21:10
PiRK committed rABC4bdc3dd0a0ae: [electrum] suppress an error when sys.stdout is None (authored by PiRK).
[electrum] suppress an error when sys.stdout is None
Jun 12 2024, 21:10
PiRK closed D16326: [electrum] rework copyright and license files, link it in About dialog.
Jun 12 2024, 21:10
PiRK committed rABCcf5d866f47b7: [electrum] rework copyright and license files, link it in About dialog (authored by PiRK).
[electrum] rework copyright and license files, link it in About dialog
Jun 12 2024, 21:10
PiRK updated the summary of D16327: [electrum] suppress an error when sys.stdout is None.
Jun 12 2024, 10:15
PiRK requested review of D16327: [electrum] suppress an error when sys.stdout is None.
Jun 12 2024, 10:13
PiRK requested review of D16326: [electrum] rework copyright and license files, link it in About dialog.
Jun 12 2024, 09:42

Jun 11 2024

PiRK accepted D16321: Remove dead link in the release note.
Jun 11 2024, 08:32

Jun 10 2024

PiRK accepted D16318: log: add orphanage logs, add TXPACKAGES category.
Jun 10 2024, 15:21
PiRK closed D16319: don't pass the avalanche processor pointer by reference to the TreadImport lambda.
Jun 10 2024, 15:14
PiRK committed rABC27638b9002d3: don't pass the avalanche processor pointer by reference to the TreadImport… (authored by PiRK).
don't pass the avalanche processor pointer by reference to the TreadImport…
Jun 10 2024, 15:14
PiRK closed D16317: fix a couple of node.avalanche nullptr dereferencing.
Jun 10 2024, 15:14
PiRK committed rABC1a982a197370: fix a couple of node.avalanche nullptr dereferencing (authored by PiRK).
fix a couple of node.avalanche nullptr dereferencing
Jun 10 2024, 15:14
teamcity awarded D16319: don't pass the avalanche processor pointer by reference to the TreadImport lambda a Haypence token.
Jun 10 2024, 14:30
PiRK added a comment to D16319: don't pass the avalanche processor pointer by reference to the TreadImport lambda.

@bot build-asan

Jun 10 2024, 14:30
PiRK requested review of D16319: don't pass the avalanche processor pointer by reference to the TreadImport lambda.
Jun 10 2024, 14:29
PiRK updated the diff for D16317: fix a couple of node.avalanche nullptr dereferencing.

fix another related bug, update summary, add test that catches both bugs

Jun 10 2024, 14:16
PiRK planned changes to D16317: fix a couple of node.avalanche nullptr dereferencing.

i should be able to add a test for this

Jun 10 2024, 10:22
teamcity awarded D16317: fix a couple of node.avalanche nullptr dereferencing a Haypence token.
Jun 10 2024, 10:20
PiRK added a comment to D16317: fix a couple of node.avalanche nullptr dereferencing.

@bot build-asan

Jun 10 2024, 10:20
PiRK requested review of D16317: fix a couple of node.avalanche nullptr dereferencing.
Jun 10 2024, 10:14
PiRK accepted D16316: RPC: Accept options as named-only parameters.
Jun 10 2024, 07:46
PiRK requested changes to D16316: RPC: Accept options as named-only parameters.
Jun 10 2024, 06:47
PiRK accepted D16315: doc: Properly report optional RPC args.
Jun 10 2024, 06:35
PiRK accepted D16314: rpc: Throw more user friendly arg type check error.
Jun 10 2024, 06:29

Jun 7 2024

PiRK closed D16224: remove g_avalanche global.
Jun 7 2024, 19:01
PiRK committed rABC8b360fa01e8c: remove g_avalanche global (authored by PiRK).
remove g_avalanche global
Jun 7 2024, 19:01
PiRK closed D16270: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock.
Jun 7 2024, 18:59
PiRK committed rABC46f5b0863250: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock (authored by PiRK).
[avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock
Jun 7 2024, 18:59
PiRK closed D16313: [avalanche] initialize the avalanche processor only when avalanche is enabled.
Jun 7 2024, 18:59
PiRK closed D16312: [avalanche] pass a fRelayProofs flag to the Peer struct.
Jun 7 2024, 18:59
PiRK committed rABC9687e8a6dfcd: [avalanche] pass a fRelayProofs flag to the Peer struct (authored by PiRK).
[avalanche] pass a fRelayProofs flag to the Peer struct
Jun 7 2024, 18:59
PiRK committed rABC6f63fc475125: [avalanche] initialize the avalanche processor only when avalanche is enabled (authored by PiRK).
[avalanche] initialize the avalanche processor only when avalanche is enabled
Jun 7 2024, 18:59
PiRK closed D16311: [avalanche] pass fAutoUnpark to Chainstate::FindMostWorkChain.
Jun 7 2024, 18:59
PiRK committed rABCf51f51f07a52: [avalanche] pass fAutoUnpark to Chainstate::FindMostWorkChain (authored by PiRK).
[avalanche] pass fAutoUnpark to Chainstate::FindMostWorkChain
Jun 7 2024, 18:59
PiRK updated the diff for D16270: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock.

pass a reference. This happens in a scope in which we have the guarantee that avalanche is initialized.

Jun 7 2024, 13:26
PiRK updated the diff for D16313: [avalanche] initialize the avalanche processor only when avalanche is enabled.

store and reuse a flag

Jun 7 2024, 13:07
PiRK updated the diff for D16313: [avalanche] initialize the avalanche processor only when avalanche is enabled.

completely inline the GetBoolArg call

Jun 7 2024, 10:15
PiRK updated the diff for D16224: remove g_avalanche global.

dedup forward declaration

Jun 7 2024, 07:52
PiRK updated the diff for D16224: remove g_avalanche global.

rebase

Jun 7 2024, 07:49
PiRK updated the diff for D16270: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock.

rebase on D16313 (now we can rely on the processor pointer to determine if avalanche is enabled)

Jun 7 2024, 07:48
PiRK requested review of D16313: [avalanche] initialize the avalanche processor only when avalanche is enabled.
Jun 7 2024, 07:40
PiRK requested review of D16312: [avalanche] pass a fRelayProofs flag to the Peer struct.
Jun 7 2024, 07:17
PiRK requested review of D16311: [avalanche] pass fAutoUnpark to Chainstate::FindMostWorkChain.
Jun 7 2024, 07:02
PiRK accepted D16310: [unvalue] Run clang-tidy against the univalue codebase.
Jun 7 2024, 06:17
PiRK accepted D16308: [univalue] Lint the univalue code.
Jun 7 2024, 06:15
PiRK accepted D16307: [univalue] Remove autotools.
Jun 7 2024, 06:13

Jun 6 2024

PiRK accepted D16298: [e.cash] Remove video rotation on landing page.
Jun 6 2024, 15:17
PiRK accepted D16306: [explorer] Fix unconfirmed txs showing as block height 0.
Jun 6 2024, 15:00
PiRK accepted D16305: [explorer] Unfold the token balances by default if there is any.
Jun 6 2024, 14:59
PiRK planned changes to D16301: [electrum] refactor ecc.py.
Jun 6 2024, 14:13
PiRK closed D16300: [electrum] prefer int.from_bytes over int('0x'+hex, 16).
Jun 6 2024, 12:58
PiRK closed D16279: [electrum] move-only: split bip32 from bitcoin.py.
Jun 6 2024, 12:58
PiRK committed rABC24d6a0a49da0: [electrum] prefer int.from_bytes over int('0x'+hex, 16) (authored by PiRK).
[electrum] prefer int.from_bytes over int('0x'+hex, 16)
Jun 6 2024, 12:58
PiRK committed rABC346272c6adb7: [electrum] move-only: split bip32 from bitcoin.py (authored by PiRK).
[electrum] move-only: split bip32 from bitcoin.py
Jun 6 2024, 12:58
PiRK closed D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.
Jun 6 2024, 12:58
PiRK closed D16303: [electrum] add test coverage for base58 address encoding.
Jun 6 2024, 12:58
PiRK committed rABC0de5b333b9d5: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py (authored by PiRK).
[electrum] move-only: extract more crypto code from bitcoin.py into ecc.py
Jun 6 2024, 12:58
PiRK committed rABCad4b678ffef3: [electrum] add test coverage for base58 address encoding (authored by PiRK).
[electrum] add test coverage for base58 address encoding
Jun 6 2024, 12:58
PiRK closed D16277: [electrum] move-only: split part of bitcoin.py into crypto.py.
Jun 6 2024, 12:58
PiRK committed rABC6877d06fc660: [electrum] move-only: split part of bitcoin.py into crypto.py (authored by PiRK).
[electrum] move-only: split part of bitcoin.py into crypto.py
Jun 6 2024, 12:58
PiRK accepted D16294: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it.
Jun 6 2024, 10:00
PiRK updated the summary of D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.
Jun 6 2024, 09:56
PiRK updated the diff for D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.

rebase after adding test coverage

Jun 6 2024, 09:56
PiRK requested review of D16303: [electrum] add test coverage for base58 address encoding.
Jun 6 2024, 09:49
PiRK requested review of D16302: [electrum] minor cleanup in Transaction.verify_signature.
Jun 6 2024, 09:10
PiRK updated the summary of D16301: [electrum] refactor ecc.py.
Jun 6 2024, 08:55
PiRK requested review of D16301: [electrum] refactor ecc.py.
Jun 6 2024, 08:55
PiRK updated the summary of D16300: [electrum] prefer int.from_bytes over int('0x'+hex, 16).
Jun 6 2024, 08:52
PiRK requested review of D16300: [electrum] prefer int.from_bytes over int('0x'+hex, 16).
Jun 6 2024, 08:52
PiRK accepted D16297: test: Fix failing univalue float test.
Jun 6 2024, 07:08
PiRK accepted D16296: Remove unused raw-pointer read helper from univalue.
Jun 6 2024, 07:07
PiRK accepted D16295: scripted-diff: Following the C++ Standard rules for identifiers with _..
Jun 6 2024, 07:02
PiRK requested changes to D16294: refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it.

This is a partial backport. Did you skip the second commit intentionally?

Jun 6 2024, 07:01
PiRK accepted D16293: refactor: RPC: pass named argument value as string_view.
Jun 6 2024, 06:53
PiRK accepted D16292: refactor: use convenience fn to auto parse non-string parameters.
Jun 6 2024, 06:50
PiRK accepted D16291: univalue: Remove confusing getBool method.
Jun 6 2024, 06:47
PiRK accepted D16290: rpc: treat univalue type check error as RPC_TYPE_ERROR, not RPC_MISC_ERROR.
Jun 6 2024, 06:46
PiRK accepted D16289: univalue: Avoid std::string copies.
Jun 6 2024, 06:43
PiRK accepted D16285: Fix issues when calling std::move(const&).
Jun 6 2024, 06:40

Jun 5 2024

PiRK accepted D16288: Fix some std::move issues.
Jun 5 2024, 18:37
PiRK accepted D16286: CBlockLocator: performance-move-const-arg Clang tidy fixups.
Jun 5 2024, 14:10