base58.cpp change wes made in D624 and then the code was moved to a different file in D3577.
The majority of other changes were made in D873.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 10 2019
Jul 10 2019
nakihito requested review of D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Allowed linter to relayout help string.
Jul 9 2019
Jul 9 2019
nakihito updated the diff for D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).
Fixed comment formatting.
nakihito added a comment to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).
GetCoin() in txmempool.h was changed here: https://reviews.bitcoinabc.org/D763#change-X7xlaclCBwBo
In D3587#84811, @markblundeberg wrote:Note: alternatively we could keep the split and rename diskblockpos.h to flatfilepos.h and put the ToString() implementation in a .cpp file also, or ...?
I'm not totally sure if it's worth splitting up the two, the main thing seems to have been getting it out of chain.h.
Jul 8 2019
Jul 8 2019
Changed logging() to static.
Rebased due to some file names being changed in a different patch.
Jul 6 2019
Jul 6 2019
nakihito updated the diff for D3569: Merge #10530: Fix invalid instantiation and possibly unsafe accesses of array in class base_uint<BITS>.
Changed (uint32_t)-1 to std::numeric_limits<uint32_t>::max().
Jul 5 2019
Jul 5 2019
nakihito added a comment to D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.
In D3542#84072, @Fabien wrote:The changes to consensus/tx_verify.cpp need to be backported. It's not in our codebase.
nakihito requested review of D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.
coins.cpp changes were previously made here: https://reviews.bitcoinabc.org/D470
consensus/tx_verify.cpp changes were made here: https://reviews.bitcoinabc.org/D1739 (note: GetTransactionSigOpCost() was never added)
validation.cpp changes made here: https://reviews.bitcoinabc.org/D1479 and here: https://reviews.bitcoinabc.org/D471#change-8J68DPC7df8b
Changed title to better describe changes as requested by @deadalnix.
Changed title to better describe changes as requested by @deadalnix.
Jul 3 2019
Jul 3 2019
nakihito retitled D3530: Make various functions in src/test/ static from Merge #13163: Make it clear which functions that are intended to be translation unit local (src/test/) to Make various functions in src/test/ static.
nakihito retitled D3526: Make printchunk() in support/lockedpool.cpp static from Merge #13163: Make it clear which functions that are intended to be translation unit local (support/lockedpool.cpp) to Make printchunk() in support/lockedpool.cpp static.
nakihito planned changes to D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.
Added libevent filter, but had to pull the updated code from PR12954 along with some other changes to make everything fit together.
nakihito updated the diff for D3505: Merge #10347: Use range-based for loops (C++11) when looping over vector elements.
Fixed nits.
Jul 2 2019
Jul 2 2019
nakihito abandoned D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.
Reverted accidental variable type changes.
nakihito retitled D3512: Merge #13163: Make it clear which functions that are intended to be translation unit local (validation.cpp) from Merge #13163: Make it clear which functions that are intended to be translation unit local (validation) to Merge #13163: Make it clear which functions that are intended to be translation unit local (validation.cpp).
D3510: Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files) is now accepted and ready to land.
nakihito retitled D3510: Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files) from Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet) to Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files).
Jul 1 2019
Jul 1 2019
nakihito added a comment to D3505: Merge #10347: Use range-based for loops (C++11) when looping over vector elements.
Changed CTxIn to auto.
Removed enableCategoryMask and disableCategoryMask functions and replaced them with EnableOrDisableLogCategories from Core PR12954. Also squashed libevent commit.
Jun 29 2019
Jun 29 2019
nakihito added a comment to D3466: Merge #10415: [tests] Speed up fuzzing by ~200x when using afl-fuzz.
In D3466#81930, @Fabien wrote:Code looks good, but I fail to see how make check is testing that.
nakihito added a comment to D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.
Going to try and break this into smaller pieces.
In D3464#81957, @Fabien wrote:Also I don't see the filter on libevent, even if there is a comment remaining about it. Is there a reason why it is not required for us ?
Jun 28 2019
Jun 28 2019
D3465: Merge #11635: trivial: Fix typo – alreardy → already is now accepted and ready to land.
D3463: Merge #11480: [ui] Add toggle for unblinding password fields is now accepted and ready to land.
nakihito added a comment to D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.
Rebased.
Jun 24 2019
Jun 24 2019
D3405: Merge #10744: Use method name via __func__ macro is now accepted and ready to land.
D3404: Fix inconsistencies and grammar in various files is now accepted and ready to land.
Clarified test plan concerning tor.
Ran bitcoind under tor and updated test plan.
Jun 22 2019
Jun 22 2019
Jun 21 2019
Jun 21 2019
nakihito added a comment to D3385: Merge #10380: [doc] Removing comments about dirty entries on txmempool.
Fixed spacing.
nakihito added a comment to D3385: Merge #10380: [doc] Removing comments about dirty entries on txmempool.
Fixed duplicate //.