Page MenuHomePhabricator
Feed All Stories

Jun 23 2020

jasonbcox requested review of D6691: [land-bot] Skip sanity check during arc patch.
Jun 23 2020, 21:10
majcosta committed rABCadf568cc5989: [backport#15751] Speed up deriveaddresses for large ranges (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#15751] Speed up deriveaddresses for large ranges
Jun 23 2020, 21:09
majcosta closed D6641: [backport#15751] Speed up deriveaddresses for large ranges.
Jun 23 2020, 21:08
Fabien abandoned D6675: Do not review.
Jun 23 2020, 19:55
Fabien requested review of D6690: [CI] Wrap build_depends.sh on ibd.sh into functions.
Jun 23 2020, 19:54
Fabien updated the diff for D6689: [CI] Setup don't need to be a function.

Fix CI_SCRIPT_DIR so it doesn't depend on the caller location

Jun 23 2020, 19:35
teamcity added a comment to D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 19:25
majcosta committed rABCc7bc25d97f07: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and… (authored by John Newbery <john@johnnewbery.com>).
[backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and…
Jun 23 2020, 18:43
majcosta closed D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.
Jun 23 2020, 18:43
majcosta committed rABC4bfb19a4c357: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#15427 3/3] Add support for descriptors to utxoupdatepsbt
Jun 23 2020, 18:39
majcosta closed D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.
Jun 23 2020, 18:39
majcosta committed rABC3264546a77b3: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT
Jun 23 2020, 18:39
majcosta closed D6624: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT.
Jun 23 2020, 18:39
majcosta committed rABCc8309573b923: [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset
Jun 23 2020, 18:33
majcosta closed D6616: [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset.
Jun 23 2020, 18:33
majcosta committed rABCbb01006c69ee: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16512] rpc: Shuffle inputs and outputs after joining psbts
Jun 23 2020, 18:30
majcosta closed D6665: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.
Jun 23 2020, 18:30
majcosta committed rABC019603ed8d72: [backport#10574] Remove includes in .cpp files for things the corresponding .h… (authored by majcosta).
[backport#10574] Remove includes in .cpp files for things the corresponding .h…
Jun 23 2020, 18:29
majcosta closed D6666: [backport#10574] Remove includes in .cpp files for things the corresponding .h file already included.
Jun 23 2020, 18:29
Fabien planned changes to D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 17:38
teamcity added a comment to D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 17:31
teamcity added a comment to D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 17:31
teamcity added a comment to D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 17:30
Fabien requested review of D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 16:53
Fabien committed rABCc55ecd0094c1: [CI] Remove duplicated `cd` to the build dir with build-make-generator (authored by Fabien).
[CI] Remove duplicated `cd` to the build dir with build-make-generator
Jun 23 2020, 16:52
Fabien closed D6688: [CI] Remove duplicated `cd` to the build dir with build-make-generator.
Jun 23 2020, 16:52
deadalnix committed rABC980b086d1896: Clean up banning levels (authored by Matt Corallo <git@bluematt.me>).
Clean up banning levels
Jun 23 2020, 16:49
deadalnix closed D6685: Clean up banning levels.
Jun 23 2020, 16:49
deadalnix accepted D6688: [CI] Remove duplicated `cd` to the build dir with build-make-generator.
Jun 23 2020, 16:44
deadalnix committed rABC6523d29f7cf4: [refactor] drop IsInvalid(nDoSOut) (authored by Matt Corallo <git@bluematt.me>).
[refactor] drop IsInvalid(nDoSOut)
Jun 23 2020, 16:43
deadalnix closed D6684: [refactor] drop IsInvalid(nDoSOut).
Jun 23 2020, 16:43
Fabien requested review of D6688: [CI] Remove duplicated `cd` to the build dir with build-make-generator.
Jun 23 2020, 16:43
Fabien committed rABCc4b1781e835f: [CI] Wrap the build_autotools.sh script in a function (authored by Fabien).
[CI] Wrap the build_autotools.sh script in a function
Jun 23 2020, 16:42
Fabien closed D6687: [CI] Wrap the build_autotools.sh script in a function.
Jun 23 2020, 16:42
deadalnix committed rABCc02c6c9966ce: [refactor] Refactor misbehavior ban decisions to MaybePunishNode() (authored by Matt Corallo <git@bluematt.me>).
[refactor] Refactor misbehavior ban decisions to MaybePunishNode()
Jun 23 2020, 16:42
deadalnix closed D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().
Jun 23 2020, 16:42
Fabien closed D6686: [CI] Make the build_autotools.sh script take a list of targets.
Jun 23 2020, 16:41
Fabien committed rABC4f31ce8a67fa: [CI] Make the build_autotools.sh script take a list of targets (authored by Fabien).
[CI] Make the build_autotools.sh script take a list of targets
Jun 23 2020, 16:41
deadalnix updated the diff for D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().

nits

Jun 23 2020, 16:41
Fabien added inline comments to D6686: [CI] Make the build_autotools.sh script take a list of targets.
Jun 23 2020, 16:40
deadalnix accepted D6686: [CI] Make the build_autotools.sh script take a list of targets.
Jun 23 2020, 16:38
deadalnix accepted D6687: [CI] Wrap the build_autotools.sh script in a function.
Jun 23 2020, 16:37
Fabien requested review of D6687: [CI] Wrap the build_autotools.sh script in a function.
Jun 23 2020, 16:22
Fabien added a comment to D6686: [CI] Make the build_autotools.sh script take a list of targets.

@bot build-autotools

Jun 23 2020, 16:17
Fabien requested review of D6686: [CI] Make the build_autotools.sh script take a list of targets.
Jun 23 2020, 16:12
Fabien accepted D6685: Clean up banning levels.
Jun 23 2020, 16:01
Fabien accepted D6684: [refactor] drop IsInvalid(nDoSOut).
Jun 23 2020, 15:48
Fabien accepted D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().
Jun 23 2020, 15:47
teamcity added a comment to D6685: Clean up banning levels.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 23 2020, 15:37
teamcity updated the summary of D6685: Clean up banning levels.
Jun 23 2020, 15:37
deadalnix requested review of D6685: Clean up banning levels.
Jun 23 2020, 15:37
Fabien committed rABC883cffa2de02: [CI] Wrap the build_cmake.sh environment and script path into a function (authored by Fabien).
[CI] Wrap the build_cmake.sh environment and script path into a function
Jun 23 2020, 15:37
Fabien closed D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.
Jun 23 2020, 15:37
teamcity updated the summary of D6684: [refactor] drop IsInvalid(nDoSOut).
Jun 23 2020, 15:28
teamcity added a comment to D6684: [refactor] drop IsInvalid(nDoSOut).

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 23 2020, 15:28
deadalnix requested review of D6684: [refactor] drop IsInvalid(nDoSOut).
Jun 23 2020, 15:28
Fabien committed rABC6884f60c355e: [CI] Add an option to select the compiler to build_cmake.sh (authored by Fabien).
[CI] Add an option to select the compiler to build_cmake.sh
Jun 23 2020, 15:26
Fabien closed D6677: [CI] Add an option to select the compiler to build_cmake.sh.
Jun 23 2020, 15:26
teamcity added a comment to D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 23 2020, 15:16
teamcity updated the summary of D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().
Jun 23 2020, 15:16
deadalnix requested review of D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().
Jun 23 2020, 15:16
deadalnix committed rABCa41c791355ca: Remove double if in tx_verify.cpp (authored by deadalnix).
Remove double if in tx_verify.cpp
Jun 23 2020, 14:45
deadalnix closed D6682: Remove double if in tx_verify.cpp.
Jun 23 2020, 14:45
deadalnix committed rABCe54a99e4eba9: test: Add basic test for BIP34 (authored by MarcoFalke <falke.marco@gmail.com>).
test: Add basic test for BIP34
Jun 23 2020, 14:28
deadalnix closed D6679: test: Add basic test for BIP34.
Jun 23 2020, 14:28
Fabien accepted D6682: Remove double if in tx_verify.cpp.
Jun 23 2020, 14:27
Fabien committed rABC2d11352f940d: [CI] Make build-configurations.sh take the build name as an argument (authored by Fabien).
[CI] Make build-configurations.sh take the build name as an argument
Jun 23 2020, 14:26
Fabien closed D6681: [CI] Make build-configurations.sh take the build name as an argument.
Jun 23 2020, 14:26
Fabien committed rABC7f128bd46521: [CI] Don't print an error if there is no sanitizer log files (authored by Fabien).
[CI] Don't print an error if there is no sanitizer log files
Jun 23 2020, 14:25
Fabien closed D6680: [CI] Don't print an error if there is no sanitizer log files.
Jun 23 2020, 14:25
Fabien updated the diff for D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.

Rebase

Jun 23 2020, 14:24
deadalnix requested review of D6682: Remove double if in tx_verify.cpp.
Jun 23 2020, 14:23
Fabien accepted D6679: test: Add basic test for BIP34.
Jun 23 2020, 14:22
Fabien updated the diff for D6677: [CI] Add an option to select the compiler to build_cmake.sh.

Rebase

Jun 23 2020, 14:15
Fabien committed rABCfdaed1dcc29d: [CI] Add a build plan to run clang-tidy on the changed files (authored by Fabien).
[CI] Add a build plan to run clang-tidy on the changed files
Jun 23 2020, 14:13
Fabien closed D6627: [CI] Add a build plan to run clang-tidy on the changed files.
Jun 23 2020, 14:13
deadalnix requested changes to D6597: Merge #15059: test: Add basic test for BIP34.

Unfortunately, D6603 appears to be based on erroneous assumption about what the problem is. This turned out to be a blocker for some stuff I'm working on so I backported it in D6679 .

Jun 23 2020, 14:12
Fabien added a reverting change for D6639: [CI] Install the latest wine version from the winehq repository: rABC80101a81e8ae: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 14:11
Fabien committed rABC80101a81e8ae: Revert "[CI] Install the latest wine version from the winehq repository" (authored by Fabien).
Revert "[CI] Install the latest wine version from the winehq repository"
Jun 23 2020, 14:11
Fabien added a reverting change for rABCb25c0bf30ae0: [CI] Install the latest wine version from the winehq repository: rABC80101a81e8ae: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 14:11
Fabien closed D6676: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 14:11
deadalnix accepted D6677: [CI] Add an option to select the compiler to build_cmake.sh.
Jun 23 2020, 14:10
deadalnix accepted D6676: Revert "[CI] Install the latest wine version from the winehq repository".
Jun 23 2020, 14:10
deadalnix accepted D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.
Jun 23 2020, 14:09
deadalnix accepted D6681: [CI] Make build-configurations.sh take the build name as an argument.
Jun 23 2020, 14:09
deadalnix accepted D6680: [CI] Don't print an error if there is no sanitizer log files.
Jun 23 2020, 14:08
Fabien requested review of D6681: [CI] Make build-configurations.sh take the build name as an argument.
Jun 23 2020, 13:58
Fabien requested review of D6680: [CI] Don't print an error if there is no sanitizer log files.
Jun 23 2020, 13:42
teamcity added a comment to D6679: test: Add basic test for BIP34.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 23 2020, 13:40
teamcity updated the summary of D6679: test: Add basic test for BIP34.
Jun 23 2020, 13:40
deadalnix requested review of D6679: test: Add basic test for BIP34.
Jun 23 2020, 13:39
Fabien requested review of D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.
Jun 23 2020, 13:18
Fabien added a comment to D6627: [CI] Add a build plan to run clang-tidy on the changed files.

I'm working on cleaning the whole thing

Jun 23 2020, 11:49
deadalnix accepted D6627: [CI] Add a build plan to run clang-tidy on the changed files.

There is some trash in the log.

Jun 23 2020, 11:45
deadalnix committed rABC9421c8048267: test: add invalid tx templates for use in functional tests (authored by James O'Beirne <james.obeirne@gmail.com>).
test: add invalid tx templates for use in functional tests
Jun 23 2020, 11:13
deadalnix closed D6674: test: add invalid tx templates for use in functional tests.
Jun 23 2020, 11:13
deadalnix committed rABCb4c7688e45b0: [refactor] rename stateDummy -> orphan_state (authored by Matt Corallo <git@bluematt.me>).
[refactor] rename stateDummy -> orphan_state
Jun 23 2020, 10:27
deadalnix closed D6673: [refactor] rename stateDummy -> orphan_state.
Jun 23 2020, 10:27
Fabien requested review of D6677: [CI] Add an option to select the compiler to build_cmake.sh.
Jun 23 2020, 09:39
Fabien added a comment to D6627: [CI] Add a build plan to run clang-tidy on the changed files.

@deadalnix Here is an example of the output in case of missing braces

Jun 23 2020, 09:34