Page MenuHomePhabricator
Feed All Stories

Jun 9 2020

nakihito committed rABCe269cb2f708c: Merge #14054: p2p: Disable BIP 61 by default (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14054: p2p: Disable BIP 61 by default
Jun 9 2020, 18:07
nakihito closed D6455: Merge #14054: p2p: Disable BIP 61 by default.
Jun 9 2020, 18:07
majcosta committed rABCb160ed70b766: [backport#14060] ZMQ: add options to configure outbound message high water mark… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14060] ZMQ: add options to configure outbound message high water mark…
Jun 9 2020, 17:59
majcosta closed D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.
Jun 9 2020, 17:59
majcosta committed rABCf3e4c24c987b: [backport#13756] bitcoind: update -avoidpartialspends description to account… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] bitcoind: update -avoidpartialspends description to account…
Jun 9 2020, 17:58
majcosta closed D6469: [backport#13756] bitcoind: update -avoidpartialspends description to account for auto-enable for avoid_reuse wallets.
Jun 9 2020, 17:58
majcosta committed rABC5e090611603a: [backport#13756] doc: release notes for avoid_reuse (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] doc: release notes for avoid_reuse
Jun 9 2020, 17:58
majcosta closed D6468: [backport#13756] doc: release notes for avoid_reuse.
Jun 9 2020, 17:58
majcosta committed rABC449e061db0c7: [backport#13756] wallet: enable avoid_partial_spends by default if avoid_reuse… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] wallet: enable avoid_partial_spends by default if avoid_reuse…
Jun 9 2020, 17:58
majcosta closed D6467: [backport#13756] wallet: enable avoid_partial_spends by default if avoid_reuse is set.
Jun 9 2020, 17:57
majcosta committed rABCe471189790d9: [backport#13756] test: add test for avoidreuse feature (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] test: add test for avoidreuse feature
Jun 9 2020, 17:57
majcosta closed D6466: [backport#13756] test: add test for avoidreuse feature.
Jun 9 2020, 17:57
majcosta committed rABCfc648c84ba6f: [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands
Jun 9 2020, 17:56
majcosta closed D6465: [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands.
Jun 9 2020, 17:56
majcosta committed rABC3f601d7850a5: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS
Jun 9 2020, 17:56
majcosta closed D6464: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS.
Jun 9 2020, 17:56
majcosta committed rABC162108998db7: [backport#13756] wallet: enable avoid_reuse feature (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[backport#13756] wallet: enable avoid_reuse feature
Jun 9 2020, 17:55
majcosta closed D6463: [backport#13756] wallet: enable avoid_reuse feature.
Jun 9 2020, 17:55
nakihito planned changes to D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 17:46
Fabien accepted D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.
Jun 9 2020, 17:45
nakihito committed rABC7de90a0236ab: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check
Jun 9 2020, 17:45
nakihito closed D6454: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check.
Jun 9 2020, 17:45
Fabien accepted D6468: [backport#13756] doc: release notes for avoid_reuse.
Jun 9 2020, 17:43
Fabien accepted D6465: [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands.
Jun 9 2020, 17:42
Fabien accepted D6463: [backport#13756] wallet: enable avoid_reuse feature.
Jun 9 2020, 17:39
nakihito updated the diff for D6460: Move GenerateSelectSet logic to private method..

Addressed nit.

Jun 9 2020, 17:12
teamcity updated the summary of D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 17:09
teamcity added a comment to D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 17:09
nakihito requested review of D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 17:09
majcosta committed rABC0eddb715c412: [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances
Jun 9 2020, 16:37
majcosta closed D6447: [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances.
Jun 9 2020, 16:37
majcosta committed rABC1b1b61fd39cf: [backport#15930] rpc: Add getbalances RPC (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15930] rpc: Add getbalances RPC
Jun 9 2020, 16:37
majcosta closed D6446: [backport#15930] rpc: Add getbalances RPC.
Jun 9 2020, 16:37
majcosta committed rABC4174deaa1bb3: [backport#15930] rpcwallet: Make helper methods const on CWallet (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15930] rpcwallet: Make helper methods const on CWallet
Jun 9 2020, 16:37
majcosta closed D6445: [backport#15930] rpcwallet: Make helper methods const on CWallet.
Jun 9 2020, 16:36
majcosta committed rABCbb39798e5b9f: [backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc
Jun 9 2020, 16:36
majcosta closed D6444: [backport#15930] wallet: Use IsValidNumArgs in getwalletinfo rpc.
Jun 9 2020, 16:36
majcosta closed D6443: [backport#15758] test: Add reorg test to wallet_balance.
Jun 9 2020, 16:27
majcosta committed rABC906a4e6c153e: [backport#15758] test: Add reorg test to wallet_balance (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15758] test: Add reorg test to wallet_balance
Jun 9 2020, 16:27
majcosta committed rABC2982610b6993: [backport#15758] test: Check that wallet txs not in the mempool are untrusted (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15758] test: Check that wallet txs not in the mempool are untrusted
Jun 9 2020, 16:27
majcosta closed D6442: [backport#15758] test: Check that wallet txs not in the mempool are untrusted.
Jun 9 2020, 16:27
majcosta committed rABC7ac7090ca0f5: [backport#15758] test: Add getunconfirmedbalance test with conflicts (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15758] test: Add getunconfirmedbalance test with conflicts
Jun 9 2020, 16:27
majcosta closed D6441: [backport#15758] test: Add getunconfirmedbalance test with conflicts.
Jun 9 2020, 16:26
majcosta committed rABC6d30026d43f8: [backport#15758] test: Add wallet_balance test for watchonly (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15758] test: Add wallet_balance test for watchonly
Jun 9 2020, 16:25
majcosta closed D6440: [backport#15758] test: Add wallet_balance test for watchonly.
Jun 9 2020, 16:25
deadalnix accepted D6440: [backport#15758] test: Add wallet_balance test for watchonly.
Jun 9 2020, 16:22
majcosta updated the diff for D6468: [backport#13756] doc: release notes for avoid_reuse.

fixed name and version -avoidpartialspends was introduced

Jun 9 2020, 16:14
majcosta updated the diff for D6465: [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands.

relayouted

Jun 9 2020, 16:06
majcosta updated the diff for D6463: [backport#13756] wallet: enable avoid_reuse feature.

addressed comments and nits

Jun 9 2020, 15:04
majcosta updated the diff for D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.

undid RPCHelpMan removal

Jun 9 2020, 14:46
Fabien added a comment to D5852: Fix the abc_sigops_mempool_mining test.

Test comment with markup and reference @Fabien

Jun 9 2020, 12:30
qeqylybesa added a comment to rABC1232b0292cc3: util: Make thread names shorter.
Jun 9 2020, 09:55
Fabien added a comment to D5852: Fix the abc_sigops_mempool_mining test.

This is a test comment

Jun 9 2020, 08:47
teamcity added a comment to D5999: Add a test for the mempool dynamic memory usage.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Jun 9 2020, 08:15
Fabien requested changes to D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.
Jun 9 2020, 07:52
Fabien accepted D6469: [backport#13756] bitcoind: update -avoidpartialspends description to account for auto-enable for avoid_reuse wallets.
Jun 9 2020, 07:41
Fabien requested changes to D6468: [backport#13756] doc: release notes for avoid_reuse.
Jun 9 2020, 07:41
Fabien accepted D6467: [backport#13756] wallet: enable avoid_partial_spends by default if avoid_reuse is set.
Jun 9 2020, 07:39
Fabien accepted D6466: [backport#13756] test: add test for avoidreuse feature.
Jun 9 2020, 07:37
Fabien requested changes to D6465: [backport#13756] Wallet/rpc: add 'avoid_reuse' option to RPC commands.
Jun 9 2020, 07:21
Fabien accepted D6464: [backport#13756] wallet/rpc: add setwalletflag RPC and MUTABLE_WALLET_FLAGS.
Jun 9 2020, 07:08
Fabien requested changes to D6463: [backport#13756] wallet: enable avoid_reuse feature.
Jun 9 2020, 07:00
Fabien accepted D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.
Jun 9 2020, 06:51
Fabien accepted D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 06:50
Fabien accepted D6474: Merge #15194: Add comment describing fDisconnect behavior.
Jun 9 2020, 06:44
Fabien updated the summary of D6474: Merge #15194: Add comment describing fDisconnect behavior.
Jun 9 2020, 06:44
Fabien accepted D6460: Move GenerateSelectSet logic to private method..
Jun 9 2020, 06:43
Fabien accepted D6457: Merge #14436: doc: add comment explaining recentRejects-DoS behavior.
Jun 9 2020, 06:32
Fabien accepted D6454: Merge #13096: [Policy] Fix MAX_STANDARD_TX_WEIGHT check.
Jun 9 2020, 06:27
deadalnix accepted D6455: Merge #14054: p2p: Disable BIP 61 by default.
Jun 9 2020, 02:01
teamcity updated the summary of D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.
Jun 9 2020, 00:42
teamcity added a comment to D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 00:42
nakihito requested review of D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.
Jun 9 2020, 00:42
nakihito requested review of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:21
nakihito updated the summary of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:21
teamcity added a comment to D6475: Merge #15254: Trivial: fixup a few doxygen comments.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 00:19
teamcity updated the summary of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:19
nakihito planned changes to D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:18
nakihito requested review of D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 00:18

Jun 8 2020

majcosta accepted D6461: Move SocketEvents logic to private method..
Jun 8 2020, 23:55
nakihito requested review of D6474: Merge #15194: Add comment describing fDisconnect behavior.
Jun 8 2020, 23:53
majcosta accepted D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 23:53
majcosta requested changes to D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 23:46
majcosta accepted D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.
Jun 8 2020, 23:37
teamcity added a comment to D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 8 2020, 23:16
teamcity updated the summary of D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.
Jun 8 2020, 23:16
majcosta requested review of D6473: [backport#14060] ZMQ: add options to configure outbound message high water mark, aka SNDHWM.
Jun 8 2020, 23:16
teamcity added a comment to D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 8 2020, 23:02
teamcity updated the summary of D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.
Jun 8 2020, 23:02
nakihito requested review of D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.
Jun 8 2020, 23:02
nakihito requested review of D6461: Move SocketEvents logic to private method..
Jun 8 2020, 22:16
nakihito requested review of D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 22:16
nakihito requested review of D6460: Move GenerateSelectSet logic to private method..
Jun 8 2020, 22:16
nakihito requested review of D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:16
nakihito updated the summary of D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:15
nakihito updated the summary of D6470: Implement poll() on systems which support it properly..
Jun 8 2020, 22:15
nakihito updated the summary of D6461: Move SocketEvents logic to private method..
Jun 8 2020, 22:15
nakihito updated the summary of D6460: Move GenerateSelectSet logic to private method..
Jun 8 2020, 22:14
teamcity updated the summary of D6471: Increase maxconnections limit when using poll..
Jun 8 2020, 22:13
teamcity added a comment to D6471: Increase maxconnections limit when using poll..

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 8 2020, 22:13