Page MenuHomePhabricator
Feed All Stories

Aug 4 2020

deadalnix requested changes to D7129: Add layout to RPC doc template.

The description doesn't make it clear why this is needed. In any case, this sounds like a violation of SRP, as this is baking jekyll related stuff in there.

Aug 4 2020, 22:16
deadalnix accepted D7127: Make the doc directory a collection.
Aug 4 2020, 22:13
jasonbcox accepted D7126: [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag.
Aug 4 2020, 21:33
jasonbcox accepted D7125: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages.
Aug 4 2020, 21:30
jasonbcox accepted D7124: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages.
Aug 4 2020, 21:27
jasonbcox accepted D7128: [backport#17300] LegacyScriptPubKeyMan code cleanups.
Aug 4 2020, 21:22
jasonbcox added inline comments to D7131: Add top-level documentation index for serving docs by version.
Aug 4 2020, 20:08
jasonbcox requested review of D7131: Add top-level documentation index for serving docs by version.
Aug 4 2020, 20:06
jasonbcox abandoned D6596: [RPC docs] Remove unused index files.
Aug 4 2020, 19:22
jasonbcox abandoned D7087: Add index page for /en/doc/<version>/rpc.

See D7130 and associated stack.

Aug 4 2020, 19:22
jasonbcox committed rABC7778ab3bbd47: Remove language sub-route from RPC doc permalinks (authored by jasonbcox).
Remove language sub-route from RPC doc permalinks
Aug 4 2020, 19:21
jasonbcox closed D7065: Remove language sub-route from RPC doc permalinks.
Aug 4 2020, 19:21
jasonbcox requested review of D7130: Add RPC commands indices, by version.
Aug 4 2020, 19:18
jasonbcox requested review of D7129: Add layout to RPC doc template.
Aug 4 2020, 19:05
Fabien accepted D7065: Remove language sub-route from RPC doc permalinks.

Talked offline, it is clear that setting the link is not the responsibility of this script and should be done on the website side.
Greening it for the sake of helping the tests in short term since it's not a regression per se, but the permalink should be removed from the generator at some point or at least rebuilt on the website side.

Aug 4 2020, 19:01
Fabien accepted D6994: [backport#15655] Resolve the checkpoints <-> validation circular dependency.
Aug 4 2020, 19:01
teamcity added a comment to D7128: [backport#17300] LegacyScriptPubKeyMan code cleanups.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 17:31
teamcity updated the summary of D7128: [backport#17300] LegacyScriptPubKeyMan code cleanups.
Aug 4 2020, 17:31
majcosta requested review of D7128: [backport#17300] LegacyScriptPubKeyMan code cleanups.
Aug 4 2020, 17:31
jasonbcox requested review of D7127: Make the doc directory a collection.
Aug 4 2020, 16:06
teamcity added a comment to D7126: [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 15:43
teamcity updated the summary of D7126: [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag.
Aug 4 2020, 15:43
majcosta requested review of D7126: [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag.
Aug 4 2020, 15:43
teamcity added a comment to D7125: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 15:43
teamcity updated the summary of D7125: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages.
Aug 4 2020, 15:43
majcosta requested review of D7125: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages.
Aug 4 2020, 15:43
teamcity added a comment to D7124: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 15:39
teamcity updated the summary of D7124: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages.
Aug 4 2020, 15:39
majcosta requested review of D7124: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages.
Aug 4 2020, 15:39
majcosta updated the diff for D6994: [backport#15655] Resolve the checkpoints <-> validation circular dependency.

addressed comments

Aug 4 2020, 14:30
majcosta updated the test plan for D6994: [backport#15655] Resolve the checkpoints <-> validation circular dependency.
Aug 4 2020, 14:23
majcosta committed rABC8e243c9eb5fc: [backport#15457] Check std::system for -[alert|block|wallet]notify (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#15457] Check std::system for -[alert|block|wallet]notify
Aug 4 2020, 12:53
majcosta closed D7031: [backport#15457] Check std::system for -[alert|block|wallet]notify.
Aug 4 2020, 12:53
teamcity added a comment to D7123: [backport#16383 3/3] tests: functional watch-only wallet tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 12:38
teamcity updated the summary of D7123: [backport#16383 3/3] tests: functional watch-only wallet tests.
Aug 4 2020, 12:38
majcosta requested review of D7123: [backport#16383 3/3] tests: functional watch-only wallet tests.
Aug 4 2020, 12:38
teamcity added a comment to D7122: [backport#16383 2/3] rpcwallet: document include_watchonly default for watchonly wallets.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 12:38
teamcity updated the summary of D7122: [backport#16383 2/3] rpcwallet: document include_watchonly default for watchonly wallets.
Aug 4 2020, 12:38
majcosta requested review of D7122: [backport#16383 2/3] rpcwallet: document include_watchonly default for watchonly wallets.
Aug 4 2020, 12:37
teamcity added a comment to D7121: [backport#16383 1/3] rpcwallet: default include_watchonly to true for watchonly wallets.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 4 2020, 12:36
teamcity updated the summary of D7121: [backport#16383 1/3] rpcwallet: default include_watchonly to true for watchonly wallets.
Aug 4 2020, 12:36
majcosta requested review of D7121: [backport#16383 1/3] rpcwallet: default include_watchonly to true for watchonly wallets.
Aug 4 2020, 12:36

Aug 3 2020

majcosta updated the summary of D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.
Aug 3 2020, 21:35
majcosta updated the diff for D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.

corrected lint-circular-dependencies.sh script

Aug 3 2020, 21:15
teamcity added a comment to D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 3 2020, 21:13
teamcity updated the summary of D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.
Aug 3 2020, 21:13
majcosta requested review of D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.
Aug 3 2020, 21:13
deadalnix accepted D7031: [backport#15457] Check std::system for -[alert|block|wallet]notify.
Aug 3 2020, 20:09
Fabien committed rABC956b1e18fbfa: [CI] Increase build-coverage timeout (authored by Fabien).
[CI] Increase build-coverage timeout
Aug 3 2020, 18:59
Fabien closed D7116: [CI] Increase build-coverage timeout.
Aug 3 2020, 18:59
majcosta updated the summary of D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
Aug 3 2020, 18:49
majcosta updated the summary of D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.
Aug 3 2020, 18:48
majcosta updated the diff for D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.

rebase

Aug 3 2020, 18:46
majcosta updated the diff for D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.

rebase

Aug 3 2020, 18:46
teamcity added a comment to D7118: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 3 2020, 18:36
teamcity updated the summary of D7118: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing.
Aug 3 2020, 18:36
majcosta requested review of D7118: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing.
Aug 3 2020, 18:36
majcosta updated the diff for D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.

rebase on top of all the finished deps

Aug 3 2020, 17:27
jasonbcox accepted D7116: [CI] Increase build-coverage timeout.
Aug 3 2020, 17:20
majcosta accepted D7116: [CI] Increase build-coverage timeout.
Aug 3 2020, 17:19
Fabien requested review of D7116: [CI] Increase build-coverage timeout.
Aug 3 2020, 17:00
majcosta updated the diff for D7031: [backport#15457] Check std::system for -[alert|block|wallet]notify.

moved build system changes to config cmakelists.txt file and changed it to use the bitcoin-config.h generated header

Aug 3 2020, 16:15
majcosta committed rABC385d24d8dce7: [backport#17070] wallet: Avoid showing GUI popups on RPC errors (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17070] wallet: Avoid showing GUI popups on RPC errors
Aug 3 2020, 15:16
majcosta closed D7111: [backport#17070] wallet: Avoid showing GUI popups on RPC errors.
Aug 3 2020, 15:16
deadalnix requested changes to D7031: [backport#15457] Check std::system for -[alert|block|wallet]notify.
Aug 3 2020, 15:13
majcosta committed rABCa87a2f00aec6: [backport#15450 5/5] Add Create Wallet menu action (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#15450 5/5] Add Create Wallet menu action
Aug 3 2020, 15:05
majcosta closed D7106: [backport#15450 5/5] Add Create Wallet menu action.
Aug 3 2020, 15:05
majcosta committed rABCd41a0be9c01e: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#15450 4/5] Expose wallet creation to the GUI via WalletController
Aug 3 2020, 15:05
majcosta closed D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.
Aug 3 2020, 15:05
majcosta committed rABCb7a031448919: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI
Aug 3 2020, 15:05
majcosta closed D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.
Aug 3 2020, 15:05
majcosta committed rABC1d0e49b8553f: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#15450 2/5] Optionally allow AskPassphraseDialog to output the…
Aug 3 2020, 15:04
majcosta closed D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.
Aug 3 2020, 15:04
majcosta committed rABCe677cd743796: [backport#15450 1/5] gui: Refactor OpenWalletActivity (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[backport#15450 1/5] gui: Refactor OpenWalletActivity
Aug 3 2020, 15:04
majcosta closed D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Aug 3 2020, 15:04
majcosta added inline comments to D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 3 2020, 14:51
majcosta updated the diff for D7031: [backport#15457] Check std::system for -[alert|block|wallet]notify.

add missing cmake build changes

Aug 3 2020, 14:38
deadalnix added inline comments to D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 3 2020, 14:12
deadalnix accepted D7102: [backport#15450 1/5] gui: Refactor OpenWalletActivity.
Aug 3 2020, 14:10
majcosta added inline comments to D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 3 2020, 14:04
Fabien accepted D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.
Aug 3 2020, 13:30
majcosta updated the diff for D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.

redid the layout on several lines

Aug 3 2020, 13:28
howoldami added a comment to rABC1232b0292cc3: util: Make thread names shorter.
Aug 3 2020, 11:46
majcosta updated the summary of D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.
Aug 3 2020, 11:02
majcosta updated the diff for D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.

rebase

Aug 3 2020, 11:01
howoldami added a comment to rABC1232b0292cc3: util: Make thread names shorter.
Aug 3 2020, 10:57
howoldami edited a custom field on howoldami.
Aug 3 2020, 10:48
Fabien committed rABCad8837b6f943: [CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI (authored by Fabien).
[CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI
Aug 3 2020, 09:51
Fabien closed D7070: [CI] Make the bench use the ENABLE_JUNIT_REPORT option and use it on CI.
Aug 3 2020, 09:51
Fabien added inline comments to D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 3 2020, 09:30
Fabien accepted D7113: [backport#17154 2/3][wallet] Remove return value from CommitTransaction().
Aug 3 2020, 09:21
Fabien accepted D7112: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction().
Aug 3 2020, 09:17
Fabien accepted D7111: [backport#17070] wallet: Avoid showing GUI popups on RPC errors.
Aug 3 2020, 09:14
Fabien accepted D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.

Just seen the test plan from D7106

Aug 3 2020, 08:57
Fabien accepted D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.

Just seen the test plan from D7106

Aug 3 2020, 08:56
Fabien accepted D7106: [backport#15450 5/5] Add Create Wallet menu action.
Aug 3 2020, 08:56
Fabien requested changes to D7105: [backport#15450 4/5] Expose wallet creation to the GUI via WalletController.

See D7104, the backport seems OK but there is no evidence this has been tested

Aug 3 2020, 08:54
Fabien requested changes to D7104: [backport#15450 3/5] Add CreateWalletDialog to create wallets from the GUI.

Please make sure you tested the new dialog as it doesn't appear in your test plan.

Aug 3 2020, 08:42
Fabien requested changes to D7103: [backport#15450 2/5] Optionally allow AskPassphraseDialog to output the passphrase.
Aug 3 2020, 08:31
Fabien accepted D6981: Implement Grasberg DAA.

A few typos found by @Mengerian are still here.

Aug 3 2020, 07:55