I guess one frustrating thing with assert is that it doesn't throw an exception (just kills program without any information), if it happens that these fail for some reason.

note: will probably rebase this onto D3262, supposing people are in for that one.

IBD successful on both nets.

recomment json-gen line

In D3253#76958, @deadalnix wrote:

There are still a lot of leftovers, like the flags that are passed down to functions that do not need them, the caching layer depending on flags, or the exception tot he banning code for schnorr txns. Not all need to be done in this patch, but this need some battle plan or we'll have a lot of pieces laying around.

script_tests nit
remove now-unused "hasStricts" variable from two tests

fix a few nits

works as promised

Note: other usage site was already removed in D1539.

Thanks @nakihito !

rebased onto D3230

rebase to check build

@schancel this fixes the functional test failure you had in D2788. Would still be worth removing the "%d of last 100 blocks have unexpected version" debug.log noise as well, IMO.

OK should be good to go! Will you backport https://github.com/bitcoin/bitcoin/pull/12198 as well, or shall I?

Oh neat! Another usage of "A fast alternative to the modulo reduction"
https://lemire.me/blog/2016/06/27/a-fast-alternative-to-the-modulo-reduction/

Oh nice, I always wondered why these were out of alphabetical order.

@deadalnix I recall you mentioned a slight concern about this backport ... or was it just another commit in the same PR?

Confirm hash & chainwork. Block mediantime is:

"mediantime": 1557922620,

while its parent and parent-parent blocks have 1557922278 and 1557921111 respectively (compared to upgrade MTP 1557921600). This makes 1303884 the activation block (the last under old rules) and 1303885 the first post-activation block (i.e., the first under new rules).

Looks good, except just tweak the version number there (& this would make sense to land in same version as when we drop getinfo RPC).

Looks good, indeed this appears to invert the flag without changing behaviour. However, just to be sure I'd quickly follow it up with a Diff that makes it an ordinary Standard flag.

rebase before land

I think given the current backporting efforts we should put this on back burner for now. I'll put 'request changes' just to get it out of review queue.

just one mistake I missed on first pass

remove txindex.h dependency on chain.h

Since we only have one type, I'd strongly recommend dropping the address_type support from RPC, and just set output_type = OutputType::LEGACY.

man this is confusing stuff...

ok build fail looks unrelated; tried on my end too and it's good.