Page MenuHomePhabricator
Feed Advanced Search

May 22 2020

nakihito planned changes to D6215: Test importing descriptors with key origin information and add release notes.
May 22 2020, 19:51
nakihito accepted D6216: [backport#15644] Simplify orphan processing in preparation for interruptibility.
May 22 2020, 19:48
nakihito updated the diff for D6228: Store key origin info in key metadata.

Fixed some comment formatting.

May 22 2020, 19:42
nakihito requested review of D6230: Import KeyOriginData when importing descriptors.
May 22 2020, 19:39
nakihito requested review of D6229: Implement a function to add KeyOriginInfo to a wallet.
May 22 2020, 19:37
nakihito requested review of D6228: Store key origin info in key metadata.
May 22 2020, 19:34
nakihito requested review of D6227: Add a method to CWallet to write just CKeyMetadata.
May 22 2020, 19:25
nakihito planned changes to D6215: Test importing descriptors with key origin information and add release notes.
May 22 2020, 19:02
nakihito requested review of D6226: Merge #14129: Trivial: update clang thread-safety docs url.
May 22 2020, 18:22
nakihito updated the diff for D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.

Fixed nits.

May 22 2020, 17:39
nakihito updated the diff for D6004: Refactor keymetadata writing to a separate method.

Fixed overwrite.

May 22 2020, 17:38
nakihito accepted D6217: [backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx.
May 22 2020, 00:41
nakihito requested changes to D6216: [backport#15644] Simplify orphan processing in preparation for interruptibility.
May 22 2020, 00:31

May 21 2020

nakihito abandoned D6130: Merge #14565: Overhaul importmulti logic and Make getaddressinfo return solvability.
May 21 2020, 23:21
nakihito requested review of D5933: Remove hdmasterkeyid.
May 21 2020, 22:58
nakihito requested review of D6215: Test importing descriptors with key origin information and add release notes.
May 21 2020, 22:58
nakihito requested review of D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
May 21 2020, 22:54
nakihito requested review of D6004: Refactor keymetadata writing to a separate method.
May 21 2020, 22:54
nakihito accepted D6213: Fix code alignement in rpc/misc.cpp.
May 21 2020, 22:36
nakihito planned changes to D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
May 21 2020, 19:48
nakihito planned changes to D6004: Refactor keymetadata writing to a separate method.
May 21 2020, 19:48
nakihito planned changes to D5933: Remove hdmasterkeyid.
May 21 2020, 19:47
nakihito updated the diff for D5933: Remove hdmasterkeyid.

Rebased and added release notes.

May 21 2020, 19:37
nakihito updated the summary of D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
May 21 2020, 19:26
nakihito requested review of D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
May 21 2020, 19:26
nakihito updated the diff for D6004: Refactor keymetadata writing to a separate method.

Rebase.

May 21 2020, 19:02
nakihito accepted D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
May 21 2020, 18:21
nakihito committed rSTAGING99785d07bdf8: Replace message type literals with protocol.h constants (authored by nakihito).
Replace message type literals with protocol.h constants
May 21 2020, 00:35
nakihito committed rABC99785d07bdf8: Replace message type literals with protocol.h constants (authored by nakihito).
Replace message type literals with protocol.h constants
May 21 2020, 00:32
nakihito closed D6182: Replace message type literals with protocol.h constants.
May 21 2020, 00:32
nakihito updated the diff for D5987: Start using Logger for seeder logging.

Added release notes and rebased.

May 21 2020, 00:29

May 20 2020

nakihito committed rSTAGING2cd65b6968aa: Recategorize seeder connections as not manual (authored by nakihito).
Recategorize seeder connections as not manual
May 20 2020, 22:55
nakihito committed rABC2cd65b6968aa: Recategorize seeder connections as not manual (authored by nakihito).
Recategorize seeder connections as not manual
May 20 2020, 22:52
nakihito closed D6176: Recategorize seeder connections as not manual.
May 20 2020, 22:51
nakihito requested review of D6182: Replace message type literals with protocol.h constants.
May 20 2020, 22:36
nakihito updated the diff for D6127: Add options to seeder to determine initial seed list at start up.

Refined help text.

May 20 2020, 22:19
nakihito planned changes to D5987: Start using Logger for seeder logging.
May 20 2020, 20:03
nakihito requested review of D6176: Recategorize seeder connections as not manual.
May 20 2020, 19:52
nakihito updated the diff for D5380: [seeder] Require good seeds to have latest checkpoint.

MAX_HEADERS_PER_MESSAGE -> MAX_HEADERS_RESULTS. Restructured messaging sequence to request headers before addrs.

May 20 2020, 18:22
nakihito retitled D5380: [seeder] Require good seeds to have latest checkpoint from Seeder requires good seeds to have block after most recent checkpoint in its chain to Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
May 20 2020, 18:19
nakihito updated the diff for D5956: Add -datadir option to allow specification of seeder's data directory.

Adjusted help text.

May 20 2020, 18:14
nakihito updated the diff for D6127: Add options to seeder to determine initial seed list at start up.

Adjusted help text.

May 20 2020, 18:05
nakihito updated the test plan for D5956: Add -datadir option to allow specification of seeder's data directory.
May 20 2020, 00:46
nakihito planned changes to D5956: Add -datadir option to allow specification of seeder's data directory.
May 20 2020, 00:40
nakihito updated the diff for D5956: Add -datadir option to allow specification of seeder's data directory.

Removed added files/functions. Option uses pre-existing -datadir related code.

May 20 2020, 00:40

May 19 2020

nakihito updated the diff for D6127: Add options to seeder to determine initial seed list at start up.

Added release notes.

May 19 2020, 20:21
nakihito requested review of D6127: Add options to seeder to determine initial seed list at start up.
May 19 2020, 20:14
nakihito retitled D6127: Add options to seeder to determine initial seed list at start up from Add a -debugseedlist option to seeder to limit initial seed list to Add options to seeder to determine initial seed list at start up.
May 19 2020, 20:14
nakihito planned changes to D6127: Add options to seeder to determine initial seed list at start up.
May 19 2020, 19:50
nakihito updated the diff for D6127: Add options to seeder to determine initial seed list at start up.

Increased the usability of new option.

May 19 2020, 19:50
nakihito abandoned D6120: Have Seeder's ProcessMessage return fall through.
May 19 2020, 19:47
nakihito planned changes to D6127: Add options to seeder to determine initial seed list at start up.
May 19 2020, 06:41

May 18 2020

nakihito requested review of D6130: Merge #14565: Overhaul importmulti logic and Make getaddressinfo return solvability.
May 18 2020, 23:22
nakihito requested review of D6127: Add options to seeder to determine initial seed list at start up.
May 18 2020, 22:47
nakihito requested review of D6120: Have Seeder's ProcessMessage return fall through.
May 18 2020, 18:13

May 16 2020

nakihito accepted D6099: Fix typo related to ZMQ in build docs.
May 16 2020, 00:03

May 15 2020

nakihito accepted D6079: [backport#15508] Refactor analyzepsbt for use outside RPC code.
May 15 2020, 20:22
nakihito accepted D6084: [backport#15638] [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp.
May 15 2020, 18:33
nakihito committed rSTAGING353446e5400b: [tests] add test_importmulti method to wallet_import.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add test_importmulti method to wallet_import.py
May 15 2020, 17:50
nakihito committed rSTAGINGe87bc138f44c: [tests] add test_address method to wallet_import.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add test_address method to wallet_import.py
May 15 2020, 17:50
nakihito committed rABCe87bc138f44c: [tests] add test_address method to wallet_import.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add test_address method to wallet_import.py
May 15 2020, 17:48
nakihito closed D6088: [tests] add test_address method to wallet_import.py.
May 15 2020, 17:47
nakihito committed rABC353446e5400b: [tests] add test_importmulti method to wallet_import.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add test_importmulti method to wallet_import.py
May 15 2020, 17:46
nakihito closed D6087: [tests] add test_importmulti method to wallet_import.py.
May 15 2020, 17:46
nakihito committed rSTAGINGbd95bed5a028: [tests] add get_multisig function to wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add get_multisig function to wallet_importmulti.py
May 15 2020, 17:45
nakihito committed rSTAGING689070f97e36: [tests] add get_key function to wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add get_key function to wallet_importmulti.py
May 15 2020, 17:45
nakihito committed rABCbd95bed5a028: [tests] add get_multisig function to wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add get_multisig function to wallet_importmulti.py
May 15 2020, 17:43
nakihito closed D6086: [tests] add get_multisig function to wallet_importmulti.py.
May 15 2020, 17:43
nakihito committed rABC689070f97e36: [tests] add get_key function to wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>).
[tests] add get_key function to wallet_importmulti.py
May 15 2020, 17:41
nakihito closed D6083: [tests] add get_key function to wallet_importmulti.py.
May 15 2020, 17:40
nakihito committed rSTAGING41707be22c38: Partial Merge #14454: ProcessImport() cleanup (excluding witness) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Partial Merge #14454: ProcessImport() cleanup (excluding witness)
May 15 2020, 17:40
nakihito committed rABC41707be22c38: Partial Merge #14454: ProcessImport() cleanup (excluding witness) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Partial Merge #14454: ProcessImport() cleanup (excluding witness)
May 15 2020, 17:35
nakihito closed D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 15 2020, 17:35
nakihito requested changes to D6084: [backport#15638] [build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp.

Test plan should include autotools build.

May 15 2020, 14:26
nakihito requested changes to D6079: [backport#15508] Refactor analyzepsbt for use outside RPC code.
May 15 2020, 13:59
nakihito accepted D6091: Update chainparams to a post-upgrade block.
May 15 2020, 13:50
nakihito accepted D6090: Fix incorrect mocktime set in miner fund test.
May 15 2020, 13:23
nakihito requested review of D6088: [tests] add test_address method to wallet_import.py.
May 15 2020, 00:56
nakihito requested review of D6087: [tests] add test_importmulti method to wallet_import.py.
May 15 2020, 00:55
nakihito requested review of D6083: [tests] add get_key function to wallet_importmulti.py.
May 15 2020, 00:54
nakihito requested review of D6086: [tests] add get_multisig function to wallet_importmulti.py.
May 15 2020, 00:29
nakihito committed rSTAGING73ce44f302f2: [tests] tidy up imports in wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>).
[tests] tidy up imports in wallet_importmulti.py
May 15 2020, 00:20
nakihito committed rABC73ce44f302f2: [tests] tidy up imports in wallet_importmulti.py (authored by John Newbery <john@johnnewbery.com>).
[tests] tidy up imports in wallet_importmulti.py
May 15 2020, 00:10
nakihito closed D6081: [tests] tidy up imports in wallet_importmulti.py.
May 15 2020, 00:10

May 14 2020

nakihito accepted D6080: [backport#15508] Add documentation of struct PSBTAnalysis et al.
May 14 2020, 22:03
nakihito requested review of D6083: [tests] add get_key function to wallet_importmulti.py.
May 14 2020, 21:41
nakihito planned changes to D6083: [tests] add get_key function to wallet_importmulti.py.
May 14 2020, 21:41
nakihito updated the summary of D6081: [tests] tidy up imports in wallet_importmulti.py.
May 14 2020, 21:26
nakihito abandoned D5766: Increase seeder timeout for non-Tor connections.

I cannot replicate this issue consistently.

May 14 2020, 21:24
nakihito requested review of D6081: [tests] tidy up imports in wallet_importmulti.py.
May 14 2020, 21:22
nakihito accepted D6077: [backport#15508] Move PSBT decoding functions from core_io to psbt.cpp.
May 14 2020, 20:54
nakihito committed rSTAGING58f39df9ae1c: Remove white space between list in v0.21.5 release notes (authored by nakihito).
Remove white space between list in v0.21.5 release notes
May 14 2020, 20:40
nakihito committed rSTAGINGa6b244747e9c: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys
May 14 2020, 20:40
nakihito committed rABC58f39df9ae1c: Remove white space between list in v0.21.5 release notes (authored by nakihito).
Remove white space between list in v0.21.5 release notes
May 14 2020, 20:37
nakihito closed D6078: Remove white space between list in v0.21.5 release notes.
May 14 2020, 20:36
nakihito committed rABCa6b244747e9c: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys
May 14 2020, 20:36
nakihito closed D6061: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys.
May 14 2020, 20:35
nakihito requested review of D6078: Remove white space between list in v0.21.5 release notes.
May 14 2020, 20:28
nakihito accepted D6073: [backport#14906] refactor: Make explicit CMutableTransaction -> CTransaction conversion..

Most of the changes in the original backport were already done in D1106, except for a few changes related to PartiallySignedTransactions, which we already moved so that is why the files changed are different. The line change in wallet/rpcwallet.cpp also just brings up to parity with Core.

May 14 2020, 20:25
nakihito updated the summary of D6061: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys.
May 14 2020, 20:10