Page MenuHomePhabricator
Feed Advanced Search

Oct 25 2020

deadalnix closed D8101: Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT.
Oct 25 2020, 15:15
deadalnix committed rABCbee3cb09b38b: Move key and script filling and signing from CWallet::FillPSBT to… (authored by Andrew Chow <achow101-github@achow101.com>).
Move key and script filling and signing from CWallet::FillPSBT to…
Oct 25 2020, 15:15
deadalnix closed D8097: Move FillPSBT to be a member of CWallet.
Oct 25 2020, 15:09
deadalnix committed rABCf0ce8173081f: Move FillPSBT to be a member of CWallet (authored by Andrew Chow <achow101-github@achow101.com>).
Move FillPSBT to be a member of CWallet
Oct 25 2020, 15:09
deadalnix closed D8103: Clear any input_errors for an input after it is signed.
Oct 25 2020, 00:35
deadalnix committed rABC7f2483ac9415: Clear any input_errors for an input after it is signed (authored by Andrew Chow <achow101-github@achow101.com>).
Clear any input_errors for an input after it is signed
Oct 25 2020, 00:35
deadalnix updated the diff for D8097: Move FillPSBT to be a member of CWallet.

rebase on top of PR17264

Oct 25 2020, 00:34
deadalnix closed D8104: rpc: set default bip32derivs to true for psbt methods.
Oct 25 2020, 00:10
deadalnix committed rABCc6f37464e379: rpc: set default bip32derivs to true for psbt methods (authored by Sjors Provoost <sjors@sprovoost.nl>).
rpc: set default bip32derivs to true for psbt methods
Oct 25 2020, 00:10

Oct 24 2020

deadalnix closed D8100: Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet.
Oct 24 2020, 23:55
deadalnix committed rABC27fe47e7afc9: Use CWallet::SignTransaction in CreateTransaction and… (authored by Andrew Chow <achow101-github@achow101.com>).
Use CWallet::SignTransaction in CreateTransaction and…
Oct 24 2020, 23:55
deadalnix closed D8098: refactor: deduplicate the message sign/verify code.
Oct 24 2020, 23:36
deadalnix committed rABCa6c7f25feeea: refactor: deduplicate the message sign/verify code (authored by Vasil Dimov <vd@FreeBSD.org>).
refactor: deduplicate the message sign/verify code
Oct 24 2020, 23:36
deadalnix closed D8099: Various nits in abc_wallet_standardness.
Oct 24 2020, 23:31
deadalnix committed rABC1171c36d376c: Various nits in abc_wallet_standardness (authored by deadalnix).
Various nits in abc_wallet_standardness
Oct 24 2020, 23:31
deadalnix requested review of D8104: rpc: set default bip32derivs to true for psbt methods.
Oct 24 2020, 22:46
deadalnix requested review of D8097: Move FillPSBT to be a member of CWallet.
Oct 24 2020, 22:25
deadalnix requested review of D8103: Clear any input_errors for an input after it is signed.
Oct 24 2020, 22:23
deadalnix requested review of D8102: Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan.
Oct 24 2020, 22:03
deadalnix requested review of D8101: Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT.
Oct 24 2020, 21:51
deadalnix requested review of D8100: Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet.
Oct 24 2020, 21:49
deadalnix requested review of D8099: Various nits in abc_wallet_standardness.
Oct 24 2020, 21:38
deadalnix requested review of D8098: refactor: deduplicate the message sign/verify code.
Oct 24 2020, 19:10
deadalnix closed D8096: Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction.
Oct 24 2020, 19:00
deadalnix committed rABCdd2c6cebcda0: Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction (authored by Andrew Chow <achow101-github@achow101.com>).
Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction
Oct 24 2020, 19:00
deadalnix closed D8095: Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan.
Oct 24 2020, 18:59
deadalnix committed rABC588d25004d15: Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan
Oct 24 2020, 18:59
deadalnix closed D8094: Refactor rawtransaction's SignTransaction into generic SignTransaction function.
Oct 24 2020, 18:57
deadalnix committed rABCdabfedaea058: Refactor rawtransaction's SignTransaction into generic SignTransaction function (authored by Andrew Chow <achow101-github@achow101.com>).
Refactor rawtransaction's SignTransaction into generic SignTransaction function
Oct 24 2020, 18:57
deadalnix closed D8092: psbt: check that various indexes and amounts are within bounds.
Oct 24 2020, 18:53
deadalnix committed rABC781c27cdbd01: psbt: check that various indexes and amounts are within bounds (authored by Andrew Chow <achow101-github@achow101.com>).
psbt: check that various indexes and amounts are within bounds
Oct 24 2020, 18:53
deadalnix requested review of D8097: Move FillPSBT to be a member of CWallet.
Oct 24 2020, 17:18
deadalnix requested review of D8096: Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction.
Oct 24 2020, 17:02
deadalnix requested review of D8095: Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan.
Oct 24 2020, 16:56
deadalnix requested review of D8094: Refactor rawtransaction's SignTransaction into generic SignTransaction function.
Oct 24 2020, 16:45
deadalnix accepted D8093: Fix Python Docstring to include all Args..
Oct 24 2020, 16:14
deadalnix requested review of D8092: psbt: check that various indexes and amounts are within bounds.
Oct 24 2020, 01:07

Oct 23 2020

deadalnix accepted D8091: Bump version to 0.22.6.
Oct 23 2020, 22:52
deadalnix accepted D8090: Automatically show a customized message for the upgrade notice before and after activation.
Oct 23 2020, 22:47
deadalnix accepted D8089: Add an upgrade notice on the release page.
Oct 23 2020, 22:47
deadalnix accepted D8088: Make SignatureExtractorChecker private to its own file.
Oct 23 2020, 17:47
deadalnix accepted D8087: [BUILDBOT] Use tokens as an immediate feedback and anti DoS mechanism.
Oct 23 2020, 15:09
deadalnix accepted D8086: [BUILDBOT] Add facilities to manipulate tokens.
Oct 23 2020, 15:08
deadalnix accepted D8085: [BUILDBOT] Use phabricator version from master instead of pip.
Oct 23 2020, 15:08
deadalnix closed D8082: Make signrawtransaction* give an error when amount is needed but missing.
Oct 23 2020, 14:59
deadalnix committed rABC1eeffea66ff0: Make signrawtransaction* give an error when amount is needed but missing (authored by Anthony Towns <aj@erisian.com.au>).
Make signrawtransaction* give an error when amount is needed but missing
Oct 23 2020, 14:59
deadalnix accepted D8083: qa: Fix service flag comparison check in rpc_net test.
Oct 23 2020, 14:45
deadalnix accepted D8084: Correct docstring param name..
Oct 23 2020, 14:43
deadalnix requested review of D8082: Make signrawtransaction* give an error when amount is needed but missing.
Oct 23 2020, 14:28
deadalnix closed D8079: test: Replace gArgs with local argsman in bench.
Oct 23 2020, 14:27
deadalnix committed rABCb515add3355d: test: Replace gArgs with local argsman in bench (authored by MarcoFalke <falke.marco@gmail.com>).
test: Replace gArgs with local argsman in bench
Oct 23 2020, 14:27
deadalnix requested review of D8079: test: Replace gArgs with local argsman in bench.
Oct 23 2020, 13:31
deadalnix accepted D8077: doc: Improve test READMEs.
Oct 23 2020, 13:11
deadalnix accepted D8078: qt: Change default size of intro frame.
Oct 23 2020, 13:10
deadalnix closed D8076: gui: show watch-only balance in send screen.
Oct 23 2020, 13:09
deadalnix committed rABCa690e66ad2c1: gui: show watch-only balance in send screen (authored by Sjors Provoost <sjors@sprovoost.nl>).
gui: show watch-only balance in send screen
Oct 23 2020, 13:09
deadalnix requested review of D8076: gui: show watch-only balance in send screen.
Oct 23 2020, 12:16
deadalnix closed D8071: [gui] load PSBT.
Oct 23 2020, 12:15
deadalnix committed rABCbcfcc43e5915: [gui] load PSBT (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] load PSBT
Oct 23 2020, 12:15
deadalnix accepted D8075: [RPC] Fix casing in getblockchaininfo to be inline with the rest of the response.
Oct 23 2020, 12:04
deadalnix updated the diff for D8071: [gui] load PSBT.

Rebase and fix shaddowing

Oct 23 2020, 11:05
deadalnix closed D8070: [psbt] add file size limit.
Oct 23 2020, 11:01
deadalnix committed rABC9d528e20ef4a: [psbt] add file size limit (authored by Sjors Provoost <sjors@sprovoost.nl>).
[psbt] add file size limit
Oct 23 2020, 11:01
deadalnix closed D8069: [gui] save PSBT to file.
Oct 23 2020, 10:59
deadalnix committed rABCec039f660025: [gui] save PSBT to file (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] save PSBT to file
Oct 23 2020, 10:58
deadalnix closed D8068: Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h.
Oct 23 2020, 10:57
deadalnix committed rABC2b61196f19ce: Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h (authored by Sjors Provoost <sjors@sprovoost.nl>).
Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h
Oct 23 2020, 10:56
deadalnix closed D8067: [util] GetFileSize.
Oct 23 2020, 10:54
deadalnix committed rABC0bef88c34e39: [util] GetFileSize (authored by Sjors Provoost <sjors@sprovoost.nl>).
[util] GetFileSize
Oct 23 2020, 10:53
deadalnix closed D8066: [gui] send dialog: split on_sendButton_clicked.
Oct 23 2020, 10:49
deadalnix committed rABCfaa53213a723: [gui] send dialog: split on_sendButton_clicked (authored by Sjors Provoost <sjors@sprovoost.nl>).
[gui] send dialog: split on_sendButton_clicked
Oct 23 2020, 10:49
deadalnix closed D8065: psbt: handle unspendable psbts.
Oct 23 2020, 10:48
deadalnix committed rABC5a49f316c182: psbt: handle unspendable psbts (authored by Andrew Chow <achow101-github@achow101.com>).
psbt: handle unspendable psbts
Oct 23 2020, 10:48
deadalnix requested review of D8071: [gui] load PSBT.
Oct 23 2020, 02:14
deadalnix updated the summary of D8069: [gui] save PSBT to file.
Oct 23 2020, 02:13
deadalnix requested review of D8070: [psbt] add file size limit.
Oct 23 2020, 02:11
deadalnix requested review of D8069: [gui] save PSBT to file.
Oct 23 2020, 02:10
deadalnix requested review of D8068: Move DEFAULT_MAX_RAW_TX_FEE_RATE to node/transaction.h.
Oct 23 2020, 02:04
deadalnix requested review of D8067: [util] GetFileSize.
Oct 23 2020, 02:02
deadalnix requested review of D8066: [gui] send dialog: split on_sendButton_clicked.
Oct 23 2020, 01:59
deadalnix requested review of D8065: psbt: handle unspendable psbts.
Oct 23 2020, 01:45

Oct 22 2020

deadalnix accepted D8063: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict.
Oct 22 2020, 23:10
deadalnix accepted D8064: Merge #18262: bnb: exit selection when best_waste is 0.
Oct 22 2020, 23:10
deadalnix accepted D8034: Merge #13928: qa: blocktools enforce named args for amount.
Oct 22 2020, 21:21
deadalnix accepted D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Oct 22 2020, 14:38
deadalnix accepted D8056: [backport#16465 3/3] test: minor refactoring.
Oct 22 2020, 14:14
deadalnix accepted D8055: [backport#16465 2/3] test: Replace fragile "rng" with call to random().
Oct 22 2020, 14:12
deadalnix accepted D8054: [backport#16465 1/3] test: Generate one block for each send in wallet_import_rescan.
Oct 22 2020, 14:11
deadalnix requested changes to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..

You need to figure out the CI failure.

Oct 22 2020, 12:03
deadalnix accepted D8053: doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util.
Oct 22 2020, 12:02
deadalnix accepted D8043: [SECP256K1] Check correctness of lambda split without -DVERIFY.
Oct 22 2020, 11:59
deadalnix accepted D8042: [SECP256K1] Make lambda constant accessible.
Oct 22 2020, 11:59
deadalnix accepted D8041: [SECP256K1] Add tests to exercise lambda split near bounds.
Oct 22 2020, 11:58
deadalnix accepted D8040: [SECP256K1] Add secp256k1_split_lambda_verify.
Oct 22 2020, 11:58
deadalnix accepted D8039: [SECP256K1] Detailed comments for secp256k1_scalar_split_lambda.
Oct 22 2020, 11:57
deadalnix accepted D8038: [SECP256K1] Increase precision of g1 and g2.
Oct 22 2020, 11:56
deadalnix accepted D8037: [SECP256K1] Switch to our own memcmp function.
Oct 22 2020, 11:52
deadalnix accepted D8036: [SECP256K1] Add fallback LE/BE for architectures with known endianness + SHA256 selftest.
Oct 22 2020, 11:52
deadalnix accepted D8044: [SECP256K1] Rip out non-endomorphism code.
Oct 22 2020, 11:51
deadalnix accepted D8045: [SECP256K1] WNAF of lambda_split output has max size 129.
Oct 22 2020, 11:19