Page MenuHomePhabricator
Feed Advanced Search

Feb 22 2021

majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

added test cases and removed test cases that no longer apply (the number of digits in PRs are no longer in the code)

Feb 22 2021, 23:34
majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

making the tests happy

Feb 22 2021, 22:42
majcosta updated the summary of D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:41
majcosta requested review of D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:39
majcosta added a comment to D9257: qt: Fix regression in TransactionTableModel.
In D9257#210616, @PiRK wrote:

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

Feb 22 2021, 20:59
majcosta accepted D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 20:22
majcosta abandoned D8633: [refactor] use compile time string_view for DBKeys.

yea this ain't worth it

Feb 22 2021, 20:02
majcosta requested changes to D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 19:50
majcosta requested changes to D9257: qt: Fix regression in TransactionTableModel.

we need to come up with a standard notation to ease automation of tagging the done backports in the bitcoin-core/gui repo, what about using Backport of core-gui PRxxxxxx?

Feb 22 2021, 18:53
majcosta accepted D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Feb 22 2021, 18:49
majcosta accepted D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Feb 22 2021, 18:41
majcosta closed D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 22 2021, 18:38
majcosta committed rABCdf89383bb6ed: [refactor] add alias for Schnorr signatures and remove size magic number (authored by majcosta).
[refactor] add alias for Schnorr signatures and remove size magic number
Feb 22 2021, 18:38
majcosta accepted D9236: wallet: descriptor wallet cleanups.
Feb 22 2021, 18:36
majcosta requested changes to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 22 2021, 18:33

Feb 21 2021

majcosta updated the diff for D9251: [refactor] add alias for Schnorr signatures and remove size magic number.

couldn't reproduce with for i in {1..100}; do ninja check-bitcoin-coinselector_tests; done, rebasing

Feb 21 2021, 11:05
majcosta planned changes to D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 21 2021, 10:49
majcosta requested review of D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Feb 21 2021, 10:13

Feb 19 2021

majcosta requested changes to D9236: wallet: descriptor wallet cleanups.
Feb 19 2021, 17:30
majcosta accepted D9249: Update version to 0.22.14.
Feb 19 2021, 16:36

Feb 18 2021

majcosta accepted D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 18 2021, 11:48

Feb 17 2021

majcosta accepted D9242: test: add -getinfo multiwallet functional tests.
Feb 17 2021, 19:21
majcosta accepted D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.
Feb 17 2021, 19:18
majcosta accepted D9240: cli: use GetWalletBalances() functionality for -getinfo.
Feb 17 2021, 19:14
majcosta requested changes to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Feb 17 2021, 19:13
majcosta accepted D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Feb 17 2021, 18:32
majcosta accepted D9237: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().
Feb 17 2021, 18:09

Feb 15 2021

majcosta accepted D9225: Move replay protection activation to Nov. 15, 2021.
Feb 15 2021, 15:44

Feb 12 2021

majcosta accepted D9221: [Cashtab] Update cashtab docs links to point to web wallet docs.
Feb 12 2021, 23:22

Feb 11 2021

majcosta accepted D9213: [Cashtab] Clean up onboarding page + docs link.
Feb 11 2021, 15:56
majcosta accepted D9212: Faster sigcache nonce.
Feb 11 2021, 15:00

Feb 10 2021

majcosta accepted D9209: [cashtab-docs] remove BCH logo from twitter card.
Feb 10 2021, 23:03
majcosta accepted D9200: net: advertise support for ADDRv2 via new message.
Feb 10 2021, 21:36
majcosta planned changes to D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.

this should probably be the last step once all of cashtab is proper React'd

Feb 10 2021, 21:02
majcosta commandeered D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.
Feb 10 2021, 21:01
majcosta accepted D9208: [cashtab-docs] Add google analytics.
Feb 10 2021, 20:28
majcosta accepted D9207: [Cashtab] Add missing meta field per errors reported by Twitter card validator.
Feb 10 2021, 20:16
majcosta closed D9196: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed.
Feb 10 2021, 19:26
majcosta committed rABC3e3efbd77fa7: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys… (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys…
Feb 10 2021, 19:26
majcosta requested changes to D9207: [Cashtab] Add missing meta field per errors reported by Twitter card validator.
Feb 10 2021, 19:25
majcosta accepted D9202: addrman: ensure old versions don't parse peers.dat.
Feb 10 2021, 18:43
majcosta accepted D9201: tor: make a TORv3 hidden service instead of TORv2.
Feb 10 2021, 18:34
majcosta requested changes to D9200: net: advertise support for ADDRv2 via new message.
Feb 10 2021, 18:31
majcosta accepted D9199: net: CAddress & CAddrMan: (un)serialize as ADDRv2.
Feb 10 2021, 17:48
majcosta updated the diff for D9196: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed.

addressed comments

Feb 10 2021, 17:29

Feb 9 2021

majcosta requested review of D9196: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed.
Feb 9 2021, 19:35
majcosta accepted D9195: p2p: Unify Send and Receive protocol versions.
Feb 9 2021, 17:20
majcosta closed D9066: [backport#18727] test: Add CreateWalletFromFile test.
Feb 9 2021, 16:42
majcosta committed rABCa8ce4f8ed85e: [backport#18727] test: Add CreateWalletFromFile test (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18727] test: Add CreateWalletFromFile test
Feb 9 2021, 16:42
majcosta accepted D9193: tests: Add fuzzing harness for CNode.
Feb 9 2021, 16:40
majcosta accepted D9192: [net] split PushInventory().
Feb 9 2021, 16:29
majcosta accepted D9190: net: Use C++11 member initialization in protocol.
Feb 9 2021, 16:24
majcosta accepted D9189: net: recognize TORv3/I2P/CJDNS networks.
Feb 9 2021, 16:17
majcosta closed D9191: [backport#19164] ci: tsan with wallet.
Feb 9 2021, 16:00
majcosta committed rABCde9e50126c34: [backport#19164] ci: tsan with wallet (authored by fanquake <fanquake@gmail.com>).
[backport#19164] ci: tsan with wallet
Feb 9 2021, 16:00
majcosta accepted D9188: net: CNetAddr: add support to (un)serialize as ADDRv2.
Feb 9 2021, 15:39
majcosta accepted D9187: test: move HasReason so it can be reused.
Feb 9 2021, 15:33
majcosta updated the summary of D9187: test: move HasReason so it can be reused.
Feb 9 2021, 15:32
teamcity awarded D9066: [backport#18727] test: Add CreateWalletFromFile test a Haypence token.
Feb 9 2021, 15:31
majcosta accepted D9186: util: move HasPrefix() so it can be reused.
Feb 9 2021, 15:30
majcosta added a comment to D9066: [backport#18727] test: Add CreateWalletFromFile test.

@bot build-tsan

Feb 9 2021, 15:29
teamcity awarded D9191: [backport#19164] ci: tsan with wallet a Haypence token.
Feb 9 2021, 15:27
majcosta updated the diff for D9066: [backport#18727] test: Add CreateWalletFromFile test.

rebase on top of D9191

Feb 9 2021, 15:25
majcosta requested review of D9191: [backport#19164] ci: tsan with wallet.
Feb 9 2021, 15:24
majcosta accepted D9185: Implement Keccak and SHA3_256.
Feb 9 2021, 15:19

Feb 8 2021

majcosta accepted D9182: Bump version to 0.23.0.
Feb 8 2021, 15:52

Feb 6 2021

majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Feb 6 2021, 01:31

Feb 5 2021

majcosta accepted D9180: [Cashtab] Apply BigNumber to all base unit calcs in sendBch.
Feb 5 2021, 22:16
majcosta accepted D9181: Fix the deserialization of CoinEntry.

tested locally, looks good

Feb 5 2021, 21:46
majcosta closed D9168: [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged.
Feb 5 2021, 18:12
majcosta committed rABC94640cfde31c: [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel… (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel…
Feb 5 2021, 18:11
majcosta accepted D9178: Restore compatibility with old CSubNet serialization.
Feb 5 2021, 17:17
majcosta accepted D9176: net: change CNetAddr::ip to have flexible size.
Feb 5 2021, 17:11
majcosta accepted D9169: Serialization improvements step 6 (all except wallet/gui).
Feb 5 2021, 17:10

Feb 4 2021

majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

update release notes

Feb 4 2021, 23:38
majcosta accepted D9177: [Cashtab] change hover text for wallet mgmt icons.
Feb 4 2021, 23:08
majcosta requested changes to D9176: net: change CNetAddr::ip to have flexible size.
Feb 4 2021, 23:05
majcosta accepted D9175: net: don't accept non-left-contiguous netmasks.
Feb 4 2021, 22:40
majcosta accepted D9174: [Docusaurus] Adding docker deployment files.
Feb 4 2021, 22:36
majcosta accepted D9172: net: save the network type explicitly in CNetAddr.
Feb 4 2021, 22:22
majcosta accepted D9171: net: improve encapsulation of CNetAddr.
Feb 4 2021, 22:16
majcosta accepted D9170: test: add two edge case tests for CSubNet.
Feb 4 2021, 22:15
majcosta requested changes to D9169: Serialization improvements step 6 (all except wallet/gui).
Feb 4 2021, 22:15
majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

update for ecash

Feb 4 2021, 21:40
majcosta retitled D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node from [CashAddr] replace bitcoincash: prefix with abc: in the node to [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Feb 4 2021, 21:37
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

*ecash

Feb 4 2021, 21:37
majcosta accepted D9167: [Cashtab] Incoming notifications use ticker variable.
Feb 4 2021, 15:43
majcosta requested review of D9168: [backport#18587] gui: Avoid wallet tryGetBalances calls in WalletModel::pollBalanceChanged.
Feb 4 2021, 15:39
majcosta accepted D9166: [Cashtab] Remove instance of toSatoshi from tx builder.
Feb 4 2021, 15:34
majcosta closed D9165: [backport#14848] docs: Fix broken Gmane URL in security-check.py.
Feb 4 2021, 14:36
majcosta committed rABCcdbeaa15bd6e: [backport#14848] docs: Fix broken Gmane URL in security-check.py (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14848] docs: Fix broken Gmane URL in security-check.py
Feb 4 2021, 14:35
majcosta accepted D9161: [Cashtab] Remove mint artifact object of arrays style input.
Feb 4 2021, 14:34
majcosta requested review of D9165: [backport#14848] docs: Fix broken Gmane URL in security-check.py.
Feb 4 2021, 13:29
majcosta accepted D9163: util: remove unused c-string variant of atoi64().
Feb 4 2021, 12:56
majcosta closed D9162: [backport#18861] Do not answer GETDATA for to-be-announced tx.
Feb 4 2021, 12:46
majcosta accepted D9154: Make Hash[160] consume range-like objects.
Feb 4 2021, 12:46
majcosta committed rABCdb81f26de654: [backport#18861] Do not answer GETDATA for to-be-announced tx (authored by fanquake <fanquake@gmail.com>).
[backport#18861] Do not answer GETDATA for to-be-announced tx
Feb 4 2021, 12:46
majcosta closed D9156: [backport#16946] wallet: include a checksum of encrypted private keys.
Feb 4 2021, 12:45
majcosta committed rABCa7bb5a014c3b: [backport#16946] wallet: include a checksum of encrypted private keys (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16946] wallet: include a checksum of encrypted private keys
Feb 4 2021, 12:45

Feb 3 2021

majcosta requested review of D9162: [backport#18861] Do not answer GETDATA for to-be-announced tx.
Feb 3 2021, 23:35