Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

May 14 2020

nakihito added inline comments to D6061: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys.
May 14 2020, 20:09
nakihito accepted D6076: Bump PORT_MIN in test framework to not collide with testnet.
May 14 2020, 19:56
nakihito committed rSTAGING76d513094857: Remove Core release note file, update previous release notes, and fix generate… (authored by nakihito).
Remove Core release note file, update previous release notes, and fix generate…
May 14 2020, 19:50
nakihito committed rABC76d513094857: Remove Core release note file, update previous release notes, and fix generate… (authored by nakihito).
Remove Core release note file, update previous release notes, and fix generate…
May 14 2020, 19:48
nakihito closed D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.
May 14 2020, 19:48
nakihito requested changes to D6073: [backport#14906] refactor: Make explicit CMutableTransaction -> CTransaction conversion..

Backport doesn't match the original PR.

May 14 2020, 19:44
nakihito accepted D6075: Merge #16918: test: Make PORT_MIN in test runner configurable.

diff looks correct.

May 14 2020, 19:38
nakihito updated the diff for D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.

Actually remove the Core release note file.

May 14 2020, 19:34
nakihito updated the diff for D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.

Removed note from current release notes.

May 14 2020, 19:32
nakihito updated the summary of D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.
May 14 2020, 19:26
nakihito requested review of D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.
May 14 2020, 19:22
nakihito accepted D6072: [backport#13769] Mark single-argument constructors "explicit".
May 14 2020, 18:24
nakihito accepted D6071: Merge #18641: test: Create cached blocks not in the future.
May 14 2020, 18:00
nakihito accepted D6062: [backport#15159] [RPC] Update getrawtransaction interface.
May 14 2020, 01:32
nakihito committed rSTAGING3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp (authored by nakihito).
Fix string layout in rpc/rawtransaction.cpp
May 14 2020, 01:15
nakihito committed rABC3e4f45f38e83: Fix string layout in rpc/rawtransaction.cpp (authored by nakihito).
Fix string layout in rpc/rawtransaction.cpp
May 14 2020, 01:11
nakihito closed D6066: Fix string layout in rpc/rawtransaction.cpp.
May 14 2020, 01:10
nakihito requested review of D6066: Fix string layout in rpc/rawtransaction.cpp.
May 14 2020, 00:35
nakihito requested changes to D6062: [backport#15159] [RPC] Update getrawtransaction interface.
May 14 2020, 00:05

May 13 2020

nakihito accepted D6058: [backport#13932] Implement analyzepsbt RPC and tests.
May 13 2020, 21:13
nakihito requested review of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 13 2020, 19:57
nakihito updated the summary of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 13 2020, 19:43
nakihito planned changes to D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 13 2020, 19:43
nakihito updated the diff for D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).

Moved PR9332 to its own patch (D6061) and rebased off it.

May 13 2020, 19:43
nakihito requested changes to D6058: [backport#13932] Implement analyzepsbt RPC and tests.
May 13 2020, 19:39
nakihito retitled D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness) from Merge #9332 and #14454: Let wallet importmulti RPC accept labels for standard scriptPubKeys and ProcessImport() cleanup to Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 13 2020, 19:17
nakihito planned changes to D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
In D6051#148328, @deadalnix wrote:

I started reviewing this but this is incredibly difficult. If the problem backport PR9332 is that some test is broken, isn't it possible to modify the PR slightly so that it doesn't break the test?

May 13 2020, 18:31
nakihito requested review of D6061: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys.
May 13 2020, 18:28
nakihito planned changes to D6061: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys.
May 13 2020, 18:19
nakihito requested review of D6061: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys.
May 13 2020, 18:18
nakihito accepted D6046: [backport#13932] Figure out what is missing during signing.
May 13 2020, 17:03
nakihito requested changes to D6046: [backport#13932] Figure out what is missing during signing.
May 13 2020, 01:07

May 12 2020

nakihito updated the summary of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 12 2020, 23:48
nakihito updated the summary of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 12 2020, 23:46
nakihito updated the summary of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 12 2020, 23:45
nakihito requested review of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 12 2020, 23:44
nakihito planned changes to D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 12 2020, 23:11
nakihito requested review of D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).
May 12 2020, 23:11
nakihito committed rSTAGING46afc3475dab: Merge #14150: Add key origin support to descriptors (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #14150: Add key origin support to descriptors
May 12 2020, 18:35
nakihito committed rABC46afc3475dab: Merge #14150: Add key origin support to descriptors (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #14150: Add key origin support to descriptors
May 12 2020, 18:34
nakihito closed D6006: Merge #14150: Add key origin support to descriptors.
May 12 2020, 18:34

May 11 2020

nakihito updated the diff for D6006: Merge #14150: Add key origin support to descriptors.

Fixed formatting.

May 11 2020, 18:02
nakihito added inline comments to D5987: Start using Logger for seeder logging.
May 11 2020, 17:39

May 8 2020

nakihito accepted D6000: [backport#15638] [build] Move wallet load functions to wallet/load unit.
May 8 2020, 17:31
nakihito updated the diff for D6006: Merge #14150: Add key origin support to descriptors.

Reformatted comment.

May 8 2020, 17:12

May 7 2020

nakihito requested review of D6006: Merge #14150: Add key origin support to descriptors.
May 7 2020, 23:16
nakihito requested review of D5933: Remove hdmasterkeyid.

The removed return values are duplicates of hdseedid. It even says in the help text that its an alias for hdseedid. The rest of the PR does not actually replace this value with an alternative because the alternative is already there. See relevant changes:
src/wallet/rpcwallet.cpp
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL2421
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL2459
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL3663
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL3726-L3729

May 7 2020, 20:40
nakihito planned changes to D6004: Refactor keymetadata writing to a separate method.
May 7 2020, 20:23
nakihito requested review of D6004: Refactor keymetadata writing to a separate method.
May 7 2020, 20:18
nakihito requested changes to D6000: [backport#15638] [build] Move wallet load functions to wallet/load unit.

Small nit and test plan should include autotools build:

../configure -enable-deprecated-build-system
make check
May 7 2020, 19:33
nakihito added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.
In D5956#146767, @deadalnix wrote:

It seems like there is already a machinery to select the folder in which business happen, why does this needs to be all duplicated with a different name?

May 7 2020, 19:24
nakihito updated the diff for D5956: Add -datadir option to allow specification of seeder's data directory.

Error outputs to std::cerr and changed GetSeederDir() to call GetDefaultDataDir() directly when -seederdir is not set.

May 7 2020, 19:24
nakihito updated the test plan for D5956: Add -datadir option to allow specification of seeder's data directory.
May 7 2020, 19:23
nakihito updated the summary of D5987: Start using Logger for seeder logging.
May 7 2020, 00:48
nakihito requested review of D5987: Start using Logger for seeder logging.
May 7 2020, 00:46
nakihito updated the test plan for D5987: Start using Logger for seeder logging.
May 7 2020, 00:37
nakihito planned changes to D5987: Start using Logger for seeder logging.
May 7 2020, 00:32
nakihito requested review of D5987: Start using Logger for seeder logging.
May 7 2020, 00:32

May 6 2020

nakihito accepted D5986: prevector: avoid misaligned member accesses.
May 6 2020, 22:31

May 5 2020

nakihito updated the test plan for D5956: Add -datadir option to allow specification of seeder's data directory.
May 5 2020, 20:20
nakihito updated the diff for D5956: Add -datadir option to allow specification of seeder's data directory.

Moved seeder specific functions out of regular node code.

May 5 2020, 20:19
nakihito updated the test plan for D5956: Add -datadir option to allow specification of seeder's data directory.
May 5 2020, 19:23
nakihito committed rSTAGINGe55251f4329b: Finish PR14987 and clean up some functions (authored by nakihito).
Finish PR14987 and clean up some functions
May 5 2020, 19:19
nakihito committed rSTAGINGfa91619ce8b3: Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan (authored by nakihito).
Pass some of wallet/rpcwallet RPC results and examples to RPCHelpMan
May 5 2020, 19:18
nakihito committed rSTAGING70ba2634e165: Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan (authored by nakihito).
Finish passing rpcwallet RPCs Results and Examples to RPCHelpMan
May 5 2020, 19:17
nakihito committed rSTAGINGa65bffe62fab: Pass some more (3/4) rpcwallet RPCs Results and Examples to RPCHelpMan (authored by nakihito).
Pass some more (3/4) rpcwallet RPCs Results and Examples to RPCHelpMan
May 5 2020, 19:16
nakihito committed rSTAGING50beb5f36aea: Pass more (2/4) rpcwallet RPCs Results and Examples to RPCHelpMan (authored by nakihito).
Pass more (2/4) rpcwallet RPCs Results and Examples to RPCHelpMan
May 5 2020, 19:16
nakihito committed rSTAGING69f5edb69071: Pass pruneblockchain RPC Results and Examples to RPCHelpMan (authored by nakihito).
Pass pruneblockchain RPC Results and Examples to RPCHelpMan
May 5 2020, 19:16
nakihito committed rSTAGINGdf9019c00825: Pass rpc/avalanche Results and Examples to RPCHelpMan (authored by nakihito).
Pass rpc/avalanche Results and Examples to RPCHelpMan
May 5 2020, 19:16
nakihito committed rSTAGING499a48084018: Pass rpc/misc RPC Results and Exmaples to RPCHelpMan (authored by nakihito).
Pass rpc/misc RPC Results and Exmaples to RPCHelpMan
May 5 2020, 19:16
nakihito committed rSTAGINGc03c766cf334: Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan (authored by nakihito).
Finish Passing rpc/blockchain RPC results and examples to RPCHelpMan
May 5 2020, 19:13
nakihito committed rSTAGING4bc2f9217b1e: Pass some rpc/blockchain RPC results and examples to RPCHelpMan (authored by nakihito).
Pass some rpc/blockchain RPC results and examples to RPCHelpMan
May 5 2020, 19:13
nakihito committed rSTAGINGc006172f5b02: Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan (authored by nakihito).
Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan
May 5 2020, 19:13
nakihito committed rSTAGINGf2d4686b9352: Pass wallet/rpcdump RPC results and examples to RPCHelpMan (authored by nakihito).
Pass wallet/rpcdump RPC results and examples to RPCHelpMan
May 5 2020, 19:12
nakihito committed rSTAGING22f5cdd265bc: Pass rpc/rawtransaction RPC results and examples to RPCHelpMan (authored by nakihito).
Pass rpc/rawtransaction RPC results and examples to RPCHelpMan
May 5 2020, 19:10
nakihito committed rSTAGING8cc917edc1d8: Pass rpc/net RPC Results and Examples to RPCHelpMan (authored by nakihito).
Pass rpc/net RPC Results and Examples to RPCHelpMan
May 5 2020, 19:10
nakihito committed rSTAGING9f1d09d7937d: Pass rpc/mining RPC results and examples to RPCHelpMan (authored by nakihito).
Pass rpc/mining RPC results and examples to RPCHelpMan
May 5 2020, 19:10
nakihito committed rSTAGING2debdb2ce94c: Rename IsGood() to IsReliable() (authored by nakihito).
Rename IsGood() to IsReliable()
May 5 2020, 19:08
nakihito committed rSTAGING6cc421370619: Pass zmq RPC results and examples to RPCHelpMan (authored by nakihito).
Pass zmq RPC results and examples to RPCHelpMan
May 5 2020, 19:07
nakihito committed rSTAGINGae8d0e0ef626: Pass rpc/server RPC results and examples to RPCHelpMan (authored by nakihito).
Pass rpc/server RPC results and examples to RPCHelpMan
May 5 2020, 19:07
nakihito committed rSTAGINGe6cc692608b8: Pass rpc/abc RPC Results and Examples to RPCHelpMan (authored by nakihito).
Pass rpc/abc RPC Results and Examples to RPCHelpMan
May 5 2020, 19:06
nakihito committed rSTAGING0a7fb85228f5: Remove TestNode() (authored by nakihito).
Remove TestNode()
May 5 2020, 19:05
nakihito committed rSTAGINGf7690c0f382b: Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc
May 5 2020, 19:03
nakihito committed rSTAGING43d44b2e899b: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan
May 5 2020, 19:03
nakihito committed rSTAGINGc7f7fe772158: Merge #15943: tests: Fail if RPC has been added without tests (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15943: tests: Fail if RPC has been added without tests
May 5 2020, 19:00
nakihito committed rSTAGING02ab89366a5a: Complete PR14796 by cleaning up some old functions and names (authored by nakihito).
Complete PR14796 by cleaning up some old functions and names
May 5 2020, 18:58
nakihito committed rSTAGINGa0950966fd85: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to… (authored by nakihito).
Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to…
May 5 2020, 18:58
nakihito committed rSTAGING245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan (authored by nakihito).
Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan
May 5 2020, 18:58
nakihito committed rSTAGING28c8d7fa85b5: Pass rpc/mining RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/mining RPC argument descriptions to RPCHelpMan
May 5 2020, 18:58
nakihito committed rSTAGINGb8e343ee301f: Pass wallet/rpcdump RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass wallet/rpcdump RPC argument descriptions to RPCHelpMan
May 5 2020, 18:58
nakihito committed rSTAGINGc69d41b2bc44: Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/rawtransaction RPC argument descriptions to RPCHelpMan
May 5 2020, 18:58
nakihito committed rSTAGING5850294bc6e7: Pass rpc/misc RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/misc RPC argument descriptions to RPCHelpMan
May 5 2020, 18:58
nakihito committed rSTAGINGb17d1db1baaf: Pass rpc/blockchain RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/blockchain RPC argument descriptions to RPCHelpMan
May 5 2020, 18:57
nakihito committed rSTAGING3413afd1ce58: Pass rpc/net RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/net RPC argument descriptions to RPCHelpMan
May 5 2020, 18:57
nakihito committed rSTAGINGf7eb5edff8aa: Pass rpc/server RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/server RPC argument descriptions to RPCHelpMan
May 5 2020, 18:57
nakihito committed rSTAGING969731122b25: Pass rpc/avalanche RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass rpc/avalanche RPC argument descriptions to RPCHelpMan
May 5 2020, 18:57
nakihito committed rSTAGING28b437a49d59: Make use of ADDR_SOFT_CAP outside just the seeder test suite (authored by nakihito).
Make use of ADDR_SOFT_CAP outside just the seeder test suite
May 5 2020, 18:57
nakihito committed rSTAGING578deeb08e19: Pass abc RPC argument descriptions to RPCHelpMan (authored by nakihito).
Pass abc RPC argument descriptions to RPCHelpMan
May 5 2020, 18:56

May 4 2020

nakihito retitled D5956: Add -datadir option to allow specification of seeder's data directory from Add -seederdir option to allow selection of seeder's data directory to Add -seederdir option to allow specification of seeder's data directory.
May 4 2020, 22:41
nakihito requested review of D5956: Add -datadir option to allow specification of seeder's data directory.
May 4 2020, 22:40
First
Prev
Next