Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 11 2021

majcosta added a comment to D8867: [validation] Remove NotifyEntryRemoved callback from ConnectTrace.

@bot build-clang

Jan 11 2021, 12:06
majcosta accepted D8866: [validation] Remove conflictedTxs from PerBlockConnectTrace.
Jan 11 2021, 12:05
majcosta accepted D8865: [validation interface] Remove vtxConflicted from BlockConnected.
Jan 11 2021, 11:40
majcosta accepted D8864: [wallet] Notify conflicted transactions in TransactionRemovedFromMempool.
Jan 11 2021, 11:32
majcosta accepted D8863: [FUZZER] Fix build failure.
Jan 11 2021, 11:21
majcosta accepted D8861: [net] Add extra entropy to the version message.
Jan 11 2021, 00:44

Jan 10 2021

majcosta requested changes to D8861: [net] Add extra entropy to the version message.
Jan 10 2021, 08:53
majcosta accepted D8856: [cashtab] Remove autocomplete from address inputs.
Jan 10 2021, 07:19

Jan 9 2021

majcosta accepted D8859: rpc: add missing HelpExampleRpc for getblockfilter.
Jan 9 2021, 05:50
majcosta accepted D8858: Update merkle.cpp.
Jan 9 2021, 05:45
majcosta accepted D8857: Fix UB with bench on genesis block.
Jan 9 2021, 05:13
majcosta requested changes to D8856: [cashtab] Remove autocomplete from address inputs.

can we do that for the seed import textbox too?

Jan 9 2021, 05:10
majcosta accepted D8855: Add bn2vch test to functional tests.
Jan 9 2021, 05:03
majcosta accepted D8852: [tests] remove bignum.py.
Jan 9 2021, 05:02
majcosta closed D8853: [cashtab] update CI to npm7/node15.
Jan 9 2021, 04:41
majcosta committed rABC8c42cddde0b5: [cashtab] update CI to npm7/node15 (authored by majcosta).
[cashtab] update CI to npm7/node15
Jan 9 2021, 04:41

Jan 8 2021

teamcity awarded D8853: [cashtab] update CI to npm7/node15 a Haypence token.
Jan 8 2021, 18:54
majcosta added a comment to D8853: [cashtab] update CI to npm7/node15.

@bot cashtab-tests

Jan 8 2021, 18:54
majcosta requested review of D8853: [cashtab] update CI to npm7/node15.
Jan 8 2021, 18:45
majcosta closed D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 16:20
majcosta committed rABC937e3797392e: [cashtab] use npm ci instead of install on CI (authored by majcosta).
[cashtab] use npm ci instead of install on CI
Jan 8 2021, 16:20
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Mountain of Wealth token.
Jan 8 2021, 15:59
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 15:58
majcosta updated the diff for D8849: [cashtab] use npm ci instead of install on CI.

rebase

Jan 8 2021, 15:58
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Doubloon token.
Jan 8 2021, 15:16
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 15:16
majcosta updated the diff for D8849: [cashtab] use npm ci instead of install on CI.

fixed backports installation erroring out and fixed the issue with npm breaking when trying to talk to github via ssh

Jan 8 2021, 15:14
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.
In D8849#203179, @alcipir wrote:

Can you add these instructions to the README? (instead of npm install, npm ci)

Jan 8 2021, 15:12
majcosta planned changes to D8849: [cashtab] use npm ci instead of install on CI.

investigating bustedness

Jan 8 2021, 12:50
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Piece of Eight token.
Jan 8 2021, 12:31
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 12:30
majcosta updated the diff for D8849: [cashtab] use npm ci instead of install on CI.

adding nodejs

Jan 8 2021, 12:29
teamcity awarded D8849: [cashtab] use npm ci instead of install on CI a Haypence token.
Jan 8 2021, 12:14
majcosta added a comment to D8849: [cashtab] use npm ci instead of install on CI.

@bot cashtab-tests

Jan 8 2021, 12:13
majcosta requested review of D8849: [cashtab] use npm ci instead of install on CI.
Jan 8 2021, 12:11
majcosta accepted D8844: [CI] Fix gitian script path.
Jan 8 2021, 10:42
majcosta accepted D8839: [CI] Generate coverage reports for cashtab.
Jan 8 2021, 09:17
majcosta accepted D8842: [CI] Improve cashtab reporting in case of a test failure.

looks good

Jan 8 2021, 09:06
majcosta accepted D8770: test: check custom descendant limit in mempool_packages.py.
Jan 8 2021, 00:58
majcosta requested changes to D8839: [CI] Generate coverage reports for cashtab.
Jan 8 2021, 00:35
majcosta added a comment to D8839: [CI] Generate coverage reports for cashtab.

got this when running ./contrib/teamcity/build-configurations.py cashtab-tests

Jan 8 2021, 00:17

Jan 7 2021

majcosta accepted D8837: Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic.
Jan 7 2021, 18:19
majcosta accepted D8836: [refactor] interpreter: define interface for vfExec.
Jan 7 2021, 18:14
majcosta requested changes to D8836: [refactor] interpreter: define interface for vfExec.

Depends on D8835 right? not D8335

Jan 7 2021, 17:56
majcosta accepted D8835: Benchmark script verification with 100 nested IFs.
Jan 7 2021, 17:28
majcosta accepted D8834: [CASHTAB] Remove the no longer needed --legacy-peer-deps install flag.
Jan 7 2021, 16:53
majcosta accepted D8833: [CASHTAB] Update the README.
Jan 7 2021, 16:53
majcosta requested changes to D8833: [CASHTAB] Update the README.
Jan 7 2021, 16:29
majcosta accepted D8832: [CI] Generate Junit output for the cashtab tests.
Jan 7 2021, 16:09
majcosta accepted D8824: [CI] Run cashtab tests on CI.
Jan 7 2021, 16:04
majcosta accepted D8828: [CASHTAB] Update the jest dependency.
Jan 7 2021, 15:51
majcosta accepted D8827: test: Add bad-txns-*-toolarge test cases to invalid_txs.
Jan 7 2021, 15:25
majcosta accepted D8826: doc: Warn about wallet.dat re-use and backups.
Jan 7 2021, 15:23
majcosta accepted D8821: [CI] Allow for running arbitrary scripts.
Jan 7 2021, 15:21
majcosta accepted D8819: [cashtab] Update css-loader.
Jan 7 2021, 06:04
majcosta accepted D8818: [cashtab] Upgrade mini-css-extract-plugin.
Jan 7 2021, 06:04
majcosta accepted D8814: [cashtab] Update file-loader and fs-extra.
Jan 7 2021, 06:03
majcosta accepted D8813: [cashtab] Upgrade eslint.
Jan 7 2021, 06:03
majcosta accepted D8812: [cashtab] Update webpack.
Jan 7 2021, 06:02
majcosta accepted D8811: [cashtab] Upgrade node modules.
Jan 7 2021, 06:02
majcosta accepted D8816: Do not format autogenerated files.
Jan 7 2021, 05:17

Jan 6 2021

majcosta closed D8804: [backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.
Jan 6 2021, 20:51
majcosta committed rABC685164613eda: [backport#13655] bitcoinconsensus: invalid flags error should be set to… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#13655] bitcoinconsensus: invalid flags error should be set to…
Jan 6 2021, 20:51
majcosta updated the summary of D8804: [backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.
Jan 6 2021, 14:12
majcosta updated the diff for D8804: [backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.

readded test case using bitcoinconsensus_SCRIPT_ENABLE_SIGHASH_FORKID instead

Jan 6 2021, 14:11
majcosta accepted D8805: rpc/wallet: initialize nFeeRequired explicitely to 0.
Jan 6 2021, 10:53
majcosta updated the summary of D8804: [backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.
Jan 6 2021, 10:52
majcosta accepted D8802: qa: Add getdescriptorinfo functional test.
Jan 6 2021, 10:48
majcosta requested review of D8804: [backport#13655] bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.
Jan 6 2021, 10:46
majcosta accepted D8801: test: add logging to wallet_listsinceblock.py.
Jan 6 2021, 10:44
majcosta accepted D8794: [p2p] Add Peer struct for per-peer data in net processing.
Jan 6 2021, 09:58
majcosta accepted D8793: p2p: clean up Misbehaving().
Jan 6 2021, 09:20
majcosta closed D8800: [backport#19512] p2p: banscore updates to gui, tests, release notes.
Jan 6 2021, 09:16
majcosta closed D8799: [backport#19464] net: remove -banscore configuration option.
Jan 6 2021, 09:16
majcosta committed rABC59fd163cc4f2: [backport#19512] p2p: banscore updates to gui, tests, release notes (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#19512] p2p: banscore updates to gui, tests, release notes
Jan 6 2021, 09:16
majcosta closed D8798: [backport#19469] rpc: deprecate banscore field in getpeerinfo.
Jan 6 2021, 09:16
majcosta committed rABC91502b3998ac: [backport#19464] net: remove -banscore configuration option (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19464] net: remove -banscore configuration option
Jan 6 2021, 09:16
majcosta committed rABCa40a553f0488: [backport#19469] rpc: deprecate banscore field in getpeerinfo (authored by fanquake <fanquake@gmail.com>).
[backport#19469] rpc: deprecate banscore field in getpeerinfo
Jan 6 2021, 09:16
majcosta accepted D8789: Add CustomUintFormatter.
Jan 6 2021, 08:36
majcosta accepted D8788: Add DifferenceFormatter.
Jan 6 2021, 08:36
majcosta updated the diff for D8799: [backport#19464] net: remove -banscore configuration option.

couldn't reproduce the error

Jan 6 2021, 07:56
majcosta updated the diff for D8800: [backport#19512] p2p: banscore updates to gui, tests, release notes.

couldn't reproduce the error at all, don't think it's related to the diff

Jan 6 2021, 05:37
majcosta planned changes to D8799: [backport#19464] net: remove -banscore configuration option.

investigating failure

Jan 6 2021, 02:16

Jan 5 2021

majcosta accepted D8777: net: Avoid redundant and confusing FAILED log.
Jan 5 2021, 22:35
majcosta requested review of D8800: [backport#19512] p2p: banscore updates to gui, tests, release notes.
Jan 5 2021, 22:27
majcosta requested review of D8799: [backport#19464] net: remove -banscore configuration option.
Jan 5 2021, 21:59
majcosta requested review of D8798: [backport#19469] rpc: deprecate banscore field in getpeerinfo.
Jan 5 2021, 21:44
majcosta requested changes to D8794: [p2p] Add Peer struct for per-peer data in net processing.
Jan 5 2021, 21:23
majcosta requested changes to D8793: p2p: clean up Misbehaving().
Jan 5 2021, 20:50
majcosta accepted D8792: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect().
Jan 5 2021, 19:49
majcosta accepted D8790: Convert blockencodings.h to new serialization framework.
Jan 5 2021, 19:14
majcosta requested changes to D8789: Add CustomUintFormatter.
Jan 5 2021, 18:48
majcosta requested changes to D8788: Add DifferenceFormatter.
Jan 5 2021, 18:45
majcosta accepted D8787: Make VectorFormatter support stateful formatters.
Jan 5 2021, 18:44
majcosta accepted D8796: Add monorepo link to CONTRIBUTING.md.
Jan 5 2021, 18:01

Jan 4 2021

majcosta accepted D8779: httpserver: use own HTTP status codes.
Jan 4 2021, 19:11
majcosta requested changes to D8777: net: Avoid redundant and confusing FAILED log.

hm Segfault in build-clang

Jan 4 2021, 17:28
majcosta accepted D8776: Drop unused mach time headers.
Jan 4 2021, 17:27

Dec 29 2020

majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

yea it does look nicer that way, thanks

Dec 29 2020, 20:07
majcosta requested review of D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Dec 29 2020, 19:54
First
Prev
Next