Page MenuHomePhabricator
Feed Advanced Search

Apr 1 2020

deadalnix accepted D5642: depends: cleanup package configure flags.
Apr 1 2020, 18:18
deadalnix requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

I don't think this will work at all. Which you'd know if you had tested this.

Apr 1 2020, 16:56
deadalnix accepted D5636: depends: Prune X packages.
Apr 1 2020, 16:45
deadalnix accepted D5640: build: make building protobuf optional in depends.
Apr 1 2020, 16:43
deadalnix accepted D5637: Added some factors that affect the dependency list.
Apr 1 2020, 16:42
deadalnix accepted D5638: depends: disable unused Qt features.
Apr 1 2020, 16:42
deadalnix accepted D5634: packages.md: document depends build targets.
Apr 1 2020, 16:41
deadalnix accepted D5633: build: disable libxcb extensions.
Apr 1 2020, 16:39
deadalnix accepted D5639: build: remove qt libjpeg check from bitcoin_qt.m4.
Apr 1 2020, 16:38
deadalnix accepted D5631: depends: expat 2.2.7.
Apr 1 2020, 16:37
deadalnix updated the test plan for D5641: Also track dependencies of native targets.
Apr 1 2020, 16:36
deadalnix created D5641: Also track dependencies of native targets.
Apr 1 2020, 16:33
deadalnix committed rABCec66b9b27e2e: Use ninja to generate dep files for the native build (authored by deadalnix).
Use ninja to generate dep files for the native build
Apr 1 2020, 14:56
deadalnix closed D5628: Use ninja to generate dep files for the native build.
Apr 1 2020, 14:56
deadalnix added inline comments to D5628: Use ninja to generate dep files for the native build.
Apr 1 2020, 14:56
deadalnix updated the diff for D5628: Use ninja to generate dep files for the native build.

Address comments

Apr 1 2020, 14:18
deadalnix added inline comments to D5628: Use ninja to generate dep files for the native build.
Apr 1 2020, 14:18
deadalnix added inline comments to D5628: Use ninja to generate dep files for the native build.
Apr 1 2020, 12:36
deadalnix committed rABC26dc0c3112bc: Rebuild native executable when changes to the build system are made (authored by deadalnix).
Rebuild native executable when changes to the build system are made
Apr 1 2020, 12:35
deadalnix closed D5624: Rebuild native executable when changes to the build system are made.
Apr 1 2020, 12:35
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Ok I spent forever, went through maybe 1/4 of it and find at least one problem.

Apr 1 2020, 02:45

Mar 31 2020

deadalnix accepted D5626: Merge #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo.
Mar 31 2020, 20:53
deadalnix requested changes to D5611: [DOC] Add checking the secp256k1 Travis build to the release process.
Mar 31 2020, 20:51
deadalnix accepted D5623: [depends] boost: update to 1.70.
Mar 31 2020, 20:51
deadalnix accepted D5621: depends: Purge libtool archives.
Mar 31 2020, 20:49
deadalnix accepted D5622: depends: xtrans: Configure flags cleanup..
Mar 31 2020, 20:45
deadalnix updated the diff for D5628: Use ninja to generate dep files for the native build.

Use something simpler for extra dependencies.

Mar 31 2020, 20:42
deadalnix updated the diff for D5628: Use ninja to generate dep files for the native build.

remove leftover comment

Mar 31 2020, 20:19
deadalnix accepted D5620: depends: add ability to skip building zeromq.
Mar 31 2020, 19:27
deadalnix accepted D5625: build: prune dbus from depends.
Mar 31 2020, 19:26
deadalnix created D5628: Use ninja to generate dep files for the native build.
Mar 31 2020, 19:23
deadalnix updated the diff for D5624: Rebuild native executable when changes to the build system are made.

Always generate the dep file. It doesn't hurt on other targets and makes things simpler.

Mar 31 2020, 18:22
deadalnix created D5624: Rebuild native executable when changes to the build system are made.
Mar 31 2020, 18:19
deadalnix accepted D5617: Add version number to the seeder.
Mar 31 2020, 13:57
deadalnix accepted D5614: depends: Make less assumptions about build env.
Mar 31 2020, 12:35
deadalnix committed rABC5a74bd17d75c: Clean the native directory when using the clean target (authored by deadalnix).
Clean the native directory when using the clean target
Mar 31 2020, 12:07
deadalnix closed D5613: Clean the native directory when using the clean target.
Mar 31 2020, 12:07
deadalnix accepted D5619: [CMAKE] Replace the test runner with a test wrapper.
Mar 31 2020, 12:02

Mar 30 2020

deadalnix requested changes to D5617: Add version number to the seeder.

Good call, but this needs to be consistent accross executables.

Mar 30 2020, 23:30
deadalnix requested changes to D5614: depends: Make less assumptions about build env.

This is not the backport this claims to be. Can you update the description?

Mar 30 2020, 23:26
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Alright, I looked at a few diffs, but this is clear that this is still not reviewable as this.

Mar 30 2020, 23:14
deadalnix requested review of D5613: Clean the native directory when using the clean target.
Mar 30 2020, 23:06
deadalnix added inline comments to D5611: [DOC] Add checking the secp256k1 Travis build to the release process.
Mar 30 2020, 20:48
deadalnix created D5613: Clean the native directory when using the clean target.
Mar 30 2020, 17:03
deadalnix requested changes to D5611: [DOC] Add checking the secp256k1 Travis build to the release process.
Mar 30 2020, 16:35
deadalnix accepted D5608: Improve depends debuggability.
Mar 30 2020, 14:28
deadalnix accepted D5600: [tests] Remove rpc_zmq.py.
Mar 30 2020, 14:26
deadalnix accepted D5607: Update zmq to 4.3.1.
Mar 30 2020, 14:13
deadalnix accepted D5603: [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq.
Mar 30 2020, 14:11
deadalnix accepted D5606: depends: expat 2.2.6 and qt 5.9.7.
Mar 30 2020, 14:09
deadalnix accepted D5604: depends: Enable unicode support on dbd for Windows.
Mar 30 2020, 14:08
deadalnix accepted D5605: depends: native_protobuf: avoid system zlib.
Mar 30 2020, 14:07
deadalnix accepted D5601: depends: Add 'make clean' and 'make clean-all' rules.
Mar 30 2020, 14:07
deadalnix accepted D5602: build: Remove illegal spacing in darwin.mk.
Mar 30 2020, 14:06
deadalnix accepted D5598: [SECP256K1] Travis Don't run the constant time check with java tests.
Mar 30 2020, 14:05
deadalnix requested changes to D5600: [tests] Remove rpc_zmq.py.

You actually did not remove the test.

Mar 30 2020, 14:00
deadalnix accepted D5599: depends: zeromq 4.2.3.
Mar 30 2020, 13:56
deadalnix committed rABCc41458899bf3: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures (authored by deadalnix).
[secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures
Mar 30 2020, 13:55
deadalnix closed D5597: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures.
Mar 30 2020, 13:54

Mar 29 2020

deadalnix created D5597: [secp256k1] Extend libsecp256k1's ctime test to check schnorr signatures.
Mar 29 2020, 19:37
deadalnix committed rABC1147a5277298: Constant-time behaviour test using valgrind memtest. (authored by Gregory Maxwell <greg@xiph.org>).
Constant-time behaviour test using valgrind memtest.
Mar 29 2020, 18:40
deadalnix closed D5580: Constant-time behaviour test using valgrind memtest..
Mar 29 2020, 18:40
deadalnix updated the diff for D5580: Constant-time behaviour test using valgrind memtest..

Update travis strategy

Mar 29 2020, 16:02
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

I spotted at least one discrepancy. This is review hell. Generating the list of help for all RPC before and after that patch and providing a diff is the only way to go here.

Mar 29 2020, 15:31

Mar 27 2020

deadalnix committed rABC98369fa6fd64: [secp256k1] Install all packages in travis (authored by deadalnix).
[secp256k1] Install all packages in travis
Mar 27 2020, 15:28
deadalnix closed D5589: [secp256k1] Install all packages in travis.
Mar 27 2020, 15:27
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make sure that the opposite of no is indeed gmp.

Mar 27 2020, 15:18
deadalnix retitled D5589: [secp256k1] Install all packages in travis from [secp256k1] Install all packes in travis to [secp256k1] Install all packages in travis.
Mar 27 2020, 15:10
deadalnix accepted D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Mar 27 2020, 15:09
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make bignum explicitely yes and remove install directive

Mar 27 2020, 14:31
deadalnix created D5589: [secp256k1] Install all packages in travis.
Mar 27 2020, 14:26
deadalnix accepted D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:55
deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

I'm sorry, but I don't buy the finalization argument, mostly because it's not an argument. I've seen enough cultish behavior in this industry to know people will say you shouldn't do X or must do Y the Z way with absolutely no reason whatsoever and it often turns out to be a bad idea. If there is a reason to not do it, then people should be able to state it and we should be able to assert why it applies or not to our current situation. Every time someone brings up that this is the "the way" without providing a proper rationale, this is only a stronger reason to dismiss this concern.

Mar 27 2020, 13:34

Mar 26 2020

deadalnix accepted D5582: Merge #14813: qa: Add wallet_encryption error tests.
Mar 26 2020, 23:19
deadalnix accepted D5581: Add missing softforks help text to getblockchaininfo.
Mar 26 2020, 23:16
deadalnix updated the diff for D5580: Constant-time behaviour test using valgrind memtest..

Fix travis

Mar 26 2020, 18:07
deadalnix created D5580: Constant-time behaviour test using valgrind memtest..
Mar 26 2020, 18:02
deadalnix committed rABC46e449e05795: Eliminate harmless non-constant time operations on secret data. (authored by Gregory Maxwell <greg@xiph.org>).
Eliminate harmless non-constant time operations on secret data.
Mar 26 2020, 16:33
deadalnix closed D5524: Eliminate harmless non-constant time operations on secret data..
Mar 26 2020, 16:32
deadalnix accepted D5573: [depends] Don't build libevent sample code.
Mar 26 2020, 15:13
deadalnix committed rABC0bd04e38c10b: [avalanche] sign avaresponse (authored by deadalnix).
[avalanche] sign avaresponse
Mar 26 2020, 14:56
deadalnix closed D5537: [avalanche] sign avaresponse.
Mar 26 2020, 14:56
deadalnix added inline comments to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 26 2020, 01:53
deadalnix added a comment to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 26 2020, 01:51
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Mar 26 2020, 01:50
deadalnix added inline comments to D5537: [avalanche] sign avaresponse.
Mar 26 2020, 01:39
deadalnix updated the diff for D5537: [avalanche] sign avaresponse.

Address comments

Mar 26 2020, 00:22

Mar 25 2020

deadalnix accepted D5562: Return a status enum from ScanForWalletTransactions.
Mar 25 2020, 23:58
deadalnix accepted D5557: qt: test: Create at most one testing setup.
Mar 25 2020, 23:49
deadalnix accepted D5531: build: macOS toolchain update.
Mar 25 2020, 23:48
deadalnix committed rABCed15a61e72c8: [avalanche] Fix test when ran without wallet (authored by deadalnix).
[avalanche] Fix test when ran without wallet
Mar 25 2020, 22:54
deadalnix closed D5568: [avalanche] Fix test when ran without wallet.
Mar 25 2020, 22:54
deadalnix created D5568: [avalanche] Fix test when ran without wallet.
Mar 25 2020, 19:46
deadalnix committed rABCfe0c8d1c3766: [avalanche] Add handling of ava_poll command in the network layer (authored by deadalnix).
[avalanche] Add handling of ava_poll command in the network layer
Mar 25 2020, 19:02
deadalnix closed D5528: [avalanche] Add handling of ava_poll command in the network layer.
Mar 25 2020, 19:02
deadalnix accepted D5564: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions.
Mar 25 2020, 19:02
deadalnix requested changes to D5562: Return a status enum from ScanForWalletTransactions.
Mar 25 2020, 18:59
deadalnix accepted D5563: Add stop_block out arg to ScanForWalletTransactions.
Mar 25 2020, 18:58
deadalnix accepted D5562: Return a status enum from ScanForWalletTransactions.
Mar 25 2020, 18:56
deadalnix accepted D5561: Make CWallet::ScanForWalletTransactions args and return value const.
Mar 25 2020, 18:41