Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Jun 23 2020

Fabien added inline comments to D6686: [CI] Make the build_autotools.sh script take a list of targets.

Jun 23 2020, 16:40

Fabien requested review of D6687: [CI] Wrap the build_autotools.sh script in a function.

Jun 23 2020, 16:22

Fabien added a comment to D6686: [CI] Make the build_autotools.sh script take a list of targets.

@bot build-autotools

Jun 23 2020, 16:17

Fabien requested review of D6686: [CI] Make the build_autotools.sh script take a list of targets.

Jun 23 2020, 16:12

Fabien accepted D6685: Clean up banning levels.

Jun 23 2020, 16:01

Fabien accepted D6684: [refactor] drop IsInvalid(nDoSOut).

Jun 23 2020, 15:48

Fabien accepted D6683: [refactor] Refactor misbehavior ban decisions to MaybePunishNode().

Jun 23 2020, 15:47

Fabien committed rABC883cffa2de02: [CI] Wrap the build_cmake.sh environment and script path into a function (authored by Fabien).

[CI] Wrap the build_cmake.sh environment and script path into a function

Jun 23 2020, 15:37

Fabien closed D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.

Jun 23 2020, 15:37

Fabien committed rABC6884f60c355e: [CI] Add an option to select the compiler to build_cmake.sh (authored by Fabien).

[CI] Add an option to select the compiler to build_cmake.sh

Jun 23 2020, 15:26

Fabien closed D6677: [CI] Add an option to select the compiler to build_cmake.sh.

Jun 23 2020, 15:26

Fabien accepted D6682: Remove double if in tx_verify.cpp.

Jun 23 2020, 14:27

Fabien committed rABC2d11352f940d: [CI] Make build-configurations.sh take the build name as an argument (authored by Fabien).

[CI] Make build-configurations.sh take the build name as an argument

Jun 23 2020, 14:26

Fabien closed D6681: [CI] Make build-configurations.sh take the build name as an argument.

Jun 23 2020, 14:26

Fabien committed rABC7f128bd46521: [CI] Don't print an error if there is no sanitizer log files (authored by Fabien).

[CI] Don't print an error if there is no sanitizer log files

Jun 23 2020, 14:25

Fabien closed D6680: [CI] Don't print an error if there is no sanitizer log files.

Jun 23 2020, 14:25

Fabien updated the diff for D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.

Rebase

Jun 23 2020, 14:24

Fabien accepted D6679: test: Add basic test for BIP34.

Jun 23 2020, 14:22

Fabien updated the diff for D6677: [CI] Add an option to select the compiler to build_cmake.sh.

Rebase

Jun 23 2020, 14:15

Fabien committed rABCfdaed1dcc29d: [CI] Add a build plan to run clang-tidy on the changed files (authored by Fabien).

[CI] Add a build plan to run clang-tidy on the changed files

Jun 23 2020, 14:13

Fabien closed D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Jun 23 2020, 14:13

Fabien added a reverting change for D6639: [CI] Install the latest wine version from the winehq repository: rABC80101a81e8ae: Revert "[CI] Install the latest wine version from the winehq repository".

Jun 23 2020, 14:11

Fabien committed rABC80101a81e8ae: Revert "[CI] Install the latest wine version from the winehq repository" (authored by Fabien).

Revert "[CI] Install the latest wine version from the winehq repository"

Jun 23 2020, 14:11

Fabien added a reverting change for rABCb25c0bf30ae0: [CI] Install the latest wine version from the winehq repository: rABC80101a81e8ae: Revert "[CI] Install the latest wine version from the winehq repository".

Jun 23 2020, 14:11

Fabien closed D6676: Revert "[CI] Install the latest wine version from the winehq repository".

Jun 23 2020, 14:11

Fabien requested review of D6681: [CI] Make build-configurations.sh take the build name as an argument.

Jun 23 2020, 13:58

Fabien requested review of D6680: [CI] Don't print an error if there is no sanitizer log files.

Jun 23 2020, 13:42

Fabien requested review of D6678: [CI] Wrap the build_cmake.sh environment and script path into a function.

Jun 23 2020, 13:18

Fabien added a comment to D6627: [CI] Add a build plan to run clang-tidy on the changed files.

I'm working on cleaning the whole thing

Jun 23 2020, 11:49

Fabien requested review of D6677: [CI] Add an option to select the compiler to build_cmake.sh.

Jun 23 2020, 09:39

Fabien added a comment to D6627: [CI] Add a build plan to run clang-tidy on the changed files.

@deadalnix Here is an example of the output in case of missing braces

Jun 23 2020, 09:34

Fabien planned changes to D6675: Do not review.

Jun 23 2020, 09:32

Fabien updated the diff for D6675: Do not review.

Rebase

Jun 23 2020, 09:19

Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Pass the clang-tidy binary to the script

Jun 23 2020, 09:19

Fabien planned changes to D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Jun 23 2020, 09:10

Fabien planned changes to D6675: Do not review.

Jun 23 2020, 08:53

Fabien updated the diff for D6675: Do not review.

Rebase due to D6676

Jun 23 2020, 08:52

Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Rebase on top of D6676

Jun 23 2020, 08:52

Fabien added a comment to D6676: Revert "[CI] Install the latest wine version from the winehq repository".

@bot build-win64

Jun 23 2020, 08:50

Fabien requested review of D6676: Revert "[CI] Install the latest wine version from the winehq repository".

Jun 23 2020, 08:39

Fabien added a reverting change for D6639: [CI] Install the latest wine version from the winehq repository: D6676: Revert "[CI] Install the latest wine version from the winehq repository".

Jun 23 2020, 08:39

Fabien added a reverting change for rABCb25c0bf30ae0: [CI] Install the latest wine version from the winehq repository: D6676: Revert "[CI] Install the latest wine version from the winehq repository".

Jun 23 2020, 08:39

Fabien planned changes to D6675: Do not review.

Jun 23 2020, 07:32

Fabien requested review of D6675: Do not review.

Jun 23 2020, 07:32

Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Change "errors" to "issues" in the message and move the file to the build dir.

Jun 23 2020, 07:31

Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Rebase

Jun 23 2020, 07:15

Fabien accepted D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.

Jun 23 2020, 07:13

Fabien accepted D6674: test: add invalid tx templates for use in functional tests.

Jun 23 2020, 07:13

Fabien accepted D6673: [refactor] rename stateDummy -> orphan_state.

Jun 23 2020, 06:53

Jun 22 2020

Fabien accepted D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.

Jun 22 2020, 21:02

Fabien accepted D6665: [backport#16512] rpc: Shuffle inputs and outputs after joining psbts.

Jun 22 2020, 20:50

Fabien accepted D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.

Jun 22 2020, 20:42

Fabien accepted D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.

Jun 22 2020, 08:36

Fabien accepted D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.

Jun 22 2020, 08:36

Fabien accepted D6664: [backport#16322] wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction.

Jun 22 2020, 08:05

Fabien requested changes to D6663: [backport#14935] tests: Test for expected return values when calling functions returning a success code.

Jun 22 2020, 08:01

Fabien requested changes to D6662: [backport#14953] test: Make g_insecure_rand_ctx thread_local.

NACK, see https://github.com/bitcoin/bitcoin/pull/14985, and also D3485 and D3628.

Jun 22 2020, 07:41

Fabien accepted D6661: [backport#16079] wallet_balance.py: Prevent edge cases.

Jun 22 2020, 07:39

Fabien requested changes to D6660: [backport#16326] [RPC] add new utxoupdatepsbt arguments to the CRPCCommand and CPRCConvertParam tables.

Jun 22 2020, 07:35

Jun 20 2020

Fabien accepted D6659: [avalanche] Increase quorum size in the test..

Jun 20 2020, 13:10

Fabien committed rABCb25c0bf30ae0: [CI] Install the latest wine version from the winehq repository (authored by Fabien).

[CI] Install the latest wine version from the winehq repository

Jun 20 2020, 06:49

Fabien closed D6639: [CI] Install the latest wine version from the winehq repository.

Jun 20 2020, 06:49

Jun 19 2020

Fabien accepted D6652: Merge #16688: log: Add validation interface logging.

Talked offline, the change that requires a lot of other backports is the removal of the error code from the message.
Since the message change is not related with the intent of this PR, let's move forward.

Jun 19 2020, 19:19

Fabien updated the diff for D6639: [CI] Install the latest wine version from the winehq repository.

Prevent 301

Jun 19 2020, 08:24

Fabien added a comment to D6654: Merge #18551: Do not clear validationinterface entries being executed.

Build failures are fixed in D6655

Jun 19 2020, 07:17

Fabien accepted D6654: Merge #18551: Do not clear validationinterface entries being executed.

Jun 19 2020, 07:15

Fabien accepted D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.

Jun 19 2020, 07:08

Fabien added a comment to D6652: Merge #16688: log: Add validation interface logging.

I don't see what is preventing the change to FormatStateMessage to be part of the backport ? AFAIK the massive stack you mention is a class rename but all the changes from the PR can be done now without conflict.

Jun 19 2020, 06:53

Jun 18 2020

Fabien committed rABCWEBc570651e4aeb: [WEB] Add a link to the new Bitcoin ABC Blog (authored by Fabien).

[WEB] Add a link to the new Bitcoin ABC Blog

Jun 18 2020, 18:58

Fabien closed D6637: [WEB] Add a link to the new Bitcoin ABC Blog.

Jun 18 2020, 18:58

Fabien requested review of D6639: [CI] Install the latest wine version from the winehq repository.

Jun 18 2020, 18:53

Fabien committed rABCWEB54158ed4693d: [WEB] Add a Developers menu with Contributing and Code coverage (authored by Fabien).

[WEB] Add a Developers menu with Contributing and Code coverage

Jun 18 2020, 18:44

Fabien closed D6636: [WEB] Add a Developers menu with Contributing and Code coverage.

Jun 18 2020, 18:44

Fabien committed rABCf3691320504a: Fix missing braces (authored by Fabien).

Fix missing braces

Jun 18 2020, 18:43

Fabien closed D6638: Fix missing braces.

Jun 18 2020, 18:43

Fabien updated the diff for D6639: [CI] Install the latest wine version from the winehq repository.

Install in non interactive mode

Jun 18 2020, 16:13

Fabien requested review of D6639: [CI] Install the latest wine version from the winehq repository.

Jun 18 2020, 15:12

Fabien updated the diff for D6638: Fix missing braces.

Rebase for CI

Jun 18 2020, 13:58

Fabien committed rABC8b9c76abbae6: [CI] Temporarly fix adoptopenjdk8 failure (authored by Fabien).

[CI] Temporarly fix adoptopenjdk8 failure

Jun 18 2020, 13:55

Fabien closed D6635: [CI] Temporarly fix adoptopenjdk8 failure.

Jun 18 2020, 13:55

Fabien committed rABC2c9b8b60c38b: tests: Make coins_tests/updatecoins_simulation_test deterministic (authored by practicalswift <practicalswift@users.noreply.github.com>).

tests: Make coins_tests/updatecoins_simulation_test deterministic

Jun 18 2020, 13:00

Fabien closed D6621: tests: Make coins_tests/updatecoins_simulation_test deterministic.

Jun 18 2020, 13:00

Fabien committed rABCd64efa6c638e: tests: Make updatecoins_simulation_test deterministic (authored by practicalswift <practicalswift@users.noreply.github.com>).

tests: Make updatecoins_simulation_test deterministic

Jun 18 2020, 12:55

Fabien closed D6620: tests: Make updatecoins_simulation_test deterministic.

Jun 18 2020, 12:55

Fabien requested review of D6638: Fix missing braces.

Jun 18 2020, 12:51

Fabien updated the diff for D6637: [WEB] Add a link to the new Bitcoin ABC Blog.

Make the blog link a top level entry

Jun 18 2020, 12:41

Fabien retitled D6637: [WEB] Add a link to the new Bitcoin ABC Blog from [WEB] Add a News menu with Announcements and Blog to [WEB] Add a link to the new Bitcoin ABC Blog.

Jun 18 2020, 12:41

Fabien planned changes to D6637: [WEB] Add a link to the new Bitcoin ABC Blog.

Jun 18 2020, 12:37

Fabien updated the summary of D6637: [WEB] Add a link to the new Bitcoin ABC Blog.

Jun 18 2020, 12:32

Fabien updated the summary of D6636: [WEB] Add a Developers menu with Contributing and Code coverage.

Jun 18 2020, 12:32

Fabien requested review of D6637: [WEB] Add a link to the new Bitcoin ABC Blog.

Jun 18 2020, 12:31

Fabien requested review of D6636: [WEB] Add a Developers menu with Contributing and Code coverage.

Jun 18 2020, 12:27

Fabien accepted D6634: Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp.

Jun 18 2020, 11:53

Fabien accepted D6631: Merge #15999: init: Remove dead code in LoadChainTip.

@deadalnix I fail to remember if there was anything remaining that was waiting on this change, can you take a look ?

Jun 18 2020, 11:42

Fabien accepted D6628: Merge #15824: docs: Improve netbase comments.

Jun 18 2020, 10:13

Fabien requested changes to D6626: [backport#15427 3/3] Add support for descriptors to utxoupdatepsbt.

Jun 18 2020, 10:05

Fabien accepted D6624: [backport#15427 2/3] Abstract out UpdatePSBTOutput from FillPSBT.

Jun 18 2020, 09:59

Fabien accepted D6623: [backport#15986] Add unmodified-but-with-checksum to getdescriptorinfo.

Jun 18 2020, 09:55

Fabien accepted D6622: [backport#15986] Factor out checksum checking from descriptor parsing.

Jun 18 2020, 09:54

Fabien updated the diff for D6627: [CI] Add a build plan to run clang-tidy on the changed files.

Rebase on top of D6635 to unbreak the CI

Jun 18 2020, 09:11