Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 7 2019

jasonbcox added inline comments to D2245: Implement RCU synchronization mechanism.
Jan 7 2019, 21:43
jasonbcox accepted D2262: Remove github-merge.py documentation.
Jan 7 2019, 21:14
jasonbcox requested changes to D2245: Implement RCU synchronization mechanism.
Jan 7 2019, 07:24
jasonbcox accepted D2251: Use information stored in TestNode to connect nodes via p2p and RPC.
Jan 7 2019, 06:58
Herald added a reviewer for D2260: Move scheduler/threadGroup into common-init instead of per-app: Restricted Project.
Jan 7 2019, 06:46
jasonbcox triaged T507: Backport Core PR 12266 as Normal priority.
Jan 7 2019, 05:55 · Backport
jasonbcox closed T440: Backport Core PR 12610 and friends for multiwallet support, a subtask of T417: Backport PR10244 from core, as Resolved.
Jan 7 2019, 05:28 · Backport
jasonbcox committed rABCf957f5b34ce8: [qt] Multiwallet support for GUI (Core PR12610) (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[qt] Multiwallet support for GUI (Core PR12610)
Jan 7 2019, 05:27
jasonbcox closed T440: Backport Core PR 12610 and friends for multiwallet support as Resolved.
Jan 7 2019, 05:27 · Unknown Object (Project), Backport
jasonbcox closed D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 7 2019, 05:27
jasonbcox updated the summary of D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 7 2019, 05:26

Jan 6 2019

jasonbcox accepted D2222: [avalanche] Add some safety to AvalancheBlockUpdate using static asserts.
Jan 6 2019, 02:16

Jan 5 2019

jasonbcox requested review of D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 5 2019, 23:39
jasonbcox updated the test plan for D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 5 2019, 23:39
jasonbcox updated the test plan for D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 5 2019, 23:35
Herald added a reviewer for D2258: Bump cmake version 3.5 -> 3.10 to match lowest supported version for CMP0071: Restricted Project.
Jan 5 2019, 23:25
jasonbcox planned changes to D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 5 2019, 17:50
jasonbcox updated the diff for D1979: [qt] Multiwallet support for GUI (Core PR12610).

Fix imports + rebase

Jan 5 2019, 17:50
jasonbcox committed rABC1b979d882ffa: Accept unrequested blocks with work equal to our tip (authored by Matt Corallo <git@bluematt.me>).
Accept unrequested blocks with work equal to our tip
Jan 5 2019, 17:40
jasonbcox closed D2254: Accept unrequested blocks with work equal to our tip.
Jan 5 2019, 17:40
jasonbcox updated the test plan for D1979: [qt] Multiwallet support for GUI (Core PR12610).
Jan 5 2019, 17:38
Herald added a reviewer for D2254: Accept unrequested blocks with work equal to our tip: Restricted Project.
Jan 5 2019, 02:45

Jan 4 2019

jasonbcox added inline comments to D2169: [secp256k1] Implement Schnorr signatures.
Jan 4 2019, 18:18

Jan 3 2019

jasonbcox committed rABC9bc3e8965f82: Revert "Stop always storing blocks from whitelisted peers" (authored by jasonbcox).
Revert "Stop always storing blocks from whitelisted peers"
Jan 3 2019, 23:06
jasonbcox added a reverting change for rABCc3f4936b0453: Stop always storing blocks from whitelisted peers: rABC9bc3e8965f82: Revert "Stop always storing blocks from whitelisted peers".
Jan 3 2019, 23:06
jasonbcox closed D2252: Revert "Stop always storing blocks from whitelisted peers".
Jan 3 2019, 23:06
jasonbcox requested changes to D2251: Use information stored in TestNode to connect nodes via p2p and RPC.
Jan 3 2019, 22:56
Herald added a reviewer for D2252: Revert "Stop always storing blocks from whitelisted peers": Restricted Project.
Jan 3 2019, 22:47
jasonbcox added a reverting change for rABCc3f4936b0453: Stop always storing blocks from whitelisted peers: D2252: Revert "Stop always storing blocks from whitelisted peers".
Jan 3 2019, 22:47
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Jan 3 2019, 22:05
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Jan 3 2019, 20:14
jasonbcox removed a reviewer for D1894: Added RPCCommand base classes in preparation for RPC migration: schancel.
Jan 3 2019, 20:10
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Simplified dependency injection

Jan 3 2019, 20:08
jasonbcox committed rABCc3f4936b0453: Stop always storing blocks from whitelisted peers (authored by Matt Corallo <git@bluematt.me>).
Stop always storing blocks from whitelisted peers
Jan 3 2019, 18:28
jasonbcox closed D2246: Stop always storing blocks from whitelisted peers.
Jan 3 2019, 18:27
jasonbcox accepted D2249: Update Copyright year to 2019.
Jan 3 2019, 18:18
jasonbcox planned changes to D1894: Added RPCCommand base classes in preparation for RPC migration.

Talked with Amaury offline and he clarified how the dependency injection can be simplified. Planning changes until the new changes are done.

Jan 3 2019, 00:15

Jan 2 2019

jasonbcox triaged T437: Backport core PR 11738 as High priority.
Jan 2 2019, 22:35 · Unknown Object (Project)
jasonbcox triaged T436: Backport core PR 10286 as High priority.
Jan 2 2019, 22:35 · Unknown Object (Project)
jasonbcox raised the priority of T417: Backport PR10244 from core from High to Unbreak Now!.
Jan 2 2019, 22:34 · Backport
jasonbcox requested changes to D2164: [Part 4 of 4] [qa] De-globalize port seeding.

Please check harbormaster failure

Jan 2 2019, 18:46
jasonbcox requested changes to D2165: [Part 3 of 4] [qa] De-globalize port seeding.

Please check harbormaster failure

Jan 2 2019, 18:46
jasonbcox requested changes to D2163: [Part 2 of 4] [qa] De-globalize port seeding.

Noticed harbormaster isn't passing.

Jan 2 2019, 18:45
jasonbcox accepted D2163: [Part 2 of 4] [qa] De-globalize port seeding.
Jan 2 2019, 18:45
jasonbcox requested changes to D2249: Update Copyright year to 2019.
Jan 2 2019, 18:43
jasonbcox requested changes to D2170: [wip] [qa] Allow multiple tests per file..

Need to cleanup the review queue, so setting request changes for now.

Jan 2 2019, 18:41
jasonbcox requested changes to D2171: [wip] [qa] Basic test decorators.

Need to cleanup the review queue, so setting request changes for now.

Jan 2 2019, 18:41
jasonbcox requested changes to D2173: [WIP] Use mempool for fee estimates, not blocks..

Need to cleanup the review queue, so setting request changes for now.

Jan 2 2019, 18:41
jasonbcox accepted D2247: Store the node name as a local variable rather than recomputing it every time in different places.
Jan 2 2019, 18:39

Jan 1 2019

Herald added a reviewer for D2246: Stop always storing blocks from whitelisted peers: Restricted Project.
Jan 1 2019, 01:41
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Rebase and rename RegisterCommand() -> RegisterCommandFactory()

Jan 1 2019, 01:26
jasonbcox accepted D2241: Temporarly skip running rpcbind_test on WSL.
Jan 1 2019, 00:08
jasonbcox added inline comments to D2241: Temporarly skip running rpcbind_test on WSL.
Jan 1 2019, 00:08
jasonbcox added inline comments to D2222: [avalanche] Add some safety to AvalancheBlockUpdate using static asserts.
Jan 1 2019, 00:06

Dec 30 2018

jasonbcox accepted D2242: Remove fallbacks for boost_filesystem < v3.
Dec 30 2018, 18:28
jasonbcox requested changes to D2241: Temporarly skip running rpcbind_test on WSL.
Dec 30 2018, 18:10

Dec 29 2018

jasonbcox accepted D2237: Fix header guards using reserved identifiers.
Dec 29 2018, 17:50
jasonbcox accepted D2235: Fix races in AppInitMain and others with lock and atomic bools.
Dec 29 2018, 17:46
jasonbcox accepted D2236: Move local include to before system includes.
Dec 29 2018, 17:43
jasonbcox accepted D2219: Remove check for thread_local in build systems.

I reran the build for you. Looks like it was a spurious failure with the build bot, not an issue with the codebase.

Dec 29 2018, 01:10

Dec 28 2018

jasonbcox requested changes to D2222: [avalanche] Add some safety to AvalancheBlockUpdate using static asserts.

Nits on the variable naming to make it explicit what is being masked. Looks good otherwise.

Dec 28 2018, 22:33
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Dec 28 2018, 22:25
jasonbcox accepted D2230: wallet: Fix memory leak when loading a corrupted wallet file.
Dec 28 2018, 22:19
jasonbcox accepted D2231: [wallet] Fix leak in CDB constructor.
Dec 28 2018, 22:18
jasonbcox requested review of D1979: [qt] Multiwallet support for GUI (Core PR12610).
Dec 28 2018, 22:10
jasonbcox accepted D2228: Regenerate timing.json.
Dec 28 2018, 21:55
jasonbcox committed rABC570a09320a31: Remove redundant connect_nodes call in abc-parkedchain.py (authored by jasonbcox).
Remove redundant connect_nodes call in abc-parkedchain.py
Dec 28 2018, 04:06
jasonbcox closed D2189: Remove redundant connect_nodes call in abc-parkedchain.py.
Dec 28 2018, 04:06
jasonbcox updated the diff for D2189: Remove redundant connect_nodes call in abc-parkedchain.py.

Rebase

Dec 28 2018, 03:30
jasonbcox committed rABCe724cfe160dd: Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks (authored by jasonbcox).
Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks
Dec 28 2018, 03:13
jasonbcox closed D2188: Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks.
Dec 28 2018, 03:12

Dec 21 2018

jasonbcox updated the diff for D2188: Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks.

Updated according to feedback

Dec 21 2018, 22:47
jasonbcox added inline comments to D2188: Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks.
Dec 21 2018, 22:22
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Removed unused include + rebase

Dec 21 2018, 22:19
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Dec 21 2018, 22:18
jasonbcox closed T467: Backport Core PR11638 as Resolved.
Dec 21 2018, 21:59 · Unknown Object (Project), Backport
jasonbcox closed T467: Backport Core PR11638, a subtask of T439: Backport Core PR 11648, as Resolved.
Dec 21 2018, 21:59 · Unknown Object (Project), Backport
jasonbcox closed T467: Backport Core PR11638, a subtask of T468: Backport Core PRs related to mininode cleanup, as Resolved.
Dec 21 2018, 21:59 · Unknown Object (Project), Backport
jasonbcox committed rABCb36d97b25971: Merge #11638: [tests] Dead mininode code (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11638: [tests] Dead mininode code
Dec 21 2018, 21:59
jasonbcox closed D2210: Merge #11638: [tests] Dead mininode code.
Dec 21 2018, 21:59
jasonbcox updated the diff for D2189: Remove redundant connect_nodes call in abc-parkedchain.py.

Use wait_until according to feedback

Dec 21 2018, 21:47
jasonbcox accepted D2207: Declare single-argument (non-converting) constructors "explicit".
Dec 21 2018, 21:35
jasonbcox accepted D2216: Update disconnect_nodes API so it does take the node object directly.
Dec 21 2018, 21:34
jasonbcox accepted D2215: Update connect_nodes API so it does take the node object directly.
Dec 21 2018, 21:33
jasonbcox added inline comments to D2210: Merge #11638: [tests] Dead mininode code.
Dec 21 2018, 21:19
jasonbcox accepted D2006: Ensure config variables are initalized.
Dec 21 2018, 01:48
jasonbcox requested changes to D2169: [secp256k1] Implement Schnorr signatures.
Dec 21 2018, 01:33
Herald added a reviewer for D2210: Merge #11638: [tests] Dead mininode code: Restricted Project.
Dec 21 2018, 00:37

Dec 20 2018

jasonbcox accepted D2184: Prepare functional tests for deprecation of signrawtransaction rpc.
Dec 20 2018, 20:16
jasonbcox committed rABCe55fb9e61eee: [Part 1] Core PR 11531: p2p-acceptblock improvements (authored by Matt Corallo <git@bluematt.me>).
[Part 1] Core PR 11531: p2p-acceptblock improvements
Dec 20 2018, 02:18
jasonbcox triaged T497: Backport Core PR 10104 as Normal priority.
Dec 20 2018, 02:17 · Unknown Object (Project), Backport
jasonbcox renamed T445: December backports from November backports to December backports.
Dec 20 2018, 02:15 · Unknown Object (Project)
jasonbcox triaged T476: Write a script to automate the collection of gitian outputs as Unbreak Now! priority.
Dec 20 2018, 01:54 · Unknown Object (Project)
jasonbcox closed T497: Backport Core PR 10104 as Resolved.
Dec 20 2018, 01:44 · Unknown Object (Project), Backport
jasonbcox closed T497: Backport Core PR 10104, a subtask of T473: Backport Core PR10781, as Resolved.
Dec 20 2018, 01:43 · Unknown Object (Project), Backport
jasonbcox committed rABCc854fd7e71c6: Use the variable name _ for unused return values (authored by practicalswift <practicalswift@users.noreply.github.com>).
Use the variable name _ for unused return values
Dec 20 2018, 01:38
jasonbcox closed T473: Backport Core PR10781 as Resolved.
Dec 20 2018, 01:37 · Unknown Object (Project), Backport
jasonbcox closed T473: Backport Core PR10781, a subtask of T467: Backport Core PR11638, as Resolved.
Dec 20 2018, 01:35 · Restricted Project, Backport
jasonbcox committed rABCebd95f0c7ddd: Remove unused variables and/or function calls (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove unused variables and/or function calls
Dec 20 2018, 01:18
jasonbcox committed rABCe5662f0b544a: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs (authored by practicalswift <practicalswift@users.noreply.github.com>).
Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs
Dec 20 2018, 01:17
First
Prev
Next