Page MenuHomePhabricator
Feed All Stories

Aug 12 2019

Harbormaster failed remote builds in B7129: Diff 10748 for D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework!
Aug 12 2019, 23:23
teamcity added a comment to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Aug 12 2019, 23:23
teamcity added a comment to D3833: Merge #11395: Qt: Enable searching by transaction id.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 23:20
jasonbcox committed rABCf694f58845f6: Fix incorrect node being checked in segwit recovery test (authored by jasonbcox).
Fix incorrect node being checked in segwit recovery test
Aug 12 2019, 23:20
jasonbcox closed D3859: Fix incorrect node being checked in segwit recovery test.
Aug 12 2019, 23:20
jasonbcox updated the summary of D3862: qa: Read reject reasons from debug log, not p2p messages.
Aug 12 2019, 23:19
teamcity added a comment to D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 23:18
jasonbcox created D3863: Migrate abc-invalid-chains off of the ComparisonTestFramework.
Aug 12 2019, 23:18
teamcity added a comment to D3862: qa: Read reject reasons from debug log, not p2p messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 23:15
teamcity added a comment to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 23:10
teamcity added a comment to D3862: qa: Read reject reasons from debug log, not p2p messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 23:09
jasonbcox created D3862: qa: Read reject reasons from debug log, not p2p messages.
Aug 12 2019, 23:08
Harbormaster failed remote builds in B7126: Diff 10744 for D3833: Merge #11395: Qt: Enable searching by transaction id!
Aug 12 2019, 23:08
teamcity added a comment to D3833: Merge #11395: Qt: Enable searching by transaction id.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Aug 12 2019, 23:07
teamcity added a comment to D3861: Merge #14101: qa: Use named args in validation acceptance tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 23:05
teamcity added a comment to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 23:04
teamcity added a comment to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 23:03
nakihito planned changes to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Aug 12 2019, 23:02
nakihito updated the diff for D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Rebased off dependency.

Aug 12 2019, 23:02
teamcity added a comment to D3833: Merge #11395: Qt: Enable searching by transaction id.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 22:59
teamcity added a comment to D3833: Merge #11395: Qt: Enable searching by transaction id.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 22:59
nakihito updated the diff for D3833: Merge #11395: Qt: Enable searching by transaction id.

Fixed formatting.

Aug 12 2019, 22:59
teamcity added a comment to D3861: Merge #14101: qa: Use named args in validation acceptance tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 22:59
jasonbcox created D3861: Merge #14101: qa: Use named args in validation acceptance tests.
Aug 12 2019, 22:59
nakihito requested review of D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Aug 12 2019, 22:55
nakihito accepted D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.
Aug 12 2019, 22:54
teamcity added a comment to D3860: Merge #14024: qa: Add TestNode::assert_debug_log.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 22:17
markblundeberg accepted D3859: Fix incorrect node being checked in segwit recovery test.

oops! that was me :)

Aug 12 2019, 22:12
teamcity added a comment to D3860: Merge #14024: qa: Add TestNode::assert_debug_log.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 22:10
jasonbcox created D3860: Merge #14024: qa: Add TestNode::assert_debug_log.
Aug 12 2019, 22:10
teamcity added a comment to D3859: Fix incorrect node being checked in segwit recovery test.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 21:08
teamcity added a comment to D3859: Fix incorrect node being checked in segwit recovery test.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 21:02
jasonbcox created D3859: Fix incorrect node being checked in segwit recovery test.
Aug 12 2019, 21:01
teamcity added a comment to D3858: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 20:35
teamcity added a comment to D3858: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 20:28
nakihito created D3858: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots.
Aug 12 2019, 20:28
teamcity added a comment to D3857: Merge #12996: tests: Remove redundant bytes(…) calls.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 18:58
teamcity added a comment to D3857: Merge #12996: tests: Remove redundant bytes(…) calls.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 18:47
nakihito created D3857: Merge #12996: tests: Remove redundant bytes(…) calls.
Aug 12 2019, 18:47
teamcity added a comment to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 18:38
teamcity added a comment to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 18:32
jasonbcox created D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.
Aug 12 2019, 18:31
Nico Guiton <nico@bitframe.org> committed rABC61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of…
Aug 12 2019, 17:36
Nico Guiton <nico@bitframe.org> closed D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.
Aug 12 2019, 17:36
Nico Guiton <nico@bitframe.org> committed rABCcdbd2983808b: Merge #12969: Drop dead code CScript::Find (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12969: Drop dead code CScript::Find
Aug 12 2019, 17:23
Nico Guiton <nico@bitframe.org> closed D3850: Merge #12969: Drop dead code CScript::Find.
Aug 12 2019, 17:23
Mengerian accepted D3853: Bump version to 0.20.0.

Looks good.

Aug 12 2019, 17:20
Nico Guiton <nico@bitframe.org> committed rABC87684f13e3fa: Merge #11573: [Util] Update tinyformat.h (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11573: [Util] Update tinyformat.h
Aug 12 2019, 17:14
Nico Guiton <nico@bitframe.org> closed D3849: Merge #11573: [Util] Update tinyformat.h.
Aug 12 2019, 17:14
jasonbcox accepted D3855: Fix missing plural form from commit reversal.
Aug 12 2019, 16:24
teamcity added a comment to D3855: Fix missing plural form from commit reversal.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 16:18
teamcity added a comment to D3855: Fix missing plural form from commit reversal.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 16:12
Fabien created D3855: Fix missing plural form from commit reversal.
Aug 12 2019, 16:12
teamcity added a comment to D3854: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 15:50
teamcity added a comment to D3854: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 15:44
Fabien created D3854: [CMAKE] Fix typos in the secp256k1 CMakeLists.txt file.
Aug 12 2019, 15:43
jasonbcox added a reverting change for D3793: macOS: Prevent Xcode 9.3 build warnings: rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 12 2019, 14:51
jasonbcox committed rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings" (authored by jasonbcox).
Revert "macOS: Prevent Xcode 9.3 build warnings"
Aug 12 2019, 14:51
jasonbcox added a reverting change for rABC4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings: rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 12 2019, 14:51
jasonbcox closed D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 12 2019, 14:51
jasonbcox added a reverting change for D3838: Bump version to 0.20.0: rABC115dbcfe0f5b: Revert "Bump version to 0.20.0".
Aug 12 2019, 14:50
jasonbcox added a reverting change for rABCb6179d8326eb: Bump version to 0.20.0: rABC115dbcfe0f5b: Revert "Bump version to 0.20.0".
Aug 12 2019, 14:50
jasonbcox committed rABC115dbcfe0f5b: Revert "Bump version to 0.20.0" (authored by jasonbcox).
Revert "Bump version to 0.20.0"
Aug 12 2019, 14:50
jasonbcox closed D3851: Revert "Bump version to 0.20.0".
Aug 12 2019, 14:50
teamcity added a comment to D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 13:18
teamcity added a comment to D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 13:11
Fabien updated the diff for D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Assert that the hex string length is even.

Aug 12 2019, 13:11
teamcity added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 12 2019, 13:02
teamcity added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 12 2019, 12:54
Fabien updated the diff for D3834: [TRIVIAL] Cleanup the JNI test file.

Update as per comment.
Add a newline between the TODO and the javadoc comments for better readability.

Aug 12 2019, 12:53
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Aug 12 2019, 08:41
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Aug 12 2019, 08:37
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Aug 12 2019, 08:34
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Aug 12 2019, 08:15
Fabien accepted D3845: Merge #12447: test: Add missing signal.h header.

FreeBSD tests build is OK without this, it should be included by some other dependency.

Aug 12 2019, 07:17
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

Aug 12 2019, 07:13
Fabien accepted D3848: Merge #11842: [build] Add missing stuff to clean-local.
Aug 12 2019, 07:00
Fabien accepted D3846: Merge #12489: Bugfix: respect user defined configuration file (-conf) in QT settings.
Aug 12 2019, 06:58
Fabien accepted D3843: Merge #10036: Fix init README format to render correctly on github.
Aug 12 2019, 06:39
Fabien accepted D3841: Merge #10085: Docs: remove 'noconnect' option.
Aug 12 2019, 06:38
Fabien accepted D3840: Merge #9910: Docs: correct and elaborate -rpcbind doc.
Aug 12 2019, 06:34
Fabien accepted D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 12 2019, 06:11
Fabien accepted D3851: Revert "Bump version to 0.20.0".
Aug 12 2019, 06:11
deadalnix accepted D3827: [CMAKE] Make secp256k1 build standalone.
Aug 12 2019, 05:57
deadalnix accepted D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.
Aug 12 2019, 05:32

Aug 11 2019

teamcity added a comment to D3853: Bump version to 0.20.0.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 11 2019, 22:09
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 11 2019, 22:05
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Aug 11 2019, 22:03
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Aug 11 2019, 22:00
teamcity added a comment to D3851: Revert "Bump version to 0.20.0".

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 11 2019, 21:59
teamcity added a comment to D3853: Bump version to 0.20.0.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 11 2019, 21:55
jasonbcox created D3853: Bump version to 0.20.0.
Aug 11 2019, 21:55
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Aug 11 2019, 21:52
teamcity added a comment to D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 11 2019, 21:50
jasonbcox added a reverting change for D3793: macOS: Prevent Xcode 9.3 build warnings: D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 11 2019, 21:50
jasonbcox added a reverting change for rABC4f0e8a5a102a: macOS: Prevent Xcode 9.3 build warnings: D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 11 2019, 21:50
jasonbcox created D3852: Revert "macOS: Prevent Xcode 9.3 build warnings".
Aug 11 2019, 21:50
teamcity added a comment to D3851: Revert "Bump version to 0.20.0".

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 11 2019, 21:46
jasonbcox added a reverting change for D3838: Bump version to 0.20.0: D3851: Revert "Bump version to 0.20.0".
Aug 11 2019, 21:45
jasonbcox created D3851: Revert "Bump version to 0.20.0".
Aug 11 2019, 21:45