Page MenuHomePhabricator
Feed All Stories

Jul 28 2020

majcosta committed rABC715386dc1fa1: [backport#16624 4/4] Add a test wallet_reorgsrestore (authored by Antoine Riard <ariard@student.42.fr>).
[backport#16624 4/4] Add a test wallet_reorgsrestore
Jul 28 2020, 11:05
majcosta committed rABCdb8f22c0635a: [backport#16624 3/4] Modify wallet tx status if has been reorged out (authored by Antoine Riard <ariard@student.42.fr>).
[backport#16624 3/4] Modify wallet tx status if has been reorged out
Jul 28 2020, 11:04
majcosta closed D7050: [backport#16624 3/4] Modify wallet tx status if has been reorged out.
Jul 28 2020, 11:04
majcosta committed rABC78c6a6547d2d: [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet… (authored by Antoine Riard <ariard@student.42.fr>).
[backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet…
Jul 28 2020, 11:04
majcosta closed D7049: [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected.
Jul 28 2020, 11:04
majcosta committed rABC5e818a52f520: [backport#16624 1/4] Encapsulate tx status in a Confirmation struct (authored by Antoine Riard <ariard@student.42.fr>).
[backport#16624 1/4] Encapsulate tx status in a Confirmation struct
Jul 28 2020, 11:03
majcosta closed D7048: [backport#16624 1/4] Encapsulate tx status in a Confirmation struct.
Jul 28 2020, 11:03
Fabien committed rABC40b60bbb3c03: [CMAKE] Move the functional tests junit reports to the test/junit dir (authored by Fabien).
[CMAKE] Move the functional tests junit reports to the test/junit dir
Jul 28 2020, 10:54
Fabien closed D7004: [CMAKE] Move the functional tests junit reports to the test/junit dir.
Jul 28 2020, 10:54
majcosta committed rABC327d1005b2fa: [backport#15906] [wallet] Move min_depth and max_depth to coin control (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#15906] [wallet] Move min_depth and max_depth to coin control
Jul 28 2020, 10:51
majcosta closed D7042: [backport#15906] [wallet] Move min_depth and max_depth to coin control.
Jul 28 2020, 10:51
teamcity added a comment to D7062: [backport#16524] Wallet: Disable -fallbackfee by default.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 28 2020, 10:45
teamcity updated the summary of D7062: [backport#16524] Wallet: Disable -fallbackfee by default.
Jul 28 2020, 10:45
majcosta requested review of D7062: [backport#16524] Wallet: Disable -fallbackfee by default.
Jul 28 2020, 10:44
Fabien committed rABC98b979b0acf1: [CMAKE] Generate junit output for boost unit tests (authored by Fabien).
[CMAKE] Generate junit output for boost unit tests
Jul 28 2020, 10:39
Fabien closed D7002: [CMAKE] Generate junit output for boost unit tests.
Jul 28 2020, 10:39
majcosta requested review of D7061: [backport#16402] Remove wallet settings from chainparams.
Jul 28 2020, 10:24
Fabien added a comment to D7057: Add autoindexing for /doc route.

I don't quite get it, since D7052 updated the generated extension there is no html anymore in the RPC docs ?

Jul 28 2020, 09:38
Fabien accepted D7060: [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...).
Jul 28 2020, 09:28
Fabien accepted D7059: [backport#14103] docs: Fix broken Doxygen comments.
Jul 28 2020, 09:25
Fabien accepted D7051: [backport#16624 4/4] Add a test wallet_reorgsrestore.
Jul 28 2020, 09:21
Fabien accepted D7050: [backport#16624 3/4] Modify wallet tx status if has been reorged out.
Jul 28 2020, 09:17
Fabien accepted D7049: [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected.
Jul 28 2020, 09:14
Fabien accepted D7048: [backport#16624 1/4] Encapsulate tx status in a Confirmation struct.
Jul 28 2020, 09:13
teamcity added a comment to D7060: [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...).

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 28 2020, 09:08
teamcity updated the summary of D7060: [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...).
Jul 28 2020, 09:08
majcosta requested review of D7060: [backport#13546] wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...).
Jul 28 2020, 09:08
Fabien accepted D7042: [backport#15906] [wallet] Move min_depth and max_depth to coin control.
Jul 28 2020, 08:56
teamcity added a comment to D7059: [backport#14103] docs: Fix broken Doxygen comments.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 28 2020, 08:52
teamcity updated the summary of D7059: [backport#14103] docs: Fix broken Doxygen comments.
Jul 28 2020, 08:52
majcosta requested review of D7059: [backport#14103] docs: Fix broken Doxygen comments.
Jul 28 2020, 08:52
Fabien added a comment to D6981: Implement Grasberg DAA.

Nice improvement !

Jul 28 2020, 08:33
majcosta closed T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members, a subtask of T597: Backport Core PR 15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled , as Resolved.
Jul 28 2020, 08:32 · Restricted Project, Backport
majcosta closed T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members as Resolved.

done in D3364

Jul 28 2020, 08:32 · Restricted Project, Backport
majcosta committed rABCb1728a65f1c9: [backport#16952] gui: make sure to update the UI when deleting a transaction (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16952] gui: make sure to update the UI when deleting a transaction
Jul 28 2020, 08:26
majcosta closed D7054: [backport#16952] gui: make sure to update the UI when deleting a transaction.
Jul 28 2020, 08:26
majcosta closed D7053: [backport#16796] wallet: Fix segfault in CreateWalletFromFile.
Jul 28 2020, 08:25
majcosta committed rABC3312619d73cc: [backport#16796] wallet: Fix segfault in CreateWalletFromFile (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#16796] wallet: Fix segfault in CreateWalletFromFile
Jul 28 2020, 08:25
majcosta committed rABC35f36b8ef112: [backport#16620] util: Move ResolveErrMsg to util/error (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16620] util: Move ResolveErrMsg to util/error
Jul 28 2020, 08:16
majcosta closed D7045: [backport#16620] util: Move ResolveErrMsg to util/error.
Jul 28 2020, 08:16
Fabien requested review of D7058: Don't generate junit report for functional test unless being asked to.
Jul 28 2020, 07:18
majcosta committed rABC78c5f12b9ff1: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16745] wallet: Translate all initErrors in CreateWalletFromFile
Jul 28 2020, 07:18
majcosta closed D7044: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile.
Jul 28 2020, 07:18
majcosta committed rABC0da6d99ee232: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in…
Jul 28 2020, 07:15
majcosta closed D7043: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay().
Jul 28 2020, 07:15
majcosta updated the diff for D7042: [backport#15906] [wallet] Move min_depth and max_depth to coin control.

@Fabien, that dangling int m_min_depth{0} was part of https://github.com/bitcoin/bitcoin/pull/15557 which we skipped because it's all about RBF and fee bumping

Jul 28 2020, 07:11
Fabien updated the diff for D7004: [CMAKE] Move the functional tests junit reports to the test/junit dir.

Rebase, take ENABLE_JUNIT_REPORT into account

Jul 28 2020, 06:59
Fabien updated the diff for D7002: [CMAKE] Generate junit output for boost unit tests.

Fix bad rebase

Jul 28 2020, 06:56
Fabien updated the diff for D7002: [CMAKE] Generate junit output for boost unit tests.
Jul 28 2020, 06:55
Fabien updated the diff for D7002: [CMAKE] Generate junit output for boost unit tests.

Address feedback

Jul 28 2020, 06:35
Fabien added inline comments to D7002: [CMAKE] Generate junit output for boost unit tests.
Jul 28 2020, 06:35
nira updated nira.
Jul 28 2020, 06:25
foundationschool updated foundationschool.
Jul 28 2020, 04:54
jasonbcox requested review of D7057: Add autoindexing for /doc route.
Jul 28 2020, 01:00

Jul 27 2020

deadalnix accepted D7002: [CMAKE] Generate junit output for boost unit tests.

Accepting because I think this is good now. Make sure you look at the comments and see if they can be addressed somehow.

Jul 27 2020, 22:49
deadalnix updated the diff for D6981: Implement Grasberg DAA.

Address @Fabien 's comments

Jul 27 2020, 22:41
jasonbcox committed rABCb77a2c3698b3: Set correct markdown extension for generated RPC docs (authored by jasonbcox).
Set correct markdown extension for generated RPC docs
Jul 27 2020, 22:17
jasonbcox closed D7052: Set correct markdown extension for generated RPC docs.
Jul 27 2020, 22:17
jasonbcox committed rABC79d346dc6faa: Bump version to 0.21.13 (authored by jasonbcox).
Bump version to 0.21.13
Jul 27 2020, 22:11
jasonbcox closed D7047: Bump version to 0.21.13.
Jul 27 2020, 22:10
teamcity added a comment to D7033: [backport#15901 2/2] remove extraneous scope.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:10
teamcity updated the summary of D7033: [backport#15901 2/2] remove extraneous scope.
Jul 27 2020, 22:10
teamcity added a comment to D7029: [backport#15853] wallet: Remove unused import checkpoints.h.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:09
teamcity updated the summary of D7029: [backport#15853] wallet: Remove unused import checkpoints.h.
Jul 27 2020, 22:09
teamcity added a comment to D7028: [backport#15491] wallet: Improve log output for errors during load.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:09
teamcity updated the summary of D7028: [backport#15491] wallet: Improve log output for errors during load.
Jul 27 2020, 22:09
teamcity added a comment to D7017: [backport#15588 1/3] Remove nFileVersion from CWalletScanState.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:09
teamcity updated the summary of D7017: [backport#15588 1/3] Remove nFileVersion from CWalletScanState.
Jul 27 2020, 22:09
teamcity added a comment to D7037: [backport#16399 3/3] Use switch on status in RpcWallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:09
teamcity updated the summary of D7037: [backport#16399 3/3] Use switch on status in RpcWallet.
Jul 27 2020, 22:09
teamcity added a comment to D7023: [backport#16502] wallet: Drop unused OldKey.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:08
teamcity updated the summary of D7023: [backport#16502] wallet: Drop unused OldKey.
Jul 27 2020, 22:08
teamcity added a comment to D7020: [backport#16475 1/2] wallet: Enumerate walletdb keys.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:08
teamcity updated the summary of D7020: [backport#16475 1/2] wallet: Enumerate walletdb keys.
Jul 27 2020, 22:08
teamcity updated the summary of D7014: [backport#15870 1/3] wallet: Only fail rescan when blocks have actually been pruned.
Jul 27 2020, 22:08
teamcity added a comment to D7014: [backport#15870 1/3] wallet: Only fail rescan when blocks have actually been pruned.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:08
teamcity added a comment to D7044: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:07
teamcity updated the summary of D7044: [backport#16745] wallet: Translate all initErrors in CreateWalletFromFile.
Jul 27 2020, 22:07
teamcity added a comment to D7054: [backport#16952] gui: make sure to update the UI when deleting a transaction.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:07
teamcity updated the summary of D7054: [backport#16952] gui: make sure to update the UI when deleting a transaction.
Jul 27 2020, 22:07
teamcity added a comment to D7043: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:07
teamcity updated the summary of D7043: [backport#16557] [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay().
Jul 27 2020, 22:07
teamcity added a comment to D7040: [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:07
teamcity updated the summary of D7040: [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic.
Jul 27 2020, 22:07
teamcity added a comment to D7036: [backport#16399 2/3] Return error for ignored passphrase through disable private keys option.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:06
teamcity updated the summary of D7036: [backport#16399 2/3] Return error for ignored passphrase through disable private keys option.
Jul 27 2020, 22:06
teamcity added a comment to D7022: [backport#15709] wallet: Do not add "setting" key as unknown.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:06
teamcity updated the summary of D7022: [backport#15709] wallet: Do not add "setting" key as unknown.
Jul 27 2020, 22:06
teamcity added a comment to D7019: [backport#15588 3/3] Remove ReadVersion and WriteVersion.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:06
teamcity updated the summary of D7019: [backport#15588 3/3] Remove ReadVersion and WriteVersion.
Jul 27 2020, 22:06
teamcity added a comment to D7018: [backport#15588 2/3] Log the actual wallet file version.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:05
teamcity updated the summary of D7018: [backport#15588 2/3] Log the actual wallet file version.
Jul 27 2020, 22:05
teamcity added a comment to D7051: [backport#16624 4/4] Add a test wallet_reorgsrestore.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:05
teamcity updated the summary of D7051: [backport#16624 4/4] Add a test wallet_reorgsrestore.
Jul 27 2020, 22:05
teamcity added a comment to D7049: [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:05
teamcity updated the summary of D7049: [backport#16624 2/4] Remove SyncTransaction for conflicted txn in CWallet::BlockConnected.
Jul 27 2020, 22:05
teamcity added a comment to D7048: [backport#16624 1/4] Encapsulate tx status in a Confirmation struct.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:05
teamcity updated the summary of D7048: [backport#16624 1/4] Encapsulate tx status in a Confirmation struct.
Jul 27 2020, 22:05
teamcity added a comment to D7046: [backport#16572] wallet: Fix Char as Bool in Wallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 27 2020, 22:05
teamcity updated the summary of D7046: [backport#16572] wallet: Fix Char as Bool in Wallet.
Jul 27 2020, 22:04