Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Jun 8 2020

jasonbcox accepted D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.

Jun 8 2020, 16:58

jasonbcox committed rABC294237a627c8: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic

Jun 8 2020, 16:53

jasonbcox closed D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.

Jun 8 2020, 16:53

jasonbcox committed rABC76ebb03789ff: Merge #15330: test: Fix race in p2p_invalid_messages (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #15330: test: Fix race in p2p_invalid_messages

Jun 8 2020, 16:52

jasonbcox closed D6395: Merge #15330: test: Fix race in p2p_invalid_messages.

Jun 8 2020, 16:52

jasonbcox committed rABCbf2721f4c9ee: [land-bot] Point land bot at bitcoinabc.org (authored by jasonbcox).

[land-bot] Point land bot at bitcoinabc.org

Jun 8 2020, 16:48

jasonbcox closed D6397: [land-bot] Point land bot at bitcoinabc.org.

Jun 8 2020, 16:48

Jun 5 2020

jasonbcox requested review of D6397: [land-bot] Point land bot at bitcoinabc.org.

Jun 5 2020, 21:57

jasonbcox requested review of D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.

Jun 5 2020, 21:45

jasonbcox requested review of D6395: Merge #15330: test: Fix race in p2p_invalid_messages.

Jun 5 2020, 21:41

jasonbcox committed rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #15246: qa: Add tests for invalid message headers

Jun 5 2020, 21:36

jasonbcox closed D6394: Merge #15246: qa: Add tests for invalid message headers.

Jun 5 2020, 21:36

jasonbcox committed rABC883815514dfe: Simplify install instructions for linter dependencies (authored by jasonbcox).

Simplify install instructions for linter dependencies

Jun 5 2020, 21:08

jasonbcox closed D6389: Simplify install instructions for linter dependencies.

Jun 5 2020, 21:07

jasonbcox committed rABC554d897104b2: Add remaining linter dependencies to CI base image (authored by jasonbcox).

Add remaining linter dependencies to CI base image

Jun 5 2020, 20:37

jasonbcox closed D6380: Add remaining linter dependencies to CI base image.

Jun 5 2020, 20:37

jasonbcox retitled D6380: Add remaining linter dependencies to CI base image from Add shellcheck to CI base image to Add remaining linter dependencies to CI base image.

Jun 5 2020, 20:30

jasonbcox committed rABC8227e3687e9b: [land-bot] Clarify review status error message (authored by jasonbcox).

[land-bot] Clarify review status error message

Jun 5 2020, 20:29

jasonbcox closed D6388: [land-bot] Clarify review status error message.

Jun 5 2020, 20:29

jasonbcox updated the diff for D6389: Simplify install instructions for linter dependencies.

clang-format -> clang-format-8

Jun 5 2020, 20:29

jasonbcox retitled D6389: Simplify install instructions for linter dependencies from Simply install instructions for linter dependencies to Simplify install instructions for linter dependencies.

Jun 5 2020, 20:28

jasonbcox added inline comments to D6394: Merge #15246: qa: Add tests for invalid message headers.

Jun 5 2020, 20:27

jasonbcox requested review of D6394: Merge #15246: qa: Add tests for invalid message headers.

Jun 5 2020, 20:26

jasonbcox retitled D6389: Simplify install instructions for linter dependencies from Simply install instructions for linter depenendencies to Simply install instructions for linter dependencies.

Jun 5 2020, 19:30

jasonbcox requested review of D6389: Simplify install instructions for linter dependencies.

Jun 5 2020, 18:49

jasonbcox updated the diff for D6380: Add remaining linter dependencies to CI base image.

Add missing php-codesniffer

Jun 5 2020, 18:44

jasonbcox requested review of D6388: [land-bot] Clarify review status error message.

Jun 5 2020, 18:07

jasonbcox requested changes to D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

Missing backport of p2p_dos_header_tree.py

Jun 5 2020, 17:57

jasonbcox committed rABC95173738367c: [devtools] Use -daemon instead of backgrounding bitcoind (authored by jasonbcox).

[devtools] Use -daemon instead of backgrounding bitcoind

Jun 5 2020, 17:55

jasonbcox closed D6379: [devtools] Use -daemon instead of backgrounding bitcoind.

Jun 5 2020, 17:55

Jun 4 2020

jasonbcox committed rABCda311f5ed8fe: Fix UniValue .write() changes for C++98 (authored by jasonbcox).

Fix UniValue .write() changes for C++98

Jun 4 2020, 23:32

jasonbcox closed D6359: Fix UniValue .write() changes for C++98.

Jun 4 2020, 23:32

jasonbcox requested review of D6380: Add remaining linter dependencies to CI base image.

Jun 4 2020, 23:15

jasonbcox committed rABC3aa12ec3b525: [devtools] Use a trap to cleanup bitcoind instead of a background process (authored by jasonbcox).

[devtools] Use a trap to cleanup bitcoind instead of a background process

Jun 4 2020, 23:10

jasonbcox closed D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.

Jun 4 2020, 23:10

jasonbcox requested changes to D6375: [backport#16898] test: Remove connect_nodes_bi.

Figure out what's up with the build-without-wallet failure

Jun 4 2020, 23:08

jasonbcox accepted D6377: util: Add Join helper to join a list of strings.

Jun 4 2020, 23:05

jasonbcox accepted D6376: util: refactor upper/lowercase functions.

Jun 4 2020, 23:02

jasonbcox requested review of D6379: [devtools] Use -daemon instead of backgrounding bitcoind.

Jun 4 2020, 22:53

jasonbcox requested review of D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.

Jun 4 2020, 22:28

jasonbcox accepted D6374: [CI] Disable jemalloc for running the tests with wine.

Jun 4 2020, 21:33

jasonbcox accepted D6373: [CI] Let build_cmake.sh take a list of targets and use it.

Jun 4 2020, 21:15

jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

size_t

Jun 4 2020, 20:13

jasonbcox updated the summary of D6359: Fix UniValue .write() changes for C++98.

Jun 4 2020, 20:12

jasonbcox updated the summary of D6359: Fix UniValue .write() changes for C++98.

Jun 4 2020, 18:30

jasonbcox added inline comments to D6373: [CI] Let build_cmake.sh take a list of targets and use it.

Jun 4 2020, 18:21

jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

Use swap to emulate std::move for C++98

Jun 4 2020, 18:13

jasonbcox accepted D6350: [backport#15777] [docs] Add doxygen comment for CKeyPool.

Jun 4 2020, 18:04

jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

Introduce preprocessor directive to allow compilation with std::move. This change differs from
the upstream PR for now, as a strategy for C++11 in UniValue will take more time.

Jun 4 2020, 17:35

jasonbcox committed rABC91184c7616fc: Merge #13047: [trivial] Tidy blocktools.py (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #13047: [trivial] Tidy blocktools.py

Jun 4 2020, 17:14

jasonbcox closed D6354: Merge #13047: [trivial] Tidy blocktools.py.

Jun 4 2020, 17:14

jasonbcox accepted D6346: init: Add CLI option to enable block filter index..

Jun 4 2020, 17:06

jasonbcox committed rABC53e142a7ed44: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #12856: Tests: Add Metaclass for BitcoinTestFramework

Jun 4 2020, 17:02

jasonbcox closed D6353: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework.

Jun 4 2020, 17:02

jasonbcox requested changes to D6373: [CI] Let build_cmake.sh take a list of targets and use it.

Jun 4 2020, 17:01

jasonbcox accepted D6372: Update multiset hash benchmark to use get_iters.

Jun 4 2020, 16:43

jasonbcox accepted D6371: [CI] Disable jemalloc for running the JNI bindings tests.

Jun 4 2020, 16:24

Jun 3 2020

jasonbcox accepted D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.

Since we own the seeder code now, consider new class names to not include the C... prefix. It's not useful.

Jun 3 2020, 23:56

jasonbcox accepted D6351: blockfilter: Update BIP 158 test vectors..

Jun 3 2020, 23:54

jasonbcox accepted D6349: rpc: Add getblockfilter RPC method..

Looks fine, but please investigate why the linter was not applied to the imports.

Jun 3 2020, 23:48

jasonbcox accepted D6358: test: Add RegTestingSetup to setup_common.

Jun 3 2020, 23:36

jasonbcox accepted D6356: test: move-only ComputeFilter to src/test/lib/blockfilter.

Jun 3 2020, 23:34

jasonbcox requested review of D6359: Fix UniValue .write() changes for C++98.

Jun 3 2020, 23:31

jasonbcox committed rABC6172b1663628: Add arcanist land bot workflow (authored by jasonbcox).

Add arcanist land bot workflow

Jun 3 2020, 22:30

jasonbcox closed D6264: Add arcanist land bot workflow.

Jun 3 2020, 22:30

jasonbcox requested review of D6354: Merge #13047: [trivial] Tidy blocktools.py.

Jun 3 2020, 22:02

jasonbcox requested changes to D6346: init: Add CLI option to enable block filter index..

Jun 3 2020, 21:53

jasonbcox requested review of D6353: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework.

Jun 3 2020, 21:26

jasonbcox accepted D6348: [backport#15777] [wallet] move-only: move CReserveKey to be next to CKeyPool.

Jun 3 2020, 20:49

jasonbcox requested changes to D6350: [backport#15777] [docs] Add doxygen comment for CKeyPool.

Jun 3 2020, 20:48

jasonbcox updated the diff for D6264: Add arcanist land bot workflow.

Fixes according to feedback

Jun 3 2020, 20:37

jasonbcox accepted D6344: gui: Fix shutdown order.

Jun 3 2020, 20:35

jasonbcox accepted D6337: index: Implement block filter index with write operations..

Jun 3 2020, 15:26

jasonbcox requested changes to D6337: index: Implement block filter index with write operations..

Jun 3 2020, 00:49

jasonbcox accepted D6335: blockfilter: Functions to translate filter types to/from names..

Jun 3 2020, 00:42

jasonbcox accepted D6333: index: Ensure block locator is not stale after chain reorg..

Jun 3 2020, 00:39

jasonbcox accepted D6332: index: Allow atomic commits of index state to be extended..

Jun 3 2020, 00:35

jasonbcox accepted D6338: Use BlockHash in BlockFilter.

Jun 3 2020, 00:31

jasonbcox committed rABCf7541c92b9fe: Fix Debian package script in case signer has multiple user IDs (authored by jasonbcox).

Fix Debian package script in case signer has multiple user IDs

Jun 3 2020, 00:30

jasonbcox closed D6329: Fix Debian package script in case signer has multiple user IDs.

Jun 3 2020, 00:30

jasonbcox committed rABC2800cca7367a: Merge #14426: utils: Fix broken Windows filelock (authored by Pieter Wuille <pieter.wuille@gmail.com>).

Merge #14426: utils: Fix broken Windows filelock

Jun 3 2020, 00:29

jasonbcox closed D6334: Merge #14426: utils: Fix broken Windows filelock.

Jun 3 2020, 00:29

Jun 2 2020

jasonbcox requested review of D6334: Merge #14426: utils: Fix broken Windows filelock.

Jun 2 2020, 22:04

jasonbcox added inline comments to D6330: [backport#16129] Make reasoning about dependencies easier by not including unused dependencies.

Jun 2 2020, 21:16

jasonbcox retitled D6329: Fix Debian package script in case signer has multiple user IDs from Fix Debian package script to support multiple user IDs from a single signer to Fix Debian package script in case signer has multiple user IDs.

Jun 2 2020, 20:14

jasonbcox updated the diff for D6329: Fix Debian package script in case signer has multiple user IDs.

Use email from keys.txt

Jun 2 2020, 20:13

jasonbcox planned changes to D6329: Fix Debian package script in case signer has multiple user IDs.

Jun 2 2020, 19:58

jasonbcox updated the test plan for D6329: Fix Debian package script in case signer has multiple user IDs.

Jun 2 2020, 19:12

jasonbcox requested review of D6329: Fix Debian package script in case signer has multiple user IDs.

Jun 2 2020, 19:12

jasonbcox accepted D6294: [backport#14599] Use functions guaranteed to be locale independent.

Jun 2 2020, 18:06

jasonbcox accepted D6325: [CI] Use proper argument handling in build_cmake.sh.

Jun 2 2020, 15:31

Jun 1 2020

jasonbcox accepted D6316: Merge #16481: Trivial: add missing space.

Jun 1 2020, 17:37

jasonbcox updated the diff for D6264: Add arcanist land bot workflow.

Check that gpg is installed
Unset unencrypted Conduit token after use

Jun 1 2020, 17:36

jasonbcox accepted D6313: [CMAKE] Rename secp256k1 test targets.

Jun 1 2020, 16:20

jasonbcox added inline comments to D6314: [CI] Install Clang 10 and use it for the werror build.

Jun 1 2020, 16:08

jasonbcox committed rABC9fc0ab8ec1ea: Add land bot dependencies to base image setup script (authored by jasonbcox).

Add land bot dependencies to base image setup script

Jun 1 2020, 16:06

jasonbcox closed D6265: Add land bot dependencies to base image setup script.

Jun 1 2020, 16:05

jasonbcox committed rABC1f965f78f94d: Generate assumed blockchain and chainstate disk sizes when updating chainparams (authored by jasonbcox).

Generate assumed blockchain and chainstate disk sizes when updating chainparams

Jun 1 2020, 15:21

jasonbcox closed D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Jun 1 2020, 15:21

jasonbcox updated the test plan for D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Jun 1 2020, 15:21