Page MenuHomePhabricator
Feed Advanced Search

Aug 27 2019

nakihito updated the diff for D3950: Merge #12953: Deprecate accounts.

Fixed incorrect version numbers.

Aug 27 2019, 19:41
nakihito added inline comments to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Aug 27 2019, 17:55
nakihito accepted D3946: Add a trailing comma to the Mode enum.
Aug 27 2019, 00:31

Aug 26 2019

nakihito added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Help entry duplication issue is fixed in D3950.

Aug 26 2019, 20:54
nakihito added a reviewer for D3950: Merge #12953: Deprecate accounts: markblundeberg.
Aug 26 2019, 20:53
nakihito added a reviewer for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet: markblundeberg.
Aug 26 2019, 20:53
nakihito updated the summary of D3950: Merge #12953: Deprecate accounts.
Aug 26 2019, 20:53
nakihito created D3950: Merge #12953: Deprecate accounts.
Aug 26 2019, 20:51
nakihito created D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Aug 26 2019, 20:38
nakihito updated the diff for D3308: Merge #9894: remove 'label' filter for rpc command help.

Rebase.

Aug 26 2019, 20:36
nakihito added inline comments to D3893: Merge #12747: Fix typos.
Aug 26 2019, 18:23
nakihito updated the test plan for D3893: Merge #12747: Fix typos.
Aug 26 2019, 18:22
nakihito updated the diff for D3893: Merge #12747: Fix typos.

Added "transation": "transaction" to the linter dictionary and added arc lint --everything to test plan.

Aug 26 2019, 18:21

Aug 23 2019

nakihito added inline comments to D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Aug 23 2019, 20:44
nakihito requested review of D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Aug 23 2019, 20:32
nakihito updated the test plan for D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Aug 23 2019, 20:31
nakihito requested review of D3893: Merge #12747: Fix typos.

The misspelled variable and function names were already correct.
See: D3306, D3243, and D3180

Aug 23 2019, 20:28
nakihito updated the summary of D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Aug 23 2019, 15:57

Aug 22 2019

nakihito created D3941: Merge #12721: Qt: remove "new" button during receive-mode in addressbook.
Aug 22 2019, 22:55
nakihito updated the test plan for D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Aug 22 2019, 20:48
nakihito updated the summary of D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Aug 22 2019, 20:47
nakihito updated the diff for D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.

Squashed changes.

Aug 22 2019, 20:46
nakihito created D3940: Merge #11131: rpc: Write authcookie atomically.
Aug 22 2019, 20:45
nakihito planned changes to D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Aug 22 2019, 20:33
nakihito created D3939: Merge #12305: [docs] [refactor] Add help messages for datadir path mangling.
Aug 22 2019, 20:32
nakihito added a comment to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

What steps did you take to make sure that this assert is unreachable?

Also, why isn't it at the start of the function like in the PR you backported from.

Aug 22 2019, 19:33
nakihito created D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Aug 22 2019, 17:02
nakihito updated the diff for D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.

Fixed casting style.

Aug 22 2019, 16:35
nakihito created D3935: Merge #11411: script: Change SignatureHash input index check to an assert..
Aug 22 2019, 00:12

Aug 21 2019

nakihito planned changes to D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.
Aug 21 2019, 23:03
nakihito created D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.
Aug 21 2019, 23:03
nakihito planned changes to D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Aug 21 2019, 23:00
nakihito created D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Aug 21 2019, 23:00
nakihito created D3932: Merge #12770: Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion.
Aug 21 2019, 20:21
nakihito created D3931: Merge #12561: Check for block corruption in ConnectBlock().
Aug 21 2019, 20:13
nakihito updated the test plan for D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Aug 21 2019, 19:22

Aug 20 2019

nakihito planned changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

It looks like Core is almost done with the patch for the regression this will add. I will update later once it is finished so they can be landed (hopefully) around the same time.

Aug 20 2019, 20:59
nakihito requested review of D3696: Merge #10036: Fix init README format to render correctly on github.

Mention PR12345 int he description.

Aug 20 2019, 18:39

Aug 19 2019

nakihito updated the test plan for D3899: Merge #12779: Qt: Remove unused method setupAmountWidget(...).
Aug 19 2019, 22:39
nakihito updated the diff for D3899: Merge #12779: Qt: Remove unused method setupAmountWidget(...).

Fixed comment.

Aug 19 2019, 22:37
nakihito updated the diff for D3903: Merge #12752: [MOVEONLY] Move compressor utility functions out of class.

Fixed nit.

Aug 19 2019, 18:19

Aug 17 2019

nakihito created D3903: Merge #12752: [MOVEONLY] Move compressor utility functions out of class.
Aug 17 2019, 01:07
nakihito created D3902: Merge #12787: rpc: Adjust ifdef to avoid unreachable code.
Aug 17 2019, 00:54
nakihito created D3901: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table.
Aug 17 2019, 00:43
nakihito created D3900: Merge #12762: Make CKeyStore an interface.
Aug 17 2019, 00:32
nakihito created D3899: Merge #12779: Qt: Remove unused method setupAmountWidget(...).
Aug 17 2019, 00:22

Aug 16 2019

nakihito created D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Aug 16 2019, 23:53
nakihito planned changes to D3897: Merge #12709: [wallet] shuffle sendmany recipients ordering.
Aug 16 2019, 23:43
nakihito created D3897: Merge #12709: [wallet] shuffle sendmany recipients ordering.
Aug 16 2019, 23:43
nakihito planned changes to D3894: Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED.
Aug 16 2019, 19:44
nakihito created D3894: Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED.
Aug 16 2019, 19:44
nakihito planned changes to D3893: Merge #12747: Fix typos.
Aug 16 2019, 19:43
nakihito created D3893: Merge #12747: Fix typos.
Aug 16 2019, 19:43
nakihito updated the diff for D3891: Merge #11200: Allow for aborting rescans in the GUI.

Fixed nits.

Aug 16 2019, 18:34
nakihito updated the summary of D3879: Merge #11353: Small refactor of CCoinsViewCache::BatchWrite().
Aug 16 2019, 17:50
nakihito created D3891: Merge #11200: Allow for aborting rescans in the GUI.
Aug 16 2019, 00:16

Aug 15 2019

nakihito created D3889: Merge #12803: Make BaseSignatureCreator a pure interface.
Aug 15 2019, 22:59
nakihito created D3888: Merge #12714: Introduce interface for signing providers.
Aug 15 2019, 20:26
nakihito created D3887: Merge #12837: rpc: fix type mistmatch in `listreceivedbyaddress`.
Aug 15 2019, 19:35
nakihito created D3885: Merge #12650: gui: Fix issue: "default port not shown correctly in settings dialog".
Aug 15 2019, 19:27
nakihito created D3882: Merge #12920: test: Fix sign for expected values.
Aug 15 2019, 18:57

Aug 14 2019

nakihito created D3879: Merge #11353: Small refactor of CCoinsViewCache::BatchWrite().
Aug 14 2019, 20:51
nakihito accepted D3874: Cleanup reject_code in p2p_invalid_block.py.
Aug 14 2019, 19:38
nakihito accepted D3877: Cleanup reject_code in feature_csv_activation.py.
Aug 14 2019, 19:36
nakihito created D3876: Merge #11417: Correct typo in comments.
Aug 14 2019, 18:40
nakihito updated the diff for D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Fixed amount initialization and removed newlines.

Aug 14 2019, 18:07

Aug 13 2019

nakihito created D3867: Merge #13188: qa: Remove unused option --srcdir.
Aug 13 2019, 23:40
nakihito created D3866: Merge #12436: [rpc] Adds a functional test to validate the transaction version number in the RPC output.
Aug 13 2019, 18:52
nakihito updated the diff for D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Rebased.

Aug 13 2019, 18:19
nakihito updated the diff for D3858: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots.

Added brackets.

Aug 13 2019, 02:03
nakihito accepted D3840: Merge #9910: Docs: correct and elaborate -rpcbind doc.
Aug 13 2019, 00:08

Aug 12 2019

nakihito planned changes to D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Aug 12 2019, 23:02
nakihito updated the diff for D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.

Rebased off dependency.

Aug 12 2019, 23:02
nakihito updated the diff for D3833: Merge #11395: Qt: Enable searching by transaction id.

Fixed formatting.

Aug 12 2019, 22:59
nakihito requested review of D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Aug 12 2019, 22:55
nakihito accepted D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.
Aug 12 2019, 22:54
nakihito created D3858: Merge #11422: qa: Verify DBWrapper iterators are taking snapshots.
Aug 12 2019, 20:28
nakihito created D3857: Merge #12996: tests: Remove redundant bytes(…) calls.
Aug 12 2019, 18:47

Aug 10 2019

nakihito created D3850: Merge #12969: Drop dead code CScript::Find.
Aug 10 2019, 00:59

Aug 9 2019

nakihito created D3849: Merge #11573: [Util] Update tinyformat.h.
Aug 9 2019, 22:32
nakihito accepted D3847: Merge #10642: Remove obsolete _MSC_VER check.

Code wise, this looks the same as what I did (even though it is a trivially small/simple change).

Aug 9 2019, 22:08
nakihito updated the diff for D3839: Merge #12947: Wallet hd functional test speedup and clarification.

Removed newline added to end of timing.json.

Aug 9 2019, 21:56
nakihito added a comment to D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.

Added inline note for documentation's sake.

Aug 9 2019, 21:47
nakihito created D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.
Aug 9 2019, 20:57
nakihito created D3842: Merge #12942: rpc: Drop redundant testing of signrawtransaction prevtxs args.
Aug 9 2019, 20:40
nakihito created D3839: Merge #12947: Wallet hd functional test speedup and clarification.
Aug 9 2019, 20:10
nakihito updated the summary of D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.
Aug 9 2019, 01:35

Aug 8 2019

nakihito planned changes to D3833: Merge #11395: Qt: Enable searching by transaction id.
Aug 8 2019, 23:57
nakihito created D3833: Merge #11395: Qt: Enable searching by transaction id.
Aug 8 2019, 23:57
nakihito planned changes to D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Aug 8 2019, 23:55
nakihito created D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Aug 8 2019, 23:24
nakihito updated the test plan for D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Aug 8 2019, 20:34
nakihito updated the diff for D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

Removed non-functional lines and no longer need imports.

Aug 8 2019, 20:34
nakihito updated the diff for D3805: Merge #12716: Fix typos and cleanup in various files.

Fixed formatting and another typo.

Aug 8 2019, 18:00

Aug 7 2019

nakihito accepted D3820: Merge #12918: test: Assert on correct variable.
Aug 7 2019, 23:35
nakihito accepted D3821: Merge #12925: wallet: Logprint the start of a rescan.
Aug 7 2019, 23:34
nakihito updated the summary of D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..
Aug 7 2019, 23:31
nakihito added a comment to D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

I also went ahead and removed the unused variables found by the linter after the change.

Aug 7 2019, 23:28
nakihito requested review of D3805: Merge #12716: Fix typos and cleanup in various files.
Aug 7 2019, 23:26
nakihito requested review of D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Aug 7 2019, 23:22